route_authorizer 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03917bb50ef8c090257e8517adeba2647738ee55
-  data.tar.gz: f0c27426804ef97d9c58390cbba72fac3660820c
+  metadata.gz: d4d097356ade4d4b4a7970ce122a62644a8bde23
+  data.tar.gz: e69733b53d7502d2ee443cbfe8adb34c50de9925
 SHA512:
-  metadata.gz: 31d86741194eb317a30120bfc30b761cb9ce0438f0b5728d7faa6022878fdcd5edbbbeb0a09c7e62d41e2583e6c92c52769a087291a66fd1a8cabdf197350e77
-  data.tar.gz: ba84579744255ef98a422e1a5e917e332ad09f9831cd183e6dd208961950a9f6dd8f3b231809aa81cbbe2930a41090c2f6c31f669fe083d7ea90f55f07d4332c
+  metadata.gz: fb4fcf832f5b96ab5e4b4e8aea623bb0a42a2c4e09c55f55f49c04cfb5b217c7c96a507694d3c0596db9c13f206766b350f4b5d0a9c71e982ee1d0e8b79829ea
+  data.tar.gz: 0589805cc20769d137ca530fcd5c9e69fc13ab917666c4947d375107663ff6075d3d01c303b0d69f3f41b153581d04344fa97b2ba911b45a1e606992ce5768df

data/lib/route_authorizer/authorizer.rb

@@ -11,11 +11,11 @@ module RouteAuthorizer::Authorizer
 private
 
   def permission
-    @permission ||= ::Permission.new(current_user.role)
+    @permission ||= ::Permission.new(current_user.try(:role))
   end
 
   def can_redirect_to?(_controller_name, _action_name)
-    permission.redirect_to?(_controller_name, _action_name) if current_user
+    permission.redirect_to?(_controller_name, _action_name)
   end
 
   def can_redirect_to_path?(path)
@@ -25,7 +25,7 @@ private
 
   def authorize_user!
     unless can_redirect_to?(controller_name, action_name)
-      raise AccessDenied.new("Acess denied to '#{controller_name}##{action_name}'") if current_user
+      raise AccessDenied.new("Acess denied to '#{controller_name}##{action_name}'")
     end
   end
 

data/lib/route_authorizer/permission.rb

@@ -1,7 +1,7 @@
 module RouteAuthorizer::Permission
 
   def initialize(role)
-    @role = role
+    @role = role.to_s
   end
 
   def redirect_to?(controller_name, action_name)

data/lib/route_authorizer/version.rb

@@ -1,3 +1,3 @@
 module RouteAuthorizer
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/route_authorizer.gemspec

@@ -22,5 +22,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.5'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'pry-meta'
+  spec.add_development_dependency 'byebug'
 end

data/spec/authorizer_spec.rb

@@ -1,10 +1,72 @@
 require 'spec_helper'
 
+Permission = Object.new
+
 describe RouteAuthorizer::Authorizer do
 
-  it 'extends active support concern' do
-    included_modules = RouteAuthorizer::Authorizer.singleton_class.included_modules
-    expect(included_modules).to be_include ActiveSupport::Concern
+  let(:role) { :admin }
+  let(:current_user) { double('User', role: role) }
+  let(:permission) { double('permission', redirect_to?: true) }
+  let(:controller) { ActionController::Base.new }
+
+  before do
+    allow(Permission).to receive(:new) { permission }
+
+    allow(controller).to receive(:controller_name) { :controller }
+    allow(controller).to receive(:action_name) { :action }
+    allow(controller).to receive(:current_user) { current_user }
+  end
+
+  context 'when has a current user' do
+    before do
+      expect(Permission).to receive(:new).with(role)
+    end
+
+    it 'returns current user role' do
+      controller.send(:permission)
+    end
+  end
+
+  context 'when does not have a current user' do
+    before do
+      allow(controller).to receive(:current_user) { nil }
+    end
+
+    it 'returns no role' do
+      expect(Permission).to receive(:new).with(nil)
+      controller.send(:permission)
+    end
+  end
+
+  context 'when user has permission' do
+    before do
+      expect(permission).to receive(:redirect_to?).with(:controller, :action) { true }
+    end
+
+    it 'raises no exception' do
+      expect {controller.send(:authorize_user!)}.not_to raise_error
+    end
+  end
+
+  context 'when user does not have permission' do
+    before do
+      expect(permission).to receive(:redirect_to?).with(:controller, :action) { false }
+    end
+
+    it 'raises AccessDenied exception' do
+      expect {controller.send(:authorize_user!)}.to raise_error(RouteAuthorizer::Authorizer::AccessDenied)
+    end
+  end
+
+  it '#can_redirect_to?' do
+    expect(permission).to receive(:redirect_to?).with(:other_controller, :other_action)
+    controller.send(:can_redirect_to?, :other_controller, :other_action)
+  end
+
+  it '#can_redirect_to_path?' do
+    expect(Rails).to receive_message_chain(:application, :routes, :recognize_path).with('path') { {a: 1, b: 2, c: 3} }
+    expect(permission).to receive(:redirect_to?).with(1, 2)
+    controller.send(:can_redirect_to_path?, 'path')
   end
 
 end

data/spec/permission_spec.rb

@@ -2,13 +2,18 @@ require 'spec_helper'
 
 describe RouteAuthorizer::Permission do
 
-  let(:permission_class) do
-    klass = Class.new
-    klass.include(RouteAuthorizer::Permission)
-    klass
+  let(:permission_class) { Class.new }
+  let(:permission) { permission_class.new(@role) }
+
+  before do
+    @role = :admin
+    permission_class.include(RouteAuthorizer::Permission)
   end
 
-  let(:permission) { permission_class.new(:admin) }
+  it 'returns no permission for no role' do
+    @role = nil
+    expect(permission.send(:role_permissions)).to eq([])
+  end
 
   it 'returns no permission by default' do
     expect(permission.send(:role_permissions)).to eq([])

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: route_authorizer
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Fábio Rodrigues
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-08 00:00:00.000000000 Z
+date: 2015-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-meta
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="