rouster 0.53 → 0.57

data/test/unit/puppet/test_get_puppet_star.rb

@@ -17,20 +17,19 @@ class TestGetPuppetStar < Test::Unit::TestCase
     Rouster.send(:public, *Rouster.protected_instance_methods)
   end
 
-  def test_happy_get_errors
+  def test_happy_27_get_errors
 
     output = "[1;35merr: Could not retrieve catalog from remote server: Error 400 on SERVER: no result for [api_vip] in Hiera (YAML/CMS)\nfizzybang\n[1;35merr: Could not retrieve catalog from remote server: Error 400 on SERVER: no result for [foobar] in Hiera (YAML/CMS)"
     @app.output.push(output)
 
     assert_not_nil(@app.get_puppet_errors())
     assert_equal(2, @app.get_puppet_errors().size)
-    assert_equal(@app.get_puppet_errors(), @app.get_puppet_errors(output)) # could be split out to a different test
+    assert_equal(@app.get_puppet_errors(), @app.get_puppet_errors(output)) # tests that passed args is same as derived
 
     assert_nil(@app.get_puppet_notices())
-
   end
 
-  def test_happy_get_notices
+  def test_happy_27_get_notices
 
     output = "[0;36mnotice: Not using cache on failed catalog\nfizzbang\n[0;36mnotice: Not using cache on failed catalog"
     @app.output.push(output)
@@ -43,6 +42,30 @@ class TestGetPuppetStar < Test::Unit::TestCase
 
   end
 
+  def test_happy_30_get_errors
+
+    output = "\e[0;32mInfo: Retrieving plugin\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/root_home.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/drac_version.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/sfdc-custom_facts.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/drac_fw_version.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/razor_version.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/oob_mac.rb\e[0m\n\e[1;31mError: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find class razor for ops-tools1-1-piab.ops.sfdc.net on node ops-tools1-1-piab.ops.sfdc.net\e[0m\n\e[1;31mWarning: Not using cache on failed catalog\e[0m\n\e[1;31mError: Could not retrieve catalog; skipping run\e[0m\n"
+    @app.output.push(output)
+
+    assert_not_nil(@app.get_puppet_errors())
+    assert_equal(2, @app.get_puppet_errors().size)
+    assert_equal(@app.get_puppet_errors(), @app.get_puppet_errors(output))
+
+    assert_nil(@app.get_puppet_notices())
+  end
+
+  def test_happy_30_get_notices
+
+    output = "\e[0;32mInfo: Retrieving plugin\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/root_home.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/drac_version.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/sfdc-custom_facts.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/drac_fw_version.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/razor_version.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb\e[0m\n\e[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/oob_mac.rb\e[0m\n\e[0;32mInfo: Caching catalog for ops-tools1-1-piab.ops.sfdc.net\e[0m\n\e[0;32mInfo: Applying configuration version '1385418175'\e[0m\n\e[mNotice: /Stage[main]/Razor::Service/Razor::Api[tag]/Exec[razor-api-tag]/returns: executed successfully\e[0m\n\e[mNotice: /Stage[main]/Razor::Service/Razor::Api[policy]/Exec[razor-api-policy]/returns: executed successfully\e[0m\n\e[mNotice: /Stage[main]/Razor::Service/Razor::Api[model]/Exec[razor-api-model]/returns: executed successfully\e[0m\n\e[mNotice: Finished catalog run in 33.76 seconds\e[0m\n"
+    @app.output.push(output)
+
+    assert_not_nil(@app.get_puppet_notices())
+    assert_equal(4, @app.get_puppet_notices().size)
+    assert_equal(@app.get_puppet_notices(), @app.get_puppet_notices(output))
+
+    assert_nil(@app.get_puppet_errors())
+  end
+
   def test_no_errors
 
     output = 'there are no errors here'

data/test/unit/test_new.rb

@@ -9,6 +9,8 @@ class TestNew < Test::Unit::TestCase
 
   def setup
     @app = nil
+    # TODO make this work, don't want to have to instance_variable_get everything..
+    #Rouster.send(:public, *Rouster.instance_variables)
   end
 
   # TODO this is an awful pattern, do better
@@ -24,6 +26,27 @@ class TestNew < Test::Unit::TestCase
     assert_equal(true, @app.uses_sudo?())
   end
 
+  def test_2_good_instantiation
+
+    assert_nothing_raised do
+      @app = Rouster.new(
+        :cache_timeout => 10,
+        :name          => 'ppm',
+        :retries       => 3,
+        :verbosity     => [3,2],
+        :unittest      => true,
+      )
+    end
+
+    assert_equal(10, @app.cache_timeout)
+    assert_equal('ppm', @app.name)
+    assert_equal(3, @app.retries)
+
+    assert_equal(3, @app.instance_variable_get(:@verbosity_console))
+    assert_equal(2, @app.instance_variable_get(:@verbosity_logfile))
+
+  end
+
   def teardown
     # noop
   end

data/test/unit/test_parse_ls_string.rb

@@ -29,6 +29,7 @@ class TestParseLsString < Test::Unit::TestCase
       :owner       => 'root',
       :group       => 'root',
       :size        => '199',
+      :symlink?    => false,
       :executable? => [false, false, false],
       :readable?   => [true, true, true],
       :writeable?  => [false, false, false]
@@ -50,6 +51,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, false, false],
         :readable?   => [true,  false, false],
         :writeable?  => [false, false, false]
@@ -71,6 +73,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, false, false],
         :readable?   => [false, true, false],
         :writeable?  => [false, false, false]
@@ -92,6 +95,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, false, false],
         :readable?   => [false, false, true],
         :writeable?  => [false, false, false]
@@ -113,6 +117,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [true, true, true],
         :readable?   => [false, false, false],
         :writeable?  => [false, false, false]
@@ -134,6 +139,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [true, false, false],
         :readable?   => [false, false, false],
         :writeable?  => [false, false, false]
@@ -155,6 +161,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, true, false],
         :readable?   => [false, false, false],
         :writeable?  => [false, false, false]
@@ -176,6 +183,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, false, true],
         :readable?   => [false, false, false],
         :writeable?  => [false, false, false]
@@ -197,6 +205,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, false, false],
         :readable?   => [false, false, false],
         :writeable?  => [true, true, true]
@@ -218,6 +227,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, false, false],
         :readable?   => [false, false, false],
         :writeable?  => [true, false, false]
@@ -239,6 +249,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, false, false],
         :readable?   => [false, false, false],
         :writeable?  => [false, true, false]
@@ -260,6 +271,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'root',
         :group       => 'root',
         :size        => '199',
+        :symlink?    => false,
         :executable? => [false, false, false],
         :readable?   => [false, false, false],
         :writeable?  => [false, false, true]
@@ -281,6 +293,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'vagrant',
         :group       => 'vagrant',
         :size        => '1909',
+        :symlink?    => false,
         :executable? => [false, false, true],
         :readable?   => [false, false, true],
         :writeable?  => [false, false, true]
@@ -302,6 +315,7 @@ class TestParseLsString < Test::Unit::TestCase
         :owner       => 'vagrant',
         :group       => 'root',
         :size        => '0',
+        :symlink?    => false,
         :executable? => [false, false, false],
         :readable?   => [true, true, true],
         :writeable?  => [true, false, false]
@@ -327,6 +341,15 @@ class TestParseLsString < Test::Unit::TestCase
 
   end
 
+  def test_symlink_detection
+    link = "lrwxrwxrwx 1 vagrant vagrant  10 Mar 13 22:53 foo -> /etc/hosts\n"
+    file = "-rw-r--r-- 2 root root 166 Mar 13 22:50 /etc/hosts\n"
+
+    assert_equal(true, @app.exposed_parse_ls_string(link)[:symlink?])
+    assert_equal(false, @app.exposed_parse_ls_string(file)[:symlink?])
+
+  end
+
   def test_suid
     str = "drwxr-sr-x 2 root root 4096 Oct  7 17:09 /etc/nagios/objects\n"
 
@@ -340,6 +363,7 @@ class TestParseLsString < Test::Unit::TestCase
       :owner       => 'root',
       :group       => 'root',
       :size        => '4096',
+      :symlink?    => false,
       :executable? => [true, true, true], # right now, we return [true,false,true]
       :readable?   => [true, true, true],
       :writeable?  => [true, false, false],

data/test/unit/testing/test_validate_cron.rb

@@ -0,0 +1,78 @@
+require sprintf('%s/../../../path_helper', File.dirname(File.expand_path(__FILE__)))
+
+require 'rouster'
+require 'rouster/puppet'
+require 'rouster/testing'
+require 'test/unit'
+
+class TestValidateCron < Test::Unit::TestCase
+
+  def setup
+    # expose private methods
+    Rouster.send(:public, *Rouster.private_instance_methods)
+    Rouster.send(:public, *Rouster.protected_instance_methods)
+
+    fake_facts = { 'is_virtual' => 'true', 'timezone' => 'PDT', 'uptime_days' => 42 }
+
+    fake_crons = {
+      'root' => {
+        'printf > /var/log/apache/error_log' => {
+          :minute => 10,
+          :hour   => 2,
+          :dom    => '*',
+          :mon    => '*',
+          :dow    => '*'
+        }
+      },
+      'a_user' => {
+        '/home/a_user/test.pl' => {
+          :minute => '0',
+          :hour   => ['0', '6', '12', '18'],
+          :dom    => '*',
+          :mon    => '*',
+          :dow    => '*'
+        }
+      }, 'cronless_user' => {}
+    }
+
+    @app = Rouster.new(:name => 'app', :unittest => true)
+    @app.deltas[:crontab] = fake_crons
+    @app.facts = fake_facts
+  end
+
+  def test_positive_basic
+
+    assert(@app.validate_cron('root', 'printf > /var/log/apache/error_log', { :minute => 10, :hour => 2, :dom => '*', :mon => '*', :dow => '*'}))
+    assert(@app.validate_cron('a_user', '/home/a_user/test.pl', { :minute => '0', :hour => ['0', '6', '12', '18'], :dom => '*', :mon => '*', :dow => '*' }))
+    assert(@app.validate_cron('root', 'chmod 1777 /tmp', { :ensure => 'absent' }))
+    assert(@app.validate_cron('cronless_user', 'rm -f /tmp/foo', { :ensure => 'absent' }))
+
+  end
+
+  def test_positive_constrained
+
+    assert(@app.validate_cron('root', 'printf > /var/log/apache/error_log', { :minute => 10 , :constrain => 'is_virtual true'} ))
+
+  end
+
+  def test_negative_basic
+
+    assert_equal(false, @app.validate_cron('root', 'printf > /var/log/apache/error_log', { :minute => 1 }))
+    assert_equal(false, @app.validate_cron('root', 'rm -rf /', { :minute => '*', :hour => '*', :dom => '*', :mon => '*', :dow => '*'}))
+    assert_equal(false, @app.validate_cron('a_user', '/home/a_user/test.pl', { :ensure => 'absent' }))
+    assert_equal(false, @app.validate_cron('root', '/home/a_user/test.pl', { :minute => '0', :hour => ['0', '6', '12', '18'], :dom => '*', :mon => '*', :dow => '*' }))
+
+  end
+
+  def test_negative_constrained
+
+    assert(@app.validate_cron('root', 'printf > /var/log/apache/error_log', { :minute => 10, :constrain => 'is_virtual false' } ))
+    assert(@app.validate_cron('root', 'printf > /var/log/apache/error_log', { :gid => 55, :constrain => 'is_virtual false' } ))
+
+  end
+
+  def teardown
+    # noop
+  end
+
+end

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: rouster
 version: !ruby/object:Gem::Version
-  version: '0.53'
+  version: '0.57'
 platform: ruby
 authors:
 - Conor Horan-Kates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-12 00:00:00.000000000 Z
+date: 2014-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: log4r
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.1.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.1.9
 - !ruby/object:Gem::Dependency
   name: net-scp
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: net-ssh
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Rouster allows you to programmatically control and interact with your
@@ -115,7 +115,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
+- .gitignore
 - LICENSE
 - README.md
 - Rakefile
@@ -123,11 +123,13 @@ files:
 - examples/bootstrap.rb
 - examples/demo.rb
 - examples/error.rb
+- examples/passthrough.rb
 - lib/rouster.rb
 - lib/rouster/deltas.rb
 - lib/rouster/puppet.rb
 - lib/rouster/testing.rb
 - lib/rouster/tests.rb
+- lib/rouster/vagrant.rb
 - path_helper.rb
 - rouster.gemspec
 - test/basic.rb
@@ -147,6 +149,7 @@ files:
 - test/functional/test_is_dir.rb
 - test/functional/test_is_file.rb
 - test/functional/test_new.rb
+- test/functional/test_passthroughs.rb
 - test/functional/test_put.rb
 - test/functional/test_rebuild.rb
 - test/functional/test_restart.rb
@@ -170,6 +173,7 @@ files:
 - test/unit/test_parse_ls_string.rb
 - test/unit/test_traverse_up.rb
 - test/unit/testing/test_meets_constraint.rb
+- test/unit/testing/test_validate_cron.rb
 - test/unit/testing/test_validate_file.rb
 - test/unit/testing/test_validate_group.rb
 - test/unit/testing/test_validate_package.rb
@@ -186,17 +190,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: Rouster
-rubygems_version: 2.0.4
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Rouster is an abstraction layer for Vagrant