rospatent 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a3938079b33ac5c291c85501df526ec12b7721a91c9f7c9a4b5c35c56a8fdab
-  data.tar.gz: 2a8cb80112a1c0380f2dd15f2e3e4909ae37f84e7ef3a819aa9d86fce6d1e765
+  metadata.gz: 886b7fc58ff9c0baec9e8e9d538d751e2d6b5f8aea24c0b144dd9d922a8128ca
+  data.tar.gz: 953a7ca14bda74da201f12b11a4006119ab3388a0165fec32d52493f7320cd0f
 SHA512:
-  metadata.gz: 8843ca4bd8c87de711bed059c9f315a8d46a6123c0763a3eb7dcbfc5af6512e1d35b03782a22b37eb74578942592cb699b4ab8eb07c7744f651230b950c03e41
-  data.tar.gz: 29896e1b71030d368a54fc4d40bc3a9cd79318b82089618f71e98eafee65ce266d781dd2d1518001e0bd388af0937f2d46a5c7f911673d155738fa61e48fda44
+  metadata.gz: 696194b474592192c22818c2eb57ff515fdd92d67aa72d4bf2f5d8f0b51a3a62f5a758e7e5def7561a71da90c8c13c56ea92e845f724096e1443fa5155aaa7b4
+  data.tar.gz: d00b71f8a0822cef0682913ddea29d1e8b564f38c983d7562a32fe185e40cfea904f56106ceb6c2f0e39d7a2ab10395fc52f993845cf55757a5c2dadb5846e46

data/CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.5.1] - 2026-05-09
+
+### Fixed
+- **Partial `validation_limits` assignment overwrote defaults**: Setting `config.validation_limits = { query_max_length: 5000 }` in a Rails initializer (or anywhere else) used to replace the entire hash, leaving the other 16 keys `nil` and breaking validators downstream (e.g. `validate_positive_integer(..., max_value: nil)` for `limit_max_value`, `offset_max_value`, etc.). The writer now merges the supplied hash into the defaults, so omitted keys keep their default values.
+- **Unknown `validation_limits` keys silently ignored**: Misspelled or unsupported keys used to be accepted and stored without effect. Assignment now raises `ArgumentError` listing the offending keys, surfacing typos at boot time.
+
+### Changed
+- Extracted `Rospatent::Configuration::DEFAULT_VALIDATION_LIMITS` as a frozen public constant — single source of truth for default limits, referenced by `reset!`, the merging writer, and tests.
+- Updated the Rails install generator template (`lib/generators/rospatent/install/templates/initializer.rb`) with a commented `validation_limits` example documenting the merge semantics.
+
 ## [1.5.0] - 2025-06-09
 
 ### Added

data/lib/generators/rospatent/install/templates/initializer.rb

@@ -45,4 +45,9 @@ Rospatent.configure do |config|
   # config.cache_ttl = ENV.fetch("ROSPATENT_CACHE_TTL", "300").to_i
   # config.cache_max_size = ENV.fetch("ROSPATENT_CACHE_MAX_SIZE", "1000").to_i
   # config.connection_pool_size = ENV.fetch("ROSPATENT_POOL_SIZE", "5").to_i
+
+  # Optional: Override one or more validation limits.
+  # Assignment merges into defaults — keys you omit keep their default values.
+  # Unknown keys raise ArgumentError. See Rospatent::Configuration::DEFAULT_VALIDATION_LIMITS.
+  # config.validation_limits = { query_max_length: 5000, similar_text_max_length: 20_000 }
 end

data/lib/rospatent/configuration.rb

@@ -7,6 +7,28 @@ module Rospatent
   class Configuration
     ENVIRONMENTS = %w[development staging production].freeze
 
+    # Default validation limits applied to all configurations.
+    # Partial overrides via {#validation_limits=} are merged into these defaults.
+    DEFAULT_VALIDATION_LIMITS = {
+      query_max_length: 2000,
+      natural_query_max_length: 2000,
+      limit_max_value: 100,
+      offset_max_value: 10_000,
+      array_max_size: 10,
+      string_max_length: 1000,
+      pre_tag_max_length: 50,
+      post_tag_max_length: 50,
+      pre_tag_max_size: 10,
+      post_tag_max_size: 10,
+      classification_query_max_length: 1000,
+      classification_code_max_length: 50,
+      similar_text_min_words: 50,
+      similar_text_max_length: 10_000,
+      similar_count_max_value: 1000,
+      batch_size_max_value: 50,
+      batch_ids_max_size: 1000
+    }.freeze
+
     # Base URL for the Rospatent API
     attr_accessor :api_url
     # JWT token for authentication
@@ -27,8 +49,8 @@ module Rospatent
     attr_accessor :token_expires_at, :token_refresh_callback
     # Connection pooling
     attr_accessor :connection_pool_size, :connection_keep_alive
-    # Validation limits
-    attr_accessor :validation_limits
+    # Validation limits — readable as a hash; assignment merges into defaults.
+    attr_reader :validation_limits
 
     # Initialize a new configuration with default values
     def initialize
@@ -59,26 +81,8 @@ module Rospatent
       @connection_pool_size = ENV.fetch("ROSPATENT_POOL_SIZE", "5").to_i
       @connection_keep_alive = ENV.fetch("ROSPATENT_KEEP_ALIVE", "true") == "true"
 
-      # Validation limits
-      @validation_limits = {
-        query_max_length: 2000,
-        natural_query_max_length: 2000,
-        limit_max_value: 100,
-        offset_max_value: 10_000,
-        array_max_size: 10,
-        string_max_length: 1000,
-        pre_tag_max_length: 50,
-        post_tag_max_length: 50,
-        pre_tag_max_size: 10,
-        post_tag_max_size: 10,
-        classification_query_max_length: 1000,
-        classification_code_max_length: 50,
-        similar_text_min_words: 50,
-        similar_text_max_length: 10_000,
-        similar_count_max_value: 1000,
-        batch_size_max_value: 50,
-        batch_ids_max_size: 1000
-      }
+      # Validation limits — start from defaults; partial overrides merge in.
+      @validation_limits = DEFAULT_VALIDATION_LIMITS.dup
 
       load_environment_config
     end
@@ -126,6 +130,26 @@ module Rospatent
       end
     end
 
+    # Merge a partial validation_limits hash into the defaults.
+    # Assigning a hash that omits some keys keeps the default value for those keys
+    # rather than dropping them, which would break validators downstream.
+    # @param values [Hash] Subset (or full set) of validation limit overrides
+    # @raise [ArgumentError] If the value is not a Hash or contains unknown keys
+    def validation_limits=(values)
+      unless values.is_a?(Hash)
+        raise ArgumentError, "validation_limits must be a Hash, got #{values.class}"
+      end
+
+      unknown = values.keys - DEFAULT_VALIDATION_LIMITS.keys
+      unless unknown.empty?
+        raise ArgumentError,
+              "Unknown validation_limits keys: #{unknown.inspect}. " \
+              "Allowed: #{DEFAULT_VALIDATION_LIMITS.keys.inspect}"
+      end
+
+      @validation_limits = DEFAULT_VALIDATION_LIMITS.merge(values)
+    end
+
     private
 
     # Load environment-specific configuration

data/lib/rospatent/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rospatent
-  VERSION = "1.5.0"
+  VERSION = "1.5.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rospatent
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Aleksandr Dryzhuk
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-15 00:00:00.000000000 Z
+date: 2026-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday