rosette_api 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8f545c246173449a4012beea3f61e9e8df915b6b
-  data.tar.gz: 9373d4c2f41b371e76bf6502fbf4bffd51fed7bd
+  metadata.gz: e53c127d939917c66e9f18732487666ed38e146e
+  data.tar.gz: df1aa05f967fb4c6c4839896fe80ce786abdcc4b
 SHA512:
-  metadata.gz: 58c0d5057af4c3ec382f1a1f5c3c3f45991d9ed330ba1e5d713cc2ade657fe1a4fa1bcc03b91a251e125d9e2bf2b3fc8574ea497c0b90b30091afb9e344ea137
-  data.tar.gz: c5f63bc528ad80fad60ca7fc872c51c7fb58da5645bee8af003dcfd4fe6e9679af76f2f305a31707eabd7e6418a0e8294fd75b69d74b8073096997fd453ee470
+  metadata.gz: 14c981a94e40839716b1d2a4f818378e58836944ae23a898fddada1fccdb85e198f190c2a40000d28bb7ccb62e28609ccacc2dc2b186fa06a9434c2c6fe5daed
+  data.tar.gz: dfc63f43667b3bb60ca419eb1065546a5c402845236cde3ba09118e320cd3fe1acd55e63b05d3abcd51140d573843e0150564f5dfa97f621e34b7b60cef7df19

data/lib/rosette_api.rb

@@ -177,6 +177,8 @@ class RosetteAPI
   def get_entities(params, resolve_entities = false)
     check_params params
 
+    raise BadRequestError.new('Expects boolean for resolve_entities') unless !!resolve_entities == resolve_entities
+
     params = params.load_params
 
     endpoint = resolve_entities ? (ENTITIES_ENDPOINT + '/linked') : ENTITIES_ENDPOINT
@@ -330,7 +332,7 @@ class RosetteAPI
 
     # Checks that the right parameter type is being passed in.
     def check_params(params, message = 'Expects a DocumentParameters type as an argument', type = DocumentParameters)
-      raise BadRequest.new message unless params.is_a? type
+      raise BadRequestError.new message unless params.is_a? type
     end
 end
 

data/tests/tests_spec.rb

@@ -242,9 +242,16 @@ describe RosetteAPI do
       params = DocumentParameters.new
       params.content = 'Last month director Paul Feig announced the movie will have an all-star female cast including' \
                        ' Kristen Wiig, Melissa McCarthy, Leslie Jones and Kate McKinnon.'
-      response = RosetteAPI.new('0123456789').get_entities_linked(params)
+      response = RosetteAPI.new('0123456789').get_entities(params, true)
       expect(response).instance_of? Hash
     end
+
+    it 'test entities linked for resolve_entities is not a boolean' do
+      params = DocumentParameters.new
+      params.content = 'Last month director Paul Feig announced the movie will have an all-star female cast including' \
+                       ' Kristen Wiig, Melissa McCarthy, Leslie Jones and Kate McKinnon.'
+      expect { RosetteAPI.new('0123456789').get_entities(params, 'smth') }.to raise_error(BadRequestError)
+    end
   end
 
   describe '.get_categories' do
@@ -329,6 +336,11 @@ describe RosetteAPI do
       response = RosetteAPI.new('0123456789').name_translation(params)
       expect(response).instance_of? Hash
     end
+
+    it 'badRequest: Expects NameTransaltionParameters type as an argument' do
+      params = NameSimilarityParameters.new('Michael Jackson', '迈克尔·杰克逊')
+      expect { RosetteAPI.new('0123456789').name_translation(params) }.to raise_error(BadRequestError)
+    end
   end
 
   describe '.name_similarity' do
@@ -357,10 +369,20 @@ describe RosetteAPI do
       expect(response).instance_of? Hash
     end
 
+    it 'badRequestFormat: name1 option can only be an instance of a String or NameParameter' do
+      params = NameSimilarityParameters.new(123, 'Michael Jackson')
+      expect { RosetteAPI.new('0123456789').name_similarity(params) }.to raise_error(BadRequestError)
+    end
+
     it 'badRequestFormat: name2 option can only be an instance of a String or NameParameter' do
       params = NameSimilarityParameters.new('Michael Jackson', 123)
       expect { RosetteAPI.new('0123456789').name_similarity(params) }.to raise_error(BadRequestError)
     end
+
+    it 'badRequest: Expects NameSimilarityParameters type as an argument' do
+      params = NameTranslationParameters.new('معمر محمد أبو منيار القذاف'.encode('UTF-8'), 'eng')
+      expect { RosetteAPI.new('0123456789').name_similarity(params) }.to raise_error(BadRequestError)
+    end
   end
 
   describe '.get_tokens' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rosette_api
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Basis Technology Corp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-29 00:00:00.000000000 Z
+date: 2016-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubysl-securerandom