rosetta-stone 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f49ad30a0b19d92be9bca2d6b43eca56f1843fe9b594d9c46c1401113304c15
-  data.tar.gz: 5989f92c630e155ea5da9a5191c6a06e5e41ac2f8854d347372f611b814a0b68
+  metadata.gz: a533462d58d84278dc028e4045c6eaaa31d85bbc57b0d84b973fc65e77ba9f54
+  data.tar.gz: ead94d4194d3f3cf9cc09e3fc4e4330ebe9d8b8f502a09ec89d972176fc1d695
 SHA512:
-  metadata.gz: ef07a8fbf976977caff7b8de46ff30df4ff500df9784bda69fb81e146d03123f7208434f5eddf8cacb57663d0113f5a352cd3ded94664ac09cd5f36eee4a8914
-  data.tar.gz: 12c85f29aebe211372dc362c221bc6f82e0ff8f64524060c2fb679e9ac7185893b0b2e9421e4f4a9dae7331b1095d71c2b5b8809d574d1ffd8531aa059475d74
+  metadata.gz: fab482ccd77877e6b8f9af64c196ef3834840e0263ea3b3bea806f2d7d1613ee64f2029c78efa4e3beec755cbacc19bdf7c28babd631dba54a1b847352003048
+  data.tar.gz: 1b0f519e1f16a1f980b3ca87a3cc0c041745aba1d26abef3c85320d2a0a68516b60d628cb459950c8639c4633645facb814c9da38c33aa2940d8cd4f27c00f78

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rosetta-stone (0.2.0)
+    rosetta-stone (0.2.1)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,4 +1,5 @@
 # Rosetta
+[![Build Status](https://travis-ci.com/Aquaj/rosetta.svg?branch=master)](https://travis-ci.com/Aquaj/rosetta)  [![Gem Version](https://badge.fury.io/rb/rosetta-stone.svg)](https://badge.fury.io/rb/rosetta-stone)
 
 A lightweight format-to-format translator.
 
@@ -142,7 +143,8 @@ Example:
 # are equivalent.
 
 Rosetta::Translation.new(:down, :up).call("you're looking for")
-  # => "YOU'RE LOOKING FOR3
+  # => "YOU'RE LOOKING FOR"
+```
 
 ## Development
 

data/lib/rosetta/deserializers.rb

@@ -1,24 +1,10 @@
 require 'rosetta/exceptions'
+require 'rosetta/support/registerable'
 
 module Rosetta
   module Deserializers
-    @registered = {}
+    extend Support::Registerable
 
-    class << self
-      attr_reader :registered
-
-      def [](key)
-        registered[key]
-      end
-
-      def register(name, deserializer, &block)
-        raise ExistingDeserializerError, <<-ERROR.strip if @registered.key? name
-          Deserializer #{name} is already registered.
-        ERROR
-
-        raise ArgumentError, "Can't take both deserializer object and block." if deserializer && block
-        @registered[name] = deserializer
-      end
-    end
+    registerable_as :deserializer
   end
 end

data/lib/rosetta/serializers.rb

@@ -1,24 +1,9 @@
 require 'rosetta/exceptions'
+require 'rosetta/support/registerable'
 
 module Rosetta
   module Serializers
-    @registered = {}
-
-    class << self
-      attr_reader :registered
-
-      def [](key)
-        @registered[key]
-      end
-
-      def register(name, serializer, &block)
-        raise ExistingSerializerError, <<-ERROR.strip if @registered.key? name
-          Serializer #{name} is already registered.
-        ERROR
-
-        raise ArgumentError, "Can't take both serializer object and block." if serializer && block
-        @registered[name] = serializer
-      end
-    end
+    extend Support::Registerable
+    registerable_as :serializer
   end
 end

data/lib/rosetta/support/registerable.rb

@@ -0,0 +1,44 @@
+require 'rosetta/exceptions'
+
+module Rosetta
+  module Support
+    module Registerable
+      def registerable_as(nature)
+        @registered = {}
+
+        class << self
+          attr_reader :registered
+
+          def [](key)
+            registered[key]
+          end
+        end
+
+        define_singleton_method :register do |name, object=nil, &block|
+          #TODO: Feels clunky, string refinement maybe?
+          nature_words = nature.to_s.downcase
+                               .split('_')
+                               .map { |word| word[0].upcase + word[1..-1] }
+
+          camel_nature = nature_words.join
+          human_nature = nature_words.join(' ')
+
+          error_name = :"Existing#{camel_nature}Error"
+          error_class = if constants.include?(error_name)
+                          const_get(error_name)
+                        else
+                          RegistrationError
+                        end
+          raise error_class, <<-ERROR.strip if @registered.key? name
+            #{human_nature} #{name} is already registered.
+          ERROR
+
+         if object && block
+           raise ArgumentError, "Can't take both #{human_nature.downcase} object and block."
+         end
+          @registered[name] = object || block
+        end
+      end
+    end
+  end
+end

data/lib/rosetta/translation.rb

@@ -1,28 +1,22 @@
 require 'rosetta/exceptions'
+require 'rosetta/support/registerable'
 
 module Rosetta
   class Translation
-    @registered = {}
-    attr_reader :serializer, :deserializer, :translator
-    alias_method :translator?, :translator
+    extend Support::Registerable
+    registerable_as :translator
 
     class << self
-      attr_reader :registered
-
-      def [](key)
-        @registered[key]
-      end
+      alias_method :register_key, :register
 
-      def register(source, destination, callable = nil, &block)
-        raise ExistingTranslatorError, <<-ERROR.strip if @registered.key? name
-          There already is a translator from #{source} to #{destination}.
-        ERROR
-
-        raise ArgumentError, "Can't take both callable object and block." if callable && block
-        @registered[source => destination] = callable || block
+      def register(source, destination, object=nil, &block)
+        register_key({ source => destination }, object, &block)
       end
     end
 
+    attr_reader :serializer, :deserializer, :translator
+    alias_method :translator?, :translator
+
     def initialize(deserializer, serializer)
       @translator = Translation[deserializer => serializer]
       unless @translator

data/lib/rosetta/version.rb

@@ -1,3 +1,3 @@
 module Rosetta
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rosetta-stone
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Jérémie Bonal
@@ -93,6 +93,7 @@ files:
 - lib/rosetta/serializers.rb
 - lib/rosetta/serializers/base.rb
 - lib/rosetta/serializers/csv.rb
+- lib/rosetta/support/registerable.rb
 - lib/rosetta/translation.rb
 - lib/rosetta/version.rb
 - rosetta.gemspec