ros-apartment 4.0.0.alpha4 → 4.0.0.alpha5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86ded64305e44aac057b97264c079d5090545b7d1740693ea1cf7c881b69fe19
-  data.tar.gz: 99e78891808ff4cdb1e0fef82f7c49a344a4c088408c9c143af465c70a150a3b
+  metadata.gz: c4e597c986618a8043acbecc8081ef0399493c545fd3720d8f57653da90025da
+  data.tar.gz: 9fb0d04fe5abb04e93a4ef654edc14744dfc8d86d35f6d6ef8b685d7eb6ddb29
 SHA512:
-  metadata.gz: 6a80e29d57f2d4d4de7cd41666b3cef737720cceb782c3d6a34f5522dec0a6ec3fc04e41ba1a45761eabfee5bee5f5b0d2d80d2ae79d1c43f8d905906d7dc1d3
-  data.tar.gz: a4c460e9ec3c2214e1a52fd399bf0038a6da1d43c66a20fbd97a31ceb6ac44b4595592eec41f0310cfc51f99e5b6699420332fa816a177865479af1772dea928
+  metadata.gz: 747e6efe4c8c073368684944bbee84cccfd0b063f389d7b4a699debd97662496db9ea220e6be6f119986fa76e3586d180bb3f61ff61c4c44bc3acc37b7784f0c
+  data.tar.gz: 9ceef5927c8169dc2db2041fbbfba99b81c7106a9cf02814812550c1775cd2566398dd8383e78bd0d24e7a82a845d2c4418bc974c43cc5e0169cd25a6072eba5

data/lib/apartment/pool_observer.rb

@@ -24,7 +24,18 @@ module Apartment
     def self.install!(sink:, sample_interval: nil, backend_count: nil)
       observer = new(sink: sink, backend_count: backend_count)
       observer.subscribe!
-      observer.start_sampler!(interval: sample_interval) if sample_interval&.positive?
+      if sample_interval.nil?
+        # nil is the intentional "no gauge sampler" signal; counters still flow.
+      elsif sample_interval.positive?
+        observer.start_sampler!(interval: sample_interval)
+      else
+        # A non-nil, non-positive interval is almost always a misconfig (e.g. an
+        # empty APARTMENT_POOL_SAMPLE_INTERVAL coerced to 0). Silently skipping
+        # the sampler ships an observer whose gauges never emit; surface it.
+        warn "[Apartment::PoolObserver] sample_interval=#{sample_interval.inspect} is not " \
+             'positive; gauge sampler not started (tenant_pools_live/backend_connections ' \
+             'will not emit). Pass a positive interval, or nil to disable the sampler.'
+      end
       observer
     rescue StandardError
       # Don't leak subscriptions if a later step (e.g. a bad sample_interval)

data/lib/apartment/tenant.rb

@@ -200,17 +200,29 @@ module Apartment
       # it drops EVERY connection leased to the current execution context, across
       # all pools and roles, not just the tenant pool. Do NOT use it inside an
       # outer ActiveRecord::Base.transaction, or while holding a non-tenant
-      # connection you mean to keep. Fail-fast: if the block raises, the failing
-      # tenant is not released (the fan-out aborts).
+      # connection you mean to keep. Fail-fast: a raising block still aborts the
+      # fan-out, but the failing tenant's connection is released first — the
+      # release is best-effort cleanup (in an ensure), not iteration semantics.
       def each(tenants = nil, release_connection: false)
         raise(ArgumentError, 'Apartment::Tenant.each requires a block') unless block_given?
 
         tenants ||= Apartment.tenant_names
         tenants.each do |tenant|
           switch(tenant) { yield(tenant) }
+        ensure
           # Handler-wide (:all) covers writing + reading roles — the gem's
-          # established release call (see memory_stability_spec).
-          ActiveRecord::Base.connection_handler.clear_active_connections!(:all) if release_connection
+          # established release call (see memory_stability_spec). In an ensure so
+          # a raising tenant is still released; the exception then propagates and
+          # halts the fan-out (fail-fast preserved). Best-effort: a release
+          # failure must never mask the block's exception, so it is rescued and
+          # warned rather than raised out of the ensure.
+          if release_connection
+            begin
+              ActiveRecord::Base.connection_handler.clear_active_connections!(:all)
+            rescue StandardError => e
+              warn("[Apartment::Tenant.each] connection release failed: #{e.class}: #{e.message}")
+            end
+          end
         end
       end
 

data/lib/apartment/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Apartment
-  VERSION = '4.0.0.alpha4'
+  VERSION = '4.0.0.alpha5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ros-apartment
 version: !ruby/object:Gem::Version
-  version: 4.0.0.alpha4
+  version: 4.0.0.alpha5
 platform: ruby
 authors:
 - Ryan Brunner