roqua-support 0.4.1 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0104ee377feaa85014f2a233e86c618a08de92e7b55cd273fe7832f491f070b4
-  data.tar.gz: 7c04430ab277f7c69cb0d1cf8d54a0901cb127460b2b68e3b91ad3c01b171204
+  metadata.gz: 26f053a4b379494d15a9b24e9b8bc81911f3315c803f087dc0798bf668b762c3
+  data.tar.gz: 564d0a8c6a2faf7dee1074d4f6f18798371febfeaacb0e76df40ff85109440e8
 SHA512:
-  metadata.gz: da8540ad9f35f3738485ec3f58b28ba14c2a330ae6ae2cd4d1bfefbe46206f0c7c8b842053829dcf4e668d57c03890137f2536c559d805d51ba1c04755daf58c
-  data.tar.gz: 01a31a8402b496e30298ceda86e2ebcbf06eb09d7453e9a56a681f159335eab03d3436487e4bb138afbe027990a1c4747acf0c3d06756a4d3ae56749144635da
+  metadata.gz: 90c413010ca39e84809c85fd7a659900293055d0db111adafcd70f7cba88c24aee6c8953bd6ef066c9861fc6406e6612ea34a318780302a6dc5488ceda29e7f1
+  data.tar.gz: 4c977d93716db251acd831231904271d8ec216bc1abc1a7ca1620da75767bada7b4ab737b0917359b975c64172fcaebad8a1ffc305833daf80d00157329c5b97

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+## 0.4.4
+
+* Fix incompatibility with Appsignal v3 which removed long-deprecated is_ignored_exception? with no alternative
+
+
+##  0.4.3
+
+* Make sort_by_alphanum sort shorter string first.
+
+## 0.4.2
+
+* Make sort_by_alphanum stable for chunks that parse to the same int like 04 and 4.
+
 ## 0.4.1
 
 * Add timezone to logging timestamps. Use milliseconds instead of microseconds precision. 

data/Gemfile.lock

@@ -10,7 +10,7 @@ GIT
 PATH
   remote: .
   specs:
-    roqua-support (0.4.1)
+    roqua-support (0.4.4)
       active_interaction (>= 3.0, < 5.0)
       activesupport (>= 5.2, < 6.2)
       appsignal (>= 2.9, < 3.1)
@@ -33,9 +33,9 @@ GEM
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    active_interaction (4.0.5)
-      activemodel (>= 5, < 7)
-      activesupport (>= 5, < 7)
+    active_interaction (4.1.0)
+      activemodel (>= 5, < 8)
+      activesupport (>= 5, < 8)
     activemodel (6.0.2.2)
       activesupport (= 6.0.2.2)
     activerecord (6.0.2.2)
@@ -51,7 +51,7 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
-    appsignal (3.0.13)
+    appsignal (3.0.26)
       rack
     ast (2.4.2)
     builder (3.2.4)

data/lib/roqua/core_ext/enumerable/sort_by_alphanum.rb

@@ -21,29 +21,47 @@ module Enumerable
 
   private
 
-  def grouped_compare(a, b)
-    loop {
-      a_chunk, a = extract_alpha_or_number_group(a)
-      b_chunk, b = extract_alpha_or_number_group(b)
+  ALL_NUM = /\d+/
+  ALL_ALPHA = /[A-Za-z]+/
+  NON_ALPHANUM = /[^A-Za-z0-9]+/
 
-      ret = if a_chunk =~ /\d/ and b_chunk =~ /\d/
+  def grouped_compare(a, b)
+    a_scanner = StringScanner.new(a)
+    b_scanner = StringScanner.new(b)
+    # each loop has to do exactly 1 non-nil-scan on both scanners or return a non-zero value.
+    loop do
+      ret = \
+        if a_scanner.eos?
+          -1
+        elsif b_scanner.eos?
+          1
+        elsif (a_chunk = a_scanner.scan(ALL_NUM))
+          if (b_chunk = b_scanner.scan(ALL_NUM))
+            if a_chunk.to_i != b_chunk.to_i
               a_chunk.to_i <=> b_chunk.to_i
-            else
+            else # 03 vs 3
               a_chunk <=> b_chunk
             end
-
-      return -1 if a_chunk == ''
+          elsif b_scanner.scan(ALL_ALPHA)
+            -1
+          else # NON_ALPHANUM
+            1
+          end
+        elsif (a_chunk = a_scanner.scan(ALL_ALPHA))
+          if (b_chunk = b_scanner.scan(ALL_ALPHA))
+            a_chunk <=> b_chunk
+          else # ALL_NUM or NON_ALPHANUM
+            1
+          end
+        else # NON_ALPHANUM
+          a_chunk = a_scanner.scan(NON_ALPHANUM)
+          if (b_chunk = b_scanner.scan(NON_ALPHANUM))
+            a_chunk <=> b_chunk
+          else
+            -1
+          end
+        end
       return ret if ret != 0
-    }
-  end
-
-  def extract_alpha_or_number_group(item)
-    matchdata = /([A-Za-z]+|[\d]+)/.match(item)
-
-    if matchdata.nil?
-      ["", ""]
-    else
-      [matchdata[0], item = item[matchdata.offset(0)[1] .. -1]]
     end
   end
 end

data/lib/roqua/support/errors.rb

@@ -69,7 +69,7 @@ module Roqua
         end
 
         def notify_appsignal?(exception)
-          const_defined?(:Appsignal) && Appsignal.active? && !Appsignal.is_ignored_exception?(exception)
+          const_defined?(:Appsignal) && Appsignal.active?
         end
 
         def notify_appsignal(exception, labels, namespace)

data/lib/roqua-support/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module Support
-    VERSION = '0.4.1'.freeze
+    VERSION = '0.4.4'.freeze
   end
 end

data/spec/roqua/core_ext/enumerable/sort_by_alphanum_spec.rb

@@ -11,8 +11,23 @@ describe Enumerable do
       expect(input.sort_by_alphanum(&:reverse)).to eq ["004some10thing", "004some11thing", "3another"]
     end
 
+    it 'sorts shorter strings first' do
+      input = %w[a_2_ a_2 a a_1]  # curlies are above alpha in utf-8, Ԙ is multi-byte
+      expect(input.sort_by_alphanum).to eq %w[a a_1 a_2 a_2_]
+    end
+
+    it 'treats non-alphanum as lower than alpha and num' do
+      input = %w[b3a b{c bԘb]  # curlies are above alpha in utf-8, Ԙ is multi-byte
+      expect(input.sort_by_alphanum).to eq %w[b{c bԘb b3a]
+    end
+
     it 'compares number chunks as integers' do
       expect(%w(004 3).sort_by_alphanum).to eq %w(3 004)
     end
+
+    it 'sorts identical integers by asci'  do
+      input = %w[b4e b0004e b04e b004e]
+      expect(input.sort_by_alphanum).to  eq %w[b0004e b004e b04e b4e]
+    end
   end
 end

data/spec/roqua/support/errors_spec.rb

@@ -96,7 +96,6 @@ describe 'Error reporting' do
     before do
       Appsignal.config = Appsignal::Config.new(Dir.pwd, "test")
       allow(Appsignal).to receive(:active?).and_return(true)
-      allow(Appsignal).to receive(:is_ignored_exception?).and_return(false)
       allow(Appsignal).to receive(:agent).and_return(agent)
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-support
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.4
 platform: ruby
 authors:
 - Marten Veldthuis
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-10-20 00:00:00.000000000 Z
+date: 2022-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_interaction
@@ -266,7 +266,7 @@ homepage: https://github.com/roqua/roqua-support
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -282,7 +282,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.4
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Helper objects and proxies used by a lot of RoQua applications
 test_files: