roqua-support 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5997425ea5b975ef1adf4b17e10d3d6c44bbdaa6507f696db1a5aad1ddf9513
-  data.tar.gz: cc565728bb3fc02e707b92d8ab507c996a793f9c6d5d16b0e6d8cfed1462ae70
+  metadata.gz: e7d9dfb663d723ece7cb2972d37b393ec69966b364324d3993bd9c132b3be106
+  data.tar.gz: 15d4f06832bf6c50e66faace5db84255ee81359d666d7fa657622832a44f9942
 SHA512:
-  metadata.gz: c9fc30367ece67f45800e8ab586f86f8aed50f8033be899265c5a03a87318ebdb960b87652c69dbb03da28c419242dffa1aa6977e82708b6e33a3b9ff445c352
-  data.tar.gz: 28c2f803f644b2244908cc52b5326074298e81b31c8e0f3f9cd6ac9a422dab00e51ac3d1e4383f2b09516fdc045bafe6b52cde2e3cf22353608d284ce9e046d9
+  metadata.gz: be346d85ae38329372ebbfcb73238dcb6edf263fb87b0fa1fff4eb7c45434b0fb1fe315df5d3d0bdb7ba24c6f45a4a44a563874c423c505644980dddc4318a07
+  data.tar.gz: 7072cb75b17a3214a4b1180736f307fbba8d916e5be3dc8812c5ece18cc1b92a8d75d042cec8225a0b708284d085c63c499eabaa98283449f34224ddfb9138de

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.3.2
+
+* Use tags for better appsignal metrics
+* Require Appsignal 2.9 to avoid probe registration problems
+
 ## 0.3.1
 
 * Added Appsignal counters for probe calls and scheduling probe call tasks in particular.

data/Gemfile

@@ -9,7 +9,7 @@ gem 'roqua_styleguide', git: 'https://gitlab.roqua.nl/roqua/styleguide.git'
 group :test do
   gem 'actionpack', '>= 4.0'
   gem 'active_interaction', '~> 3.0'
-  gem 'appsignal', '~> 2.9.6'
+  gem 'appsignal', '~> 2.9.8'
   gem 'climate_control' # For ENV modification in specs
   gem 'combustion', '~> 0.5.2'
   gem 'fakefs', require: 'fakefs/safe'

data/Gemfile.lock

@@ -8,9 +8,10 @@ GIT
 PATH
   remote: .
   specs:
-    roqua-support (0.3.0)
+    roqua-support (0.3.2)
       active_interaction (~> 3.0)
       activesupport (>= 3.2, < 6)
+      appsignal (~> 2.9.8)
       naught (~> 1.0)
       with_advisory_lock (~> 3.2)
 
@@ -47,7 +48,7 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
-    appsignal (2.9.6)
+    appsignal (2.9.8)
       rack
     arel (7.1.4)
     ast (2.3.0)
@@ -107,7 +108,7 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    rack (2.0.1)
+    rack (2.0.7)
     rack-test (0.6.3)
       rack (>= 1.0)
     rails-dom-testing (2.0.2)

data/lib/roqua-support/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module Support
-    VERSION = '0.3.1'.freeze
+    VERSION = '0.3.2'.freeze
   end
 end

data/lib/roqua/probes/base_probe.rb

@@ -17,7 +17,7 @@ module Roqua
       # do not override me, implement probes by implementing the #run method
       def call
         run
-        Appsignal.increment_counter("probe.call.completed.#{self.class.name.demodulize.underscore}", 1)
+        Appsignal.increment_counter("probe.call.completed", 1, probe_name: self.class.name.demodulize.underscore)
       end
     end
   end

data/lib/roqua/scheduling/scheduler.rb

@@ -42,7 +42,7 @@ class Roqua::Scheduling::Scheduler
     task = schedule.tasks[cron_job.name]
     task.run
 
-    Appsignal.increment_counter("scheduler.run_task.completed.#{task.name}", 1)
+    Appsignal.increment_counter("scheduler.run_task.completed", 1, task_name: task.name)
     cron_job.update completed_at: Time.now, next_run_at: task.next_run_at
   end
 end

data/roqua-support.gemspec

@@ -22,8 +22,8 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'activesupport', '>= 3.2', '< 6'
   gem.add_dependency 'naught', '~> 1.0'
   gem.add_dependency 'with_advisory_lock', '~> 3.2'
+  gem.add_dependency 'appsignal', '~> 2.9.8'
 
-  gem.add_development_dependency 'appsignal', '>= 2.3.1'
   gem.add_development_dependency 'bundler', '~> 1.0'
   gem.add_development_dependency 'delayed_job_active_record'
   gem.add_development_dependency 'rake'

data/spec/roqua/probes/delayed_job_probe_spec.rb

@@ -32,7 +32,7 @@ describe Roqua::Probes::DelayedJobProbe do
     end
 
     it 'increments the probe call counter' do
-      expect(Appsignal).to receive(:increment_counter).with('probe.call.completed.delayed_job_probe', 1)
+      expect(Appsignal).to receive(:increment_counter).with('probe.call.completed', 1, probe_name: "delayed_job_probe")
       probe.call
     end
   end

data/spec/roqua/probes/monitoring_probe_spec.rb

@@ -21,7 +21,7 @@ describe Roqua::Probes::MonitoringProbe do
     end
 
     it 'increments the probe call counter' do
-      expect(Appsignal).to receive(:increment_counter).with('probe.call.completed.monitoring_probe', 1)
+      expect(Appsignal).to receive(:increment_counter).with('probe.call.completed', 1, probe_name: "monitoring_probe")
       probe.call
     end
   end

data/spec/roqua/scheduling/scheduler_spec.rb

@@ -86,7 +86,7 @@ describe Roqua::Scheduling::Scheduler do
     end
 
     it 'counts task calls' do
-      expect(Appsignal).to receive(:increment_counter).with('scheduler.run_task.completed.hourly', 1)
+      expect(Appsignal).to receive(:increment_counter).with('scheduler.run_task.completed', 1, task_name: 'hourly')
       subject.ping
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-support
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-11 00:00:00.000000000 Z
+date: 2019-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_interaction
@@ -76,16 +76,16 @@ dependencies:
   name: appsignal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.1
-  type: :development
+        version: 2.9.8
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.1
+        version: 2.9.8
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement