roqua-support 0.1.34 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 76f68fbee8a7db03ddae10fbe3d141df7684d51dddf04b31ffe1928afb43c695
-  data.tar.gz: 71b36fe4a8d228e2cde4d0650b7fddfa7cf02d32e5020ec30cc4d8249acc2b6b
+  metadata.gz: 3b7684543b65ccc1553042df3e832dba5f40a8f42d0ff15fa31f42d865755b32
+  data.tar.gz: 3ba17388d2c2b947756ddb1ca3b4172a6bcbde85bef76b0c70a5eb9fe7fe16d5
 SHA512:
-  metadata.gz: 628059e56300c65b3414e0f66b9cf883a5994cbb9299dd0c19a08d231ebf3de4454aed75383819f4fe812801b88c5ef7c426ba9163883b2b5acd4cd665d48ef3
-  data.tar.gz: 02f51d281d67e3c432ab4a5ba5e85ab8a7a89b7ca4851220c71400a2e444c470233c7be97c7f9f5a6f138c0907deb542ddfcb589c6c79eebff0660eea1af9f89
+  metadata.gz: 880ee19112ad1e4f596a451228b7b3b6f5b07ad381f0d1706ee00c42b070af2c8dd3048a26363183c09ba9ceb2f7e34c72b3289b11f8829ee0e02a613e173742
+  data.tar.gz: fa8da4fcb52839b129019a08f4ba852cc629af98944c9aef9add34c4ef2244ace706e59f53765b551c95da8a6231bed7a096afeb0e4dacfa7e7a1d02a5f14f17

data/.gitlab-ci.yml

@@ -21,6 +21,13 @@ before_script:
     paths:
       - .gems
 
+.ruby_25: &ruby_25
+  image: registry.roqua.nl/roqua/docker-base-images:ruby-2.5
+  cache:
+    key: ruby_25
+    paths:
+      - .gems
+
 rails_42_ruby_23:
   <<: *ruby_23
   script:
@@ -36,6 +43,11 @@ rails_50_ruby_24:
   script:
     - bundle exec appraisal rails50 bundle exec rspec
 
+rails_50_ruby_25:
+  <<: *ruby_25
+  script:
+    - bundle exec appraisal rails50 bundle exec rspec
+
 rails_51_ruby_23:
   <<: *ruby_23
   script:
@@ -46,6 +58,11 @@ rails_51_ruby_24:
   script:
     - bundle exec appraisal rails51 bundle exec rspec
 
+rails_51_ruby_25:
+  <<: *ruby_25
+  script:
+    - bundle exec appraisal rails51 bundle exec rspec
+
 rails_52_ruby_23:
   <<: *ruby_23
   script:
@@ -55,3 +72,8 @@ rails_52_ruby_24:
   <<: *ruby_24
   script:
     - bundle exec appraisal rails52 bundle exec rspec
+
+rails_52_ruby_25:
+  <<: *ruby_25
+  script:
+    - bundle exec appraisal rails52 bundle exec rspec

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## 0.3.0
+
+* Support for Ruby 2.5
+* Removed Fixnum#clamp, since Fixnum was deprecated and the clamp method was never used.
+
+## 0.2.0
+
+* Removed Array#stable_sort_by, since it was not stable and the name was wrong.
+
 ## 0.1.21
 
 * Add Errors.add_parameters(add_to: 'error_report')

data/Gemfile

@@ -9,7 +9,7 @@ gem 'roqua_styleguide', git: 'https://gitlab.roqua.nl/roqua/styleguide.git'
 group :test do
   gem 'actionpack', '>= 4.0'
   gem 'active_interaction', '~> 3.0'
-  gem 'appsignal'
+  gem 'appsignal', '~> 2.9.6'
   gem 'climate_control' # For ENV modification in specs
   gem 'combustion', '~> 0.5.2'
   gem 'fakefs', require: 'fakefs/safe'

data/Gemfile.lock

@@ -8,7 +8,7 @@ GIT
 PATH
   remote: .
   specs:
-    roqua-support (0.1.33)
+    roqua-support (0.3.0)
       active_interaction (~> 3.0)
       activesupport (>= 3.2, < 6)
       naught (~> 1.0)
@@ -47,7 +47,7 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
-    appsignal (2.3.1)
+    appsignal (2.9.6)
       rack
     arel (7.1.4)
     ast (2.3.0)
@@ -181,7 +181,7 @@ DEPENDENCIES
   actionpack (>= 4.0)
   active_interaction (~> 3.0)
   appraisal
-  appsignal
+  appsignal (~> 2.9.6)
   bundler (~> 1.0)
   climate_control
   combustion (~> 0.5.2)
@@ -195,8 +195,8 @@ DEPENDENCIES
   rspec (>= 2.12.0, < 4.0)
   rspec-instrumentation-matcher
   rspec-rails
-  sqlite3
+  sqlite3 (~> 1.3.6)
   timecop
 
 BUNDLED WITH
-   1.16.4
+   1.16.6

data/lib/roqua-support/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module Support
-    VERSION = '0.1.34'.freeze
+    VERSION = '0.3.0'.freeze
   end
 end

data/lib/roqua/logging/roqua_logging_railtie.rb

@@ -1,4 +1,3 @@
-
 class RoquaLoggingRailtie < Rails::Railtie
   config.after_initialize do |app|
     RoquaLoggingRailtie.configure

data/lib/roqua/probes/base_probe.rb

@@ -3,7 +3,8 @@ module Roqua
     module BaseProbe
       def enable
         new.tap do |probe|
-          Appsignal::Minutely.probes << probe unless Appsignal::Minutely.probes.map(&:class).include?(probe.class)
+          probe_sym = probe.class.to_s.to_sym
+          Appsignal::Minutely.probes.register(probe_sym, probe) unless Appsignal::Minutely.probes[probe_sym]
         end
       end
     end

data/lib/roqua/support.rb

@@ -1,5 +1,5 @@
 require 'logger'
-require 'roqua/logging/roqua_logging_railtie'
+require 'roqua/logging/roqua_logging_railtie' if defined?(Rails)
 require 'roqua/support/instrumentation'
 require 'roqua/support/log_wrapper'
 require 'roqua/support/errors'

data/lib/roqua/support/errors.rb

@@ -62,7 +62,6 @@ module Roqua
                               parameters: parameters}
             exception_info[:notification_urls] = notification_urls if notification_urls.present?
             exception_info[:backtrace] = exception.backtrace unless skip_backtrace
-            puts exception_info.inspect
             Roqua.logger.error('roqua.exception', exception_info)
           end
         rescue Exception

data/roqua-support.gemspec

@@ -28,6 +28,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'delayed_job_active_record'
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec', '>= 2.12.0', '< 4.0'
-  gem.add_development_dependency 'sqlite3'
+  gem.add_development_dependency 'sqlite3', '~> 1.3.6'
   gem.add_development_dependency 'timecop'
 end

data/spec/roqua/core_ext/enumerable/sort_by_alphanum_spec.rb

@@ -2,20 +2,17 @@ require 'roqua/core_ext/enumerable/sort_by_alphanum'
 
 describe Enumerable do
   describe '#sort_by_alphanum' do
+    let(:input) { ["004some11thing", "004some10thing", "3another"] }
     it 'sorts by chunks' do
-      ["004some11thing",
-       "004some10thing",
-       "3another"].sort_by_alphanum.should == ["3another", "004some10thing", "004some11thing"]
+      expect(input.sort_by_alphanum).to eq ["3another", "004some10thing", "004some11thing"]
     end
 
     it 'can take a block which can transform values before comparison' do
-      ["004some11thing",
-       "004some10thing",
-       "3another"].sort_by_alphanum(&:reverse).should == ["004some10thing", "004some11thing", "3another"]
+      expect(input.sort_by_alphanum(&:reverse)).to eq ["004some10thing", "004some11thing", "3another"]
     end
 
     it 'compares number chunks as integers' do
-      %w(004 3).sort_by_alphanum.should == %w(3 004)
+      expect(%w(004 3).sort_by_alphanum).to eq %w(3 004)
     end
   end
-end
+end

data/spec/roqua/core_ext/fabrication/singleton_spec.rb

@@ -6,11 +6,13 @@ end
 
 describe Fabricate do
   it "returns singleton objects" do
-    Fabricate.singleton(:one).should == Fabricate.singleton(:one)
+    # Fabricate.singleton(:one).should == Fabricate.singleton(:one)
+    expect(Fabricate.singleton(:one)).to eq Fabricate.singleton(:one)
   end
 
   it 'maintains multiple singletons' do
-    Fabricate.singleton(:one).should_not == Fabricate.singleton(:two)
+    # Fabricate.singleton(:one).should_not == Fabricate.singleton(:two)
+    expect(Fabricate.singleton(:one)).not_to eq Fabricate.singleton(:two)
   end
 
   it 'clears singletons' do
@@ -19,4 +21,3 @@ describe Fabricate do
     expect(Fabricate.singleton(:one)).not_to eq(the_one)
   end
 end
-

data/spec/roqua/probes/delayed_job_probe_spec.rb

@@ -40,7 +40,7 @@ describe Roqua::Probes::DelayedJobProbe do
       expect { Roqua::Probes::DelayedJobProbe.enable }
         .to change { Appsignal::Minutely.probes.count }.by(1)
 
-      expect(Appsignal::Minutely.probes.map(&:class)).to include(Roqua::Probes::DelayedJobProbe)
+      expect(Appsignal::Minutely.probes[:"Roqua::Probes::DelayedJobProbe"]).to be
     end
 
     it 'will not add the same probe twice if called multiple times' do

data/spec/roqua/support/helpers_spec.rb

@@ -23,7 +23,7 @@ describe 'Helper methods' do
       end
 
       it 'returns the value returned by the block' do
-        with_instrumentation('testevent') { 1 + 1 }.should == 2
+        expect(with_instrumentation('testevent') { 1 + 1 }).to eq 2
       end
     end
 

data/spec/roqua/support/logwrapper_spec.rb

@@ -4,7 +4,7 @@ require 'stringio'
 
 module Roqua
   describe LogWrapper do
-    before { Roqua.stub(appname: 'roqua-support-testsuite') }
+    before { allow(Roqua).to receive(:appname).and_return('roqua-support-testsuite') }
 
     let(:logstream)  { StringIO.new }
     let(:logger)     { Logger.new(logstream) }
@@ -17,17 +17,17 @@ module Roqua
     describe '#add' do
       it 'writes event name to log' do
         logwrapper.add :info, "testevent"
-        log.should include("testevent {}\n")
+        expect(log).to include("testevent {}\n")
       end
 
       it 'writes given parameters as json hash' do
         logwrapper.add :info, "testevent", extra: 'params', go: 'here'
-        log.should include('testevent {"extra":"params","go":"here"}' + "\n")
+        expect(log).to include('testevent {"extra":"params","go":"here"}' + "\n")
       end
 
       it 'escapes newline characters in params' do
         logwrapper.add :info, "testevent", param: "this\nshould not have newlines"
-        log.should include('testevent {"param":"this\nshould not have newlines"')
+        expect(log).to include('testevent {"param":"this\nshould not have newlines"')
       end
     end
 
@@ -36,25 +36,25 @@ module Roqua
         logwrapper.lifecycle 'testevent', extra: 'params' do
           1 + 1
         end
-        log.should include('testevent:started {"extra":"params"}')
-        log.should match(/testevent:finished.*"extra":"params"/)
+        expect(log).to include('testevent:started {"extra":"params"}')
+        expect(log).to match(/testevent:finished.*"extra":"params"/)
       end
 
       it 'logs the duration of the block with the finished event' do
         logwrapper.lifecycle('testevent') { 1 + 1 }
-        log.should match(/testevent:finished.*"duration":/)
+        expect(log).to match(/testevent:finished.*"duration":/)
       end
 
       it 'returns the value returned by the block' do
-        logwrapper.lifecycle('testevent') { 1 + 1 }.should == 2
+        expect(logwrapper.lifecycle('testevent') { 1 + 1 }).to eq 2
       end
 
       it 'logs the start and failure of a block if it raises' do
         logwrapper.lifecycle 'testevent' do
           raise StandardError, "Foo"
         end rescue nil
-        log.should include('testevent:started')
-        log.should include('testevent:failed {"exception":"StandardError","message":"Foo"}')
+        expect(log).to include('testevent:started')
+        expect(log).to include('testevent:failed {"exception":"StandardError","message":"Foo"}')
       end
 
       it 'reraises the exception' do

data/spec/roqua/support/request_logger_spec.rb

@@ -8,7 +8,8 @@ describe Roqua::Support::RequestLogger do
   let(:logger)     { Logger.new(logstream) }
   let(:logwrapper) { Roqua::LogWrapper.new(logger) }
 
-  before { Roqua.stub(logger: logwrapper) }
+  # before { Roqua.stub(logger: logwrapper) }
+  before { allow(Roqua).to receive(:logger).and_return(logwrapper) }
 
   def log
     logstream.string
@@ -29,47 +30,47 @@ describe Roqua::Support::RequestLogger do
 
     it "logs the URL" do
       subscriber.process_action(event)
-      logstream.string.should include('/home')
+      expect(logstream.string).to include('/home')
     end
 
     it "does not log the query string" do
       subscriber.process_action(event)
-      logstream.string.should_not include('?foo=bar')
+      expect(logstream.string).to_not include('?foo=bar')
     end
 
     it "logs the HTTP method" do
       subscriber.process_action(event)
-      logstream.string.should include('"method":"GET"')
+      expect(logstream.string).to include('"method":"GET"')
     end
 
     it "logs the status code returned" do
       subscriber.process_action(event)
-      logstream.string.should include('"status":200')
+      expect(logstream.string).to include('"status":200')
     end
 
     it "logs the controller and action" do
       subscriber.process_action(event)
-      logstream.string.should include('"controller":"home","action":"index"')
+      expect(logstream.string).to include('"controller":"home","action":"index"')
     end
 
     it 'logs request parameters' do
       subscriber.process_action(event)
-      logstream.string.should include('"params":{"foo":"bar"}')
+      expect(logstream.string).to include('"params":{"foo":"bar"}')
     end
 
     it "logs how long the request took" do
       subscriber.process_action(event)
-      logstream.string.should =~ /"duration":1000.0/
+      expect(logstream.string).to match /"duration":1000.0/
     end
 
     it "logs the view rendering time" do
       subscriber.process_action(event)
-      logstream.string.should =~ /"view":0.01/
+      expect(logstream.string).to match /"view":0.01/
     end
 
     it "logs the database rendering time" do
       subscriber.process_action(event)
-      logstream.string.should =~ /"db":0.02/
+      expect(logstream.string).to match /"db":0.02/
     end
 
     it 'logs extra information added in the controller' do
@@ -82,12 +83,12 @@ describe Roqua::Support::RequestLogger do
       end
       controller.new.index
       subscriber.process_action(event)
-      logstream.string.should include('"current_user":"johndoe"')
+      expect(logstream.string).to include('"current_user":"johndoe"')
 
       # next request should not still maintain this data
       logstream.truncate 0
       subscriber.process_action(event)
-      logstream.string.should_not include('current_user')
+      expect(logstream.string).to_not include('current_user')
     end
   end
 
@@ -104,15 +105,15 @@ describe Roqua::Support::RequestLogger do
 
     it "logs the 500 status when an exception occurred" do
       subscriber.process_action(event)
-      logstream.string.should =~ /"status":500/
-      logstream.string.should =~ /"error":"AbstractController::ActionNotFound:Route not found"/
+      expect(logstream.string).to match /"status":500/
+      expect(logstream.string).to match /"error":"AbstractController::ActionNotFound:Route not found"/
     end
 
     it "should return an unknown status when no status or exception is found" do
       event.payload[:status] = nil
       event.payload[:exception] = nil
       subscriber.process_action(event)
-      logstream.string.should =~ /"status":0/
+      expect(logstream.string).to match /"status":0/
     end
   end
 
@@ -136,12 +137,12 @@ describe Roqua::Support::RequestLogger do
     it 'logs the redirect' do
       subscriber.redirect_to(redirect)
       subscriber.process_action(event)
-      log.should include('"location":"http://example.com"')
+      expect(log).to include('"location":"http://example.com"')
 
       # next request should no longer get location
       logstream.truncate 0
       subscriber.process_action(event)
-      log.should_not include('location')
+      expect(log).to_not include('location')
     end
   end
 end

data/spec/roqua/support_spec.rb

@@ -3,7 +3,7 @@ require 'roqua/support'
 describe Roqua do
   describe '#logger' do
     it 'has a default' do
-      Roqua.logger.should be_an_instance_of(Roqua::LogWrapper)
+      expect(Roqua.logger).to be_an_instance_of(Roqua::LogWrapper)
     end
   end
 
@@ -12,8 +12,8 @@ describe Roqua do
 
     it 'wraps a given logger' do
       Roqua.logger = logger
-      Roqua.logger.should be_an_instance_of(Roqua::LogWrapper)
-      Roqua.logger.logger.should == logger
+      expect(Roqua.logger).to be_an_instance_of(Roqua::LogWrapper)
+      expect(Roqua.logger.logger).to eq logger
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-support
 version: !ruby/object:Gem::Version
-  version: 0.1.34
+  version: 0.3.0
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-16 00:00:00.000000000 Z
+date: 2019-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_interaction
@@ -152,16 +152,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -207,11 +207,9 @@ files:
 - lib/roqua/core_ext/active_interaction/filters/duration_filter.rb
 - lib/roqua/core_ext/active_interaction/rails_instrumentation.rb
 - lib/roqua/core_ext/activerecord/uniq_find_or_create.rb
-- lib/roqua/core_ext/array/stable_sort_by.rb
 - lib/roqua/core_ext/delayed_job/activity_monitoring.rb
 - lib/roqua/core_ext/enumerable/sort_by_alphanum.rb
 - lib/roqua/core_ext/fabrication/singleton.rb
-- lib/roqua/core_ext/fixnum/clamp.rb
 - lib/roqua/logging/roqua_logging_railtie.rb
 - lib/roqua/probes/base_probe.rb
 - lib/roqua/probes/delayed_job_probe.rb
@@ -243,11 +241,9 @@ files:
 - spec/roqua/core_ext/active_interaction/duration_filter_spec.rb
 - spec/roqua/core_ext/active_interaction/rails_intrumentation_spec.rb
 - spec/roqua/core_ext/activerecord/uniq_find_or_create_spec.rb
-- spec/roqua/core_ext/array/stable_sort_by_spec.rb
 - spec/roqua/core_ext/delayed_job/activity_monitoring_spec.rb
 - spec/roqua/core_ext/enumerable/sort_by_alphanum_spec.rb
 - spec/roqua/core_ext/fabrication/singleton_spec.rb
-- spec/roqua/core_ext/fixnum/clamp_spec.rb
 - spec/roqua/logging/roqua_logging_railtie_spec.rb
 - spec/roqua/probes/delayed_job_probe_spec.rb
 - spec/roqua/probes/monitoring_probe_spec.rb
@@ -286,7 +282,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.9
 signing_key: 
 specification_version: 4
 summary: Helper objects and proxies used by a lot of RoQua applications
@@ -297,11 +293,9 @@ test_files:
 - spec/roqua/core_ext/active_interaction/duration_filter_spec.rb
 - spec/roqua/core_ext/active_interaction/rails_intrumentation_spec.rb
 - spec/roqua/core_ext/activerecord/uniq_find_or_create_spec.rb
-- spec/roqua/core_ext/array/stable_sort_by_spec.rb
 - spec/roqua/core_ext/delayed_job/activity_monitoring_spec.rb
 - spec/roqua/core_ext/enumerable/sort_by_alphanum_spec.rb
 - spec/roqua/core_ext/fabrication/singleton_spec.rb
-- spec/roqua/core_ext/fixnum/clamp_spec.rb
 - spec/roqua/logging/roqua_logging_railtie_spec.rb
 - spec/roqua/probes/delayed_job_probe_spec.rb
 - spec/roqua/probes/monitoring_probe_spec.rb

data/lib/roqua/core_ext/array/stable_sort_by.rb

@@ -1,37 +0,0 @@
-class Array
-  # Method for stably sorting elements in an array on multiple attributes.
-  #
-  # * Pass the method a block with two arrays containing the attributes for which the
-  #   elements should be subsequently sorted. The first attribute is applied last.
-  #   If for some attribute the sort order should be reversed, the parameters x and y can
-  #   be exchanged between the arrays.
-  #
-  # ==== Example
-  #   my_array.stable_sort_by{|x, y| [
-  #                            x.attribute1,
-  #                            y.attribute2,
-  #                            y.attribute3,
-  #                            y.attribute4
-  #                          ] <=> [
-  #                            y.attribute1,
-  #                            x.attribute2,
-  #                            x.attribute3,
-  #                            x.attribute4
-  #                          ]}
-  #
-  def stable_sort_by
-    sort do |x, y|
-      if not x
-        -1
-      elsif not y
-        1
-      else
-        if block_given?
-          yield x, y
-        else
-          x <=> y
-        end
-      end
-    end
-  end
-end

data/lib/roqua/core_ext/fixnum/clamp.rb

@@ -1,8 +0,0 @@
-class Fixnum
-  def clamp(low, high)
-    raise "Low (#{low}) must be lower than high (#{high})" unless low < high
-    return low if self < low
-    return high if self > high
-    self
-  end
-end

data/spec/roqua/core_ext/array/stable_sort_by_spec.rb

@@ -1,40 +0,0 @@
-require 'roqua/core_ext/array/stable_sort_by'
-
-describe Array do
-  describe "#stable_sort_by" do
-    it "wraps #sort" do
-      array = []
-      array.should_receive(:sort)
-      array.stable_sort_by
-    end
-
-    it "sorts nil values before all others" do
-      [1, nil, 3].stable_sort_by.should == [nil, 1, 3]
-    end
-
-    it "defaults to regular comparison" do
-      [1, 3, 2].stable_sort_by.should == [1, 2, 3]
-    end
-
-    it "accepts a block to do complex comparison" do
-      [{a: 2, b: 2, c: 3},
-       {a: 2, b: 2, c: 4},
-       {a: 1, b: 1, c: 6}].stable_sort_by do |x, y|
-        [x[:a], x[:b], x[:c]] <=> [y[:a], y[:b], y[:c]]
-       end.should == [{a: 1, b: 1, c: 6},
-                      {a: 2, b: 2, c: 3},
-                      {a: 2, b: 2, c: 4}]
-    end
-
-    it "leaves items in original order if they are the same" do
-      [{a: 2, b: 2, c: 4},
-       {a: 2, b: 1, c: 3},
-       {a: 1, b: 3, c: 6}].sort do |x, y|
-        [x[:a], x[:b]] <=> [y[:a], y[:b]]
-       end.should == [{a: 1, b: 3, c: 6},
-                      {a: 2, b: 1, c: 3},
-                      {a: 2, b: 2, c: 4}]
-
-    end
-  end
-end

data/spec/roqua/core_ext/fixnum/clamp_spec.rb

@@ -1,23 +0,0 @@
-require 'roqua/core_ext/fixnum/clamp'
-
-describe Fixnum do
-  describe '#clamp' do
-    it "returns self if within bounds" do
-      5.clamp(1,10).should == 5
-    end
-
-    it "returns the lower bound if self < low" do
-      5.clamp(8,10).should == 8
-    end
-
-    it "returns the upper bound if self > high" do
-      5.clamp(1,3).should == 3
-    end
-
-    it "should raise an exception if the lower bound is greater than the upper bound" do
-      expect {
-        5.clamp(10,1)
-      }.to raise_error
-    end
-  end
-end