roqua-support 0.1.2.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0ac53c450b17e874859934e55be62b8ddc7ae00d
-  data.tar.gz: 2f54b672a70529b33ee906ee88788c3f736e98ec
+  metadata.gz: 43a3414d9e81150939fa2856d06119486f2901e2
+  data.tar.gz: 0045f7cbe60fd4bf49ca7aea4eb53aaffcd5b1ad
 SHA512:
-  metadata.gz: 144657fabc0578bd624c3e28a098da7c3f8623791c87cf1bb40dd5433bbb21e6179c663c201699bf9ef08f87a712363a54a522c1c7c3b765d567005fd2f4bdc6
-  data.tar.gz: 9f26d2f6fb732c0fc89f54619371d12e45804cff76099f1b708ebfccf63c373c9426a51e89e984197ac64e8eaa890354621583e1e1d46f5a1ee4ce9608fa5bef
+  metadata.gz: 5598469b76b2db4761c05b40ba12d533dac4a85160537fd7c6da0b8eeeaefeead355fef69e7c6c9abc8566b28e090dcc3eb344e1b15541c06addadbe60524f15
+  data.tar.gz: d27f814a7fee1c1009656f386d547c0df7a05612dfba06c330513a4e4e5ace7ed5fefc90570975b0aca573273248ff05f7d0370a463867b12cc1e233f175e9c7

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.3 / 2014-02-24
+
+* Add ActiveRecord \#uniq\_find\_or\_create\_by method to find or create records with uniqueness constraints enforced by the database.
+
 ## 0.1.2.1
 
 * Bugfixes for Errors.

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    roqua-support (0.1.2.2)
+    roqua-support (0.1.3)
       activesupport (>= 3.2, < 5.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (4.0.2)
+    activesupport (4.0.3)
       i18n (~> 0.6, >= 0.6.4)
       minitest (~> 4.2)
       multi_json (~> 1.3)
@@ -24,9 +24,9 @@ GEM
       rspec-expectations (~> 2.14.0)
       rspec-mocks (~> 2.14.0)
     rspec-core (2.14.7)
-    rspec-expectations (2.14.4)
+    rspec-expectations (2.14.5)
       diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.4)
+    rspec-mocks (2.14.6)
     thread_safe (0.1.3)
       atomic
     tzinfo (0.3.38)

data/lib/roqua-support/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module Support
-    VERSION = "0.1.2.2"
+    VERSION = "0.1.3"
   end
 end

data/lib/roqua/core_ext/activerecord/uniq_find_or_create.rb

@@ -0,0 +1,12 @@
+require 'active_support'
+
+module ActiveRecord
+  class Base
+    def self.uniq_find_or_create_by(attributes, &block)
+      record = find_or_create_by(attributes, &block)
+    rescue ActiveRecord::RecordNotUnique
+    ensure
+      return find_by(attributes) || record
+    end
+  end
+end

data/spec/roqua/core_ext/activerecord/uniq_find_or_create_spec.rb

@@ -0,0 +1,41 @@
+require 'roqua/core_ext/activerecord/uniq_find_or_create'
+
+module ActiveRecord
+  class Base
+    def self.find_by(attributes)
+    end
+  end
+
+  class RecordNotUnique < StandardError
+  end
+end
+
+describe ActiveRecord::Base do
+  describe '#uniq_find_or_create_by' do
+    let(:attributes) { double('attributes') }
+    let(:block)      { -> {} }
+    let(:record)     { double('record') }
+
+    it 'tries to find or create a record by the attributes provided' do
+      expect(ActiveRecord::Base).to receive(:find_or_create_by).with(attributes, &block)
+      ActiveRecord::Base.uniq_find_or_create_by attributes, &block
+    end
+
+    it 'returns a preexisting or created record by querying it' do
+      allow(ActiveRecord::Base).to receive(:find_by).with(attributes).and_return record
+      expect(ActiveRecord::Base.uniq_find_or_create_by attributes, &block).to eq(record)
+    end
+
+    it 'returns a concurrenlty created record' do
+      allow(ActiveRecord::Base).to receive(:find_by).with(attributes).and_return record
+      allow(ActiveRecord::Base).to receive(:find_or_create_by).with(attributes, &block)
+                                                              .and_raise ActiveRecord::RecordNotUnique
+      expect(ActiveRecord::Base.uniq_find_or_create_by attributes, &block).to eq(record)
+    end
+
+    it 'returns a created record for inspection when saving fails for some reason' do
+      allow(ActiveRecord::Base).to receive(:find_or_create_by).with(attributes, &block).and_return record
+      expect(ActiveRecord::Base.uniq_find_or_create_by attributes, &block).to eq(record)
+    end
+  end
+end

data/spec/roqua/support/errors_spec.rb

@@ -36,6 +36,7 @@ describe 'Error reporting' do
 
     it 'sends notifications to appsignal' do
       stub_const("Appsignal", Module.new)
+      Appsignal.stub(active?: true)
       Appsignal.stub(is_ignored_exception?: false, agent: agent)
       stub_const("Appsignal::Transaction", double("Transaction", create: transaction))
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-support
 version: !ruby/object:Gem::Version
-  version: 0.1.2.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-12 00:00:00.000000000 Z
+date: 2014-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -95,6 +95,7 @@ files:
 - Rakefile
 - lib/roqua-support.rb
 - lib/roqua-support/version.rb
+- lib/roqua/core_ext/activerecord/uniq_find_or_create.rb
 - lib/roqua/core_ext/array/stable_sort_by.rb
 - lib/roqua/core_ext/enumerable/sort_by_alphanum.rb
 - lib/roqua/core_ext/fabrication/singleton.rb
@@ -106,6 +107,7 @@ files:
 - lib/roqua/support/logging.rb
 - lib/roqua/support/request_logger.rb
 - roqua-support.gemspec
+- spec/roqua/core_ext/activerecord/uniq_find_or_create_spec.rb
 - spec/roqua/core_ext/array/stable_sort_by_spec.rb
 - spec/roqua/core_ext/enumerable/sort_by_alphanum_spec.rb
 - spec/roqua/core_ext/fabrication/singleton_spec.rb
@@ -139,6 +141,7 @@ signing_key:
 specification_version: 4
 summary: Helper objects and proxies used by a lot of RoQua applications
 test_files:
+- spec/roqua/core_ext/activerecord/uniq_find_or_create_spec.rb
 - spec/roqua/core_ext/array/stable_sort_by_spec.rb
 - spec/roqua/core_ext/enumerable/sort_by_alphanum_spec.rb
 - spec/roqua/core_ext/fabrication/singleton_spec.rb