roqua-rom-api 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16fc5f0f04495f71a7a5658cdcd60939d44b7d89
-  data.tar.gz: ff78fb08b0c1fe66a2745c38f376d0c79068e759
+  metadata.gz: 9dabec741f6720854b9fa8a54c4bf4810111ffd7
+  data.tar.gz: 6a1df4977729a20a1154ef4525bf36f39e3772ee
 SHA512:
-  metadata.gz: 24e8e9bad8b0c40ee0a1ce2bc4b1b6595ac3af61823f8160dacbe2309a4a32e9c4c837ce707824746dc83eca74dcc9be00d7794ed1d82626d429b440b2e31761
-  data.tar.gz: c3cd6a83c3b7806db832b30ae6cb701633ec4742c8a6ebdc969e85218064d7769e4327bac72ba81959d5b1591d28efde0d7e65671765b6b0fcd9fdd3eb402b53
+  metadata.gz: 590dd708649de58c19626ab1c28c370d15087715dd2ff1496f869b24cbd57875d2c4963ba2d28eb82328bb001b4ef53ab4812b572d8794506e53e6d1aad8ac0e
+  data.tar.gz: f7be56cfc8cc587fcf8f0f8e527c47ead80890aa04b0182a96ddd1f2b9a73869b39956750bec3dff3c40a267be2eedd7c474d1e7c649822e235c40251810ec17

data/ChangeLog.md

@@ -1,4 +1,8 @@
-##$ 0.0.5 / 2014-03-12
+### 0.0.6 / 2014-03-12
+
+* Fix ProtocolSubscription api return value
+
+### 0.0.5 / 2014-03-12
 
 * Remove RoQua prefix from env vars
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    roqua-rom-api (0.0.5)
+    roqua-rom-api (0.0.6)
       active_interaction (~> 1.0.4)
       httparty (~> 0.12.0)
 

data/lib/roqua/rom_api/start_protocol_subscription.rb

@@ -10,9 +10,7 @@ module Roqua
         options = {dossier_id: dossier_id,
                    protocol_key: protocol_key}
         options[:start_at] = start_at.to_i if start_at
-        response = RomApi.basic_auth_session.post '/protocol_subscriptions', options
-        fail response.parsed_response.inspect unless (200..299).include? response.code
-        response
+        RomApi.basic_auth_session.post('/protocol_subscriptions', options).parsed_response
       end
     end
   end

data/lib/roqua/rom_api/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module RomApi
-    VERSION = '0.0.5'
+    VERSION = '0.0.6'
   end
 end

data/spec/lib/roqua/rom_api/start_protocol_subscription_spec.rb

@@ -3,13 +3,17 @@ require 'spec_helper'
 describe StartProtocolSubscription do
   let(:options) { {dossier_id: 'some_dossier_id', protocol_key: 'some_key'} }
   let(:session) { Sessions::BasicAuthSession.new }
-  before { allow(Sessions::BasicAuthSession).to receive(:new).and_return session }
+  let(:parsed_response) { double('parsed_response') }
+  let(:response) { double('response', parsed_response: parsed_response) }
+  before do
+    allow(Sessions::BasicAuthSession).to receive(:new).and_return session
+    allow(session).to receive(:post).and_return response
+  end
 
   it 'does a post to the rom protocol_subscription api' do
     expect(session).to receive(:post).with('/protocol_subscriptions', dossier_id: options[:dossier_id],
                                                                       protocol_key: options[:protocol_key])
-                                     .and_return double('response', code: 200)
-    StartProtocolSubscription.run(options)
+    StartProtocolSubscription.run!(options)
   end
 
   it 'passes in the start_at option when provided' do
@@ -17,12 +21,10 @@ describe StartProtocolSubscription do
     expect(session).to receive(:post).with('/protocol_subscriptions', dossier_id: options[:dossier_id],
                                                                       protocol_key: options[:protocol_key],
                                                                       start_at: start_at.to_i)
-                                     .and_return double('response', code: 200)
-    StartProtocolSubscription.run(options.merge start_at: start_at)
+    StartProtocolSubscription.run!(options.merge start_at: start_at)
   end
 
-  it 'raises when the response HTTP status is not in the 200 range' do
-    allow(session).to receive(:post).and_return double('response', code: 401)
-    expect { StartProtocolSubscription.run(options) }.to raise_error
+  it 'returns the parsed response' do
+    expect(StartProtocolSubscription.run!(options)).to eq(parsed_response)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roqua-rom-api
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Samuel Esposito