roqua-core-api 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aac3ceb72c90b7a84b630bff828aae009bcb05f8
-  data.tar.gz: be357478b0c60d82552a9bd250dbf39a95655cc6
+  metadata.gz: afcb8f55c765892ee686c50b9b069af7a42242cc
+  data.tar.gz: 231798c7c1c9f410237f4d9f4d683be12d3c8188
 SHA512:
-  metadata.gz: 607a42369fdcdd4d543b707a0c7f83ab34f412824333b6c7327e31c6703a3e93b778d421593da9daf2253e4bf6effa9ff9cc0a418cc3480b2adcc69a90d3d542
-  data.tar.gz: 9d590a27852e4818192b1e05a6e5ba835c61fc55ac1a308cb5a93d62fd329d4cfcc9f83eabae7aea0fd363ae1c567a51187310b13d588e02ecf6f35f8756ae38
+  metadata.gz: 053913480e04a70b7e0521b65ebc4bfac5fcb1901efcd7864a34e98642f1570e8c186bf54fd65271b88ead86d982c6e9575dd677d340efc4cfe43102770d7764
+  data.tar.gz: 9eb9cd12a83f09c7a8e956098b42d305ea639020a085eb3240403b90599b743951f5b442d140199eca9f743224f0f2f27a63c036707d75bd0ae7f22708311a91

data/ChangeLog.md

@@ -1,4 +1,6 @@
-* Added TokenSession model and CreateTokenSession, DestroyTokenSession usecases.
+### 0.2.1
+
+* Allow SendInviteEmail to receive a person_id instead of a dossier_id
 
 ### 0.2.0
 
@@ -7,6 +9,7 @@ Active interaction to v2.
 ### 0.1.1
 
 * Add token session.
+* Added TokenSession model and CreateTokenSession, DestroyTokenSession usecases.
 
 ### 0.1.0
 

data/config/locales/validation_errors.yml

@@ -22,13 +22,14 @@ nl:
       odd: moet oneven zijn
       record_invalid: ! 'Validatie mislukt: %{errors}'
       taken: is al in gebruik
-      too_long: is te lang (maximaal %{count} tekens)
-      too_short: is te kort (minimaal %{count} tekens)
+      too_long: is te lang
+      too_short: is te kort
       wrong_length: heeft onjuiste lengte (moet %{count} tekens lang zijn)
       invalid_key: mag enkel kleine letters, cijfers en underscores bevatten en moet beginnen met een letter.
       valid_ip_addresses: moeten geldige IP-adressen zijn
       invalid_email: Geen geldig email adres
       invalid_date: Niet een bestaande datum
+      already_exists: Bestaat al
     template:
       body: ! 'Controleer de volgende velden:'
       header:

data/lib/roqua/core_api/create_dossier.rb

@@ -6,13 +6,17 @@ module Roqua
       string :dossier_group_id
       object :dossier, class: Models::Dossier, default: nil
       object :person, class: Models::Person, default: nil
+      object :credential, class: Models::Credential, default: nil
 
       def execute
         response = session.post "/dossier_groups/#{dossier_group_id}/dossiers",
-                                person: person_attributes, dossier: dossier_attributes
+                                person: attribute_hash(person),
+                                dossier: dossier_attributes,
+                                credential: attribute_hash(credential)
         if response.code == 422
           errors_to_object(response, person)
           errors_to_object(response, dossier)
+          errors_to_object(response, credential)
         end
         Models::Dossier.new(response)
       end
@@ -24,9 +28,9 @@ module Roqua
         dossier.serializable_hash(except: :people).keep_if { |_k, v| !v.nil? }
       end
 
-      def person_attributes
-        return {} unless person
-        person.serializable_hash.keep_if { |_k, v| !v.nil? }
+      def attribute_hash(obj)
+        return {} unless obj
+        obj.serializable_hash.keep_if { |_k, v| !v.nil? }
       end
     end
   end

data/lib/roqua/core_api/models/credential.rb

@@ -0,0 +1,10 @@
+require 'virtus'
+
+class Roqua::CoreApi::Models::Credential < Roqua::CoreApi::Models::ActiveVirtus
+  attribute :id, String
+  attribute :username
+  attribute :password
+  attribute :password_confirmation
+
+  validates :password, confirmation: true
+end

data/lib/roqua/core_api/models.rb

@@ -3,4 +3,5 @@ require 'active_model'
 require 'roqua/core_api/models/active_virtus'
 require 'roqua/core_api/models/person'
 require 'roqua/core_api/models/dossier'
+require 'roqua/core_api/models/credential'
 require 'roqua/core_api/models/export'

data/lib/roqua/core_api/send_invite_email.rb

@@ -3,16 +3,27 @@ module Roqua
     # @api private
     class SendInviteEmail < ActiveInteraction::Base
       object :session, class: Sessions::AuthSession
-      string :dossier_id
+      string :dossier_id, default: nil
+      string :person_id, default: nil
       string :email_subject, default: nil
       string :email_body, default: nil
 
+      validates :person_id, presence: true, unless: :dossier_id?
+
       def execute
-        session.post "/dossiers/#{dossier_id}/send_invite_email", params
+        session.post url, params
       end
 
       private
 
+      def url
+        if person_id
+          "/people/#{person_id}/send_invite_email"
+        else
+          "/dossiers/#{dossier_id}/send_invite_email"
+        end
+      end
+
       def params
         {
           email_subject: email_subject, email_body: email_body

data/lib/roqua/core_api/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module CoreApi
-    VERSION = '0.2.0'
+    VERSION = '0.2.1'
   end
 end

data/spec/lib/roqua/core_api/create_dossier_spec.rb

@@ -51,18 +51,23 @@ describe CreateDossier do
 
   describe 'with validation errors' do
     let(:response) { httparty_response({'errors' => {'person' => {'email' => ['invalid_email']},
-                                                     'dossier' => {'external_identifier' => ['blank']}}},
+                                                     'dossier' => {'external_identifier' => ['blank']},
+                                                     'credential' => {'password' => ['too_short']}}},
                                        422) }
+    let(:credential) { Roqua::CoreApi::Models::Credential.new \
+                         username: 'foobar', password: '123', password_confirmation: '123' }
 
-    it 'Set the errors on the objects' do
+    it 'sets the errors on the objects' do
       allow(session).to receive(:post).and_return(response)
       new_dossier = CreateDossier.run!(session: session,
                                        person: person,
                                        dossier: dossier,
+                                       credential: credential,
                                        dossier_group_id: 'some_dossier_group_id')
       expect(new_dossier.persisted?).to be_falsy
       expect(person.errors[:email]).to eq ['Geen geldig email adres']
       expect(dossier.errors[:external_identifier]).to eq ['moet opgegeven zijn']
+      expect(credential.errors[:password]).to eq ['is te kort']
     end
   end
 end

data/spec/lib/roqua/core_api/send_invite_email_spec.rb

@@ -3,12 +3,43 @@ require 'spec_helper'
 describe SendInviteEmail do
   let(:session) { Fabricate :roqua_core_api_oauth_session }
 
-  it 'performs a post on the send_invite_email api path' do
-    expect(session).to receive(:post).with '/dossiers/some_dossier_id/send_invite_email',
-                                           email_subject: 'account created',
-                                           email_body: 'visit %create_account_link% to set password'
-    SendInviteEmail.run!(session: session, dossier_id: 'some_dossier_id',
-                         email_subject: 'account created',
-                         email_body: 'visit %create_account_link% to set password')
+  context 'Dossier' do
+    subject { SendInviteEmail.run! \
+                session: session,
+                dossier_id: 'some_dossier_id',
+                email_subject: 'account created',
+                email_body: 'visit %create_account_link% to set password' }
+    it 'performs a post on the send_invite_email api path' do
+      expect(session).to receive(:post).with '/dossiers/some_dossier_id/send_invite_email',
+                                             email_subject: 'account created',
+                                             email_body: 'visit %create_account_link% to set password'
+      subject
+    end
+  end
+
+  context "Person" do
+    subject { SendInviteEmail.run! \
+                session: session,
+                person_id: 'some_person_id',
+                email_subject: 'account created',
+                email_body: 'visit %create_account_link% to set password' }
+    it 'performs a post on the send_invite_email api path' do
+      expect(session).to receive(:post).with '/people/some_person_id/send_invite_email',
+                                             email_subject: 'account created',
+                                             email_body: 'visit %create_account_link% to set password'
+      subject
+    end
+  end
+
+  context "Neither Dossier nor Person" do
+    subject { SendInviteEmail.run \
+                session: session,
+                email_subject: 'account created',
+                email_body: 'visit %create_account_link% to set password' }
+
+    it 'performs a post on the send_invite_email api path' do
+      expect(subject).to be_invalid
+      expect(subject.errors).to include :person_id
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roqua-core-api
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-17 00:00:00.000000000 Z
+date: 2016-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -198,6 +198,7 @@ files:
 - lib/roqua/core_api/list_dossier_group_rights.rb
 - lib/roqua/core_api/models.rb
 - lib/roqua/core_api/models/active_virtus.rb
+- lib/roqua/core_api/models/credential.rb
 - lib/roqua/core_api/models/dossier.rb
 - lib/roqua/core_api/models/dossier_group.rb
 - lib/roqua/core_api/models/export.rb