roqua-core-api 0.0.16 → 0.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d2f0bc90e2d82c735a5ee7de9f41a34dd947f44
-  data.tar.gz: 846e6fad4b6e51fe581e8aa0dcab3bf00ac6c1ee
+  metadata.gz: 50c40344f6697004903f2952c40768b4dd5ce8e2
+  data.tar.gz: 31e41c1d5826c1a774c51a800aeb7aed08f1abd9
 SHA512:
-  metadata.gz: 13cfe5d94986414a25ac6ed16a193e2ec07dd4a8cb0b17051fb192c4383621d7e7dd4fa46ab517e83fe4d063787f8e2195c3e5177370398e3e878e5faca1fb3c
-  data.tar.gz: 75657185a13034f25c60d547174de264f8c79c07cc10c5f81491182318439af29b02281dee9ddfc2be4c9fb564d3afdd23ea16415c1d6fca7e0219d3e498a26f
+  metadata.gz: 9dba8ce70e38185f9d35800e0f113e931fdc84a8fec4f3c90b96750f2617890fed0230b62b920db1c3c8665ea454508a13fcae9ec3600988f8ad4cb7c62b7df3
+  data.tar.gz: 608ee4473cab2d2612057584a938bf23793bbc5f1c2d5da59dd8825e8795d53f24dd0d50e566ede53871e427b60499c9dc8c13875164698865ad3f5b6e948792

data/ChangeLog.md

@@ -1,3 +1,7 @@
+### 0.0.17 / 2014-03-13
+
+* Now getting environment variables using ENV.fetch, so you will get errors if they are missing
+
 ### 0.0.16 / 2014-03-13
 
 * Added NoSession and Unauthorized errors, and throwing them when applicable.

data/core_api.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec',       '~> 3.0.0.beta1'
   gem.add_development_dependency 'fabrication', '~> 2.9'
   gem.add_development_dependency 'webmock',     '~> 1.17'
+  gem.add_development_dependency 'dotenv',      '~> 0.10'
 end

data/lib/roqua/core_api/sessions/auth_session.rb

@@ -2,12 +2,12 @@ module Roqua
   module CoreApi
     module Sessions
       class AuthSession
-        attr_reader :core_host
+        attr_reader :core_site
         attr_reader :default_timeout
 
         # timeout for requests in seconds
-        def initialize(core_host: ENV['CORE_HOST'], timeout: nil)
-          @core_host = core_host
+        def initialize(core_site: ENV.fetch('CORE_SITE'), timeout: nil)
+          @core_site = core_site
           @default_timeout = timeout
         end
 
@@ -52,7 +52,7 @@ module Roqua
         end
 
         def full_url_for(path)
-          core_host + api_base + path + '.json'
+          core_site + api_base + path + '.json'
         end
 
         def api_base

data/lib/roqua/core_api/sessions/basic_auth_session.rb

@@ -5,7 +5,7 @@ module Roqua
         attr_reader :username
         attr_reader :password
 
-        def initialize(username: ENV['CORE_KEY'], password: ENV['CORE_SECRET'], **additional_arguments)
+        def initialize(username: ENV.fetch('CORE_KEY'), password: ENV.fetch('CORE_SECRET'), **additional_arguments)
           @username = username
           @password = password
           super additional_arguments

data/lib/roqua/core_api/sessions/oauth_session.rb

@@ -10,7 +10,7 @@ module Roqua
         end
 
         def logout_url(return_to:)
-          "#{core_host}/session/destroy?token=#{access_token}&redirect_to=#{CGI.escape return_to}"
+          "#{core_site}/session/destroy?token=#{access_token}&redirect_to=#{CGI.escape return_to}"
         end
 
         private

data/lib/roqua/core_api/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module CoreApi
-    VERSION = "0.0.16"
+    VERSION = "0.0.17"
   end
 end

data/lib/roqua/omniauth/rails_initializer.rb

@@ -12,8 +12,8 @@ Rails.application.config.middleware.use OmniAuth::Builder do
              client_options: {site: 'http://core.dev'}
   else
     provider :doorkeeper,
-             ENV['CORE_OAUTH_CLIENT_ID'],
-             ENV['CORE_OAUTH_CLIENT_SECRET'],
-             client_options: {site: ENV['CORE_OAUTH_URL']}
+             ENV.fetch('CORE_OAUTH_CLIENT_ID'),
+             ENV.fetch('CORE_OAUTH_CLIENT_SECRET'),
+             client_options: {site: ENV.fetch('CORE_OAUTH_URL')}
   end
 end

data/spec/fabricators/auth_session_fabricator.rb

@@ -1,3 +1,3 @@
 Fabricator(:auth_session, from: Roqua::CoreApi::Sessions::AuthSession) do
-  initialize_with { Roqua::CoreApi::Sessions::AuthSession.new core_host: 'http://core.dev' }
+  initialize_with { Roqua::CoreApi::Sessions::AuthSession.new core_site: 'http://core.dev' }
 end

data/spec/fabricators/basic_auth_session_fabricator.rb

@@ -2,6 +2,6 @@ Fabricator(:basic_auth_session, from: Roqua::CoreApi::Sessions::BasicAuthSession
   initialize_with do
     Roqua::CoreApi::Sessions::BasicAuthSession.new username: 'some_username',
                                                    password: 'some_password',
-                                                   core_host: 'http://core.dev'
+                                                   core_site: 'http://core.dev'
   end
 end

data/spec/fabricators/oauth_session_fabricator.rb

@@ -1,5 +1,5 @@
 Fabricator(:oauth_session, from: Roqua::CoreApi::Sessions::OAuthSession) do
   initialize_with do
-    Roqua::CoreApi::Sessions::OAuthSession.new access_token: 'some_access_token', core_host: 'http://core.dev'
+    Roqua::CoreApi::Sessions::OAuthSession.new access_token: 'some_access_token', core_site: 'http://core.dev'
   end
 end

data/spec/lib/roqua/core_api/sessions/auth_session_spec.rb

@@ -6,17 +6,17 @@ describe AuthSession do
   let(:response) { double('response', code: 201, parsed_response: 'some_response') }
 
   describe '#initialize' do
-    it 'sets the core_host instance attribute' do
-      session = AuthSession.new core_host: 'some_core_host'
-      expect(session.core_host).to eq('some_core_host')
+    it 'sets the core_site instance attribute' do
+      session = AuthSession.new core_site: 'some_core_site'
+      expect(session.core_site).to eq('some_core_site')
     end
 
-    it 'defaults the core_host to the CORE_HOST env variable' do
-      orginal_env_core_host = ENV['CORE_HOST']
-      ENV['CORE_HOST'] = 'some_env_core_host'
+    it 'defaults the core_site to the CORE_SITE env variable' do
+      original_env_core_site = ENV['CORE_SITE']
+      ENV['CORE_SITE'] = 'some_env_core_site'
       session = AuthSession.new
-      ENV['CORE_HOST'] = orginal_env_core_host
-      expect(session.core_host).to eq('some_env_core_host')
+      ENV['CORE_SITE'] = original_env_core_site
+      expect(session.core_site).to eq('some_env_core_site')
     end
 
     it 'sets the default timeout' do

data/spec/lib/roqua/core_api/sessions/basic_auth_session_spec.rb

@@ -8,10 +8,10 @@ describe BasicAuthSession do
     end
 
     it 'defaults the username to the CORE_KEY env variable' do
-      orginal_env_core_key = ENV['CORE_KEY']
+      original_env_core_key = ENV['CORE_KEY']
       ENV['CORE_KEY'] = 'some_env_core_key'
       session = Roqua::CoreApi.basic_auth_session
-      ENV['CORE_KEY'] = orginal_env_core_key
+      ENV['CORE_KEY'] = original_env_core_key
       expect(session.username).to eq('some_env_core_key')
     end
 
@@ -21,24 +21,24 @@ describe BasicAuthSession do
     end
 
     it 'defaults the password to the CORE_SECRET env variable' do
-      orginal_env_core_secret = ENV['CORE_SECRET']
+      original_env_core_secret = ENV['CORE_SECRET']
       ENV['CORE_SECRET'] = 'some_env_core_secret'
       session = Roqua::CoreApi.basic_auth_session
-      ENV['CORE_SECRET'] = orginal_env_core_secret
+      ENV['CORE_SECRET'] = original_env_core_secret
       expect(session.password).to eq('some_env_core_secret')
     end
 
-    it 'allows to override the core_host variable' do
-      session = Roqua::CoreApi.basic_auth_session core_host: 'some_core_host'
-      expect(session.core_host).to eq('some_core_host')
+    it 'allows to override the core_site variable' do
+      session = Roqua::CoreApi.basic_auth_session core_site: 'some_core_site'
+      expect(session.core_site).to eq('some_core_site')
     end
 
-    it 'defaults the AuthSession core_host CORE_HOST env variable default value' do
-      orginal_env_core_host = ENV['CORE_HOST']
-      ENV['CORE_HOST'] = 'some_env_core_host'
+    it 'defaults the AuthSession core_site CORE_SITE env variable default value' do
+      orginal_env_core_site = ENV['CORE_SITE']
+      ENV['CORE_SITE'] = 'some_env_core_site'
       session = Roqua::CoreApi.basic_auth_session
-      ENV['CORE_HOST'] = orginal_env_core_host
-      expect(session.core_host).to eq('some_env_core_host')
+      ENV['CORE_SITE'] = orginal_env_core_site
+      expect(session.core_site).to eq('some_env_core_site')
     end
   end
 

data/spec/lib/roqua/core_api/sessions/oauth_session_spec.rb

@@ -10,17 +10,17 @@ describe OAuthSession do
       expect(session.access_token).to eq('some_access_token')
     end
 
-    it 'allows to override the core_host variable' do
-      session = Roqua::CoreApi.oauth_session access_token: 'some_access_token', core_host: 'some_core_host'
-      expect(session.core_host).to eq('some_core_host')
+    it 'allows to override the core_site variable' do
+      session = Roqua::CoreApi.oauth_session access_token: 'some_access_token', core_site: 'some_core_site'
+      expect(session.core_site).to eq('some_core_site')
     end
 
-    it 'defaults the AuthSession core_host CORE_HOST env variable default value' do
-      orginal_env_core_host = ENV['CORE_HOST']
-      ENV['CORE_HOST'] = 'some_env_core_host'
+    it 'defaults the AuthSession core_site CORE_SITE env variable default value' do
+      original_env_core_site = ENV['CORE_SITE']
+      ENV['CORE_SITE'] = 'some_env_core_site'
       session = Roqua::CoreApi.oauth_session access_token: 'some_access_token'
-      ENV['CORE_HOST'] = orginal_env_core_host
-      expect(session.core_host).to eq('some_env_core_host')
+      ENV['CORE_SITE'] = original_env_core_site
+      expect(session.core_site).to eq('some_env_core_site')
     end
   end
 

data/spec/spec_helper.rb

@@ -1,5 +1,9 @@
 require 'rspec'
 require 'fabrication'
+
+require 'dotenv'
+Dotenv.load(File.expand_path("../../.env", File.dirname(__FILE__)))
+
 require 'roqua-core-api'
 include Roqua::CoreApi
 include Roqua::CoreApi::Sessions

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roqua-core-api
 version: !ruby/object:Gem::Version
-  version: 0.0.16
+  version: 0.0.17
 platform: ruby
 authors:
 - Marten Veldthuis
@@ -150,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.17'
+- !ruby/object:Gem::Dependency
+  name: dotenv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
 description: Provides authenticated access to Core
 email: marten@veldthuis.com
 executables: []
@@ -220,7 +234,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.1
 signing_key: 
 specification_version: 4
 summary: API wrapper gem around Core's API