roqua-core-api 0.0.15 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91c210b5761692fb51a318b62e810c00bfeeb7c5
-  data.tar.gz: b8d03f0d6bdb6b38002dc1b68ab96156ea83ad0a
+  metadata.gz: 1d2f0bc90e2d82c735a5ee7de9f41a34dd947f44
+  data.tar.gz: 846e6fad4b6e51fe581e8aa0dcab3bf00ac6c1ee
 SHA512:
-  metadata.gz: c270093ec8d41ae6f68f2670fa7fb02d9d3c3847adc63631291dc9b7b466f62f2da1f2e6523ac958f87f92da0a896a7097c895f558d3318b3c8a0907b01a9c49
-  data.tar.gz: ac7a95ddbd8f817e127463c7d15eb99220ecbffa57dba7f0c8f9f70fc1648ee0db7dd06421657c2d7dcc7ad85ff7aa145ab16995ceb7c0c30509550b20ea91d6
+  metadata.gz: 13cfe5d94986414a25ac6ed16a193e2ec07dd4a8cb0b17051fb192c4383621d7e7dd4fa46ab517e83fe4d063787f8e2195c3e5177370398e3e878e5faca1fb3c
+  data.tar.gz: 75657185a13034f25c60d547174de264f8c79c07cc10c5f81491182318439af29b02281dee9ddfc2be4c9fb564d3afdd23ea16415c1d6fca7e0219d3e498a26f

data/ChangeLog.md

@@ -1,3 +1,7 @@
+### 0.0.16 / 2014-03-13
+
+* Added NoSession and Unauthorized errors, and throwing them when applicable.
+
 ### 0.0.15 / 2014-03-13
 
 * fix session return_to
@@ -59,4 +63,4 @@
 
 * Initial release:
 
-Here be dragons
+Here be dragons

data/Gemfile

@@ -1,6 +1,10 @@
 source 'https://rubygems.org'
 
 gemspec
+gem 'httparty',           '= 0.12.0'
+gem 'active_interaction', '= 1.1.0'
+gem 'omniauth-oauth2',    '= 1.1.0'
+gem 'virtus',             '= 1.0.0'
 
 group :development do
   gem 'kramdown'

data/core_api.gemspec

@@ -18,13 +18,14 @@ Gem::Specification.new do |gem|
   gem.require_paths = ['lib']
 
   gem.add_dependency 'httparty',           '~> 0.12.0'
-  gem.add_dependency 'active_interaction', '~> 1.1.2'
-  gem.add_dependency 'omniauth-oauth2',    '~> 1.1.2'
-  gem.add_dependency 'virtus',             '~> 1.0.1'
+  gem.add_dependency 'active_interaction', '~> 1.1'
+  gem.add_dependency 'omniauth-oauth2',    '~> 1.1'
+  gem.add_dependency 'virtus',             '~> 1.0'
 
   gem.add_development_dependency 'bundler',     '~> 1.0'
   gem.add_development_dependency 'rake',        '~> 10.0'
   gem.add_development_dependency 'yard',        '~> 0.8'
   gem.add_development_dependency 'rspec',       '~> 3.0.0.beta1'
-  gem.add_development_dependency 'fabrication', '~> 2.9.6'
+  gem.add_development_dependency 'fabrication', '~> 2.9'
+  gem.add_development_dependency 'webmock',     '~> 1.17'
 end

data/lib/roqua/core_api/sessions/auth_session.rb

@@ -37,9 +37,18 @@ module Roqua
 
         def perform_request_or_fail(&block)
           response = yield
-          fail response.parsed_response unless (200..299).include?(response.code) ||
-                                               422 == response.code
-          response
+          case response.code
+          when 200..299, 422
+            response
+          when 401
+            if response['no_session']
+              fail NoSession
+            else
+              fail Unauthorized
+            end
+          else
+            fail response.parsed_response || 'error'
+          end
         end
 
         def full_url_for(path)

data/lib/roqua/core_api/version.rb

@@ -1,5 +1,5 @@
 module Roqua
   module CoreApi
-    VERSION = "0.0.15"
+    VERSION = "0.0.16"
   end
 end

data/lib/roqua/core_api.rb

@@ -9,3 +9,11 @@ require 'roqua/core_api/send_invite_email'
 require 'roqua/core_api/people'
 require 'roqua/core_api/person'
 require 'roqua/core_api/update_person'
+
+module Roqua
+  module CoreApi
+    # Raised when a request failed due to an expired/non-existant session.
+    class NoSession < StandardError; end
+    class Unauthorized < StandardError; end
+  end
+end

data/spec/lib/roqua/core_api/sessions/auth_session_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'webmock/rspec'
 
 describe AuthSession do
   let(:session) { Fabricate :auth_session }
@@ -42,6 +43,38 @@ describe AuthSession do
       session.get '/some_path', some: 'param'
     end
 
+    it 'returns the response on sucess status' do
+      stub_request(:get, 'http://core.dev/api/v1/some_path.json?').to_return(
+        status: 201,
+        body: '{ "success": true }',
+        headers: { 'Content-Type' => 'application/json' })
+      expect(session.get('/some_path')['success']).to be_truthy
+    end
+
+    it 'returns the response on a 422 status' do
+      stub_request(:get, 'http://core.dev/api/v1/some_path.json?').to_return(
+        status: 422,
+        body: '{ "errors": { "column": ["wrong"] } }',
+        headers: { 'Content-Type' => 'application/json' })
+      expect(session.get('/some_path')['errors']['column']).to eq ["wrong"]
+    end
+
+    it 'raises a no_session error when response is 401 with a no_session response' do
+      stub_request(:get, 'http://core.dev/api/v1/some_path.json?').to_return(
+        status: 401,
+        body: '{ "no_session": true }',
+        headers: { 'Content-Type' => 'application/json' })
+      expect { session.get '/some_path' }.to raise_error(NoSession)
+    end
+
+    it 'raises a unauthorized error when response is 401 without a no_session response' do
+      stub_request(:get, 'http://core.dev/api/v1/some_path.json?').to_return(
+        status: 401,
+        body: '',
+        headers: { 'Content-Type' => 'application/json' })
+      expect { session.get '/some_path' }.to raise_error(Unauthorized)
+    end
+
     it 'throws an error if the reponse is not within the 200 range' do
       allow(response).to receive(:code).and_return(500)
       allow(HTTParty).to receive(:get).and_return(response)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roqua-core-api
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.16
 platform: ruby
 authors:
 - Marten Veldthuis
@@ -30,42 +30,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.2
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.2
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth2
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.2
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.2
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: virtus
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -128,14 +128,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.6
+        version: '2.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.9'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.6
+        version: '1.17'
 description: Provides authenticated access to Core
 email: marten@veldthuis.com
 executables: []
@@ -206,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: API wrapper gem around Core's API