roo_on_rails 1.8.0 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3c14df25a7b6424101a9e98b40db865b5481b507
-  data.tar.gz: dfff2f9bea33530d06533183c2d31be578d0aa96
+  metadata.gz: a12748afeabfe5feb779e2051e59c58428709628
+  data.tar.gz: 39f18f2e6d56c739e3b95c23e73b5de7a1bce388
 SHA512:
-  metadata.gz: 8c8811e21f02b5eaf1ce83a6653e5e0329c8c0a80f9ef9cf80e407576409c57818ed90662d4ced4b1f44bc6ac51a46dff57376af82a6d8f905d66069acfa6205
-  data.tar.gz: 5e5b53d7ca2df0137cc3326c13231242f30d2ae9743024e34131ad6b9ad167aa429f746d205484e9995b472a2317e235ea528d47de73af14864ca7989dda72ae
+  metadata.gz: 30dddc77f957057480418a62fe13d82ed0d5516e3aca68bb32e1d61f188e6dacf84276fb8d0d94d4bb58e5bb9655d65e7707c33abc7b0c93c24c556294a5177c
+  data.tar.gz: e1e48287115b12b7d48792dc4e68540c20485b9ff9d801695daad2f15305f1ce9af06b7df9629c5e54f3eaf24d0bd85eebd3ed5123e52626a0bb4f98e7f2f856

data/.ruby-version

@@ -1 +1 @@
-2.3.3
+2.4.1

data/.travis.yml

@@ -1,9 +1,9 @@
-sudo: false
+sudo: required
 language: ruby
 rvm:
-  - 2.2.6
+  - 2.2.7
   - 2.3.3
-  - 2.4.0
+  - 2.4.1
   - ruby-head
 gemfile:
   - gemfiles/rails_3.gemfile
@@ -13,16 +13,22 @@ gemfile:
 install:
   - bundle install --jobs=3 --retry=3 --path=vendor/bundle
 cache:
-  bundler: false
+  bundler: true
   directories:
     - vendor/bundle
+    - vendor/bundle-scaffold
 before_script:
   - unset RACK_ENV
   - unset RAILS_ENV
+  - mkdir -p $PWD/tmp && sudo mount -t tmpfs -o size=1024m tmpfs $PWD/tmp
+  - gem install bundler
 matrix:
   allow_failures:
     - rvm: ruby-head
-    - rvm: 2.4.0
+  exclude:
+    - rvm: 2.4.1
+      gemfile: gemfiles/rails_3.gemfile
+    - rvm: ruby-head
       gemfile: gemfiles/rails_3.gemfile
 services:
   - redis-server

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# v1.8.1 (2017-07-27)
+
+Features:
+
+- Google OAuth supported in Rails 3 and 4 (#54)
+
+Bug fixes:
+
+- Allow client apps to load middleware (#54)
+
 # v1.8.0 (2017-07-26)
 
 Bug fixes:

data/README.google_oauth2.md

@@ -1,7 +1,5 @@
 ## Using the Google OAuth feature
 
-This feature is only supported when using Rails 5+.
-
 `roo_on_rails` provides a pre-baked Omniauth setup to help protect your app with
 Google authentication. Read the main `README` first to set things up; you'll
 need at least `GOOGLE_AUTH_ENABLED=YES`, and `GOOGLE_AUTH_CLIENT_ID` and

data/gemfiles/rails_3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    roo_on_rails (1.8.0)
+    roo_on_rails (1.8.1)
       dogstatsd-ruby
       dotenv-rails (~> 2.1)
       faraday
@@ -122,7 +122,7 @@ GEM
     multi_xml (0.6.0)
     multipart-post (2.0.0)
     nenv (0.3.0)
-    newrelic_rpm (4.2.0.334)
+    newrelic_rpm (4.3.0.335)
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)

data/gemfiles/rails_4.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    roo_on_rails (1.8.0)
+    roo_on_rails (1.8.1)
       dogstatsd-ruby
       dotenv-rails (~> 2.1)
       faraday
@@ -134,7 +134,7 @@ GEM
     multi_xml (0.6.0)
     multipart-post (2.0.0)
     nenv (0.3.0)
-    newrelic_rpm (4.2.0.334)
+    newrelic_rpm (4.3.0.335)
     nokogiri (1.8.0)
       mini_portile2 (~> 2.2.0)
     notiffany (0.1.1)

data/gemfiles/rails_5.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    roo_on_rails (1.8.0)
+    roo_on_rails (1.8.1)
       dogstatsd-ruby
       dotenv-rails (~> 2.1)
       faraday
@@ -137,7 +137,7 @@ GEM
     multi_xml (0.6.0)
     multipart-post (2.0.0)
     nenv (0.3.0)
-    newrelic_rpm (4.2.0.334)
+    newrelic_rpm (4.3.0.335)
     nio4r (2.1.0)
     nokogiri (1.8.0)
       mini_portile2 (~> 2.2.0)

data/gemfiles/rails_5_1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    roo_on_rails (1.8.0)
+    roo_on_rails (1.8.1)
       dogstatsd-ruby
       dotenv-rails (~> 2.1)
       faraday
@@ -138,7 +138,7 @@ GEM
     multi_xml (0.6.0)
     multipart-post (2.0.0)
     nenv (0.3.0)
-    newrelic_rpm (4.2.0.334)
+    newrelic_rpm (4.3.0.335)
     nio4r (2.1.0)
     nokogiri (1.8.0)
       mini_portile2 (~> 2.2.0)

data/lib/roo_on_rails/railties/google_oauth.rb

@@ -1,17 +1,13 @@
+require 'roo_on_rails/config'
+
 module RooOnRails
   module Railties
     class GoogleOAuth < Rails::Railtie
       initializer 'roo_on_rails.google_auth.middleware' do |app|
+        $stderr.puts 'initializer roo_on_rails.google_auth'
         _if_enabled do
           _add_middleware(app)
-        end
-      end
-
-      initializer 'roo_on_rails.google_auth.routes', after: :set_routes_reloader_hook do |app|
-        _if_enabled do
           _add_routes(app)
-          # support development mode on route changes (only works in Rails 5)
-          app.reloader.to_prepare { _add_routes(app) }
         end
       end
 
@@ -19,18 +15,10 @@ module RooOnRails
 
       def _if_enabled
         return unless Config.google_auth_enabled?
-        if Rails::VERSION::MAJOR < 5
-          Rails.logger.warn 'The Google OAuth feature is not supported with Rails < 5'
-          return
-        end
-
         yield
       end
 
       def _add_middleware(app)
-        $stderr.puts 'initializer roo_on_rails.google_auth.middleware'
-
-        require 'roo_on_rails/config'
         require 'omniauth'
         require 'omniauth-google-oauth2'
         require 'active_support/core_ext/object/blank'
@@ -55,20 +43,16 @@ module RooOnRails
       end
 
       def _add_routes(app)
-        $stderr.puts 'initializer roo_on_rails.google_auth.routes'
-
         prefix = Config.google_auth_path_prefix
         ctrl   = Config.google_auth_controller
 
-        app.routes.disable_clear_and_finalize = true
-        app.routes.draw do
+        app.routes.prepend do
           get  "#{prefix}/google_oauth2",           controller: ctrl, action: 'failure'
           get  "#{prefix}/google_oauth2/callback",  controller: ctrl, action: 'create'
           post "#{prefix}/google_oauth2/callback",  controller: ctrl, action: 'create'
           get  "#{prefix}/failure",                 controller: ctrl, action: 'failure'
           get  "#{prefix}/logout",                  controller: ctrl, action: 'destroy'
         end
-        app.routes.disable_clear_and_finalize = false
       end
     end
   end

data/lib/roo_on_rails/version.rb

@@ -1,3 +1,3 @@
 module RooOnRails
-  VERSION = '1.8.0'.freeze
+  VERSION = '1.8.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roo_on_rails
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.1
 platform: ruby
 authors:
 - Julien Letessier
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-26 00:00:00.000000000 Z
+date: 2017-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dotenv-rails
@@ -448,7 +448,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Scaffolding for building services