roo 3.0.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e760df54834eed96fbedb5e0aeffa97108962130bd861568ed1d68340487001f
-  data.tar.gz: af4b682bef65d6cc7b843aa99123fe0bc28bac335ebd5af64029584e843000dc
+  metadata.gz: 0654bc954849a46d96a91404cbf8133f46a188c86cbc7019802f957f21fc910c
+  data.tar.gz: cfd2c14c02116a9db0e68020ff1238d1fc02475366401af64448d073bb220f64
 SHA512:
-  metadata.gz: cdf6d407e8e10090720f46a60ded37a6c1ad1aa9d3e764547917fe3bb71d4fcd89b9f97d6cffd581472ce2e7df2f581c26c4d75366e342ec848a45e1fc6bd3d8
-  data.tar.gz: d91a0596f2cafd202af7e75faf2adabc8e9b3e44ff8067f0d7feacceb1f2a66d8d3d1b0e34713b489ae618c73023de472647f65f861c7c0d997ead504bdd359d
+  metadata.gz: c58925cb5695b9a9932a6fb50d8229b821e7f7ea47c20c43c616c8f7a7a7dce4b1e516b49b1336976d1d36374bd2d842eedb54dd11a3a6b1e472eb114b54e84c
+  data.tar.gz: 81bafd9e8cdb155c7df1e849a2856e521ee00a851be43e60f059c7b1ecb0e4c83236e01e8bbac40429c5ebbee83f4dd2e12fa4cb00d6be8891aec526775b3309

data/.github/dependabot.yml

@@ -0,0 +1,9 @@
+version: 2
+updates:
+  - package-ecosystem: github-actions
+    directory: /
+    schedule:
+      interval: weekly
+    commit-message:
+      prefix: chore
+      include: scope

data/.github/workflows/release-please.yml

@@ -16,7 +16,7 @@ jobs:
       release_created: ${{ steps.release.outputs.release_created }}
       tag_name: ${{ steps.release.outputs.tag_name }}
     steps:
-      - uses: googleapis/release-please-action@v4
+      - uses: googleapis/release-please-action@45996ed1f6d02564a971a2fa1b5860e934307cf7 # v5.0.0
         id: release
         with:
           config-file: release-please-config.json
@@ -32,19 +32,19 @@ jobs:
       id-token: write
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
         with:
           ref: ${{ needs.release-please.outputs.tag_name }}
           fetch-tags: true
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
+        uses: ruby/setup-ruby@e1bd6146574da5e0795075b5319b300edb30c5b0 # v1.333.0
         with:
           ruby-version: '3.4'
           bundler-cache: true
 
       - name: Publish to RubyGems
-        uses: rubygems/release-gem@v1
+        uses: rubygems/release-gem@7f9650160c1a4e7989fdc9855807bdbd421d8b6b # v1.4.1
 
       - name: Upload Gem to GitHub Release
         env:

data/.github/workflows/ruby.yml

@@ -18,20 +18,18 @@ jobs:
       fail-fast: false
       matrix:
         ruby:
-          - '3.1'
-          - '3.2'
           - '3.3'
           - '3.4'
-          - '3.5'
+          - '4.0'
           - ruby-head
-          - jruby-9.4.10.0
+          - jruby-10
         include:
           - ruby: ruby-head
             env:
               RUBYOPT: '--jit'
     steps:
-      - uses: actions/checkout@v4
-      - uses: ruby/setup-ruby@v1
+      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+      - uses: ruby/setup-ruby@e1bd6146574da5e0795075b5319b300edb30c5b0 # v1.333.0
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true

data/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "3.0.0"
+  ".": "4.0.0"
 }

data/.rubocop.yml

@@ -1,7 +1,7 @@
 require: rubocop-performance
 
 AllCops:
-  TargetRubyVersion: 3.1
+  TargetRubyVersion: 3.3
   # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
   # to ignore them, so only the ones explicitly set in this file are enabled.
   DisabledByDefault: true

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 ## Unreleased
 
+## [4.0.0](https://github.com/roo-rb/roo/compare/v3.0.0...v4.0.0) (2026-10-22)
+
+
+### ⚠ BREAKING CHANGES
+
+* **ci:** remove unsupported ruby versions
+
+### Bug Fixes
+
+* **ci:** remove unsupported ruby versions ([3425358](https://github.com/roo-rb/roo/commit/34253583250a3c6d43e632ac376dd2715c519557))
+* compare the worksheet target from workbook.xml.rels as text, not as a regexp ([#645](https://github.com/roo-rb/roo/issues/645)) ([3bfff46](https://github.com/roo-rb/roo/commit/3bfff46c21888f8969b41d9a6d69b4609e906969))
+
 ## [3.0.0](https://github.com/roo-rb/roo/compare/v2.10.1...v3.0.0) (2025-10-01)
 
 ### Miscellaneous Chores

data/lib/roo/excelx/cell/number.rb

@@ -18,6 +18,8 @@ module Roo
 
         def create_numeric(number)
           return number if Excelx::ERROR_VALUES.include?(number)
+          return nil if (number.nil? || number == "")
+
           case @format
           when /%/
             Float(number)
@@ -30,6 +32,7 @@ module Roo
 
         def formatted_value
           return @cell_value if Excelx::ERROR_VALUES.include?(@cell_value)
+          return '' if  (@cell_value.nil? || @cell_value == "")
 
           formatter = generate_formatter(@format)
           if formatter.is_a? Proc

data/lib/roo/excelx.rb

@@ -374,7 +374,7 @@ module Roo
     def extract_sheets_in_order(entries, sheet_ids, sheets, tmpdir)
       (sheet_ids & sheets.keys).each_with_index do |id, i|
         name = sheets[id]
-        entry = entries.find { |e| "/#{e.name}" =~ /#{name}$/ }
+        entry = name && entries.find { |e| "/#{e.name}".end_with?(name) }
         path = "#{tmpdir}/roo_sheet#{i + 1}"
         sheet_files << path
         @sheet_files << path

data/lib/roo/version.rb

@@ -1,3 +1,3 @@
 module Roo
-  VERSION = "3.0.0"
+  VERSION = "4.0.0"
 end

data/roo.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.files.reject! { |fn| fn.include?('test/files') }
   spec.require_paths          = ['lib']
 
-  spec.required_ruby_version  = ">= 3.1.0"
+  spec.required_ruby_version  = ">= 3.3.0"
 
   if RUBY_VERSION >= '3.4.0'
     spec.add_dependency 'base64', '~> 0.2'

data/spec/lib/roo/excelx/cell/number_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+RSpec.describe Roo::Excelx::Cell::Number do
+
+  describe '#initialize' do
+    let(:formula)     { nil }
+    let(:excelx_type) { [:numeric_or_formula, format] }
+    let(:format)      { "#,##0.00" }
+    let(:style)       { 1 }
+    let(:link)        { nil }
+    let(:coordinate)  { [1,1] }
+
+    let(:number)  { Roo::Excelx::Cell::Number.new(value, formula, excelx_type, style, link, coordinate)}
+
+    context 'with an actual value' do
+      let(:value)       { 0.1 }
+      it 'creates the object and parses the value' do
+        expect(number.value).to eq 0.1
+      end
+    end
+
+    context 'with an empty value' do
+      let(:value)       { "" }
+      it 'creates the object with a nil value' do
+        expect(number.value).to eq nil
+      end
+    end
+  end
+
+  describe '#formatted_value' do
+    let(:formula)     { nil }
+    let(:excelx_type) { [:numeric_or_formula, format] }
+    let(:format)      { "#,##0.00" }
+    let(:style)       { 1 }
+    let(:link)        { nil }
+    let(:coordinate)  { [1,1] }
+
+    let(:number)  { Roo::Excelx::Cell::Number.new(value, formula, excelx_type, style, link, coordinate)}
+
+    context 'with an actual value' do
+      let(:value)       { 0.1 }
+      it 'creates the object and parses the value' do
+        expect(number.formatted_value).to eq '0.10'
+      end
+    end
+
+    context 'with an empty value' do
+      let(:value)       { "" }
+      it 'creates the object with a nil value' do
+        expect(number.formatted_value).to eq ''
+      end
+    end
+
+  end
+end

data/spec/lib/roo/excelx_spec.rb

@@ -56,6 +56,26 @@ describe Roo::Excelx do
         expect(subject).to be_a(Roo::Excelx)
       end
     end
+
+    context 'given a worksheet target with characters that are special in a regexp' do
+      let(:path) do
+        tmpdir = Dir.mktmpdir
+        path = File.join(tmpdir, 'special_target.xlsx')
+        FileUtils.cp('test/files/only_one_sheet.xlsx', path)
+        Zip::File.open(path) do |zip|
+          zip.rename('xl/worksheets/sheet1.xml', 'xl/worksheets/sheet(1).xml')
+          rels = zip.read('xl/_rels/workbook.xml.rels')
+          zip.get_output_stream('xl/_rels/workbook.xml.rels') do |stream|
+            stream.write(rels.sub('Target="worksheets/sheet1.xml"', 'Target="worksheets/sheet(1).xml"'))
+          end
+        end
+        path
+      end
+
+      it 'finds the worksheet by its target as text, not as a pattern' do
+        expect(subject.sheets).to eq(['Sheet1'])
+      end
+    end
   end
 
   describe '#cell' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roo
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Thomas Preymesser
@@ -185,6 +185,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
 - ".github/issue_template.md"
 - ".github/pull_request_template.md"
 - ".github/workflows/release-please.yml"
@@ -253,6 +254,7 @@ files:
 - spec/helpers.rb
 - spec/lib/roo/base_spec.rb
 - spec/lib/roo/csv_spec.rb
+- spec/lib/roo/excelx/cell/number_spec.rb
 - spec/lib/roo/excelx/cell/time_spec.rb
 - spec/lib/roo/excelx/format_spec.rb
 - spec/lib/roo/excelx/relationships_spec.rb
@@ -306,7 +308,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.1.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="