roo 2.3.0 → 2.10.1

data/spec/lib/roo/base_spec.rb

@@ -127,10 +127,22 @@ describe Roo::Base do
     end
   end
 
-  describe '#row' do
-    it 'should return the specified row' do
+  describe "#row" do
+    it "should return the specified row" do
       expect(spreadsheet.row(12)).to eq([41.0, 42.0, 43.0, 44.0, 45.0, nil, nil])
-      expect(spreadsheet.row(16)).to eq([nil, '"Hello world!"', 'forty-three', 'forty-four', 'forty-five', nil, nil])
+      expect(spreadsheet.row(16)).to eq([nil, '"Hello world!"', "forty-three", "forty-four", "forty-five", nil, nil])
+    end
+
+    it "should return the specified row if default_sheet is set by a string" do
+      spreadsheet.default_sheet = "my_sheet"
+      expect(spreadsheet.row(12)).to eq([41.0, 42.0, 43.0, 44.0, 45.0, nil, nil])
+      expect(spreadsheet.row(16)).to eq([nil, '"Hello world!"', "forty-three", "forty-four", "forty-five", nil, nil])
+    end
+
+    it "should return the specified row if default_sheet is set by an integer" do
+      spreadsheet.default_sheet = 0
+      expect(spreadsheet.row(12)).to eq([41.0, 42.0, 43.0, 44.0, 45.0, nil, nil])
+      expect(spreadsheet.row(16)).to eq([nil, '"Hello world!"', "forty-three", "forty-four", "forty-five", nil, nil])
     end
   end
 
@@ -146,6 +158,11 @@ describe Roo::Base do
         expect { spreadsheet.row_with([/Missing Header/]) }.to \
           raise_error(Roo::HeaderRowNotFoundError)
       end
+
+      it 'returns missing headers' do
+        expect { spreadsheet.row_with([/Header/, /Missing Header 1/, /Missing Header 2/]) }.to \
+          raise_error(Roo::HeaderRowNotFoundError, '[/Missing Header 1/, /Missing Header 2/]')
+      end
     end
   end
 
@@ -165,6 +182,26 @@ describe Roo::Base do
     end
   end
 
+  describe '#each_with_pagename' do
+    context 'when block given' do
+      it 'iterate with sheet and sheet_name' do
+        sheet_names = []
+        spreadsheet.each_with_pagename do |sheet_name, sheet|
+          sheet_names << sheet_name
+        end
+        expect(sheet_names).to eq ['my_sheet', 'blank sheet']
+      end
+    end
+
+    context 'when called without block' do
+      it 'should return an enumerator with all the rows' do
+        each_with_pagename = spreadsheet.each_with_pagename
+        expect(each_with_pagename).to be_a(Enumerator)
+        expect(each_with_pagename.to_a.last).to eq([spreadsheet.default_sheet, spreadsheet])
+      end
+    end
+  end
+
   describe '#each' do
     it 'should return an enumerator with all the rows' do
       each = spreadsheet.each
@@ -173,6 +210,31 @@ describe Roo::Base do
     end
   end
 
+  describe "#default_sheet=" do
+    it "should correctly set the default sheet if passed a string" do
+      spreadsheet.default_sheet = "my_sheet"
+      expect(spreadsheet.default_sheet).to eq("my_sheet")
+    end
+
+    it "should correctly set the default sheet if passed an integer" do
+      spreadsheet.default_sheet = 0
+      expect(spreadsheet.default_sheet).to eq("my_sheet")
+    end
+
+    it "should correctly set the default sheet if passed an integer for the second sheet" do
+      spreadsheet.default_sheet = 1
+      expect(spreadsheet.default_sheet).to eq("blank sheet")
+    end
+
+    it "should raise an error if passed a sheet that does not exist as an integer" do
+      expect { spreadsheet.default_sheet = 10 }.to raise_error RangeError
+    end
+
+    it "should raise an error if passed a sheet that does not exist as a string" do
+      expect { spreadsheet.default_sheet = "does_not_exist" }.to raise_error RangeError
+    end
+  end
+
   describe '#to_yaml' do
     it 'should convert the spreadsheet to yaml' do
       expect(spreadsheet.to_yaml({}, 5, 1, 5, 1)).to eq("--- \n" + yaml_entry(5, 1, 'date', '1961-11-21'))

data/spec/lib/roo/csv_spec.rb

@@ -10,6 +10,13 @@ describe Roo::CSV do
     end
   end
 
+  describe '.new with stream' do
+    let(:csv) { Roo::CSV.new(File.read(path)) }
+    it 'creates an instance' do
+      expect(csv).to be_a(Roo::CSV)
+    end
+  end
+
   describe '#parse' do
     subject do
       csv.parse(options)
@@ -59,4 +66,16 @@ describe Roo::CSV do
       end
     end
   end
+
+  describe '#set_value' do
+    it 'returns the cell value' do
+      expect(csv.set_value('A', 1, 'some-value', nil)).to eq('some-value')
+    end
+  end
+
+  describe '#set_type' do
+    it 'returns the cell type' do
+      expect(csv.set_type('A', 1, 'some-type', nil)).to eq('some-type')
+    end
+  end
 end

data/spec/lib/roo/excelx/cell/time_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+RSpec.describe Roo::Excelx::Cell::Time do
+  it "should set the cell value to the correct number of seconds" do
+    value = 0.05513888888888888 # '1:19:24'
+    excelx_type = [:numeric_or_formula, "h:mm:ss"]
+    base_timestamp = Date.new(1899, 12, 30).to_time.to_i
+    time_cell = Roo::Excelx::Cell::Time.new(value, nil, excelx_type, 1, nil, base_timestamp, nil)
+    expect(time_cell.value).to eq(1*60*60 + 19*60 + 24) # '1:19:24' in seconds
+    # use case from https://github.com/roo-rb/roo/issues/310
+    value = 0.523761574074074   # '12:34:13' in seconds
+    time_cell = Roo::Excelx::Cell::Time.new(value, nil, excelx_type, 1, nil, base_timestamp, nil)
+    expect(time_cell.value).to eq(12*60*60 + 34*60 + 13) # 12:34:13 in seconds
+  end
+end

data/spec/lib/roo/excelx/relationships_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Roo::Excelx::Relationships do
+  subject(:relationships) { Roo::Excelx::Relationships.new Roo::Excelx.new(path).rels_files[0] }
+
+  describe "#include_type?" do
+    [
+      ["with hyperlink type", "test/files/link.xlsx", true, false],
+      ["with nil path", "test/files/Bibelbund.xlsx", false, false],
+      ["with comments type", "test/files/comments-google.xlsx", false, true],
+    ].each do |context_desc, file_path, hyperlink_value, comments_value|
+      context context_desc do
+        let(:path) { file_path }
+
+        it "should return #{hyperlink_value} for hyperlink" do
+          expect(subject.include_type?("hyperlink")).to be hyperlink_value
+        end
+
+        it "should return #{hyperlink_value} for link" do
+          expect(subject.include_type?("link")).to be hyperlink_value
+        end
+
+        it "should return false for hypelink" do
+          expect(subject.include_type?("hypelink")).to be false
+        end
+
+        it "should return false for coment" do
+          expect(subject.include_type?("coment")).to be false
+        end
+
+        it "should return #{comments_value} for comments" do
+          expect(subject.include_type?("comments")).to be comments_value
+        end
+
+        it "should return #{comments_value} for comment" do
+          expect(subject.include_type?("comment")).to be comments_value
+        end
+      end
+    end
+  end
+end

data/spec/lib/roo/excelx/sheet_doc_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Roo::Excelx::SheetDoc do
+  subject(:blank_children) { Roo::Excelx.new("test/files/blank_children.xlsx") }
+
+  example "#last_row" do
+    expect(subject.last_row).to eq 3
+  end
+end

data/spec/lib/roo/excelx_spec.rb

@@ -6,6 +6,18 @@ describe Roo::Excelx do
     Roo::Excelx.new(path)
   end
 
+  describe 'Constants' do
+    describe 'ERROR_VALUES' do
+      it 'returns all possible errorr values' do
+        expect(described_class::ERROR_VALUES).to eq(%w(#N/A #REF! #NAME? #DIV/0! #NULL! #VALUE! #NUM!).to_set)
+      end
+
+      it 'is a set' do
+        expect(described_class::ERROR_VALUES).to be_an_instance_of(Set)
+      end
+    end
+  end
+
   describe '.new' do
     let(:path) { 'test/files/numeric-link.xlsx' }
 
@@ -44,7 +56,6 @@ describe Roo::Excelx do
         expect(subject).to be_a(Roo::Excelx)
       end
     end
-
   end
 
   describe '#cell' do
@@ -75,6 +86,14 @@ describe Roo::Excelx do
     end
   end
 
+  describe 'for a workbook with hidden sheets' do
+    let(:path) { 'test/files/hidden_sheets.xlsx' }
+
+    it 'returns the cell contents from the visible sheet' do
+      expect(Roo::Excelx.new(path, only_visible_sheets: true).cell('A', 1)).to eq "visible sheet 1"
+    end
+  end
+
   describe '#parse' do
     let(:path) { 'test/files/numeric-link.xlsx' }
 
@@ -140,6 +159,22 @@ describe Roo::Excelx do
     it 'returns the expected result' do
       expect(subject.sheet_for("Tabelle1").instance_variable_get("@name")).to eq "Tabelle1"
     end
+
+    it 'returns the expected result when passed a number' do
+      expect(subject.sheet_for(0).instance_variable_get("@name")).to eq "Tabelle1"
+    end
+
+    it 'returns the expected result when passed a number that is not the first sheet' do
+      expect(subject.sheet_for(1).instance_variable_get("@name")).to eq "Name of Sheet 2"
+    end
+
+    it "should raise an error if passed a sheet that does not exist as an integer" do
+      expect { subject.sheet_for(10) }.to raise_error RangeError
+    end
+
+    it "should raise an error if passed a sheet that does not exist as a string" do
+      expect { subject.sheet_for("does_not_exist") }.to raise_error RangeError
+    end
   end
 
   describe '#row' do
@@ -283,6 +318,52 @@ describe Roo::Excelx do
     end
   end
 
+  describe '#formatted_value' do
+    context 'contains zero-padded numbers' do
+      let(:path) { 'test/files/zero-padded-number.xlsx' }
+
+      it 'returns a zero-padded number' do
+        expect(subject.formatted_value(4, 1)).to eq '05010'
+      end
+    end
+
+    context 'contains US currency' do
+      let(:path) { 'test/files/currency-us.xlsx' }
+
+      it 'returns a zero-padded number' do
+        expect(subject.formatted_value(4, 1)).to eq '$20.51'
+      end
+    end
+
+    context 'contains euro currency' do
+      let(:path) { 'test/files/currency-euro.xlsx' }
+
+      it 'returns a zero-padded number' do
+        expect(subject.formatted_value(4, 1)).to eq '€20.51'
+      end
+    end
+
+    context 'contains uk currency' do
+      let(:path) { 'test/files/currency-uk.xlsx' }
+
+      it 'returns a zero-padded number' do
+        expect(subject.formatted_value(4, 1)).to eq '£20.51'
+      end
+    end
+  end
+
+  describe '#row' do
+    context 'integers with leading zero'
+      let(:path) { 'test/files/number_with_zero_prefix.xlsx' }
+
+      it 'returns base 10 integer' do
+        (1..50).each do |row_index|
+          range_start = (row_index - 1) * 20 + 1
+          expect(subject.row(row_index)).to eq (range_start..(range_start+19)).to_a
+        end
+      end
+  end
+
   describe '#excelx_format' do
     let(:path) { 'test/files/style.xlsx' }
 
@@ -330,14 +411,50 @@ describe Roo::Excelx do
       expect(subject.hyperlink?(1, 1)).to eq true
       expect(subject.hyperlink?(1, 2)).to eq false
     end
+
+    context 'defined on cell range' do
+     let(:path) { 'test/files/cell-range-link.xlsx' }
+
+      it 'returns the expected result' do
+        [[false]*3, *[[true, true, false]]*4, [false]*3].each.with_index(1) do |row, row_index|
+          row.each.with_index(1) do |value, col_index|
+            expect(subject.hyperlink?(row_index, col_index)).to eq(value)
+          end
+        end
+      end
+    end
   end
 
   describe '#hyperlink' do
-    let(:path) { 'test/files/link.xlsx' }
+    context 'defined on cell range' do
+     let(:path) { 'test/files/cell-range-link.xlsx' }
 
-    it 'returns the expected result' do
-      expect(subject.hyperlink(1, 1)).to eq "http://www.google.com"
-      expect(subject.hyperlink(1, 2)).to eq nil
+      it 'returns the expected result' do
+        link = "http://www.google.com"
+        [[nil]*3, *[[link, link, nil]]*4, [nil]*3].each.with_index(1) do |row, row_index|
+          row.each.with_index(1) do |value, col_index|
+            expect(subject.hyperlink(row_index, col_index)).to eq(value)
+          end
+        end
+      end
+    end
+
+    context 'without location' do
+      let(:path) { 'test/files/link.xlsx' }
+
+      it 'returns the expected result' do
+        expect(subject.hyperlink(1, 1)).to eq "http://www.google.com"
+        expect(subject.hyperlink(1, 2)).to eq nil
+      end
+    end
+
+    context 'with location' do
+      let(:path) { 'test/files/link_with_location.xlsx' }
+
+      it 'returns the expected result' do
+        expect(subject.hyperlink(1, 1)).to eq "http://www.google.com/#hey"
+        expect(subject.hyperlink(1, 2)).to eq nil
+      end
     end
   end
 
@@ -458,10 +575,125 @@ describe Roo::Excelx do
     end
   end
 
+  describe '#html_strings' do
+    describe "HTML Parsing Enabling" do
+      let(:path) { 'test/files/html_strings_formatting.xlsx' }
+
+      it 'returns the expected result' do
+        expect(subject.excelx_value(1, 1, "Sheet1")).to eq("This has no formatting.")
+        expect(subject.excelx_value(2, 1, "Sheet1")).to eq("<html>This has<b> bold </b>formatting.</html>")
+        expect(subject.excelx_value(2, 2, "Sheet1")).to eq("<html>This has <i>italics</i> formatting.</html>")
+        expect(subject.excelx_value(2, 3, "Sheet1")).to eq("<html>This has <u>underline</u> format.</html>")
+        expect(subject.excelx_value(2, 4, "Sheet1")).to eq("<html>Superscript. x<sup>123</sup></html>")
+        expect(subject.excelx_value(2, 5, "Sheet1")).to eq("<html>SubScript.  T<sub>j</sub></html>")
+
+        expect(subject.excelx_value(3, 1, "Sheet1")).to eq("<html>Bold, italics <b><i>together</i></b>.</html>")
+        expect(subject.excelx_value(3, 2, "Sheet1")).to eq("<html>Bold, Underline <b><u>together</u></b>.</html>")
+        expect(subject.excelx_value(3, 3, "Sheet1")).to eq("<html>Bold, Superscript. <b>x</b><sup><b>N</b></sup></html>")
+        expect(subject.excelx_value(3, 4, "Sheet1")).to eq("<html>Bold, Subscript. <b>T</b><sub><b>abc</b></sub></html>")
+        expect(subject.excelx_value(3, 5, "Sheet1")).to eq("<html>Italics, Underline <i><u>together</u></i>.</html>")
+        expect(subject.excelx_value(3, 6, "Sheet1")).to eq("<html>Italics, Superscript.  <i>X</i><sup><i>abc</i></sup></html>")
+        expect(subject.excelx_value(3, 7, "Sheet1")).to eq("<html>Italics, Subscript.  <i>B</i><sub><i>efg</i></sub></html>")
+        expect(subject.excelx_value(4, 1, "Sheet1")).to eq("<html>Bold, italics underline,<b><i><u> together</u></i></b>.</html>")
+        expect(subject.excelx_value(4, 2, "Sheet1")).to eq("<html>Bold, italics, superscript. <b>X</b><sup><b><i>abc</i></b></sup><b><i>123</i></b></html>")
+        expect(subject.excelx_value(4, 3, "Sheet1")).to eq("<html>Bold, Italics, subscript. <b><i>Mg</i></b><sub><b><i>ha</i></b></sub><b><i>2</i></b></html>")
+        expect(subject.excelx_value(4, 4, "Sheet1")).to eq("<html>Bold, Underline, superscript. <b><u>AB</u></b><sup><b><u>C12</u></b></sup><b><u>3</u></b></html>")
+        expect(subject.excelx_value(4, 5, "Sheet1")).to eq("<html>Bold, Underline, subscript. <b><u>Good</u></b><sub><b><u>XYZ</u></b></sub></html>")
+        expect(subject.excelx_value(4, 6, "Sheet1")).to eq("<html>Italics, Underline, superscript. <i><u>Up</u></i><sup><i><u>swing</u></i></sup></html>")
+        expect(subject.excelx_value(4, 7, "Sheet1")).to eq("<html>Italics, Underline, subscript. <i><u>T</u></i><sub><i><u>swing</u></i></sub></html>")
+        expect(subject.excelx_value(5, 1, "Sheet1")).to eq("<html>Bold, italics, underline, superscript.  <b><i><u>GHJK</u></i></b><sup><b><i><u>190</u></i></b></sup><b><i><u>4</u></i></b></html>")
+        expect(subject.excelx_value(5, 2, "Sheet1")).to eq("<html>Bold, italics, underline, subscript. <b><i><u>Mike</u></i></b><sub><b><i><u>drop</u></i></b></sub></html>")
+        expect(subject.excelx_value(6, 1, "Sheet1")).to eq("See that regular html tags do not create html tags.\n<ol>\n  <li> Denver Broncos </li>\n  <li> Carolina Panthers </li>\n  <li> New England Patriots</li>\n  <li>Arizona Panthers</li>\n</ol>")
+        expect(subject.excelx_value(7, 1, "Sheet1")).to eq("<html>Does create html tags when formatting is used..\n<ol>\n  <li> <b>Denver Broncos</b> </li>\n  <li> <i>Carolina Panthers </i></li>\n  <li> <u>New England Patriots</u></li>\n  <li>Arizona Panthers</li>\n</ol></html>")
+      end
+    end
+  end
+
   describe '_x000D_' do
     let(:path) { 'test/files/x000D.xlsx' }
     it 'does not contain _x000D_' do
       expect(subject.cell(2, 9)).not_to include('_x000D_')
     end
   end
+
+  describe 'opening a file with a chart sheet' do
+    let(:path) { 'test/files/chart_sheet.xlsx' }
+    it 'should not raise' do
+      expect{ subject }.to_not raise_error
+    end
+  end
+
+  describe 'opening a file with white space in the styles.xml' do
+    let(:path) { 'test/files/style_nodes_with_white_spaces.xlsx' }
+    subject(:xlsx) do
+      Roo::Spreadsheet.open(path, expand_merged_ranges: true, extension: :xlsx)
+    end
+    it 'should properly recognize formats' do
+      expect(subject.sheet(0).excelx_format(2,1)).to eq 'm/d/yyyy" "h:mm:ss" "AM/PM'
+    end
+  end
+
+  describe 'opening a file with filters' do
+    let(:path) { 'test/files/wrong_coordinates.xlsx' }
+    subject(:xlsx) do
+      Roo::Spreadsheet.open(path)
+    end
+
+    it 'should properly extract defined_names' do
+      expect(subject.sheet(0).workbook.defined_names.length).to eq(1)
+    end
+  end
+
+  describe 'images' do
+    let(:path) { 'test/files/images.xlsx' }
+
+    it 'returns array of images from default sheet' do
+      expect(subject.images).to be_kind_of(Array)
+      expect(subject.images.size).to eql(19)
+    end
+
+    it 'returns empty array if there is no images on the sheet' do
+      expect(subject.images("Sheet2")).to eql([])
+    end
+  end
+end
+
+describe 'Roo::Excelx with options set' do
+  subject(:xlsx) do
+    Roo::Excelx.new(path, disable_html_wrapper: true)
+  end
+
+  describe '#html_strings' do
+    describe "HTML Parsing Disabled" do
+      let(:path) { 'test/files/html_strings_formatting.xlsx' }
+
+      it 'returns the expected result' do
+        expect(subject.excelx_value(1, 1, "Sheet1")).to eq("This has no formatting.")
+        expect(subject.excelx_value(2, 1, "Sheet1")).to eq("This has bold formatting.")
+        expect(subject.excelx_value(2, 2, "Sheet1")).to eq("This has italics formatting.")
+        expect(subject.excelx_value(2, 3, "Sheet1")).to eq("This has underline format.")
+        expect(subject.excelx_value(2, 4, "Sheet1")).to eq("Superscript. x123")
+        expect(subject.excelx_value(2, 5, "Sheet1")).to eq("SubScript.  Tj")
+
+        expect(subject.excelx_value(3, 1, "Sheet1")).to eq("Bold, italics together.")
+        expect(subject.excelx_value(3, 2, "Sheet1")).to eq("Bold, Underline together.")
+        expect(subject.excelx_value(3, 3, "Sheet1")).to eq("Bold, Superscript. xN")
+        expect(subject.excelx_value(3, 4, "Sheet1")).to eq("Bold, Subscript. Tabc")
+        expect(subject.excelx_value(3, 5, "Sheet1")).to eq("Italics, Underline together.")
+        expect(subject.excelx_value(3, 6, "Sheet1")).to eq("Italics, Superscript.  Xabc")
+        expect(subject.excelx_value(3, 7, "Sheet1")).to eq("Italics, Subscript.  Befg")
+        expect(subject.excelx_value(4, 1, "Sheet1")).to eq("Bold, italics underline, together.")
+        expect(subject.excelx_value(4, 2, "Sheet1")).to eq("Bold, italics, superscript. Xabc123")
+        expect(subject.excelx_value(4, 3, "Sheet1")).to eq("Bold, Italics, subscript. Mgha2")
+        expect(subject.excelx_value(4, 4, "Sheet1")).to eq("Bold, Underline, superscript. ABC123")
+        expect(subject.excelx_value(4, 5, "Sheet1")).to eq("Bold, Underline, subscript. GoodXYZ")
+        expect(subject.excelx_value(4, 6, "Sheet1")).to eq("Italics, Underline, superscript. Upswing")
+        expect(subject.excelx_value(4, 7, "Sheet1")).to eq("Italics, Underline, subscript. Tswing")
+        expect(subject.excelx_value(5, 1, "Sheet1")).to eq("Bold, italics, underline, superscript.  GHJK1904")
+        expect(subject.excelx_value(5, 2, "Sheet1")).to eq("Bold, italics, underline, subscript. Mikedrop")
+        expect(subject.excelx_value(6, 1, "Sheet1")).to eq("See that regular html tags do not create html tags.\n<ol>\n  <li> Denver Broncos </li>\n  <li> Carolina Panthers </li>\n  <li> New England Patriots</li>\n  <li>Arizona Panthers</li>\n</ol>")
+        expect(subject.excelx_value(7, 1, "Sheet1")).to eq("Does create html tags when formatting is used..\n<ol>\n  <li> Denver Broncos </li>\n  <li> Carolina Panthers </li>\n  <li> New England Patriots</li>\n  <li>Arizona Panthers</li>\n</ol>")
+      end
+    end
+  end
 end

data/spec/lib/roo/openoffice_spec.rb

@@ -13,10 +13,10 @@ describe Roo::OpenOffice do
     context 'for float/integer values' do
       context 'integer without point' do
         it { expect(subject.cell(3,"A","Sheet4")).to eq(1234) }
-        it { expect(subject.cell(3,"A","Sheet4")).to be_a(Fixnum) }
+        it { expect(subject.cell(3,"A","Sheet4")).to be_a(Integer) }
       end
 
-      context 'float with point' do 
+      context 'float with point' do
         it { expect(subject.cell(3,"B","Sheet4")).to eq(1234.00) }
         it { expect(subject.cell(3,"B","Sheet4")).to be_a(Float) }
       end

data/spec/lib/roo/spreadsheet_spec.rb

@@ -25,7 +25,7 @@ describe Roo::Spreadsheet do
       let(:filename) { tempfile.path }
 
       it 'loads the proper type' do
-        expect(Roo::CSV).to receive(:new).with(filename, file_warning: :ignore).and_call_original
+        expect(Roo::CSV).to receive(:new).with(filename, {file_warning: :ignore}).and_call_original
         expect(Roo::Spreadsheet.open(tempfile, extension: :csv)).to be_a(Roo::CSV)
       end
     end

data/spec/lib/roo/strict_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe Roo::Excelx do
+  subject { Roo::Excelx.new('test/files/strict.xlsx') }
+
+  example '#sheets' do
+    expect(subject.sheets).to eq %w(Sheet1 Sheet2)
+  end
+
+  example '#sheet' do
+    expect(subject.sheet('Sheet1')).to be_a(Roo::Excelx)
+  end
+
+  example '#cell' do
+    expect(subject.cell(1, 1)).to eq 'Sheet 1'
+    expect(subject.cell(1, 1, 'Sheet2')).to eq 'Sheet 2'
+  end
+
+  example '#row' do
+    expect(subject.row(1)).to eq ['Sheet 1']
+    expect(subject.row(1, 'Sheet2')).to eq ['Sheet 2']
+  end
+
+  example '#first_row' do
+    expect(subject.first_row).to eq 1
+    expect(subject.first_row('Sheet2')).to eq 1
+  end
+
+  example '#last_row' do
+    expect(subject.last_row).to eq 1
+    expect(subject.last_row('Sheet2')).to eq 1
+  end
+
+  example '#first_column' do
+    expect(subject.first_column).to eq 1
+    expect(subject.first_column('Sheet2')).to eq 1
+  end
+
+  example '#last_column' do
+    expect(subject.last_column).to eq 1
+    expect(subject.last_column('Sheet2')).to eq 1
+  end
+end

data/spec/lib/roo/utils_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe ::Roo::Utils do
   subject { described_class }
 
   context '#number_to_letter' do
-    ('A'..'Z').to_a.each_with_index do |letter, index|
+    described_class::LETTERS.each_with_index do |letter, index|
       it "should return '#{ letter }' when passed #{ index + 1 }" do
         expect(described_class.number_to_letter(index + 1)).to eq(letter)
       end
@@ -43,12 +43,12 @@ RSpec.describe ::Roo::Utils do
     end
   end
 
-  context '.split_coordinate' do
+  context '.extract_coordinate' do
     it "returns the expected result" do
-      expect(described_class.split_coordinate('A1')).to eq [1, 1]
-      expect(described_class.split_coordinate('B2')).to eq [2, 2]
-      expect(described_class.split_coordinate('R2')).to eq [2, 18]
-      expect(described_class.split_coordinate('AR31')).to eq [31, 18 + 26]
+      expect(described_class.extract_coordinate('A1')).to eq [1, 1]
+      expect(described_class.extract_coordinate('B2')).to eq [2, 2]
+      expect(described_class.extract_coordinate('R2')).to eq [2, 18]
+      expect(described_class.extract_coordinate('AR31')).to eq [31, 18 + 26]
     end
   end
 
@@ -81,26 +81,39 @@ RSpec.describe ::Roo::Utils do
     end
   end
 
+  context '.coordinates_in_range' do
+    it "returns the expected result" do
+      expect(described_class.coordinates_in_range('').to_a).to eq []
+      expect(described_class.coordinates_in_range('B2').to_a).to eq [[2, 2]]
+      expect(described_class.coordinates_in_range('D2:G3').to_a).to eq [[2, 4], [2, 5], [2, 6], [2, 7], [3, 4], [3, 5], [3, 6], [3, 7]]
+      expect(described_class.coordinates_in_range('G3:D2').to_a).to eq []
+    end
+
+    it "raises an error when appropriate" do
+      expect { described_class.coordinates_in_range('D2:G3:I5').to_a }.to raise_error(ArgumentError)
+    end
+  end
+
   context '.load_xml' do
     it 'returns the expected result' do
       expect(described_class.load_xml('test/files/sheet1.xml')).to be_a(Nokogiri::XML::Document)
       expect(described_class.load_xml('test/files/sheet1.xml').
                  remove_namespaces!.xpath("/worksheet/dimension").map do |dim|
-                  dim.attributes["ref"].value end.first).to eq "A1:B11"
+                  dim["ref"] end.first).to eq "A1:B11"
     end
   end
 
   context '.each_element' do
     it 'returns the expected result' do
       described_class.each_element('test/files/sheet1.xml', 'dimension') do |dim|
-        expect(dim.attributes["ref"].value).to eq "A1:B11"
+        expect(dim["ref"]).to eq "A1:B11"
       end
       rows = []
       described_class.each_element('test/files/sheet1.xml', 'row') do |row|
         rows << row
       end
       expect(rows.size).to eq 11
-      expect(rows[2].attributes["r"].value).to eq "3"
+      expect(rows[2]["r"]).to eq "3"
     end
   end
 end