roo-xls 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 72a5eeec41696350e22d685b1337489727f9211c
-  data.tar.gz: d149d0621aec472b1b64ef3b817ef167d7cfd785
+SHA256:
+  metadata.gz: 7b4b59a55cac5820c24bfd0ccf4bfb0edd18e88cc46516ea84157b8d92d9d399
+  data.tar.gz: 2c97afde22e182df8921f4435efd18ecaa63c6ab37d600fd4e5c88b1d34afffb
 SHA512:
-  metadata.gz: b4c1534cb3cbe004cc8bfe510c88f9565adbf4e9e607c42961a49827dbc579ce06b630716eb9804d04076afb0ee79b5269a02b333eb0a096a97b4bbbfa417e4d
-  data.tar.gz: faf978fc060d3bf38ff0011bc8ff239ffa9067835ad2cee1fa9f7c09aeb64a181136c7365e70ddb7c5015e9ac24e076cd7473414e6d8fcec60feb5cb12dd1458
+  metadata.gz: 2c776ca11c9f604871b78e9a6ea45c09314de98ec662ebefd47922ec6f366458c685094004fcfd14e7b99138c010fd5893d6ce10f6c1d6941a55f77a0d119254
+  data.tar.gz: 37f20fc518a273c1adf7f81e137d2d99b679670b69898dd4caf368716eebca6245252ca275eadf750ddacf7ba01a42eab3235723f841b76ede9aeb848f31e525

data/.github/issue_template.md

@@ -0,0 +1,16 @@
+Thanks for filing an issue. Following these instructions will help us solve your problem sooner.
+
+### Steps to reproduce
+
+1. Create an executable test case for this issue ([sample test case](https://gist.github.com/tgturner/4e2b590e0218d3b261269aa662b6a7cb))
+2. You can share your executable test case as a [gist](https://gist.github.com), or simply paste the content into the issue description.
+  - You can execute the test case by running `ruby the_file.rb` in your terminal. If all goes well, you should see your test case failing.
+3. Please provide a stripped down version of the offending spreadsheet.
+
+### Issue
+Describe the issue
+
+### System configuration
+**Roo::Xls version**:
+
+**Ruby version**:

data/.github/pull_request_template.md

@@ -0,0 +1,14 @@
+### Summary
+
+Provide a general description of the code changes in your pull
+request... were there any bugs you had fixed? If so, mention them. If
+these bugs have open GitHub issues, be sure to tag them here as well,
+to keep the conversation linked together.
+
+### Other Information
+
+If there's anything else that's important and relevant to your pull
+request, mention that information here. This could include
+benchmarks, or other information.
+
+Thanks for contributing to Roo!

data/.github/workflows/release-please.yml

@@ -0,0 +1,52 @@
+name: Release Please
+
+on:
+  push:
+    branches:
+      - master
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  release-please:
+    runs-on: ubuntu-latest
+    outputs:
+      release_created: ${{ steps.release.outputs.release_created }}
+      tag_name: ${{ steps.release.outputs.tag_name }}
+    steps:
+      - uses: googleapis/release-please-action@v4
+        id: release
+        with:
+          config-file: release-please-config.json
+          manifest-file: .release-please-manifest.json
+
+  publish:
+    needs: release-please
+    if: ${{ needs.release-please.outputs.release_created }}
+    runs-on: ubuntu-latest
+    environment: PUBLISH
+    permissions:
+      contents: write
+      id-token: write
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ needs.release-please.outputs.tag_name }}
+          fetch-tags: true
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.4'
+          bundler-cache: true
+
+      - name: Publish to RubyGems
+        uses: rubygems/release-gem@v1
+
+      - name: Upload Gem to GitHub Release
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: gh release upload ${{ needs.release-please.outputs.tag_name }} ./*.gem --clobber

data/.github/workflows/ruby.yml

@@ -0,0 +1,40 @@
+name: Ruby
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - '3.1'
+          - '3.2'
+          - '3.3'
+          - '3.4'
+          - '4.0'
+          - ruby-head
+          - jruby-9.4.10.0
+        include:
+          - ruby: ruby-head
+            env:
+              RUBYOPT: '--jit'
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: bundle exec rake
+        env:
+          LONG_RUN: true

data/.gitignore

@@ -14,3 +14,7 @@
 mkmf.log
 .idea
 .DS_Store
+
+# Appraisal
+/gemfiles/.bundle/
+/gemfiles/*.gemfile.lock

data/.release-please-manifest.json

@@ -0,0 +1,3 @@
+{
+  ".": "2.0.0"
+}

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# Changelog
+
+## [2.0.0](https://github.com/roo-rb/roo-xls/compare/v1.2.0...v2.0.0) (2026-01-05)
+
+
+### Miscellaneous Chores
+
+* release 2.0.0 ([7e85b93](https://github.com/roo-rb/roo-xls/commit/7e85b93f27573351edb90ce9c480ec36b23eb6af))

data/Gemfile

@@ -3,21 +3,20 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in roo-xls.gemspec
 gemspec
 
-if ENV['TRAVIS']
+if ENV['CI']
   gem 'roo', '>= 2.0.0beta1', git: 'https://github.com/roo-rb/roo.git'
 else
-  gem 'roo', '>= 2.0.0beta1', path: ::File.expand_path('../../roo', __FILE__)
+  gem 'roo', '>= 2.0.0beta1', '< 3'
 end
 
-gem 'activesupport', '~> 4.2.0' if RUBY_VERSION < '2.2'
-
 group :test do
   # additional testing libs
   gem 'webmock'
   gem 'shoulda'
   gem 'rspec', '>= 3.0.0'
-  gem 'simplecov', '>= 0.9.0', :require => false
-  gem 'coveralls', :require => false
+  gem 'simplecov', '>= 0.21', require: false
+  gem 'simplecov-lcov', '>= 0.8', require: false
+  gem 'coveralls', require: false
 end
 
 group :local_development do
@@ -28,5 +27,4 @@ group :local_development do
   gem 'guard-rubocop', require: false
   gem 'guard-reek', git: 'https://github.com/pericles/guard-reek', require: false
   gem 'pry'
-  gem 'transpec'
 end

data/README.md

@@ -10,6 +10,11 @@ This library extends Roo to add support for handling class Excel files, includin
 There is no support for formulas in Roo for .xls files - you can get the result
 of a formula but not the formula itself.
 
+## Limitations
+
+Roo::Xls currently doesn't provide support for the following features in Roo:
+* [Option `:expand_merged_ranged => true`](https://github.com/roo-rb/roo#expand_merged_ranges)
+
 ## License
 
 While Roo and Roo::Xls are licensed under the MIT / Expat license, please note that the `spreadsheet` gem [is released under](https://github.com/zdavatz/spreadsheet/blob/master/LICENSE.txt) the GPLv3 license. Please be aware that the author of the `spreadsheet` gem [claims you need a commercial license](http://spreadsheet.ch/2014/10/24/using-ruby-spreadsheet-on-heroku-with-dynos/) to use it as part of a public-facing, closed-source service, an interpretation [at odds with the FSF's intent and interpretation of the license](http://www.gnu.org/licenses/gpl-faq.html#UnreleasedMods). 

data/Rakefile

@@ -18,6 +18,12 @@ RSpec::Core::RakeTask.new(:spec)
 Coveralls::RakeTask.new
 
 default_task = [:test, :spec]
-default_task << 'coveralls:push' if ENV['TRAVIS']
+default_task << 'coveralls:push' if ENV['CI']
 
-task default: default_task
+if !ENV["APPRAISAL_INITIALIZED"] && !ENV['CI']
+  task :default do
+    sh "appraisal install && appraisal rake"
+  end
+else
+  task default: default_task
+end

data/lib/roo/xls/excel.rb

@@ -48,8 +48,6 @@ module Roo
       @fonts = {}
     end
 
-    attr_reader :workbook
-
     def worksheets
       @worksheets ||= workbook.worksheets
     end
@@ -285,7 +283,7 @@ module Roo
       format = row.format(idx)
       if format.date_or_time?
         cell = read_cell_content(row, idx)
-        true if Float(cell) > 0 rescue false
+        true if (Float(cell, exception: false) || 0) > 0
       else
         false
       end
@@ -309,7 +307,13 @@ module Roo
       else
         datetime =
           if row.at(idx).class == ::Spreadsheet::Formula
-            row.send(:_datetime, cell)
+            if row.respond_to?(:set_datetime, true)
+              # 1.3.4+
+              row.send(:set_datetime, cell)
+            else
+              # 1.3.3-
+              row.send(:_datetime, cell)
+            end
           else
             row.datetime(idx)
           end
@@ -322,7 +326,13 @@ module Roo
           value_type = :date
           value =
             if row.at(idx).class == ::Spreadsheet::Formula
-              row.send(:_date, cell)
+              if row.respond_to?(:set_date, true)
+                # 1.3.4+
+                row.send(:set_date, cell)
+              else
+                # 1.3.3-
+                row.send(:_date, cell)
+              end
             else
               row.date(idx)
             end

data/lib/roo/xls/excel_2003_xml.rb

@@ -21,7 +21,7 @@ class Roo::Excel2003XML < Roo::Base
       end
       @doc = ::Roo::Utils.load_xml(@filename)
     end
-    namespace = @doc.namespaces.select{|xmlns, urn| urn == 'urn:schemas-microsoft-com:office:spreadsheet'}.keys.last
+    namespace = @doc.namespaces.select { |_, urn| urn == 'urn:schemas-microsoft-com:office:spreadsheet' }.keys.last
     @namespace = (namespace.nil? || namespace.empty?) ? 'ss' : namespace.split(':').last
     super(filename, options)
     @formula = {}
@@ -58,7 +58,7 @@ class Roo::Excel2003XML < Roo::Base
   alias_method :formula?, :formula
 
   class Font
-    attr_accessor :bold, :italic, :underline
+    attr_accessor :bold, :italic, :underline, :color, :name, :size
 
     def bold?
       @bold == '1'
@@ -191,31 +191,49 @@ class Roo::Excel2003XML < Roo::Base
     validate_sheet!(sheet)
     return if @cells_read[sheet]
     sheet_found = false
+
     @doc.xpath("/#{@namespace}:Workbook/#{@namespace}:Worksheet[@#{@namespace}:Name='#{sheet}']").each do |ws|
       sheet_found = true
-      row = 1
+      column_styles = {}
+
+      # Column Styles
       col = 1
-      column_attributes = {}
-      idx = 0
       ws.xpath("./#{@namespace}:Table/#{@namespace}:Column").each do |c|
-        column_attributes[(idx += 1).to_s] = c['StyleID']
+        skip_to_col = c["#{@namespace}:Index"].to_i
+        col = skip_to_col if skip_to_col > 0
+        col_style_name = c["#{@namespace}:StyleID"]
+        column_styles[col] = col_style_name unless col_style_name.nil?
+        col += 1
       end
+
+      # Rows
+      row = 1
       ws.xpath("./#{@namespace}:Table/#{@namespace}:Row").each do |r|
-        skip_to_row = r['Index'].to_i
+        skip_to_row = r["#{@namespace}:Index"].to_i
         row = skip_to_row if skip_to_row > 0
-        style_name = r['StyleID'] if r['StyleID']
+
+        # Excel uses a 'Span' attribute on a 'Row' to indicate the presence of
+        # empty rows to skip.
+        skip_next_rows = r["#{@namespace}:Span"].to_i
+
+        row_style_name = r["#{@namespace}:StyleID"]
+
+        # Cells
+        col = 1
         r.xpath("./#{@namespace}:Cell").each do |c|
-          skip_to_col = c['Index'].to_i
+          skip_to_col = c["#{@namespace}:Index"].to_i
           col = skip_to_col if skip_to_col > 0
-          if c['StyleID']
-            style_name = c['StyleID']
-          elsif
-            style_name ||= column_attributes[c['Index']]
-          end
+
+          skip_next_cols = c["#{@namespace}:MergeAcross"].to_i
+
+          cell_style_name = c["#{@namespace}:StyleID"]
+          style_name = cell_style_name || row_style_name || column_styles[col]
+
+          # Cell Data
           c.xpath("./#{@namespace}:Data").each do |cell|
             formula = cell['Formula']
             value_type = cell["#{@namespace}:Type"].downcase.to_sym
-            v =  cell.content
+            v = cell.content
             str_v = v
             case value_type
             when :number
@@ -234,10 +252,9 @@ class Roo::Excel2003XML < Roo::Base
             end
             set_cell_values(sheet, col, row, 0, v, value_type, formula, cell, str_v, style_name)
           end
-          col += 1
+          col += (skip_next_cols + 1)
         end
-        row += 1
-        col = 1
+        row += (skip_next_rows + 1)
       end
     end
     unless sheet_found
@@ -248,12 +265,16 @@ class Roo::Excel2003XML < Roo::Base
 
   def read_styles
     @doc.xpath("/#{@namespace}:Workbook/#{@namespace}:Styles/#{@namespace}:Style").each do |style|
-      style_id = style['ID']
-      @style_definitions[style_id] = Roo::Excel2003XML::Font.new
-      if font = style.at_xpath("./#{@namespace}:Font")
-        @style_definitions[style_id].bold = font['Bold']
-        @style_definitions[style_id].italic = font['Italic']
-        @style_definitions[style_id].underline = font['Underline']
+      style_id = style["#{@namespace}:ID"]
+      font = style.at_xpath("./#{@namespace}:Font")
+      unless font.nil?
+        @style_definitions[style_id] = Roo::Excel2003XML::Font.new
+        @style_definitions[style_id].bold      = font["#{@namespace}:Bold"]
+        @style_definitions[style_id].italic    = font["#{@namespace}:Italic"]
+        @style_definitions[style_id].underline = font["#{@namespace}:Underline"]
+        @style_definitions[style_id].color     = font["#{@namespace}:Color"]
+        @style_definitions[style_id].name      = font["#{@namespace}:FontName"]
+        @style_definitions[style_id].size      = font["#{@namespace}:Size"]
       end
     end
   end

data/lib/roo/xls/version.rb

@@ -1,5 +1,5 @@
 module Roo
   module Xls
-    VERSION = '1.1.0'
+    VERSION = '2.0.0'
   end
 end

data/release-please-config.json

@@ -0,0 +1,12 @@
+{
+  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
+  "packages": {
+    ".": {
+      "version-file": "lib/roo/xls/version.rb",
+      "release-type": "ruby",
+      "changelog-path": "CHANGELOG.md",
+      "include-component-in-tag": false,
+      "include-v-in-tag": true
+    }
+  }
+}

data/roo-xls.gemspec

@@ -10,23 +10,25 @@ Gem::Specification.new do |spec|
   spec.email         = ["ruby.ruby.ruby.roo@gmail.com"]
   spec.summary       = "Roo::Excel can access the contents of classic xls files."
   spec.description   = "Roo can access the contents of various spreadsheet files. It can handle\n* OpenOffice\n* Excel\n* Google spreadsheets\n* Excelx\n* LibreOffice\n* CSV"
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/roo-rb/roo-xls"
   spec.license       = "MIT"
+  spec.metadata["changelog_uri"] = spec.homepage + '/blob/master/CHANGELOG.md'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "roo", ">= 2.0.0beta1", "< 3"
-  spec.add_dependency "spreadsheet", "> 0.9.0"
+  spec.required_ruby_version  = ">= 3.1.0"
 
-  if RUBY_VERSION >= '2.1'
-    spec.add_dependency "nokogiri"
-  else
-    spec.add_dependency "nokogiri", "~> 1.6.0"
-  end
+  spec.add_dependency "roo", ">= 2.0.0", "< 4"
+  spec.add_dependency "spreadsheet", ">= 1.3.4", "< 2"
+  spec.add_dependency "csv"
+
+  spec.add_dependency "nokogiri"
 
   spec.add_development_dependency "bundler", ">= 1.7"
   spec.add_development_dependency "rake", ">= 10.0"
+  spec.add_development_dependency "minitest", ">= 5.19.0"
+  spec.add_development_dependency "matrix"
 end

data/spec/lib/roo/xls/excel2003xml_spec.rb

@@ -1,14 +1,204 @@
 require 'spec_helper'
 
-describe Roo::Excel2003XML do
+RSpec.describe Roo::Excel2003XML do
+  subject { instance }
+
+  let(:instance) { described_class.new(path) }
+  let(:path) { File.join(test_files_dir, test_file) }
+  let(:test_files_dir) { 'test/files' }
+
   describe '.new' do
     context 'with an xml file' do
-      let(:path) { 'test/files/datetime.xml' }
+      let(:test_file) { 'datetime.xml' }
+
+      it 'loads the file without error' do
+        expect { subject }.to_not raise_error
+      end
+    end
+  end
+
+  describe '#cell' do
+    subject { super().cell(cell[:row], cell[:col]) }
+
+    before(:each) { instance.default_sheet = instance.sheets.first }
+
+    context 'with merged cells' do
+      # See font_colors_screenshot_in_Mac_Excel_16.10.png for a screenshot of
+      # this how this file looks in Mac Excel 16.10.
+      let(:test_file) { 'font_colors.xml' }
+
+      context 'the top-left cell in a merged cell' do
+        let(:cell) { { :row => 1, :col => 'A' } }
+
+        it 'returns the contents of the merged cell' do
+          is_expected.to eq 'Roo::Xls Test of Font Colors'
+        end
+      end
+
+      context 'the cell to the right of the top-left cell in a merged cell' do
+        let(:cell) { { :row => 2, :col => 'A' } }
+        it { is_expected.to be_nil }
+      end
+
+      context 'the cell below the top-left cell in a merged cell' do
+        let(:cell) { { :row => 2, :col => 'B' } }
+        it { is_expected.to be_nil }
+      end
+
+      context 'the first cell to the right of an entire merged cell' do
+        let(:cell) { { :row => 1, :col => 'K' } }
+
+        it 'returns the expected contents' do
+          is_expected.to eq 'This entire COLUMN should be ITALIC and GREEN'
+        end
+      end
+
+      context 'the first cell below an entire merged cell' do
+        let(:cell) { { :row => 6, :col => 'A' } }
+
+        it 'returns the expected contents' do
+          is_expected.to eq '(The above should be font "Courier New", size 24)'
+        end
+      end
+    end
+  end
+
+  describe '#font' do
+    subject { super().font(cell[:row], cell[:col]) }
+
+    before(:each) { instance.default_sheet = instance.sheets.first }
+
+    # See font_colors_screenshot_in_Mac_Excel_16.10.png for a screenshot of
+    # this how this file looks in Mac Excel 16.10.
+    let(:test_file) { 'font_colors.xml' }
+
+    let(:default_attrs) do
+      {
+        :name       => 'Arial',
+        :size       => '12',
+        :color      => '#000000',
+        :bold?      => false,
+        :italic?    => false,
+        :underline? => false
+      }
+    end
+
+    let(:expected_attrs) { default_attrs }
+
+    context 'with no font styling' do
+      let(:cell) { { :row => 6, :col => 'A' } }
+
+      it 'returns default font attributes' do
+        is_expected.to have_attributes(default_attrs)
+      end
+    end
+
+    context 'with styling set on an individual cell' do
+      context 'when set font name and size' do
+        let(:cell) { { :row => 1, :col => 'A' } }
+
+        it 'returns expected font attributes including name and size' do
+          expects = default_attrs.merge({ :name => 'Courier New', :size => '24' })
+          is_expected.to have_attributes(expects)
+        end
+      end
+
+      context 'when colored BLACK' do
+        let(:cell) { { :row => 7, :col => 'A' } }
+
+        it 'returns default font attributes (which include black)' do
+          is_expected.to have_attributes(default_attrs)
+        end
+      end
+
+      context 'when colored RED' do
+        let(:cell) { { :row => 8, :col => 'A' } }
+
+        it 'returns defaults plus red color' do
+          expects = default_attrs.merge({ :color => '#FF0000' })
+          is_expected.to have_attributes(expects)
+        end
+      end
+
+      context 'when colored BLUE' do
+        let(:cell) { { :row => 9, :col => 'A' } }
+
+        it 'returns defaults plus blue color' do
+          expects = default_attrs.merge({ :color => '#0066CC' })
+          is_expected.to have_attributes(expects)
+        end
+      end
+
+      context 'when BOLD' do
+        let(:cell) { { :row => 10, :col => 'A' } }
+
+        it 'returns defaults plus bold style' do
+          # somehow in Excel, this ended up "no color" rather than black...
+          expects = default_attrs.merge({ :bold? => true, :color => nil })
+          is_expected.to have_attributes(expects)
+        end
+      end
+
+      context 'when ITALIC' do
+        let(:cell) { { :row => 11, :col => 'A' } }
+
+        it 'returns defaults plus italic style' do
+          # somehow in Excel, this ended up "no color" rather than black...
+          expects = default_attrs.merge({ :italic? => true, :color => nil })
+          is_expected.to have_attributes(expects)
+        end
+      end
+
+      context 'when UNDERLINED' do
+        let(:cell) { { :row => 12, :col => 'A' } }
+
+        it 'returns defaults plus underlined style' do
+          # somehow in Excel, this ended up "no color" rather than black...
+          expects = default_attrs.merge({ :underline? => true, :color => nil })
+          is_expected.to have_attributes(expects)
+        end
+      end
+
+      context 'when BOLD, ITALIC, UNDERLINED, and colored PURPLE' do
+        let(:cell) { { :row => 13, :col => 'A' } }
+
+        it 'returns defaults plus bold, italic, underlined, and purple color' do
+          expects = default_attrs.merge({
+                                          :color      => '#666699',
+                                          :bold?      => true,
+                                          :italic?    => true,
+                                          :underline? => true
+                                        })
+          is_expected.to have_attributes(expects)
+        end
+      end
+    end
+
+    context 'with styling set on an entire row' do
+      let(:row_style) do
+        default_attrs.merge({ :color => '#ED7D31', :bold? => true })
+      end
+
+      context 'when no cell styling' do
+        let(:cell) { { :row => 14, :col => 'L' } }
+
+        it 'returns the row style' do
+          is_expected.to have_attributes(row_style)
+        end
+      end
+    end
+
+    context 'with styling set on an entire column' do
+      let(:col_style) do
+        default_attrs.merge({ :color => '#00FF00', :italic? => true })
+      end
+
+      context 'when no cell styling' do
+        let(:cell) { { :row => 20, :col => 'K' } }
 
-      it 'loads the file' do
-        expect {
-          Roo::Excel2003XML.new(path)
-        }.to_not raise_error
+        it 'returns the column style' do
+          is_expected.to have_attributes(col_style)
+        end
       end
     end
   end

data/test/files/font_colors.xml

@@ -0,0 +1,203 @@
+<?xml version="1.0"?>
+<?mso-application progid="Excel.Sheet"?>
+<Workbook xmlns="urn:schemas-microsoft-com:office:spreadsheet"
+ xmlns:o="urn:schemas-microsoft-com:office:office"
+ xmlns:x="urn:schemas-microsoft-com:office:excel"
+ xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet"
+ xmlns:html="http://www.w3.org/TR/REC-html40">
+ <DocumentProperties xmlns="urn:schemas-microsoft-com:office:office">
+  <Author>Marc Siegel</Author>
+  <LastAuthor>Marc Siegel</LastAuthor>
+  <Created>2018-02-14T22:21:05Z</Created>
+  <LastSaved>2018-02-15T17:12:56Z</LastSaved>
+  <Version>16.00</Version>
+ </DocumentProperties>
+ <OfficeDocumentSettings xmlns="urn:schemas-microsoft-com:office:office">
+  <AllowPNG/>
+ </OfficeDocumentSettings>
+ <ExcelWorkbook xmlns="urn:schemas-microsoft-com:office:excel">
+  <WindowHeight>16940</WindowHeight>
+  <WindowWidth>27640</WindowWidth>
+  <WindowTopX>3380</WindowTopX>
+  <WindowTopY>5080</WindowTopY>
+  <ProtectStructure>False</ProtectStructure>
+  <ProtectWindows>False</ProtectWindows>
+ </ExcelWorkbook>
+ <Styles>
+  <Style ss:ID="Default" ss:Name="Normal">
+   <Alignment ss:Vertical="Bottom"/>
+   <Borders/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#000000"/>
+   <Interior/>
+   <NumberFormat/>
+   <Protection/>
+  </Style>
+  <Style ss:ID="s62">
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#000000"/>
+  </Style>
+  <Style ss:ID="s63">
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#00FF00"
+    ss:Italic="1"/>
+  </Style>
+  <Style ss:ID="s65">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Center"/>
+   <Font ss:FontName="Courier New" x:Family="Roman" ss:Size="24" ss:Color="#000000"/>
+  </Style>
+  <Style ss:ID="s67">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Center" ss:WrapText="1"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#00FF00"
+    ss:Italic="1"/>
+  </Style>
+  <Style ss:ID="s69">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#000000"/>
+  </Style>
+  <Style ss:ID="s71">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#FF0000"/>
+  </Style>
+  <Style ss:ID="s73">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Center" ss:WrapText="1"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#FF0000"
+    ss:Underline="Single"/>
+  </Style>
+  <Style ss:ID="s75">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#0066CC"/>
+  </Style>
+  <Style ss:ID="s77">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Bold="1"/>
+  </Style>
+  <Style ss:ID="s79">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Italic="1"/>
+  </Style>
+  <Style ss:ID="s81">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Underline="Single"/>
+  </Style>
+  <Style ss:ID="s83">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#666699"
+    ss:Bold="1" ss:Italic="1" ss:Underline="Single"/>
+  </Style>
+  <Style ss:ID="s90">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Center" ss:WrapText="1"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#00FF00"
+    ss:Bold="1" ss:Italic="1"/>
+  </Style>
+  <Style ss:ID="s91">
+   <Alignment ss:Vertical="Center" ss:WrapText="1"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#008080"
+    ss:Bold="1" ss:Italic="1"/>
+  </Style>
+  <Style ss:ID="s97">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#ED7D31"
+    ss:Bold="1"/>
+  </Style>
+  <Style ss:ID="s100">
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#ED7D31"
+    ss:Bold="1"/>
+  </Style>
+  <Style ss:ID="s110">
+   <Alignment ss:Horizontal="Center" ss:Vertical="Bottom"/>
+   <Font ss:FontName="Arial" x:Family="Swiss" ss:Size="12" ss:Color="#FF0000"
+    ss:Underline="Single"/>
+  </Style>
+ </Styles>
+ <Worksheet ss:Name="Sheet1">
+  <Table ss:ExpandedColumnCount="13" ss:ExpandedRowCount="20" x:FullColumns="1"
+   x:FullRows="1" ss:StyleID="s62" ss:DefaultColumnWidth="65"
+   ss:DefaultRowHeight="16">
+   <Column ss:Index="10" ss:StyleID="s62" ss:AutoFitWidth="0" ss:Width="96"/>
+   <Column ss:StyleID="s63" ss:AutoFitWidth="0" ss:Width="173"/>
+   <Column ss:StyleID="s62" ss:AutoFitWidth="0" ss:Width="141"/>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:MergeAcross="9" ss:MergeDown="4" ss:StyleID="s65"><Data
+      ss:Type="String">Roo::Xls Test of Font Colors</Data></Cell>
+    <Cell ss:MergeDown="6" ss:StyleID="s67"><Data ss:Type="String">This entire COLUMN should be ITALIC and GREEN</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0" ss:Span="3"/>
+   <Row ss:Index="6" ss:AutoFitHeight="0">
+    <Cell><Data ss:Type="String">(The above should be font &quot;Courier New&quot;, size 24)</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:MergeAcross="9" ss:StyleID="s69"><Data ss:Type="String">This font should be BLACK</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:MergeAcross="9" ss:StyleID="s71"><Data ss:Type="String">This font should be RED</Data></Cell>
+    <Cell ss:MergeDown="5" ss:StyleID="s73"><Data ss:Type="String">…except this cell, which should be UNDERLINED and RED</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:MergeAcross="9" ss:StyleID="s75"><Data ss:Type="String">This font should be BLUE</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:MergeAcross="9" ss:StyleID="s77"><Data ss:Type="String">This font should be BOLD</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:MergeAcross="9" ss:StyleID="s79"><Data ss:Type="String">This font should be ITALIC</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:MergeAcross="9" ss:StyleID="s81"><Data ss:Type="String">This font should be UNDERLINED</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:MergeAcross="9" ss:StyleID="s83"><Data ss:Type="String">This font should be BOLD, ITALIC, UNDERLINED, and PURPLE</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0" ss:StyleID="s100">
+    <Cell ss:MergeAcross="4" ss:StyleID="s97"><Data ss:Type="String">This entire ROW should be BOLD and ORANGE</Data></Cell>
+    <Cell ss:MergeAcross="4" ss:StyleID="s110"><Data ss:Type="String">…except this cell, which should be UNDERLINED and RED</Data></Cell>
+    <Cell ss:MergeDown="5" ss:StyleID="s90"><Data ss:Type="String">As the combination of ROW and COLUMN styles, this cell should be BOLD, ITALIC, and GREEN</Data></Cell>
+    <Cell><Data ss:Type="String">Just row style</Data></Cell>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:Index="12" ss:StyleID="s91"/>
+    <Cell ss:StyleID="s91"/>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:Index="12" ss:StyleID="s91"/>
+    <Cell ss:StyleID="s91"/>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:Index="12" ss:StyleID="s91"/>
+    <Cell ss:StyleID="s91"/>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:Index="12" ss:StyleID="s91"/>
+    <Cell ss:StyleID="s91"/>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:Index="12" ss:StyleID="s91"/>
+    <Cell ss:StyleID="s91"/>
+   </Row>
+   <Row ss:AutoFitHeight="0">
+    <Cell ss:Index="11"><Data ss:Type="String">Just column style</Data></Cell>
+    <Cell ss:StyleID="s91"/>
+    <Cell ss:StyleID="s91"/>
+   </Row>
+  </Table>
+  <WorksheetOptions xmlns="urn:schemas-microsoft-com:office:excel">
+   <PageSetup>
+    <Header x:Margin="0.3"/>
+    <Footer x:Margin="0.3"/>
+    <PageMargins x:Bottom="0.75" x:Left="0.7" x:Right="0.7" x:Top="0.75"/>
+   </PageSetup>
+   <Unsynced/>
+   <Print>
+    <ValidPrinterInfo/>
+    <VerticalResolution>0</VerticalResolution>
+   </Print>
+   <Selected/>
+   <Panes>
+    <Pane>
+     <Number>3</Number>
+     <ActiveRow>25</ActiveRow>
+     <ActiveCol>7</ActiveCol>
+    </Pane>
+   </Panes>
+   <ProtectObjects>False</ProtectObjects>
+   <ProtectScenarios>False</ProtectScenarios>
+  </WorksheetOptions>
+ </Worksheet>
+</Workbook>

data/test/test_excel_2003_xml.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class TestRooExcel < MiniTest::Test
+class TestExcel2013XML < Minitest::Test
   def with_xml_spreadsheet(name)
     yield ::Roo::Excel2003XML.new(File.join(TESTDIR, "#{name}.xml"))
   end
@@ -25,15 +25,15 @@ class TestRooExcel < MiniTest::Test
   # This test just checks for that exception to make sure it's not raised in this case
   def test_date_to_float_conversion
     with_xml_spreadsheet('datetime_floatconv') do |oo|
-      assert_nothing_raised(NoMethodError) do
-        oo.cell('a', 1)
-        oo.cell('a', 2)
-      end
+      oo.default_sheet = oo.sheets.first
+      assert oo.cell('a', 1)
+      assert oo.cell('a', 2)
     end
   end
 
   def test_ruby_spreadsheet_formula_bug
     with_xml_spreadsheet('formula_parse_error') do |oo|
+      oo.default_sheet = oo.sheets.first
       assert_equal '5026', oo.cell(2, 3)
       assert_equal '5026', oo.cell(3, 3)
     end

data/test/test_roo_excel.rb

@@ -2,7 +2,7 @@
 require 'test_helper'
 require 'stringio'
 
-class TestRooExcel < MiniTest::Test
+class TestRooExcel < Minitest::Test
   def with_spreadsheet(name)
     yield ::Roo::Spreadsheet.open(File.join(TESTDIR, "#{name}.xls"))
   end
@@ -628,14 +628,14 @@ Sheet 3:
   def test_bug_to_xml_with_empty_sheets
     with_spreadsheet('emptysheets') do |oo|
       oo.sheets.each do |sheet|
-        assert_equal nil, oo.first_row, "first_row not nil in sheet #{sheet}"
-        assert_equal nil, oo.last_row, "last_row not nil in sheet #{sheet}"
-        assert_equal nil, oo.first_column, "first_column not nil in sheet #{sheet}"
-        assert_equal nil, oo.last_column, "last_column not nil in sheet #{sheet}"
-        assert_equal nil, oo.first_row(sheet), "first_row not nil in sheet #{sheet}"
-        assert_equal nil, oo.last_row(sheet), "last_row not nil in sheet #{sheet}"
-        assert_equal nil, oo.first_column(sheet), "first_column not nil in sheet #{sheet}"
-        assert_equal nil, oo.last_column(sheet), "last_column not nil in sheet #{sheet}"
+        assert_nil oo.first_row, "first_row not nil in sheet #{sheet}"
+        assert_nil oo.last_row, "last_row not nil in sheet #{sheet}"
+        assert_nil oo.first_column, "first_column not nil in sheet #{sheet}"
+        assert_nil oo.last_column, "last_column not nil in sheet #{sheet}"
+        assert_nil oo.first_row(sheet), "first_row not nil in sheet #{sheet}"
+        assert_nil oo.last_row(sheet), "last_row not nil in sheet #{sheet}"
+        assert_nil oo.first_column(sheet), "first_column not nil in sheet #{sheet}"
+        assert_nil oo.last_column(sheet), "last_column not nil in sheet #{sheet}"
       end
       oo.to_xml
     end

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: roo-xls
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Thomas Preymesser
 - Hugh McGowan
 - Ben Woosley
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-27 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: roo
@@ -18,34 +17,54 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.0beta1
+        version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.0beta1
+        version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: spreadsheet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.4
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.4
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '2'
+- !ruby/object:Gem::Dependency
+  name: csv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -88,6 +107,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.19.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.19.0
+- !ruby/object:Gem::Dependency
+  name: matrix
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |-
   Roo can access the contents of various spreadsheet files. It can handle
   * OpenOffice
@@ -102,10 +149,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/issue_template.md"
+- ".github/pull_request_template.md"
+- ".github/workflows/release-please.yml"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
+- ".release-please-manifest.json"
 - ".rubocop.yml"
 - ".simplecov"
-- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -116,6 +168,7 @@ files:
 - lib/roo/xls/excel_2003_xml.rb
 - lib/roo/xls/spreadsheet_extensions.rb
 - lib/roo/xls/version.rb
+- release-please-config.json
 - roo-xls.gemspec
 - spec/lib/roo/xls/excel2003xml_spec.rb
 - spec/lib/roo/xls/excel_spec.rb
@@ -147,6 +200,8 @@ files:
 - test/files/excel2003_namespace.xml
 - test/files/false_encoding.xls
 - test/files/false_encoding.xml
+- test/files/font_colors.xml
+- test/files/font_colors_screenshot_in_Mac_Excel_16.10.png
 - test/files/formula.xls
 - test/files/formula.xml
 - test/files/formula_parse_error.xls
@@ -184,11 +239,11 @@ files:
 - test/test_excel_2003_xml.rb
 - test/test_helper.rb
 - test/test_roo_excel.rb
-homepage: ''
+homepage: https://github.com/roo-rb/roo-xls
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  changelog_uri: https://github.com/roo-rb/roo-xls/blob/master/CHANGELOG.md
 rdoc_options: []
 require_paths:
 - lib
@@ -196,16 +251,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Roo::Excel can access the contents of classic xls files.
 test_files:
@@ -239,6 +292,8 @@ test_files:
 - test/files/excel2003_namespace.xml
 - test/files/false_encoding.xls
 - test/files/false_encoding.xml
+- test/files/font_colors.xml
+- test/files/font_colors_screenshot_in_Mac_Excel_16.10.png
 - test/files/formula.xls
 - test/files/formula.xml
 - test/files/formula_parse_error.xls

data/.travis.yml

@@ -1,15 +0,0 @@
-language: ruby
-rvm:
-  - 2.0
-  - 2.1
-  - 2.2
-  - 2.3
-  - 2.4.0
-  - ruby-head
-  - jruby-19mode # JRuby in 1.9 mode
-  - rbx-2
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: rbx-2
-bundler_args: --without local_development