ronin 1.5.0 → 1.5.1

data/spec/campaign_spec.rb

@@ -1,5 +1,13 @@
 require 'spec_helper'
+
 require 'ronin/campaign'
 
 describe Campaign do
+  describe "targets?" do
+    pending "needs specs"
+  end
+
+  describe "#target!" do
+    pending "needs specs"
+  end
 end

data/spec/credential_spec.rb

@@ -1,26 +1,29 @@
 require 'spec_helper'
+
 require 'ronin/credential'
 
 describe Credential do
-  let(:name) { 'alice' }
-  let(:secret) { 'secret' }
+  let(:name)     { 'alice'  }
+  let(:password) { 'secret' }
 
   subject do
-    Credential.new(
+    described_class.new(
       :user_name => {:name => name},
-      :password => {:clear_text => secret}
+      :password  => {:clear_text => password}
     )
   end
 
   it "should provide the user-name" do
-    subject.user.should == name
+    expect(subject.user).to eq(name)
   end
 
   it "should provide the clear-text password" do
-    subject.clear_text.should == secret
+    expect(subject.clear_text).to eq(password)
   end
 
-  it "should be convertable to a String" do
-    subject.to_s.should == "#{name}:#{secret}"
+  describe "#to_s" do
+    it "should include the user name and password" do
+      expect(subject.to_s).to eq("#{name}:#{password}")
+    end
   end
 end

data/spec/database_spec.rb

@@ -4,25 +4,25 @@ require 'ronin/database'
 describe Database do
   describe "repositories" do
     it "should not be empty" do
-      subject.repositories.should_not be_empty
+      expect(subject.repositories).not_to be_empty
     end
 
     it "should have a ':default' repository" do
-      subject.repositories[:default].should_not be_nil
+      expect(subject.repositories[:default]).not_to be_nil
     end
   end
 
   it "shold determine if a repository is defined" do
-    subject.repository?(:default).should == true
+    expect(subject.repository?(:default)).to be(true)
   end
 
   it "should determine when a repository is setup" do
-    subject.setup?(:default).should == true
+    expect(subject.setup?(:default)).to be(true)
   end
 
   it "should not allow switching to unknown repositories" do
-    lambda {
+    expect {
       subject.repository(:foo) { }
-    }.should raise_error(Database::UnknownRepository)
+    }.to raise_error(Database::UnknownRepository)
   end
 end

data/spec/email_address_spec.rb

@@ -1,13 +1,14 @@
 require 'spec_helper'
+
 require 'ronin/email_address'
 
 describe EmailAddress do
-  let(:user) { 'joe' }
-  let(:host) { 'example.com' }
+  let(:user)  { 'joe' }
+  let(:host)  { 'example.com' }
   let(:email) { "#{user}@#{host}" }
 
   subject {
-    EmailAddress.new(
+    described_class.new(
       :user_name => {:name => user},
       :host_name => {:address => host}
     )
@@ -18,10 +19,10 @@ describe EmailAddress do
 
     let(:email1) { subject.parse('foo@bar.com') }
     let(:email2) { subject.parse('foo!bar@baz.com') }
-    let(:text)  { "To: #{email1}, #{email2}." }
+    let(:text)   { "To: #{email1}, #{email2}." }
 
     it "should extract multiple email addresses from text" do
-      subject.extract(text).should == [email1, email2]
+      expect(subject.extract(text)).to eq([email1, email2])
     end
 
     it "should yield the extracted email addresses if a block is given" do
@@ -29,23 +30,23 @@ describe EmailAddress do
 
       subject.extract(text) { |email| emails << email }
 
-      emails.should == [email1, email2]
+      expect(emails).to eq([email1, email2])
     end
   end
 
   describe "parse" do
     it "should parse email addresses" do
-      email_address = EmailAddress.parse(email)
+      email_address = described_class.parse(email)
 
-      email_address.user_name.name.should == user
-      email_address.host_name.address.should == host
+      expect(email_address.user_name.name).to eq(user)
+      expect(email_address.host_name.address).to eq(host)
     end
 
     it "should strip whitespace from emails" do
-      email_address = EmailAddress.parse("  #{email} ")
+      email_address = described_class.parse("  #{email} ")
 
-      email_address.user_name.name.should == user
-      email_address.host_name.address.should == host
+      expect(email_address.user_name.name).to eq(user)
+      expect(email_address.host_name.address).to eq(host)
     end
   end
 
@@ -53,28 +54,30 @@ describe EmailAddress do
     it "should accept Strings" do
       email_address = described_class.from(email)
 
-      email_address.user_name.name.should == user
-      email_address.host_name.address.should == host
+      expect(email_address.user_name.name).to eq(user)
+      expect(email_address.host_name.address).to eq(host)
     end
 
     it "should accept URI::MailTo objects" do
       uri = URI("mailto:#{email}")
       email_address = described_class.from(uri)
 
-      email_address.user_name.name.should == user
-      email_address.host_name.address.should == host
+      expect(email_address.user_name.name).to eq(user)
+      expect(email_address.host_name.address).to eq(host)
     end
   end
 
   it "should provide the user-name" do
-    subject.user.should == user
+    expect(subject.user).to eq(user)
   end
 
   it "should provide the host-name" do
-    subject.host.should == host
+    expect(subject.host).to eq(host)
   end
 
-  it "should convert to a String" do
-    subject.to_s.should == email
+  describe "#to_s" do
+    it "should include the email address" do
+      expect(subject.to_s).to eq(email)
+    end
   end
 end

data/spec/host_name_spec.rb

@@ -1,20 +1,23 @@
 require 'spec_helper'
+
 require 'ronin/host_name'
 
 describe HostName do
   let(:domain) { 'localhost' }
-  let(:ip) { '127.0.0.1' }
+  let(:ip)     { '127.0.0.1' }
 
-  subject { HostName.new(:address => domain) }
+  subject { described_class.new(:address => domain) }
 
-  it "should require an address" do
-    host_name = HostName.new
+  describe "validations" do
+    it "should require an address" do
+      host_name = described_class.new
 
-    host_name.should_not be_valid
+      expect(host_name).not_to be_valid
+    end
   end
 
   it "should alias #name to #address" do
-    subject.name.should == subject.address
+    expect(subject.name).to eq(subject.address)
   end
 
   describe "extract" do
@@ -25,7 +28,7 @@ describe HostName do
     let(:text)  { "Hosts: #{host1}, #{host2}." }
 
     it "should extract multiple host-names from text" do
-      subject.extract(text).should == [host1, host2]
+      expect(subject.extract(text)).to eq([host1, host2])
     end
 
     it "should yield the extracted host-names if a block is given" do
@@ -33,58 +36,57 @@ describe HostName do
 
       subject.extract(text) { |host| hosts << host }
 
-      hosts.should == [host1, host2]
+      expect(hosts).to eq([host1, host2])
     end
   end
 
   describe "lookup" do
-    subject { HostName }
-
-    let(:bad_ip) { '0.0.0.0' }
+    subject { described_class }
 
     it "should look up the host names for an IP Address" do
       host_names = subject.lookup(ip).map { |name| name.address }
       
-      host_names.should include(domain)
+      expect(host_names).to include(domain)
     end
 
     it "should associate the host names with the original IP address" do
       host_names = subject.lookup(ip)
       
       host_names.each do |host|
-        host.ip_addresses[0].address.should == ip
+        expect(host.ip_addresses[0].address).to eq(ip)
       end
     end
 
+    let(:bad_ip) { '0.0.0.0' }
+
     it "should return an empty Array for unknown host names" do
       host_names = subject.lookup(bad_ip)
       
-      host_names.should be_empty
+      expect(host_names).to be_empty
     end
   end
 
   describe "#lookup!" do
-    let(:bad_domain) { '.bad.domain.com.' }
-
     it "should look up the IP Addresses for the host name" do
       ips = subject.lookup!
       
-      ips.should_not be_empty
-      ips[0].address.should == ip
+      expect(ips.any? { |ip_address| ip_address.address == ip }).to be(true)
     end
 
     it "should associate the IP addresses with the original host name" do
       ips = subject.lookup!
       
-      ips.each do |ip|
-        ip.host_names[0].address.should == domain
+      ips.each do |ip_address|
+        expect(ip_address.host_names[0].address).to eq(domain)
       end
     end
 
+    let(:bad_domain) { 'foo' }
+
     it "should return an empty Array for unknown host names" do
-      ips = HostName.new(:address => bad_domain).lookup!
+      ips = described_class.new(:address => bad_domain).lookup!
       
-      ips.should be_empty
+      expect(ips).to be_empty
     end
   end
 end

data/spec/installation_spec.rb

@@ -3,11 +3,11 @@ require 'ronin/installation'
 
 describe Installation do
   it "should load the gemspec for the 'ronin' library" do
-    subject.gems['ronin'].should_not be_nil
+    expect(subject.gems['ronin']).not_to be_nil
   end
 
   it "should provide the names of the installed Ronin libraries" do
-    subject.libraries.should include('ronin')
+    expect(subject.libraries).to include('ronin')
   end
 
   let(:directory) { 'lib/ronin/ui/cli/commands/'                }
@@ -17,11 +17,11 @@ describe Installation do
 
   describe "each_file" do
     it "should enumerate over the files which match a glob pattern" do
-      subject.each_file(pattern).to_a.should =~ paths
+      expect(subject.each_file(pattern).to_a).to match_array(paths)
     end
 
     it "should return an Enumerator when no block is given" do
-      subject.each_file(pattern).should respond_to(:each)
+      expect(subject.each_file(pattern)).to respond_to(:each)
     end
   end
 
@@ -30,11 +30,11 @@ describe Installation do
     let(:expected) { files }
 
     it "should enumerate over the files which match a glob pattern" do
-      subject.each_file_in(directory,ext).to_a.should =~ expected
+      expect(subject.each_file_in(directory,ext).to_a).to match_array(expected)
     end
 
     it "should return an Enumerator when no block is given" do
-      subject.each_file_in(directory,ext).should respond_to(:each)
+      expect(subject.each_file_in(directory,ext)).to respond_to(:each)
     end
   end
 end

data/spec/ip_address_spec.rb

@@ -1,27 +1,28 @@
 require 'spec_helper'
+
 require 'ronin/ip_address'
 
 describe IPAddress do
   let(:example_domain) { 'localhost' }
   let(:example_ip) { '127.0.0.1' }
 
-  subject { IPAddress.new(:address => example_ip) }
+  subject { described_class.new(:address => example_ip) }
 
   it "should require an address" do
-    ip_address = IPAddress.new
+    ip_address = described_class.new
 
-    ip_address.should_not be_valid
+    expect(ip_address).not_to be_valid
   end
 
   describe "extract" do
-    subject { IPAddress }
+    subject { described_class }
 
     let(:ip1)  { subject.parse('127.0.0.1') }
     let(:ip2)  { subject.parse('10.1.1.1') }
     let(:text) { "Hosts: #{ip1}, #{ip2}" }
 
     it "should extract multiple IP Addresses from text" do
-      subject.extract(text).should == [ip1, ip2]
+      expect(subject.extract(text)).to eq([ip1, ip2])
     end
 
     it "should yield the extracted IPs if a block is given" do
@@ -29,44 +30,42 @@ describe IPAddress do
 
       subject.extract(text) { |ip| ip_addresses << ip }
 
-      ip_addresses.should == [ip1, ip2]
+      expect(ip_addresses).to eq([ip1, ip2])
     end
   end
 
   describe "lookup" do
-    subject { IPAddress }
-
-    let(:bad_domain) { '.bad.domain.com.' }
+    subject { described_class }
 
     it "should lookup host-names to IP Addresses" do
       ip_addresses = subject.lookup(example_domain)
       addresses    = ip_addresses.map { |ip| ip.address }
       
-      addresses.should include(example_ip)
+      expect(addresses).to include(example_ip)
     end
 
     it "should associate the IP addresses with the original host name" do
       ip_addresses = subject.lookup(example_domain)
       host_names   = ip_addresses.map { |ip| ip.host_names[0].address }
       
-      host_names.should include(example_domain)
+      expect(host_names).to include(example_domain)
     end
 
+    let(:bad_domain) { 'foo' }
+
     it "should return an empty Array for unknown domain names" do
       ip_addresses = subject.lookup(bad_domain)
       
-      ip_addresses.should be_empty
+      expect(ip_addresses).to be_empty
     end
   end
 
   describe "#lookup!" do
-    let(:bad_ip) { '0.0.0.0' }
-
     it "should reverse lookup the host-name for an IP Address" do
       host_names = subject.lookup!
       addresses  = host_names.map { |host_name| host_name.address }
       
-      addresses.should include(example_domain)
+      expect(addresses).to include(example_domain)
     end
 
     it "should associate the host names with the original IP address" do
@@ -75,30 +74,36 @@ describe IPAddress do
         host_name.ip_addresses[0].address
       end
 
-      ip_addresses.should include(subject)
+      expect(ip_addresses).to include(subject)
     end
 
+    let(:bad_ip) { '0.0.0.0' }
+
     it "should return an empty Array for unknown domain names" do
-      ip_address = IPAddress.new(:address => bad_ip)
+      ip_address = described_class.new(:address => bad_ip)
       host_names = ip_address.lookup!
 
-      host_names.should be_empty
+      expect(host_names).to be_empty
     end
   end
 
   describe "#version" do
-    let(:ipv4) { IPAddress.new(:address => '127.0.0.1') }
-    let(:ipv6) { IPAddress.new(:address => '::1') }
-
     it "should only accept 4 or 6" do
-      ip_address = IPAddress.new(:address => '1.1.1.1', :version => 7)
+      ip_address = described_class.new(:address => '1.1.1.1', :version => 7)
+
+      expect(ip_address).not_to be_valid
+    end
+
+    context "with IPv4 address" do
+      subject { described_class.new(:address => '127.0.0.1') }
 
-      ip_address.should_not be_valid
+      it { expect(subject.version).to be == 4 }
     end
 
-    it "should default to the version of the address" do
-      ipv4.version.should == 4
-      ipv6.version.should == 6
+    context "with IPv6 address" do
+      subject { described_class.new(:address => '::1') }
+
+      it { expect(subject.version).to be == 6 }
     end
   end
 end