ronin-support 1.0.0.beta3 → 1.0.1

data/lib/ronin/support/binary/struct.rb

@@ -37,10 +37,10 @@ module Ronin
       # ### Defining Members
       #
       #     class Point < Ronin::Support::Binary::Struct
-      #     
+      #
       #       member :x, :int32
       #       member :y, :int32
-      #     
+      #
       #     end
       #
       # ### Initializing Structs
@@ -69,10 +69,10 @@ module Ronin
       # ### Packing Structs
       #
       #     class Point < Ronin::Support::Binary::Struct
-      #     
+      #
       #       member :x, :int32
       #       member :y, :int32
-      #     
+      #
       #     end
       #
       #     point = Point.new(x: 10, y: -1)
@@ -82,12 +82,12 @@ module Ronin
       # ### Unpacking Structs
       #
       #     class Point < Ronin::Support::Binary::Struct
-      #     
+      #
       #       member :x, :int32
       #       member :y, :int32
-      #     
+      #
       #     end
-      #     
+      #
       #     point = Point.unpack("\x00\x00\x00\x01\xFF\xFF\xFF\xFF")
       #     point.x
       #     # => 1
@@ -95,30 +95,30 @@ module Ronin
       #     # => -1
       #
       # ### Inheriting Structs
-      #     
+      #
       #     class Point < Ronin::Support::Binary::Struct
-      #     
+      #
       #       member :x, :int32
       #       member :y, :int32
-      #     
+      #
       #     end
-      #     
+      #
       #     class Point3D < Point
-      #     
+      #
       #       member :z, :int32
       #
       #     end
-      #     
+      #
       #     point   = Point.new(x: 100, y: 42)
       #     point3d = Point3D.new(x: 100, y: 42, z: -1)
       #
       # ### Array Fields
       #
       #     class MyStruct < Ronin::Support::Binary::Struct
-      #     
+      #
       #       member :x,    :uint32
       #       member :nums, [:uint8, 10]
-      #     
+      #
       #     end
       #
       #     struct = MyStruct.new
@@ -129,12 +129,12 @@ module Ronin
       # ### Unbounded Array Fields
       #
       #     class MyStruct < Ronin::Support::Binary::Struct
-      #     
+      #
       #       member :length,  :uint32
       #       member :payload, (:uint8..)
-      #     
+      #
       #     end
-      #     
+      #
       #     struct = MyStruct.new
       #     struct.payload = [0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08]
       #     struct.pack
@@ -143,14 +143,14 @@ module Ronin
       # ### Struct Endianness
       #
       #     class MyStruct < Ronin::Support::Binary::Struct
-      #     
+      #
       #       platform endian: :big
-      #     
+      #
       #       member :x, :uint32
       #       member :y, :uint32
-      #     
+      #
       #     end
-      #     
+      #
       #     struct = MyStruct.new
       #     struct.x = 0xAABB
       #     struct.y = 0xCCDD
@@ -160,13 +160,13 @@ module Ronin
       # ### Struct Architecture
       #
       #     class MyStruct < Ronin::Support::Binary::Struct
-      #     
+      #
       #       platform arch: :arm64_be
-      #     
+      #
       #       member :x, :int
       #       member :y, :int
       #       member :f, :double
-      #     
+      #
       #     end
       #
       #     struct = MyStruct.new
@@ -177,16 +177,16 @@ module Ronin
       #     # => "\x00\x00\x00d\xFF\xFF\xFF\x9C@<\xA5\xDC\x1Ac\xC1\xF8"
       #
       # ### Struct Operating System (OS)
-      #    
+      #
       #     class MyStruct < Ronin::Support::Binary::Struct
-      #     
+      #
       #       platform arch: :x86_64, os: :windows
-      #     
+      #
       #       member :x, :long
       #       member :y, :long
-      #     
+      #
       #     end
-      #     
+      #
       #     struct = MyStruct.new
       #     struct.x = 255
       #     struct.y = -1
@@ -196,20 +196,20 @@ module Ronin
       # ### Struct Alignment
       #
       #     class Pixel < Ronin::Support::Binary::Struct
-      #     
+      #
       #       align 4
-      #     
+      #
       #       member :r, :uint8
       #       member :g, :uint8
       #       member :b, :uint8
-      #     
+      #
       #     end
       #
       #     class PixelBuf < Ronin::Support::Binary::Struct
-      #     
+      #
       #       member :count, :uint8
       #       member :pixels, [Pixel, 255]
-      #     
+      #
       #     end
       #
       #     pixelbuf = PixelBuf.new
@@ -226,12 +226,12 @@ module Ronin
       # ### Disable Struct Padding
       #
       #     class MyStruct < Ronin::Support::Binary::Struct
-      #     
+      #
       #       padding false
-      #     
+      #
       #       member :c, :char
       #       member :i, :int32
-      #     
+      #
       #     end
       #
       #     struct = MyStruct.new
@@ -259,13 +259,13 @@ module Ronin
         #
         # @example Initiializing a new struct from a buffer:
         #   class MyStruct < Ronin::Support::Binary::Struct
-        #   
+        #
         #     member :x,    :uint32
         #     member :f,    :double
         #     member :nums, [:uint8, 10]
-        #   
+        #
         #   end
-        #   
+        #
         #   struct = MyStruct.new("\x01\x00\x00\x00\x00\x00\x00\x00333333\xD3?\x01\x02\x03\x00\x00\x00\x00\x00\x00\x00")
         #   struct.x
         #   # => 1
@@ -328,12 +328,12 @@ module Ronin
         #
         # @example
         #   class MyStruct < Ronin::Support::Binary::Struct
-        #   
+        #
         #     member :x, :uint32
         #     member :y, :uint32
-        #   
+        #
         #   end
-        #   
+        #
         #   MyStruct.size
         #   # => 8
         #
@@ -412,13 +412,13 @@ module Ronin
         #
         # @example
         #   class MyStruct < Ronin::Support::Binary::Struct
-        #   
+        #
         #     member :x,    :uint32
         #     member :f,    :double
         #     member :nums, [:uint8, 10]
-        #   
+        #
         #   end
-        #   
+        #
         #   MyStruct.pack(x: 1, f: 0.3, nums: [1,2,3])
         #   # => "\x01\x00\x00\x00\x00\x00\x00\x00333333\xD3?\x01\x02\x03\x00\x00\x00\x00\x00\x00\x00"
         #
@@ -439,13 +439,13 @@ module Ronin
         #
         # @example
         #   class MyStruct < Ronin::Support::Binary::Struct
-        #   
+        #
         #     member :x,    :uint32
         #     member :f,    :double
         #     member :nums, [:uint8, 10]
-        #   
+        #
         #   end
-        #   
+        #
         #   struct = MyStruct.unpack("\x01\x00\x00\x00\x00\x00\x00\x00333333\xD3?\x01\x02\x03\x00\x00\x00\x00\x00\x00\x00")
         #
         # @api public
@@ -465,13 +465,13 @@ module Ronin
         #
         # @example
         #   class MyStruct < Ronin::Support::Binary::Struct
-        #   
+        #
         #     member :x,    :uint32
         #     member :f,    :double
         #     member :nums, [:uint8, 10]
-        #   
+        #
         #   end
-        #   
+        #
         #   file   = File.new('binary.dat','b')
         #   struct = MyStruct.read_from(file)
         #
@@ -480,7 +480,7 @@ module Ronin
         # @api public
         #
         def self.read_from(io)
-          new().read_from(io)
+          new.read_from(io)
         end
 
         #
@@ -497,13 +497,13 @@ module Ronin
         #
         # @example
         #   class MyStruct < Ronin::Support::Binary::Struct
-        #   
+        #
         #     member :x,    :uint32
         #     member :f,    :double
         #     member :nums, [:uint8, 10]
-        #   
+        #
         #   end
-        #   
+        #
         #   struct = MyStruct.new("\x01\x00\x00\x00\x00\x00\x00\x00333333\xD3?\x01\x02\x03\x00\x00\x00\x00\x00\x00\x00")
         #   struct[:x]
         #   # => 1
@@ -519,15 +519,21 @@ module Ronin
             case member.type
             when CTypes::UnboundedArrayType
               # XXX: but how do we handle an unbounded array of structs?
-              @cache[name] ||= (
-                slice = byteslice(member.offset,size - member.offset)
-                Binary::Array.new(member.type.type,slice)
-              )
+              @cache[name] ||= begin
+                                 offset = member.offset
+                                 length = size - member.offset
+                                 slice  = byteslice(offset,length)
+
+                                 Binary::Array.new(member.type.type,slice)
+                               end
             when CTypes::ObjectType
-              @cache[name] ||= (
-                slice = byteslice(member.offset,member.type.size)
-                member.type.unpack(slice)
-              )
+              @cache[name] ||= begin
+                                 offset = member.offset
+                                 length = member.type.size
+                                 slice  = byteslice(offset,length)
+
+                                 member.type.unpack(slice)
+                               end
             else
               data = super(member.offset,member.type.size)
               member.type.unpack(data)
@@ -554,13 +560,13 @@ module Ronin
         #
         # @example
         #   class MyStruct < Ronin::Support::Binary::Struct
-        #   
+        #
         #     member :x,    :uint32
         #     member :f,    :double
         #     member :nums, [:uint8, 10]
-        #   
+        #
         #   end
-        #   
+        #
         #   struct = MyStruct.new
         #   struct[:x] = 1
         #   struct[:x]
@@ -606,7 +612,7 @@ module Ronin
         def each(&block)
           return enum_for(__method__) unless block_given?
 
-          @type.members.each_key  do |name|
+          @type.members.each_key do |name|
             yield name, self[name]
           end
         end
@@ -620,9 +626,7 @@ module Ronin
         # @api public
         #
         def to_h
-          Hash[@type.members.keys.map { |name|
-            [name, self[name]]
-          }]
+          each.to_h
         end
 
         #
@@ -634,9 +638,7 @@ module Ronin
         # @api public
         #
         def to_a
-          @type.members.keys.map do |name|
-            self[name]
-          end
+          each.map { |name,value| value }
         end
 
         extend CTypes::Mixin
@@ -755,7 +757,7 @@ module Ronin
         # @api semipublic
         #
         def self.type_resolver
-          @resolver ||= CTypes::TypeResolver.new(type_system)
+          @type_resolver ||= CTypes::TypeResolver.new(type_system)
         end
 
         #
@@ -771,7 +773,7 @@ module Ronin
         #   class MyStruct < Ronin::Support::Binary::Struct
         #     member :x, :uint32
         #   end
-        #   
+        #
         #   struct = MyStruct.new
         #   struct.x = 0x11223344
         #
@@ -779,7 +781,7 @@ module Ronin
         #   class MyStruct < Ronin::Support::Binary::Struct
         #     member :nums, [:uint32, 10]
         #   end
-        #   
+        #
         #   struct = MyStruct.new
         #   struct.x = [0x11111111, 0x22222222, 0x33333333, 0x44444444]
         #
@@ -787,7 +789,7 @@ module Ronin
         #   class MyStruct < Ronin::Support::Binary::Struct
         #     member :payload, :uint8..
         #   end
-        #   
+        #
         #   struct = MyStruct.new
         #   struct.payloads = [0x1, 0x2, 0x3, 0x4]
         #

data/lib/ronin/support/binary/template.rb

@@ -151,6 +151,7 @@ module Ronin
 
           @fields = []
           @types  = []
+
           @pack_string = String.new
 
           fields.each do |field|

data/lib/ronin/support/binary/unhexdump/parser.rb

@@ -46,9 +46,7 @@ module Ronin
           )
 
           # Visible characters
-          VISIBLE_CHARS = Hash[
-            Chars::VISIBLE.chars.sort.zip(Chars::VISIBLE.bytes.sort)
-          ]
+          VISIBLE_CHARS = Chars::VISIBLE.chars.sort.zip(Chars::VISIBLE.bytes.sort).to_h
 
           # Escaped characters
           CHARS = {
@@ -261,7 +259,7 @@ module Ronin
             case @type
             when CTypes::CharType
               @base  = 8
-              @chars = CHARS 
+              @chars = CHARS
             end
           end
 
@@ -310,6 +308,8 @@ module Ronin
                 starts_repeating_at  = previous_address + previous_row_size
               else
                 address, row = parse_line(line)
+
+                # remember the first address
                 first_address ||= address
 
                 if previous_row_repeats
@@ -317,8 +317,8 @@ module Ronin
                   range     = starts_repeating_at...address
                   addresses = range.step(previous_row_size)
 
-                  addresses.each do |address|
-                    yield address, previous_row
+                  addresses.each do |next_address|
+                    yield next_address, previous_row
                   end
 
                   previous_row_repeats = false
@@ -368,7 +368,6 @@ module Ronin
             buffer = String.new(encoding: Encoding::ASCII_8BIT)
 
             length = parse(hexdump) do |address,row|
-              first_address ||= address
               buffer << pack(row)
             end
 
@@ -385,7 +384,7 @@ module Ronin
           #   The parsed address.
           #
           # @api private
-          #   
+          #
           def parse_address(address)
             address.to_i(@address_base)
           end
@@ -400,7 +399,7 @@ module Ronin
           #   The parsed Integer.
           #
           # @api private
-          #   
+          #
           def parse_int(string)
             string.to_i(@base)
           end
@@ -415,7 +414,7 @@ module Ronin
           #   The parsed integer or byte value of the character.
           #
           def parse_char_or_int(string)
-            @chars.fetch(string) do |string|
+            @chars.fetch(string) do
               string.to_i(@base)
             end
           end
@@ -459,6 +458,7 @@ module Ronin
               end
             else
               address, *numbers = line.split
+
               address = parse_address(address)
               numbers.map!(&@parse_method)
 
@@ -480,7 +480,7 @@ module Ronin
           #   The packed segment.
           #
           # @api private
-          #   
+          #
           def pack(values)
             values.pack(@type.pack_string * values.length)
           end

data/lib/ronin/support/binary/union.rb

@@ -37,7 +37,7 @@ module Ronin
       #       member :c, :char
       #       member :i, :int16
       #       member :u, :uint32
-      #     
+      #
       #     end
       #
       # ### Initializing Fields
@@ -54,19 +54,19 @@ module Ronin
       #       member :c, :char
       #       member :i, :int16
       #       member :u, :uint32
-      #     
+      #
       #     end
-      #     
+      #
       #     class MyUnion2 < MyUnion
-      #     
+      #
       #       member :f, :float32
       #       member :d, :float64
-      #     
+      #
       #     end
-      #     
+      #
       #     union   = MyUnion.new
       #     union.i = -1
-      #     
+      #
       #     union2   = MyUnion.new
       #     union2.i = -1
       #     union2.d = 1.123
@@ -74,13 +74,13 @@ module Ronin
       # ### Packing Unions
       #
       #     class MyUnion < Ronin::Support::Binary::Union
-      #     
+      #
       #       member :c, :char
       #       member :i, :int16
       #       member :u, :uint32
-      #     
+      #
       #     end
-      #     
+      #
       #     union = MyUnion.new
       #     union.u = 0x11111111
       #     union.i = -1
@@ -90,13 +90,13 @@ module Ronin
       # ### Unpacking Unions
       #
       #     class MyUnion < Ronin::Support::Binary::Union
-      #     
+      #
       #       member :c, :char
       #       member :i, :int32
       #       member :u, :uint32
-      #     
+      #
       #     end
-      #     
+      #
       #     union = MyUnion.unpack("\xFF\xFF\x11\x11")
       #     union.c
       #     # => "\xFF"
@@ -108,12 +108,12 @@ module Ronin
       # ### Array Fields
       #
       #     class MyUnion < Ronin::Support::Binary::Union
-      #     
+      #
       #       member :c, :char
       #       member :i, :int16
       #       member :u, :uint32
       #       member :nums, [:uint8, 10]
-      #     
+      #
       #     end
       #
       #     union = MyUnion.new
@@ -124,14 +124,14 @@ module Ronin
       # ### Unbounded Array Fields
       #
       #     class MyUnion < Ronin::Support::Binary::Union
-      #     
+      #
       #       member :c, :char
       #       member :i, :int16
       #       member :u, :uint32
       #       member :payload, (:uint8..)
-      #     
+      #
       #     end
-      #     
+      #
       #     union = MyUnion.new
       #     union.payload = [0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08]
       #     union.pack
@@ -140,15 +140,15 @@ module Ronin
       # ### Default Endianness
       #
       #     class MyUnion < Ronin::Support::Binary::Union
-      #     
+      #
       #       endian :big
-      #     
+      #
       #       member :c, :char
       #       member :i, :int32
       #       member :u, :uint32
-      #     
+      #
       #     end
-      #     
+      #
       #     union = MyUnion.new(u: 0xaabbccdd)
       #     union.pack
       #     # => "\xAA\xBB\xCC\xDD"

data/lib/ronin/support/cli/ansi.rb

@@ -323,7 +323,6 @@ module Ronin
             end
           end
         end
-
       end
     end
   end

data/lib/ronin/support/cli/io_shell/core_ext/io.rb

@@ -40,7 +40,7 @@ class IO
   #   # NOTICE AUTH :*** Checking Ident
   #   # NOTICE AUTH :*** Found your hostname
   #   # NOTICE AUTH :*** No ident response
-  #   # USER test_ruby * * * 
+  #   # USER test_ruby * * *
   #   # NICK test_ruby
   #   # PING :3167790481
   #   # PONG 3167790481

data/lib/ronin/support/cli/io_shell.rb

@@ -34,7 +34,7 @@ module Ronin
       # NOTICE AUTH :*** Checking Ident
       # NOTICE AUTH :*** Found your hostname
       # NOTICE AUTH :*** No ident response
-      # USER test_ruby * * * 
+      # USER test_ruby * * *
       # NICK test_ruby
       # PING :3167790481
       # PONG 3167790481
@@ -123,7 +123,7 @@ module Ronin
           io_array = [@io, @stdin]
 
           loop do
-            readable, writable, errors = IO.select(io_array,nil,io_array)
+            readable, _writable, errors = IO.select(io_array,nil,io_array)
 
             if errors.include?(@io) || errors.include?(@stdin)
               return false
@@ -132,7 +132,7 @@ module Ronin
             if readable.include?(@io)
               data = begin
                        @io.readpartial(4096)
-                     rescue EOFError => error
+                     rescue EOFError
                        return false
                      end
 
@@ -142,7 +142,7 @@ module Ronin
             if readable.include?(@stdin)
               data = begin
                        @stdin.readpartial(4096)
-                     rescue EOFError => error
+                     rescue EOFError
                        return true
                      end