romanumerals 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f5ac06e5eb0a28e7a395360b07beec8393ad2b830f8cd96ef9de735846f8d7fd
-  data.tar.gz: 0b2947002ff049ea538473d520df45455b2c69d3e5d309ec75a3cde1e801f993
+  metadata.gz: ce9a2c835b1abd6e4aede7c8aad10ca02abb19532da0c6389e6207deffacf96f
+  data.tar.gz: 8ca0e19c63694bb28ee450d88e64e9578d2a97a88a4f71b275bf35df45c93fcf
 SHA512:
-  metadata.gz: fbc5e0a96c43aadd92300f11d3a7b397cd009d1d23b9857ec75cd73fbf7435092c0dec61c2cd19c24d311ddeef7fdf3f18c5b921539feaec1c9d27f97997cd73
-  data.tar.gz: ae3519940702d8b3b367fabbf78d336a8d297a7e5ee06854c0a35d84d0378454eecac6525f16ba454b16cfe68fbe092cdd88f6e80def4dc830bfcd429777b490
+  metadata.gz: 6eb90ef45faf6f20cfd82c9cbc5f73139dd161f9bac6be11f85b30a41463a54c547dae130f3ae716e2bc9083ec9b4195f9ab34bcfbed9a3868dede773a70bb4a
+  data.tar.gz: b292909557427f0ab63deca96206de50cea434b63dc106590be8711e18c3d2fce03608013affe0b5d8d4e6611fa3c9f3b7e0c45c3107f23a7c2ecd85b589f7e9

data/.ruby-version

@@ -0,0 +1 @@
+3.1.2

data/Gemfile

@@ -4,7 +4,7 @@ source 'https://rubygems.org'
 
 gemspec
 
+gem 'codecov', require: false, group: :test
 gem 'rake', '~> 13.0'
 gem 'rspec', '~> 3.0'
 gem 'rubocop', '~> 1.21'
-gem 'codecov', require: false, group: :test

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    romanumerals (0.1.0)
+    romanumerals (0.2.1)
 
 GEM
   remote: https://rubygems.org/
@@ -53,6 +53,7 @@ GEM
 
 PLATFORMS
   x86_64-darwin-20
+  x86_64-darwin-21
   x86_64-linux
 
 DEPENDENCIES
@@ -63,4 +64,4 @@ DEPENDENCIES
   rubocop (~> 1.21)
 
 BUNDLED WITH
-   2.3.12
+   2.3.14

data/README.md

@@ -18,6 +18,7 @@ If bundler is not being used to manage dependencies, install the gem by executin
 
 Usage is very simple:
 
+#### Convert to roman:
 ```ruby
 10.to_roman # => "X" 
 110.to_roman # => "CX" 
@@ -27,6 +28,23 @@ Usage is very simple:
 2022.to_roman # => "MMXXII"
 ```
 
+#### Convert from roman:
+```ruby
+'MMXXII'.to_numeral # => 2022
+```
+
+#### Other cases:
+```ruby
+0.to_roman # => ""
+11.9.to_roman # => "XI"
+
+# If a string does not contain roman numerals then the String#to_i will be used 
+''.to_numeral # => 0
+'0'.to_numeral # => 0
+'XIIi'.to_numeral # => 0
+'5 contributors'.to_numeral # => 5
+```
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/febonazzic/romanumerals.

data/lib/romanumerals/numeric.rb

@@ -6,19 +6,14 @@ module Romanumerals
       return '' if zero?
 
       decompose.each_with_object([]) do |(divider, count), result|
-        result <<
-          if count == 4
-            DICTIONARY[divider] + DICTIONARY[divider * 5]
-          else
-            DICTIONARY[divider] * count
-          end
+        result << DICTIONARY[divider] * count
       end.join
     end
 
     private
 
     def decompose
-      number = self
+      number = dup
 
       DICTIONARY.keys.each_with_object({}) do |divider, result|
         dividers_count = number / divider

data/lib/romanumerals/string.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+module Romanumerals
+  DICTIONARY_SORTED_BY_WEIGHT = {
+    'CM' => 900,
+    'CD' => 400,
+    'XC' => 90,
+    'XL' => 40,
+    'IX' => 9,
+    'IV' => 4,
+    'M'  => 1000,
+    'D'  => 500,
+    'C'  => 100,
+    'L'  => 50,
+    'X'  => 10,
+    'V'  => 5,
+    'I'  => 1
+  }.freeze
+
+  module String
+    def to_numeral
+      return to_i unless roman?
+
+      decompose.map { |value, count| DICTIONARY_SORTED_BY_WEIGHT[value] * count }.sum
+    end
+
+    def to_roman
+      to_i.to_roman
+    end
+
+    private
+
+    def roman?
+      match?(/^[IVXMCDL]*$/)
+    end
+
+    def decompose
+      initial_string = dup
+
+      DICTIONARY_SORTED_BY_WEIGHT.keys.each_with_object({}) do |value, result|
+        matches_count = initial_string.scan(/#{value}/).size
+        result[value] ||= 0
+
+        matches_count.times do
+          initial_string.sub!(/#{value}/, '')
+
+          result[value] += 1
+        end
+      end
+    end
+  end
+end
+
+class String
+  include Romanumerals::String
+end

data/lib/romanumerals/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Romanumerals
-  VERSION = '0.1.0'
+  VERSION = '0.2.1'
 end

data/lib/romanumerals.rb

@@ -2,6 +2,7 @@
 
 require_relative 'romanumerals/version'
 require_relative 'romanumerals/numeric'
+require_relative 'romanumerals/string'
 
 module Romanumerals
   class Error < StandardError; end

data/sig/romanumerals/numeric.rbs

@@ -0,0 +1,9 @@
+module Romanumerals
+  module Numeric
+    def to_roman: -> String
+
+    private
+
+    def decompose: -> Hash[Integer, Integer]
+  end
+end

data/sig/romanumerals/string.rbs

@@ -0,0 +1,13 @@
+module Romanumerals
+  DICTIONARY_SORTED_BY_WEIGHT: Hash[String, Integer]
+
+  module String
+    def to_numeral: -> Integer
+    def to_roman: -> ::String
+
+    private
+
+    def roman?: -> bool
+    def decompose: -> Hash[::String, Integer]
+  end
+end

data/sig/romanumerals.rbs

@@ -1,3 +1,4 @@
 module Romanumerals
   VERSION: String
+  DICTIONARY: Hash[Integer, String]
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: romanumerals
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - febonazzic
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-05-30 00:00:00.000000000 Z
+date: 2022-06-02 00:00:00.000000000 Z
 dependencies: []
 description:
 email:
@@ -19,6 +19,7 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - ".rubocop.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -27,8 +28,11 @@ files:
 - Rakefile
 - lib/romanumerals.rb
 - lib/romanumerals/numeric.rb
+- lib/romanumerals/string.rb
 - lib/romanumerals/version.rb
 - sig/romanumerals.rbs
+- sig/romanumerals/numeric.rbs
+- sig/romanumerals/string.rbs
 homepage: https://github.com/febonazzic/romanumerals
 licenses:
 - MIT