romanianvalidators 0.1.1 → 0.1.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 77accfec82cda9b706ea0ac3fe7dda0d4c642996
+  data.tar.gz: 9848303566d97e623d97d6f4cf4bc0c4c7ec5410
+SHA512:
+  metadata.gz: 47586d2962a1f8857d3dad0258331e1b9a69a99864515096fcbe7dce94947c6e0f626eb1c906406efc1c6653d9d4f8dc21b6c5d377443fa7448164f43f5a2cf9
+  data.tar.gz: 076077782f9438a71dd877dc97ed1aecc02b0a4e2957eb57cb9bcffd153d0462e177665844bf614bc051ee116617095a5789b5f9376070681b168f819167f41f

data/.travis.yml

@@ -9,3 +9,4 @@ rvm:
   - jruby-19mode
   - rbx-19mode
   - ruby-head
+  - 2.0.0

data/CHANGELOG.md

@@ -0,0 +1,3 @@
+### 0.1.2 (2013-04-15)
+ * can pass custom validation message
+ * tested on ruby 2.0

data/Gemfile

@@ -1,2 +1,2 @@
-source :rubygems
+source 'https://rubygems.org'
 gemspec

data/README.md

@@ -1,10 +1,13 @@
-# Romanian Validators
+# Romanian Validators [![Build Status](https://travis-ci.org/mtarnovan/romanianvalidators.png)](https://travis-ci.org/mtarnovan/romanianvalidators)
 
-Rails validators for: 
+ActiveModel validators for: 
 
   * Cod Numeric Personal (CNP)
   * Cod de identificare fiscală (CIF) and 
   * IBAN (only Romanian format as published by Romanian National Bank).
+  * BIC
+
+Extracted from [Factureaza.ro](https://factureaza.ro), our online invoicing solution for the Romanian market.
 
 ## Installation
 
@@ -21,9 +24,13 @@ Next install it with Bundler.
 
     $ bundle install
 
+Has no other dependency than `ActiveModel`, so it should work without Rails too.
+
+Tested with MRI 1.8.7, 1.9.3, 2.0.0, REE, Rubinius and JRuby (see `.travis.yml`)
+
 ## Usage
 
-In your models (ActiveModel), the gem provides the following new validators:
+In your models (`ActiveModel`), the gem provides the following new validators:
 * CIF
 * CNP
 * IBAN
@@ -33,7 +40,7 @@ The algorithms for validation are found in the source code.
 
 ```ruby
     class User
-      validates :cnp,             :cnp   => true
+      validates :cnp,             :cnp   => { :message => 'This is not a valid CNP'}
       validates :company_cif,     :cif => true
     end
 ```
@@ -41,6 +48,7 @@ The algorithms for validation are found in the source code.
 ### TODO
 
   * test more edge cases; test nil, blank; test messages; test in app
+  * add javascript validation ?
 
 ### Copyright
 

data/lib/active_model/validations/bic_validator.rb

@@ -5,9 +5,10 @@ module ActiveModel
       def validate_each(record, attribute, value)
         allow_blank = options.fetch(:allow_blank, false)
         allow_nil = options.fetch(:allow_nil, false)
+        message = options.fetch(:message, nil)
         record.errors.add_on_empty(attribute) if value.nil? && !allow_nil
         record.errors.add_on_blank(attribute) if value.blank? && !allow_blank
-        record.errors.add(attribute) unless Bic.valid?(value)
+        record.errors.add(attribute, message) unless Bic.valid?(value)
       end
 
       # This is only a basic validation of a BIC

data/lib/active_model/validations/cif_validator.rb

@@ -5,9 +5,10 @@ module ActiveModel
       def validate_each(record, attribute, value)
         allow_blank = options.fetch(:allow_blank, false)
         allow_nil = options.fetch(:allow_nil, false)
+        message = options.fetch(:message, nil)
         record.errors.add_on_empty(attribute) if value.nil? && !allow_nil
         record.errors.add_on_blank(attribute) if value.blank? && !allow_blank
-        record.errors.add(attribute) unless Cif.valid?(value)
+        record.errors.add(attribute, message) unless Cif.valid?(value)
       end
 
       # Algoritmul de validare al unui cod CUI

data/lib/active_model/validations/cnp_validator.rb

@@ -5,9 +5,10 @@ module ActiveModel
       def validate_each(record, attribute, value)
         allow_blank = options.fetch(:allow_blank, false)
         allow_nil = options.fetch(:allow_nil, false)
+        message = options.fetch(:message, nil)
         record.errors.add_on_empty(attribute) if value.nil? && !allow_nil
         record.errors.add_on_blank(attribute) if value.blank? && !allow_blank
-        record.errors.add(attribute) unless Cnp.valid?(value)
+        record.errors.add(attribute, message) unless Cnp.valid?(value)
       end
 
       # Algoritm de validare CNP

data/lib/active_model/validations/iban_validator.rb

@@ -5,9 +5,10 @@ module ActiveModel
       def validate_each(record, attribute, value)
         allow_blank = options.fetch(:allow_blank, false)
         allow_nil = options.fetch(:allow_nil, false)
+        message = options.fetch(:message, nil)
         record.errors.add_on_empty(attribute) if value.nil? && !allow_nil
         record.errors.add_on_blank(attribute) if value.blank? && !allow_blank
-        record.errors.add(attribute) unless Iban.valid?(value)
+        record.errors.add(attribute, message) unless Iban.valid?(value)
       end
 
       # Descrierea algoritmului:

data/romanianvalidators.gemspec

@@ -1,10 +1,11 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name        = 'romanianvalidators'
-  s.version     = '0.1.1'
+  s.version     = '0.1.2'
   s.authors     = ['Mihai Târnovan']
   s.email       = ['mihai.tarnovan@cubus.ro']
   s.homepage    = 'http://github.com/mtarnovan/romanianvalidators'
+  s.license     = 'MIT'
   s.summary     = %q{Collection of validations for Cod Numeric Personal (CNP), Cod de identificare fiscală (CIF) and IBAN (only Romanian format, as published by Romanian National Bank)}
   s.description = %q{Collection of validations for Cod Numeric Personal (CNP), Cod de identificare fiscală (CIF) and IBAN (only Romanian format, as published by Romanian National Bank).}
 

data/test/validations/bic_test.rb

@@ -20,11 +20,24 @@ describe "BICs" do
       subject.valid?.must_equal false
       subject.errors.size.must_equal 1
     end
+
+    it "rejects invalid BICs and allows custom error message" do
+      message = "Some custom error message"
+      subject = build_bic_record({:bic => '1'}, {:message => message})
+      subject.valid?.must_equal false
+      subject.errors.size.must_equal 1
+      subject.errors[:bic].must_equal Array.wrap(message)
+    end
   end
 
   def build_bic_record(attrs = {}, opts = {})
+    custom_message = opts.fetch(:message, false)
     TestRecord.reset_callbacks(:validate)
-    TestRecord.validates :bic, :bic => true
+    if custom_message
+      TestRecord.validates :bic, :bic => {:message => custom_message}
+    else
+      TestRecord.validates :bic, :bic => true
+    end
     TestRecord.new attrs
   end
 

data/test/validations/cif_test.rb

@@ -20,12 +20,26 @@ describe "Cod de identificare fiscală" do
       subject.valid?.must_equal false
       subject.errors.size.must_equal 1
     end
+
+    it "rejects invalid CIFs and allows custom error message" do
+      message = "Some custom error message"
+      subject = build_cif_record({:cif => '1'}, {:message => message})
+      subject.valid?.must_equal false
+      subject.errors.size.must_equal 1
+      subject.errors[:cif].must_equal Array.wrap(message)
+    end
+
   end
 
   def build_cif_record(attrs = {}, opts = {})
+    custom_message = opts.fetch(:message, false)
     TestRecord.reset_callbacks(:validate)
-    TestRecord.validates :cif, :cif => true
+    if custom_message
+      TestRecord.validates :cif, :cif => {:message => custom_message}
+    else
+      TestRecord.validates :cif, :cif => true
+    end
     TestRecord.new attrs
   end
 
-end
+end

data/test/validations/cnp_test.rb

@@ -20,11 +20,23 @@ describe "Cod numeric personal" do
       subject.valid?.must_equal false
       subject.errors.size.must_equal 1
     end
+    it "rejects invalid cnps and allows custom error message" do
+      message = "Some custom error message"
+      subject = build_cnp_record({:cnp => '1'}, {:message => message})
+      subject.valid?.must_equal false
+      subject.errors.size.must_equal 1
+      subject.errors[:cnp].must_equal Array.wrap(message)
+    end
   end
 
   def build_cnp_record(attrs = {}, opts = {})
+    custom_message = opts.fetch(:message, false)
     TestRecord.reset_callbacks(:validate)
-    TestRecord.validates :cnp, :cnp => true
+    if custom_message
+      TestRecord.validates :cnp, :cnp => {:message => custom_message}
+    else
+      TestRecord.validates :cnp, :cnp => true
+    end
     TestRecord.new attrs
   end
 

data/test/validations/iban_test.rb

@@ -20,11 +20,23 @@ describe "Iban (BNR only)" do
       subject.valid?.must_equal false
       subject.errors.size.must_equal 1
     end
+    it "rejects invalid ibans and allows custom error message" do
+      message = "Some custom error message"
+      subject = build_iban_record({:iban => '1'}, {:message => message})
+      subject.valid?.must_equal false
+      subject.errors.size.must_equal 1
+      subject.errors[:iban].must_equal Array.wrap(message)
+    end
   end
 
   def build_iban_record(attrs = {}, opts = {})
+    custom_message = opts.fetch(:message, false)
     TestRecord.reset_callbacks(:validate)
-    TestRecord.validates :iban, :iban => true
+    if custom_message
+      TestRecord.validates :iban, :iban => {:message => custom_message}
+    else
+      TestRecord.validates :iban, :iban => true
+    end
     TestRecord.new attrs
   end
 

metadata

@@ -1,78 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: romanianvalidators
 version: !ruby/object:Gem::Version
-  version: 0.1.1
-  prerelease: 
+  version: 0.1.2
 platform: ruby
 authors:
 - Mihai Târnovan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-12 00:00:00.000000000 Z
+date: 2013-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.8.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.8.7
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 description: Collection of validations for Cod Numeric Personal (CNP), Cod de identificare
@@ -86,6 +77,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .travis.yml
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -106,28 +98,28 @@ files:
 - test/validations/cnp_test.rb
 - test/validations/iban_test.rb
 homepage: http://github.com/mtarnovan/romanianvalidators
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: romanianvalidators
-rubygems_version: 1.8.24
+rubygems_version: 2.0.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Collection of validations for Cod Numeric Personal (CNP), Cod de identificare
   fiscală (CIF) and IBAN (only Romanian format, as published by Romanian National
   Bank)