roman_numbers 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a63442949e877487bc70a6f74548a2c5656efc57
-  data.tar.gz: d1e26b50ff30a72c472d0a7f19cdb329f6e0a648
+  metadata.gz: 154520d9143e2297d9ca4437b70f1eb36de4cf57
+  data.tar.gz: 6764dcb2c45acd10300909022016e5c400708ef8
 SHA512:
-  metadata.gz: 6519d9e809a9ed4baead73af212e2200b7a182cee544fb358e27f7eaf72ee91de9ca5c6c0b86b5e8a4b5e686cc504ef25b8b96882ce0a56fa6b47ee9ebf29cec
-  data.tar.gz: 10c0319e772228553c9e3d58b2d2218d7c17900ad518d90c622b94298e5a8b8f526501a7af60bfad9c2fefa5186cb6aa5c3050f5b4ad0d19792a2fdcf80feb08
+  metadata.gz: 2c0d2b3fb03daaed1778de72df60e8f94f1496870073a3111998f1fcec225e9366d8830fedfa4f1e966d8f7a16eaf1f7c55d42d680cc351f15e6e131704f12ee
+  data.tar.gz: 1bb43845ca739c2ebded476deb5d8088a199458edbdd1797e3675c1856cc3946c2b95ac6d51583d710b1bb69ef8a744dbff9b1110fdf27fa3e26a7459e736dd4

data/lib/roman_numbers/version.rb

@@ -1,3 +1,3 @@
 module RomanNumbers
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/helpers.rb

@@ -1,28 +1,47 @@
 module Helpers
-  def self.valid_inputs
+  def input_set_1
     [
-        [1, 'I'],
-        [5, 'V'],
-        [10, 'X'],
-        [50, 'L'],
-        [100, 'C'],
-        [500, 'D'],
-        [1000, 'M'],
-        [4, 'IV'],
-        [9, 'IX'],
-        [40, 'XL'],
-        [90, 'XC'],
-        [400, 'CD'],
-        [900, 'CM'],
-        [207, 'CCVII'],
-        [1066, 'MLXVI'],
-        [44, 'XLIV'],
-        [49, 'XLIX'],
-        [904, 'CMIV'],
-        [944, 'CMXLIV'],
-        [1904, 'MCMIV'],
-        [1944, 'MCMXLIV'],
-        [3999, 'MMMCMXCIX'],
+        {integer: 39, roman: 'XXXIX'}, 
+        {integer: 390, roman: 'CCCXC'}, 
     ]
   end
+  module_function :input_set_1
+  def input_set_2
+    [
+        {integer: 4, roman: 'IV'}, 
+        {integer: 9, roman: 'IX'},
+        {integer: 40, roman: 'XL'},
+        {integer: 90, roman: 'XC'},
+        {integer: 400, roman: 'CD'},
+        {integer: 900, roman: 'CM'},
+    ]
+  end
+  module_function :input_set_2
+  def valid_inputs
+    [
+       {integer: 1, roman: 'I'},
+       {integer: 5, roman: 'V'},
+       {integer: 10, roman: 'X'},
+       {integer: 50, roman: 'L'},
+       {integer: 100, roman: 'C'},
+       {integer: 500, roman: 'D'},
+       {integer: 1000, roman: 'M'},
+       {integer: 4, roman: 'IV'},
+       {integer: 9, roman: 'IX'},
+       {integer: 40, roman: 'XL'},
+       {integer: 90, roman: 'XC'},
+       {integer: 400, roman: 'CD'},
+       {integer: 900, roman: 'CM'},
+       {integer: 207, roman: 'CCVII'},
+       {integer: 1066, roman: 'MLXVI'},
+       {integer: 44, roman: 'XLIV'},
+       {integer: 49, roman: 'XLIX'},
+       {integer: 904, roman: 'CMIV'},
+       {integer: 944, roman: 'CMXLIV'},
+       {integer: 1904, roman: 'MCMIV'},
+       {integer: 1944, roman: 'MCMXLIV'},
+       {integer: 3999, roman: 'MMMCMXCIX'},
+    ]
+  end
+  module_function :valid_inputs
 end

data/spec/roman_numbers/roman_number_spec.rb

@@ -1,55 +1,95 @@
 require_relative '../spec_helper'
 
 module RomanNumbers
-  describe RomanNumber do # EXAMPLE GROUP
+  describe RomanNumber do
+
+    $invalid_input_error = InvalidInputError
 
     before(:each) do
       @roman_number = RomanNumber.new(1)
     end
     
-    describe '#convert_arabic_to_roman' do
-      context 'For Valid Input' do
-        Helpers.valid_inputs.each do |exp_input, exp_output|
-          it %Q{returns #{exp_output} for #{exp_input} as input} do
-            RomanNumber.new(exp_input).convert_decimal_to_roman.should == exp_output
+    describe '#convert_decimal_to_roman' do
+      shared_examples_for "works_with_valid_integral_roman_input_collection" do |array|
+        # Note: here array is array of hashes
+        array.each do |hsh|
+          it %Q{returns #{hsh[:integer]} for #{hsh[:roman]} as input} do
+            RomanNumber.new(hsh[:integer]).convert_decimal_to_roman.should == hsh[:roman]
           end
         end
       end
-      context 'For Invalid Input' do
-        exp_output = InvalidInputError
-        [
-            4000, 0, -10, '10'
-        ].each do |exp_input|
-          it %Q{raises #{exp_output} for #{exp_input} as input} do
+      
+      shared_examples_for "raises_error_on_invalid_roman_input_collection" do |array|
+        # Note: here array is array of integers
+        array.each do |integral_elem|
+          it %Q{raises #{$invalid_input_error} for #{integral_elem} as input} do
+            expect {
+              RomanNumber.new(integral_elem).convert_decimal_to_roman
+            }.to raise_error($invalid_input_error)
+        end
+        end
+      end
+
+      context %q(Symbols 'I', 'X', 'C', and 'M' cannot be repeated more than three times in succession) do 
+        it_behaves_like "raises_error_on_invalid_roman_input_collection", %w(VIIII IIIIV XXXXI XXXXC CCCCX XCCCC MMMMC)
+      end
+    
+      context %q(Symbols 'I', 'X', 'C', and 'M' can be repeated 4 times if 3rd and 4th are separated by smaller value) do 
+        it_behaves_like "works_with_valid_integral_roman_input_collection", Helpers.input_set_1
+      end
+
+      context %q(Symbols 'D', 'L', 'V' can never be repeated in succession) do 
+        it_behaves_like "raises_error_on_invalid_roman_input_collection", %w(DD DDC LL LLX VV VVI)
+      end
+
+      context %Q(Symbol 'I' can be subtrated from 'V' and 'X', and
+        Symbol 'L' can be subtracted from 'L' and 'C', and
+        Symbol 'C' can be subtracted from 'D' and 'M') do 
+        it_behaves_like "works_with_valid_integral_roman_input_collection", Helpers.input_set_2
+      end
+
+      context %Q(Symbol 'I' can be subtrated from 'V' and 'X' only, and
+        Symbol 'X' can be subtracted from 'L' and 'C' only, and
+        Symbol 'C' can be subtracted from 'D' and 'M' only) do
+        it_behaves_like "raises_error_on_invalid_roman_input_collection", %w(IL IC ID IM XD XM)
+      end
+    
+      context 'For Following Valid Inputs' do
+        it_behaves_like "works_with_valid_integral_roman_input_collection", Helpers.valid_inputs
+      end
+    
+      context 'For Following Invalid Input' do
+        [4000, 0, -10, '10'].each do |exp_input|
+          it %Q{raises #{$invalid_input_error} for #{exp_input} as input} do
             expect {
               RomanNumber.new(exp_input).convert_decimal_to_roman
-            }.to raise_error(exp_output)
+            }.to raise_error($invalid_input_error)
           end
         end
       end
     end
 
-    describe '#convert_roman_to_arabic' do
+    describe '#convert_roman_to_decimal' do
       context 'For Valid Input' do
-        Helpers.valid_inputs.each do |exp_output, exp_input|
-          it %Q{returns #{exp_output} for #{exp_input} as input} do
-            RomanNumber.new(exp_input).convert_roman_to_decimal.should == exp_output
+        Helpers.valid_inputs.each do |hsh|
+          it %Q{returns #{hsh[:roman]} for #{hsh[:integer]} as input} do
+            RomanNumber.new(hsh[:roman]).convert_roman_to_decimal.should == hsh[:integer]
           end
         end
       end
+
       context 'For Invalid Input' do
-        exp_output = InvalidInputError
-        %w(ABCDE CCCCVII CCVVVVI XXM).each do |exp_input|
-          it %Q{raises #{exp_output} for #{exp_input} as input} do
+        %w(ABCDE CCCCVII CCVVVVI).each do |exp_input|
+          it %Q{raises #{$invalid_input_error} for #{exp_input} as input} do
             expect {
               RomanNumber.new(exp_input).convert_roman_to_decimal
-            }.to raise_error(exp_output)
+            }.to raise_error($invalid_input_error)
           end
         end
       end
     end
 
-    describe 'PRIVATE_INTERFACE' do 
+    describe 'PRIVATE_INTERFACE (for developer)' do 
       describe '#largest_repeatable_element' do
         # set 1
         [
@@ -93,7 +133,6 @@ module RomanNumbers
         end
       end
     end
-
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roman_numbers
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Munish Goyal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-05 00:00:00.000000000 Z
+date: 2015-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler