rom 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 29e221f399a6c003c04d45c03b9518d19b5ffd48
-  data.tar.gz: 223b1648de818651d5cc89f05e088fefdaf8ec19
+  metadata.gz: e6dd420bd1787efc67261de110b316f6b5c92ae8
+  data.tar.gz: e9f8fb3dbc40528ac46f6427d7b7238c162980bd
 SHA512:
-  metadata.gz: 144b7539ca43248fd1c8304b624e5fd46f229016bb5057b20615f95026421b916b66888d223b49b4f5119a5698b44c7f96165fd454922b722387701e0d9eb7ee
-  data.tar.gz: 7dee28d63ed1e6a7c7eee538172249d6d8c71cd83b8840c38d86550cc323f2944ef4d68cab49236f69c55ac632fa00f29e06d44439fb2c6a1f1cd9a67e054e97
+  metadata.gz: 6a48171fa2e771fec4e68e14b99e4f78cfd31f6d5162ff5f14546f41d6970b44c8522304cfa9546cff203967696853002e3524f714023d7ac0fd5ea086d7ea9f
+  data.tar.gz: 34e9a0f63fabaf30897d767db9b8d26e1ac92cd0661cff7bdb5b1f27979fe56feb9f6b0c12ae7305f514c623322e270009ecd3ce35e51867bfdac5a199393408

data/.travis.yml

@@ -1,24 +1,24 @@
 language: ruby
-sudo: false
+dist: trusty
+sudo: required
 cache: bundler
-env:
-  - CODECLIMATE_REPO_TOKEN=f7c652b65a700fcf1032174afc5ea243b991e48bf73077cc34c148e1c800a2f7
 bundler_args: --without sql benchmarks console tools
 script: "bundle exec rake ci"
+after_success:
+  - '[ "$TRAVIS_RUBY_VERSION" = "2.3.1" ] && [ "$TRAVIS_BRANCH" = "master" ] && bundle exec codeclimate-test-reporter'
 rvm:
   - 2.1
   - 2.2
   - 2.3.1
-  - rbx-2
+  - rbx-3
   - jruby-9.1.5.0
-  - ruby-head
 env:
   global:
     - JRUBY_OPTS='--dev -J-Xmx1024M'
+    - COVERAGE='true'
 matrix:
   allow_failures:
-    - rvm: ruby-head
-    - rvm: rbx-2
+    - rvm: rbx-3
 notifications:
   webhooks:
     urls:

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+## v2.0.2 2016-11-11
+
+## Added
+
+* API docs for `ROM::Container` (solnic)
+
+## Fixed
+
+* Custom command input function is no longer overridden by schema hash (solnic)
+* `Relation::Name#to_s` returns a string properly when there is no alias (solnic)
+
+[Compare v2.0.1...v2.0.2](https://github.com/rom-rb/rom/compare/v2.0.0...v2.0.2)
+
 ## v2.0.1 2016-09-30
 
 ### Added

data/Gemfile

@@ -8,14 +8,18 @@ group :console do
 end
 
 group :test do
-  gem 'virtus'
-  gem 'anima', '~> 0.2.0'
+  gem 'dry-equalizer'
+  gem 'dry-struct'
   gem 'minitest'
   gem 'inflecto', '~> 0.0', '>= 0.0.2'
 
-  platforms :rbx do
-    gem 'rubysl-bigdecimal', platforms: :rbx
+  platforms :mri do
     gem 'codeclimate-test-reporter', require: false
+    gem 'simplecov', require: false
+  end
+
+  platforms :rbx do
+    gem 'rubysl-bigdecimal'
   end
 end
 
@@ -27,7 +31,7 @@ group :sql do
 end
 
 group :benchmarks do
-  gem 'activerecord', '5.0.0.beta4'
+  gem 'activerecord', '~> 5.0'
   gem 'benchmark-ips', '~> 2.2.0'
   gem 'rom-repository', github: 'rom-rb/rom-repository', branch: 'master'
 end

data/Rakefile

@@ -7,7 +7,7 @@ task default: [:ci]
 desc 'Run specs in isolation'
 task :"spec:isolation" do
   FileList["spec/**/*_spec.rb"].each do |spec|
-    sh "rspec", spec
+    sh "COVERAGE=false bundle exec rspec #{spec}"
   end
 end
 

data/lib/rom/container.rb

@@ -4,7 +4,97 @@ require 'rom/commands/graph/builder'
 require 'rom/support/publisher'
 
 module ROM
-  # Exposes defined gateways, relations and mappers
+  # ROM container is an isolated environment with no global state where all
+  # components are registered. Container objects provide access to your
+  # relations, commands and mappers. ROM containers are usually configured and
+  # handled via framework integrations, although it is easy to use them
+  # standalone.
+  #
+  # There are 3 types of container setup:
+  #
+  # * in-line setup - a simple block-based configuration which allows configuring
+  #   all components and gives you back a container instance. This type is suitable
+  #   for small scripts, or in some cases rake tasks
+  # * multi-step setup - this type requires creating a configuration object,
+  #   registering component classes (ie relation classes) and passing the config
+  #   to container builder function. This type is suitable when your environment
+  #   is not typical and you need full control over component registration
+  # * multi-step setup with auto-registration - same as multi-step but allows
+  #   you to configure auto-registration mechanism which will register component
+  #   classes for you, based on dir/file naming conventions. This is the most
+  #   common type of setup that's used by framework integrations
+  #
+  # @example in-line setup
+  #   rom = ROM.container(:sql, 'sqlite::memory') do |config|
+  #     config.default.create_table :users do
+  #       primary_key :id
+  #       column :name, String, null: false
+  #     end
+  #
+  #     config.relation(:users) do
+  #       schema(infer: true)
+  #
+  #       def by_name(name)
+  #         where(name: name)
+  #       end
+  #     end
+  #   end
+  #
+  #   rom.relations[:users].insert(name: "Jane")
+  #
+  #   rom.relations[:users].by_name("Jane").to_a
+  #   # [{:id=>1, :name=>"Jane"}]
+  #
+  # @example multi-step setup with explicit component classes
+  #   config = ROM::Configuration.new(:sql, 'sqlite::memory')
+  #
+  #   config.default.create_table :users do
+  #     primary_key :id
+  #     column :name, String, null: false
+  #   end
+  #
+  #   class Users < ROM::Relation[:sql]
+  #     schema(:users, infer: true)
+  #
+  #     def by_name(name)
+  #       where(name: name)
+  #     end
+  #   end
+  #
+  #   config.register_relation(Users)
+  #
+  #   rom = ROM.container(config)
+  #
+  #   rom.relations[:users].insert(name: "Jane")
+  #
+  #   rom.relations[:users].by_name("Jane").to_a
+  #   # [{:id=>1, :name=>"Jane"}]
+  #
+  #
+  # @example multi-step setup with auto-registration
+  #   config = ROM::Configuration.new(:sql, 'sqlite::memory')
+  #   config.auto_registration('./persistence', namespace: false)
+  #
+  #   config.default.create_table :users do
+  #     primary_key :id
+  #     column :name, String, null: false
+  #   end
+  #
+  #   # ./persistence/relations/users.rb
+  #   class Users < ROM::Relation[:sql]
+  #     schema(infer: true)
+  #
+  #     def by_name(name)
+  #       where(name: name)
+  #     end
+  #   end
+  #
+  #   rom = ROM.container(config)
+  #
+  #   rom.relations[:users].insert(name: "Jane")
+  #
+  #   rom.relations[:users].by_name("Jane").to_a
+  #   # [{:id=>1, :name=>"Jane"}]
   #
   # @api public
   class Container
@@ -18,12 +108,12 @@ module ROM
 
     # @return [RelationRegistry] relation registry
     #
-    # @api private
+    # @api public
     attr_reader :relations
 
     # @return [Registry] command registry
     #
-    # @api private
+    # @api public
     attr_reader :commands
 
     # @return [Registry] mapper registry
@@ -39,7 +129,11 @@ module ROM
       @commands = commands
     end
 
-    # Get lazy relation identified by its name
+    # Get relation instance identified by its name
+    #
+    # This method will use a custom mapper if it was configured. ie if you have
+    # a relation called `:users` and a mapper configured for `:users` relation,
+    # then by default this mapper will be used.
     #
     # @example
     #   rom.relation(:users)
@@ -58,7 +152,7 @@ module ROM
     #
     # @yield [Relation]
     #
-    # @return [Relation::Lazy]
+    # @return [Relation]
     #
     # @api public
     def relation(name, &block)
@@ -79,8 +173,7 @@ module ROM
     # Returns commands registry for the given relation
     #
     # @example
-    #
-    #   # plain command returning tuples
+    #   # plain command without mapping
     #   rom.command(:users).create
     #
     #   # allows auto-mapping using registered mappers
@@ -121,6 +214,16 @@ module ROM
       end
     end
 
+    # Disconnect all gateways
+    #
+    # @example
+    #   rom = ROM.container(:sql, 'sqlite://my_db.sqlite')
+    #   rom.relations[:users].insert(name: "Jane")
+    #   rom.disconnect
+    #
+    # @return [Hash<Symbol=>Gateway>] a hash with disconnected gateways
+    #
+    # @api public
     def disconnect
       gateways.each_value(&:disconnect)
     end

data/lib/rom/plugins/command/schema.rb

@@ -16,7 +16,18 @@ module ROM
             if options.key?(:input) || !relation.schema?
               super
             else
-              super(relation, options.merge(input: relation.schema_hash))
+              default_input = options.fetch(:input, input)
+
+              input_handler =
+                if default_input != Hash && relation.schema?
+                  -> tuple { relation.schema_hash[input[tuple]] }
+                elsif relation.schema?
+                  relation.schema_hash
+                else
+                  default_input
+                end
+
+              super(relation, options.merge(input: input_handler))
             end
           end
         end

data/lib/rom/relation/name.rb

@@ -65,7 +65,7 @@ module ROM
       # @api private
       def to_s
         if relation == dataset
-          relation
+          relation.to_s
         else
           "#{relation} on #{dataset}"
         end

data/lib/rom/schema/dsl.rb

@@ -51,7 +51,7 @@ module ROM
 
       # @api private
       def call
-        Schema.new(name, attributes, inferrer: inferrer && inferrer.new(self))
+        Schema.new(name, attributes, inferrer: inferrer)
       end
     end
   end

data/lib/rom/version.rb

@@ -1,3 +1,3 @@
 module ROM
-  VERSION = '2.0.1'.freeze
+  VERSION = '2.0.2'.freeze
 end

data/spec/integration/commands/create_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'dry-struct'
 
 describe 'Commands / Create' do
   include_context 'container'
@@ -40,12 +41,14 @@ describe 'Commands / Create' do
       end
     end
 
-    Test::User = Class.new do
-      include Anima.new(:name, :email)
+    Test::User = Class.new(Dry::Struct) do
+      attribute :name, Types::String
+      attribute :email, Types::String
     end
 
-    Test::Task = Class.new do
-      include Anima.new(:name, :title)
+    Test::Task = Class.new(Dry::Struct) do
+      attribute :name, Types::String
+      attribute :title, Types::String
     end
 
     class Test::UserMapper < ROM::Mapper

data/spec/integration/commands/update_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
-
-require 'ostruct'
+require 'dry-struct'
 
 describe 'Commands / Update' do
   include_context 'container'
@@ -87,7 +86,10 @@ describe 'Commands / Update' do
 
   describe 'piping results through mappers' do
     it 'allows scoping to a virtual relation' do
-      user_model = Class.new { include Anima.new(:name, :email) }
+      user_model = Class.new(Dry::Struct) {
+        attribute :name, Types::String
+        attribute :email, Types::String
+      }
 
       configuration.mappers do
         define(:users) do

data/spec/integration/mappers/combine_spec.rb

@@ -101,9 +101,9 @@ describe 'Mapper definition DSL' do
     it 'works' do
       container
 
-      Test::User.send(:include, Equalizer.new(:name, :email, :tasks, :address, :book))
-      Test::Task.send(:include, Equalizer.new(:title, :meta))
-      Test::Address.send(:include, Equalizer.new(:city))
+      Test::User.send(:include, Dry::Equalizer(:name, :email, :tasks, :address, :book))
+      Test::Task.send(:include, Dry::Equalizer(:title, :meta))
+      Test::Address.send(:include, Dry::Equalizer(:city))
 
       result = users.combine(
         tasks.for_users.combine(tasks.tags),

data/spec/integration/mappers/definition_dsl_spec.rb

@@ -130,7 +130,7 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::TaskWithUser.send(:include, Equalizer.new(:title, :priority, :user))
+      Test::TaskWithUser.send(:include, Dry::Equalizer(:title, :priority, :user))
 
       jane = container.relation(:tasks).with_user.as(:with_user).to_a.last
 
@@ -159,7 +159,7 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::TaskWithUser.send(:include, Equalizer.new(:title, :priority, :user))
+      Test::TaskWithUser.send(:include, Dry::Equalizer(:title, :priority, :user))
 
       jane = container.relation(:tasks).with_user.as(:with_user).to_a.last
 
@@ -189,8 +189,8 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::TaskWithUser.send(:include, Equalizer.new(:title, :priority, :user))
-      Test::User.send(:include, Equalizer.new(:email))
+      Test::TaskWithUser.send(:include, Dry::Equalizer(:title, :priority, :user))
+      Test::User.send(:include, Dry::Equalizer(:email))
 
       jane = container.relation(:tasks).with_user.as(:with_user).to_a.last
 

data/spec/integration/mappers/embedded_spec.rb

@@ -54,7 +54,7 @@ describe 'Mappers / embedded' do
 
     jane = container.relation(:users).as(:users).first
 
-    Test::Address.send(:include, Equalizer.new(:street, :city))
+    Test::Address.send(:include, Dry::Equalizer(:street, :city))
 
     expect(jane.name).to eql('Jane')
     expect(jane.address).to eql(Test::Address.new(street: 'Somewhere 1', city: 'NYC'))

data/spec/integration/mappers/group_spec.rb

@@ -44,7 +44,7 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::UserWithTasks.send(:include, Equalizer.new(:name, :email, :tasks))
+      Test::UserWithTasks.send(:include, Dry::Equalizer(:name, :email, :tasks))
 
       jane = container.relation(:users).with_tasks.map_with(:with_tasks).to_a.last
 
@@ -74,7 +74,7 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::UserWithTasks.send(:include, Equalizer.new(:name, :email, :tasks))
+      Test::UserWithTasks.send(:include, Dry::Equalizer(:name, :email, :tasks))
 
       jane = container.relation(:users).with_tasks.map_with(:with_tasks).to_a.last
 
@@ -106,8 +106,8 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::UserWithTasks.send(:include, Equalizer.new(:name, :email, :tasks))
-      Test::Task.send(:include, Equalizer.new(:title, :priority))
+      Test::UserWithTasks.send(:include, Dry::Equalizer(:name, :email, :tasks))
+      Test::Task.send(:include, Dry::Equalizer(:title, :priority))
 
       jane = container.relation(:users).with_tasks.map_with(:with_tasks).to_a.last
 
@@ -145,9 +145,9 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::TaskWithUsers.send(:include, Equalizer.new(:title, :priority, :users))
-      Test::TaskUser.send(:include, Equalizer.new(:name, :contacts))
-      Test::Contact.send(:include, Equalizer.new(:email))
+      Test::TaskWithUsers.send(:include, Dry::Equalizer(:title, :priority, :users))
+      Test::TaskUser.send(:include, Dry::Equalizer(:name, :contacts))
+      Test::Contact.send(:include, Dry::Equalizer(:email))
 
       task = container.relation(:tasks).with_users.map_with(:with_users).first
 

data/spec/integration/mappers/prefixing_attributes_spec.rb

@@ -28,7 +28,7 @@ describe 'Mappers / Prefixing attributes' do
       user_email: 'jane@doe.org'
     }
 
-    Test::User.send(:include, Equalizer.new(:id, :name, :email))
+    Test::User.send(:include, Dry::Equalizer(:id, :name, :email))
 
     jane = container.relation(:users).as(:users).first
 

data/spec/integration/mappers/renaming_attributes_spec.rb

@@ -30,7 +30,7 @@ describe 'Mappers / Renaming attributes' do
 
     container
 
-    Test::User.send(:include, Equalizer.new(:id, :name))
+    Test::User.send(:include, Dry::Equalizer(:id, :name))
 
     container.relations.users << { _id: 123, user_name: 'Jane' }
 
@@ -63,7 +63,7 @@ describe 'Mappers / Renaming attributes' do
 
     container
 
-    Test::UserWithAddress.send(:include, Equalizer.new(:id, :name, :address))
+    Test::UserWithAddress.send(:include, Dry::Equalizer(:id, :name, :address))
 
     container.relations.users << { _id: 123, user_name: 'Jane' }
 
@@ -102,7 +102,7 @@ describe 'Mappers / Renaming attributes' do
 
     container
 
-    Test::UserWithAddresses.send(:include, Equalizer.new(:id, :name, :addresses))
+    Test::UserWithAddresses.send(:include, Dry::Equalizer(:id, :name, :addresses))
 
     container.relations.users << { _id: 123, user_name: 'Jane' }
 

data/spec/integration/mappers/wrap_spec.rb

@@ -40,7 +40,7 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::TaskWithUser.send(:include, Equalizer.new(:title, :priority, :user))
+      Test::TaskWithUser.send(:include, Dry::Equalizer(:title, :priority, :user))
 
       jane = container.relation(:tasks).with_user.as(:with_user).to_a.last
 
@@ -69,7 +69,7 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::TaskWithUser.send(:include, Equalizer.new(:title, :priority, :user))
+      Test::TaskWithUser.send(:include, Dry::Equalizer(:title, :priority, :user))
 
       jane = container.relation(:tasks).with_user.as(:with_user).to_a.last
 
@@ -104,9 +104,9 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::TaskWithUser.send(:include, Equalizer.new(:title, :priority, :user))
-      Test::TaskUser.send(:include, Equalizer.new(:name, :contact))
-      Test::Contact.send(:include, Equalizer.new(:email))
+      Test::TaskWithUser.send(:include, Dry::Equalizer(:title, :priority, :user))
+      Test::TaskUser.send(:include, Dry::Equalizer(:name, :contact))
+      Test::Contact.send(:include, Dry::Equalizer(:email))
 
       jane = container.relation(:tasks).with_user.as(:with_user).to_a.last
 
@@ -138,8 +138,8 @@ describe 'Mapper definition DSL' do
 
       container
 
-      Test::TaskWithUser.send(:include, Equalizer.new(:title, :priority, :user))
-      Test::User.send(:include, Equalizer.new(:email))
+      Test::TaskWithUser.send(:include, Dry::Equalizer(:title, :priority, :user))
+      Test::User.send(:include, Dry::Equalizer(:email))
 
       jane = container.relation(:tasks).with_user.as(:with_user).to_a.last
 

data/spec/integration/relations/reading_spec.rb

@@ -63,8 +63,8 @@ describe 'Reading relations' do
 
     container
 
-    Test::User.send(:include, Equalizer.new(:name, :email))
-    Test::UserWithTasks.send(:include, Equalizer.new(:name, :email, :tasks))
+    Test::User.send(:include, Dry::Equalizer(:name, :email))
+    Test::UserWithTasks.send(:include, Dry::Equalizer(:name, :email, :tasks))
 
     user = container.relation(:users).sorted.as(:users).first
 
@@ -100,8 +100,8 @@ describe 'Reading relations' do
 
     container
 
-    Test::User.send(:include, Equalizer.new(:name, :email))
-    Test::UserWithTask.send(:include, Equalizer.new(:name, :email, :task))
+    Test::User.send(:include, Dry::Equalizer(:name, :email))
+    Test::UserWithTask.send(:include, Dry::Equalizer(:name, :email, :task))
 
     user = container.relation(:users).sorted.with_task.as(:with_task).first
 

data/spec/integration/setup_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-require 'virtus'
+require 'dry-struct'
 
 describe 'Configuring ROM' do
   context 'with existing schema' do
@@ -79,9 +79,8 @@ describe 'Configuring ROM' do
     # NOTE: move to DSL tests
     it 'exposes boot DSL inside the setup block via `macros` plugin' do
       module Test
-        User = Class.new do
-          include Virtus.value_object
-          values { attribute :name, String }
+        User = Class.new(Dry::Struct) do
+          attribute :name, Types::String
         end
       end
 
@@ -113,9 +112,8 @@ describe 'Configuring ROM' do
   describe 'multi-step setup' do
     it 'exposes boot DSL that can be invoked multiple times' do
       module Test
-        User = Class.new do
-          include Virtus.value_object
-          values { attribute :name, String }
+        User = Class.new(Dry::Struct) do
+          attribute :name, Types::String
         end
       end
 

data/spec/spec_helper.rb

@@ -4,9 +4,11 @@
 require "bundler"
 Bundler.setup
 
-if RUBY_ENGINE == "rbx"
-  require "codeclimate-test-reporter"
-  CodeClimate::TestReporter.start
+if ENV['COVERAGE'] == 'true' && RUBY_ENGINE == 'ruby' && RUBY_VERSION='2.3.1'
+  require "simplecov"
+  SimpleCov.start do
+    add_filter '/spec/'
+  end
 end
 
 SPEC_ROOT = root = Pathname(__FILE__).dirname
@@ -15,7 +17,6 @@ require 'rom/support/deprecations'
 ROM::Deprecations.set_logger!(SPEC_ROOT.join('../log/deprecations.log'))
 
 require 'rom'
-require 'anima'
 
 begin
   require 'byebug'

data/spec/support/types.rb

@@ -0,0 +1,5 @@
+require 'dry-types'
+
+module Types
+  include Dry::Types.module
+end

data/spec/unit/rom/commands/graph_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'dry-struct'
 
 describe ROM::Commands::Graph do
   shared_examples_for 'a persisted graph' do
@@ -134,9 +135,19 @@ describe ROM::Commands::Graph do
     end
 
     before do
-      Test::Tag = Class.new { include Anima.new(:name) }
-      Test::Task = Class.new { include Anima.new(:title, :tags) }
-      Test::User = Class.new { include Anima.new(:name, :task) }
+      Test::Tag = Class.new(Dry::Struct) {
+        attribute :name, Types::String
+      }
+
+      Test::Task = Class.new(Dry::Struct) {
+        attribute :title, Types::String
+        attribute :tags, Types::Array.member(Test::Tag)
+      }
+
+      Test::User = Class.new(Dry::Struct) {
+        attribute :name, Types::String
+        attribute :task, Test::Task
+      }
 
       class Test::UserMapper < ROM::Mapper
         relation :users

data/spec/unit/rom/plugins/command/schema_spec.rb

@@ -0,0 +1,66 @@
+require 'rom/relation'
+require 'rom/command'
+require 'rom/plugins/command/schema'
+
+RSpec.describe ROM::Plugins::Command::Schema do
+  describe '.build' do
+    let(:command_class) do
+      Class.new(ROM::Command) { use :schema }
+    end
+
+    context 'when relation has no schema defined' do
+      let(:relation) do
+        instance_double(ROM::Relation, schema?: false)
+      end
+
+      it 'sets default input handler when command does not have a custom one' do
+        command = Class.new(command_class).build(relation)
+
+        expect(command.input).to be(ROM::Command.input)
+      end
+
+      it 'sets custom input handler when command defines it' do
+        my_handler = double(:my_handler)
+
+        command = Class.new(command_class) { input my_handler }.build(relation)
+
+        expect(command.input).to be(my_handler)
+      end
+
+      it 'sets custom input handler when it is passed as an option' do
+        my_handler = double(:my_handler)
+
+        command = Class.new(command_class).build(relation, input: my_handler)
+
+        expect(command.input).to be(my_handler)
+      end
+    end
+
+    context 'when relation has a schema' do
+      let(:relation) do
+        instance_double(ROM::Relation, schema?: true, schema_hash: schema_hash)
+      end
+
+      let(:schema_hash) do
+        double(:schema_hash)
+      end
+
+      it 'sets schema hash as input handler' do
+        command = Class.new(command_class).build(relation)
+
+        expect(command.input).to be(schema_hash)
+      end
+
+      it 'sets a composed input handler with schema hash and a custom one' do
+        my_handler = double(:my_handler)
+
+        command = Class.new(command_class) { input my_handler }.build(relation)
+
+        expect(my_handler).to receive(:[]).with('some value').and_return('my handler')
+        expect(schema_hash).to receive(:[]).with('my handler').and_return('a tuple')
+
+        expect(command.input['some value']).to eql('a tuple')
+      end
+    end
+  end
+end

data/spec/unit/rom/relation/name_spec.rb

@@ -48,4 +48,11 @@ RSpec.describe ROM::Relation::Name do
       expect(ROM::Relation::Name.new(:authors, :users).to_sym).to be(:authors)
     end
   end
+
+  describe '#to_s' do
+    it 'returns stringified relation name' do
+      expect(ROM::Relation::Name.new(:users).to_s).to eql('users')
+      expect(ROM::Relation::Name.new(:authors, :users).to_s).to eql('authors on users')
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rom
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-30 00:00:00.000000000 Z
+date: 2016-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -281,6 +281,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/constant_leak_finder.rb
 - spec/support/mutant.rb
+- spec/support/types.rb
 - spec/test/memory_repository_lint_test.rb
 - spec/unit/rom/association_set_spec.rb
 - spec/unit/rom/commands/graph_spec.rb
@@ -300,6 +301,7 @@ files:
 - spec/unit/rom/memory/repository_spec.rb
 - spec/unit/rom/memory/storage_spec.rb
 - spec/unit/rom/plugin_spec.rb
+- spec/unit/rom/plugins/command/schema_spec.rb
 - spec/unit/rom/plugins/relation/key_inference_spec.rb
 - spec/unit/rom/plugins/relation/view_spec.rb
 - spec/unit/rom/relation/composite_spec.rb