rom 0.5.0 → 0.6.0.beta1

data/spec/unit/rom/support/enumerable_dataset_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+require 'rom/support/enumerable_dataset'
+
+describe ROM::EnumerableDataset do
+  let(:klass) do
+    Class.new do
+      include ROM::EnumerableDataset
+
+      def self.row_proc
+        Transproc(:symbolize_keys)
+      end
+    end
+  end
+
+  it_behaves_like 'an enumerable dataset'
+end

data/spec/unit/rom/support/inflector_spec.rb

@@ -0,0 +1,89 @@
+require 'spec_helper'
+
+describe ROM::Inflector do
+  shared_examples 'an inflector' do
+    it 'singularises' do
+      expect(api.singularize('tasks')).to eq 'task'
+    end
+
+    it 'pluralizes' do
+      expect(api.pluralize('task')).to eq 'tasks'
+    end
+
+    it 'camelizes' do
+      expect(api.camelize('task_user')).to eq 'TaskUser'
+    end
+
+    it 'underscores' do
+      expect(api.underscore('TaskUser')).to eq 'task_user'
+    end
+
+    it 'demodulizes' do
+      expect(api.demodulize('Task::User')).to eq 'User'
+    end
+
+    it 'constantizes' do
+      expect(api.constantize('String')).to equal String
+    end
+
+    it 'classifies' do
+      expect(api.classify('task_user/name')).to eq 'TaskUser::Name'
+    end
+  end
+
+  subject(:api) { ROM::Inflector }
+
+  context 'with detected inflector' do
+    before do
+      if api.instance_variables.include?(:@inflector)
+        api.__send__(:remove_instance_variable, :@inflector)
+      end
+    end
+
+    it 'prefers ActiveSupport::Inflector' do
+      expect(api.inflector == ::ActiveSupport::Inflector).to be true
+    end
+  end
+
+  context 'with automatic detection' do
+    before do
+      if api.instance_variables.include?(:@inflector)
+        api.__send__(:remove_instance_variable, :@inflector)
+      end
+    end
+
+    it 'automatically selects an inflector backend' do
+      expect(api.inflector).not_to be nil
+    end
+  end
+
+  context 'with ActiveSupport::Inflector' do
+    before do
+      api.select_backend(:activesupport)
+    end
+
+    it 'is ActiveSupport::Inflector' do
+      expect(api.inflector).to be(::ActiveSupport::Inflector)
+    end
+
+    it_behaves_like 'an inflector'
+  end
+
+  context 'with Inflecto' do
+    before do
+      api.select_backend(:inflecto)
+    end
+
+    it 'is Inflecto' do
+      expect(api.inflector).to be(::Inflecto)
+    end
+
+    it_behaves_like 'an inflector'
+  end
+
+  context 'an unrecognized inflector library is selected' do
+    it 'raises a NameError' do
+      expect { api.select_backend(:foo) }.to raise_error(NameError)
+    end
+  end
+end

data/spec/unit/rom/support/options_spec.rb

@@ -0,0 +1,119 @@
+require 'spec_helper'
+
+describe ROM::Options do
+  let(:klass) do
+    Class.new do
+      include ROM::Options
+
+      option :name, type: String, reader: true, allow: %w(foo bar)
+      option :repo, reader: true
+      option :other
+    end
+  end
+
+  describe '.new' do
+    it 'works without passing a hash' do
+      expect { klass.new }.not_to raise_error
+    end
+
+    it 'sets options hash' do
+      object = klass.new(name: 'foo')
+      expect(object.options).to eql(name: 'foo')
+    end
+
+    it 'allows any value when :allow is not specified' do
+      repo = double('repo')
+      object = klass.new(repo: repo)
+      expect(object.options).to eql(repo: repo)
+    end
+
+    it 'sets readers for options when specified' do
+      object = klass.new(name: 'bar', repo: 'default')
+      expect(object.name).to eql('bar')
+      expect(object.repo).to eql('default')
+      expect(object).to_not respond_to(:other)
+    end
+
+    it 'checks option key' do
+      expect { klass.new(unexpected: 'foo') }
+        .to raise_error(ROM::InvalidOptionKeyError, /:unexpected/)
+    end
+
+    it 'checks option type' do
+      expect { klass.new(name: :foo) }
+        .to raise_error(ROM::InvalidOptionValueError, /:foo/)
+    end
+
+    it 'checks option value' do
+      expect { klass.new(name: 'invalid') }
+        .to raise_error(ROM::InvalidOptionValueError, /invalid/)
+    end
+
+    it 'copies klass options to descendant' do
+      other = Class.new(klass).new(name: 'foo')
+      expect(other.options).to eql(name: 'foo')
+    end
+
+    it 'does not interfere with its parent`s option definitions' do
+      Class.new(klass) do
+        option :child, default: :nope
+      end
+      object = klass.new
+      expect(object.options).to eql({})
+    end
+
+    it 'sets option defaults statically' do
+      default_value = []
+      klass.option :args, default: default_value
+
+      object = klass.new
+
+      expect(object.options).to eql(args: default_value)
+      expect(object.options[:args]).to equal(default_value)
+    end
+
+    it 'sets option defaults dynamically via proc' do
+      klass.option :args, default: proc { |*a| a }
+
+      object = klass.new
+
+      expect(object.options).to eql(args: [object])
+    end
+
+    it 'allow nil as default value' do
+      klass.option :args, default: nil
+
+      object = klass.new
+
+      expect(object.options).to eql(args: nil)
+    end
+
+    it 'options are frozen' do
+      object = klass.new
+
+      expect { object.options[:foo] = :bar }
+        .to raise_error(RuntimeError, /frozen/)
+    end
+
+    it 'call parent`s `inherited` hook' do
+      m = Module.new do
+        def inherited(_base)
+          raise "hook called"
+        end
+      end
+      klass.extend m
+
+      expect { Class.new(klass).new }
+        .to raise_error(/hook called/)
+    end
+
+    it 'does not modify passed options' do
+      options = {}
+      klass.option :foo, default: :bar
+
+      klass.new(options)
+
+      expect(options).to eq({})
+    end
+  end
+end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: rom
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0.beta1
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-31 00:00:00.000000000 Z
+date: 2015-02-26 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: addressable
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: transproc
   requirement: !ruby/object:Gem::Requirement
@@ -58,66 +44,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.9
-- !ruby/object:Gem::Dependency
-  name: concord
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.1.4
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.1.4
-- !ruby/object:Gem::Dependency
-  name: charlatan
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.1'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.1'
-- !ruby/object:Gem::Dependency
-  name: inflecto
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.0.2
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.0.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -138,42 +64,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rspec-mocks
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rspec-expectations
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
 description: Persistence and mapping toolkit for Ruby
 email: piotr.solnica@gmail.com
 executables: []
@@ -183,6 +109,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
@@ -192,52 +119,71 @@ files:
 - README.md
 - Rakefile
 - lib/rom.rb
-- lib/rom/adapter.rb
-- lib/rom/adapter/memory.rb
-- lib/rom/adapter/memory/commands.rb
-- lib/rom/adapter/memory/dataset.rb
-- lib/rom/adapter/memory/storage.rb
+- lib/rom/command.rb
 - lib/rom/command_registry.rb
 - lib/rom/commands.rb
+- lib/rom/commands/abstract.rb
+- lib/rom/commands/composite.rb
 - lib/rom/commands/create.rb
 - lib/rom/commands/delete.rb
 - lib/rom/commands/result.rb
 - lib/rom/commands/update.rb
-- lib/rom/commands/with_options.rb
-- lib/rom/config.rb
+- lib/rom/constants.rb
 - lib/rom/env.rb
 - lib/rom/global.rb
 - lib/rom/header.rb
 - lib/rom/header/attribute.rb
+- lib/rom/lint/enumerable_dataset.rb
+- lib/rom/lint/linter.rb
+- lib/rom/lint/repository.rb
+- lib/rom/lint/spec.rb
+- lib/rom/lint/test.rb
 - lib/rom/mapper.rb
-- lib/rom/mapper_builder.rb
-- lib/rom/mapper_builder/mapper_dsl.rb
-- lib/rom/mapper_builder/model_dsl.rb
+- lib/rom/mapper/attribute_dsl.rb
+- lib/rom/mapper/dsl.rb
+- lib/rom/mapper/model_dsl.rb
 - lib/rom/mapper_registry.rb
+- lib/rom/memory.rb
+- lib/rom/memory/commands.rb
+- lib/rom/memory/dataset.rb
+- lib/rom/memory/relation.rb
+- lib/rom/memory/repository.rb
+- lib/rom/memory/storage.rb
 - lib/rom/model_builder.rb
 - lib/rom/processor.rb
 - lib/rom/processor/transproc.rb
 - lib/rom/reader.rb
-- lib/rom/reader_builder.rb
 - lib/rom/relation.rb
-- lib/rom/relation_builder.rb
+- lib/rom/relation/composite.rb
+- lib/rom/relation/curried.rb
+- lib/rom/relation/lazy.rb
+- lib/rom/relation/loaded.rb
+- lib/rom/relation/registry_reader.rb
 - lib/rom/repository.rb
 - lib/rom/setup.rb
-- lib/rom/setup/base_relation_dsl.rb
-- lib/rom/setup/command_dsl.rb
 - lib/rom/setup/finalize.rb
-- lib/rom/setup/mapper_dsl.rb
-- lib/rom/setup/relation_dsl.rb
-- lib/rom/setup/schema_dsl.rb
+- lib/rom/setup_dsl/command.rb
+- lib/rom/setup_dsl/command_dsl.rb
+- lib/rom/setup_dsl/mapper.rb
+- lib/rom/setup_dsl/mapper_dsl.rb
+- lib/rom/setup_dsl/relation.rb
+- lib/rom/setup_dsl/setup.rb
+- lib/rom/support/array_dataset.rb
+- lib/rom/support/class_builder.rb
+- lib/rom/support/class_macros.rb
+- lib/rom/support/data_proxy.rb
+- lib/rom/support/enumerable_dataset.rb
+- lib/rom/support/inflector.rb
+- lib/rom/support/options.rb
 - lib/rom/support/registry.rb
 - lib/rom/version.rb
+- rakelib/benchmark.rake
+- rakelib/mutant.rake
+- rakelib/rubocop.rake
 - rom.gemspec
-- spec/integration/adapters/extending_relations_spec.rb
-- spec/integration/adapters/setting_logger_spec.rb
 - spec/integration/commands/create_spec.rb
 - spec/integration/commands/delete_spec.rb
 - spec/integration/commands/error_handling_spec.rb
-- spec/integration/commands/try_spec.rb
 - spec/integration/commands/update_spec.rb
 - spec/integration/mappers/deep_embedded_spec.rb
 - spec/integration/mappers/definition_dsl_spec.rb
@@ -250,27 +196,43 @@ files:
 - spec/integration/multi_repo_spec.rb
 - spec/integration/relations/reading_spec.rb
 - spec/integration/relations/registry_dsl_spec.rb
-- spec/integration/schema_spec.rb
+- spec/integration/repositories/extending_relations_spec.rb
+- spec/integration/repositories/setting_logger_spec.rb
 - spec/integration/setup_spec.rb
+- spec/shared/enumerable_dataset.rb
+- spec/shared/one_behavior.rb
 - spec/shared/users_and_tasks.rb
 - spec/spec_helper.rb
+- spec/support/constant_leak_finder.rb
 - spec/support/mutant.rb
-- spec/unit/config_spec.rb
-- spec/unit/rom/adapter/memory/dataset_spec.rb
-- spec/unit/rom/adapter_spec.rb
+- spec/test/memory_repository_lint_test.rb
+- spec/unit/rom/command_registry_spec.rb
+- spec/unit/rom/commands/result_spec.rb
+- spec/unit/rom/commands_spec.rb
 - spec/unit/rom/env_spec.rb
+- spec/unit/rom/global_spec.rb
 - spec/unit/rom/header_spec.rb
-- spec/unit/rom/mapper_builder_spec.rb
+- spec/unit/rom/mapper/dsl_spec.rb
 - spec/unit/rom/mapper_registry_spec.rb
 - spec/unit/rom/mapper_spec.rb
+- spec/unit/rom/memory/dataset_spec.rb
+- spec/unit/rom/memory/repository_spec.rb
+- spec/unit/rom/memory/storage_spec.rb
 - spec/unit/rom/model_builder_spec.rb
 - spec/unit/rom/processor/transproc_spec.rb
 - spec/unit/rom/reader_spec.rb
 - spec/unit/rom/registry_spec.rb
+- spec/unit/rom/relation/composite_spec.rb
+- spec/unit/rom/relation/lazy_spec.rb
+- spec/unit/rom/relation/loaded_spec.rb
 - spec/unit/rom/relation_spec.rb
 - spec/unit/rom/repository_spec.rb
 - spec/unit/rom/setup_spec.rb
-- spec/unit/rom_spec.rb
+- spec/unit/rom/support/array_dataset_spec.rb
+- spec/unit/rom/support/class_builder_spec.rb
+- spec/unit/rom/support/enumerable_dataset_spec.rb
+- spec/unit/rom/support/inflector_spec.rb
+- spec/unit/rom/support/options_spec.rb
 homepage: http://rom-rb.org
 licenses:
 - MIT
@@ -281,14 +243,14 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2