rom-sql 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 691692ffdf54a81e4df7c4925a73936c9e426ef6
-  data.tar.gz: 3120b4cfbb32e6a7b6a5b972ac2187637fa797b7
+  metadata.gz: 65667c45aace8c6a4ca6998f10bc23cca6acb6e0
+  data.tar.gz: c63cf22daea5c103abca9c75b46df203228a5f2e
 SHA512:
-  metadata.gz: 860aba9311e5cdce1cce77c5ee20aa377e65e6bf453c2bd51d8790b7c57303f3b1219637ad3c3276c0bc2b779fff5c4e94cdc4c89061dfed74fcf9a7af52ee05
-  data.tar.gz: 859c52e928ecddd75bc6354c7ed32453e579a1d266cda597ba3a202fd1d6624828f6bd777ecd1a031f6068600ba4927c74c5b5f2529f11e7d64ec444173fe579
+  metadata.gz: eeb635de13c7519b535a73fccfbd0213af82ed8381a3709b082e1b50f976215b20588611899916feea315053f3b60bae7b51300dc99b2fcc2c3fe3bf602785f3
+  data.tar.gz: 6ffb7da871553147a54a7976e008d70ee927189cd06b0f5f0f3130dec0ae3fcb6c2e8011893792fb60adaa48c41019c2fe8e82c6d832b8b2ecabf8a83e4f2c9e

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## v0.4.1 2015-04-04
+
+### Added
+
+* Database error handling for update and delete commands (kwando + solnic)
+* Migration interface as a repository plugin (gotar + solnic)
+
+[Compare v0.4.0...v0.4.1](https://github.com/rom-rb/rom-sql/compare/v0.4.0...v0.4.1)
+
 ## v0.4.0 2015-03-22
 
 ### Added

data/Gemfile

@@ -3,6 +3,7 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
+  gem 'byebug', platforms: :mri
   gem 'rom', '~> 0.6.0.beta', github: 'rom-rb/rom', branch: 'master'
   gem 'virtus'
   gem 'activesupport'

data/README.md

@@ -64,8 +64,6 @@ end
 ``` ruby
 
 class Users < ROM::Relation[:sql]
-  base_name :users
-
   def by_name(name)
     where(name: name)
   end
@@ -79,7 +77,7 @@ tasks = rom.relations.tasks
 users.insert(id: 1, name: "Piotr")
 tasks.insert(user_id: 1, title: "Be happy")
 
-puts users.by_name("Piotr").with_tasks.to_a.inspect
+puts rom.relation(:users).by_name("Piotr").with_tasks.to_a.inspect
 # => [{:id=>1, :name=>"Piotr", :user_id=>1, :title=>"Be happy"}]
 ```
 
@@ -114,6 +112,7 @@ end
 
 class UserMapper < ROM::Mapper
   relation :users
+  register_as :model
 
   model name: 'User'
 
@@ -128,7 +127,7 @@ tasks = rom.relations.tasks
 users.insert(id: 1, name: "Piotr")
 tasks.insert(user_id: 1, title: "Be happy")
 
-rom.read(:users).with_tasks.by_name("Piotr").to_a
+rom.relation(:users).as(:model).with_tasks.by_name("Piotr").to_a
 # => [#<User:0x007fb31542a098 @id=1, @name="Piotr", @tasks=[{:title=>"Be happy"}]>]
 ```
 

data/lib/rom/sql.rb

@@ -4,6 +4,15 @@ require "rom"
 module ROM
   module SQL
     ConstraintError = Class.new(ROM::CommandError)
+
+    class DatabaseError < ROM::CommandError
+      attr_reader :original_exception
+
+      def initialize(error, message)
+        super(message)
+        @original_exception = error
+      end
+    end
   end
 end
 

data/lib/rom/sql/commands/create.rb

@@ -1,4 +1,5 @@
 require 'rom/sql/commands'
+require 'rom/sql/commands/error_wrapper'
 require 'rom/sql/commands/transaction'
 
 module ROM
@@ -6,6 +7,7 @@ module ROM
     module Commands
       class Create < ROM::Commands::Create
         include Transaction
+        include ErrorWrapper
 
         def execute(tuples)
           insert_tuples = Array([tuples]).flatten.map do |tuple|
@@ -15,8 +17,6 @@ module ROM
           end
 
           insert(insert_tuples)
-        rescue *ERRORS => e
-          raise ConstraintError, e.message
         end
 
         def insert(tuples)

data/lib/rom/sql/commands/delete.rb

@@ -1,4 +1,5 @@
 require 'rom/sql/commands'
+require 'rom/sql/commands/error_wrapper'
 require 'rom/sql/commands/transaction'
 
 module ROM
@@ -6,6 +7,7 @@ module ROM
     module Commands
       class Delete < ROM::Commands::Delete
         include Transaction
+        include ErrorWrapper
 
         def execute
           deleted = target.to_a

data/lib/rom/sql/commands/error_wrapper.rb

@@ -0,0 +1,15 @@
+module ROM
+  module SQL
+    module Commands
+      module ErrorWrapper
+        def call(*args)
+          super
+        rescue *ERRORS => e
+          raise ConstraintError, e.message
+        rescue Sequel::DatabaseError => e
+          raise DatabaseError.new(e, e.message)
+        end
+      end
+    end
+  end
+end

data/lib/rom/sql/commands/update.rb

@@ -1,4 +1,5 @@
 require 'rom/sql/commands'
+require 'rom/sql/commands/error_wrapper'
 require 'rom/sql/commands/transaction'
 
 module ROM
@@ -6,10 +7,12 @@ module ROM
     module Commands
       class Update < ROM::Commands::Update
         include Transaction
+        include ErrorWrapper
 
         option :original, type: Hash, reader: true
 
         alias_method :to, :call
+        alias_method :set, :call
 
         def execute(tuple)
           attributes = input[tuple]

data/lib/rom/sql/migration.rb

@@ -1,23 +1,86 @@
+require 'rom/sql/migration/migrator'
+
 module ROM
   module SQL
-    class Migration
-      ::Sequel.extension :migration
+    # Create a database migration for a specific repository
+    #
+    # @example
+    #   ROM.setup(
+    #     default: [:sql, 'sqlite::memory'],
+    #     other: [:sql, 'postgres://localhost/test']
+    #   )
+    #
+    #   ROM.finalize
+    #
+    #   ROM::SQL.migration do
+    #     change do
+    #       create_table(:users) do
+    #         primary_key :id
+    #         String :name
+    #       end
+    #     end
+    #   end
+    #
+    #   # for a non-default repository
+    #   ROM::SQL.migration(:other) do
+    #     # ...
+    #   end
+    #
+    # @api public
+    def self.migration(repository = :default, &block)
+      ROM.env.repositories[repository].migration(&block)
+    end
+
+    module Migration
+      Sequel.extension :migration
 
-      DEFAULT_PATH = 'db/migrate'
+      def self.included(klass)
+        super
+        klass.class_eval do
+          option :migrator, reader: true, default: proc { |repository|
+            Migrator.new(repository.connection)
+          }
+        end
+      end
+
+      # @see ROM::SQL.migration
+      #
+      # @api public
+      def migration(&block)
+        migrator.migration(&block)
+      end
+
+      # Run migrations for a given repository
+      #
+      # @example
+      #   ROM.setup(:sql, ['sqlite::memory'])
+      #   ROM.finalize
+      #   ROM.env.repositories[:default].run_migrations
+      #
+      #
+      # @param [Hash] options The options used by Sequel migrator
+      #
+      # @api public
+      def run_migrations(options = {})
+        migrator.run(options)
+      end
 
+      # TODO: this should be removed in favor of migration API in Repository
       class << self
         attr_writer :path
         attr_accessor :connection
 
         def path
-          @path || DEFAULT_PATH
+          @path || Migrator::DEFAULT_PATH
         end
 
         def run(options = {})
+          warn "ROM::SQL::Migration.run is deprecated please ROM::SQL::Repository#run_migrations (#{caller[0]})"
           ::Sequel::Migrator.run(connection, path, options)
         end
 
         def create(&block)
+          warn "ROM::SQL::Migration.create is deprecated please use ROM::SQL.migration (#{caller[0]})"
           ::Sequel.migration(&block)
         end
       end

data/lib/rom/sql/migration/migrator.rb

@@ -0,0 +1,48 @@
+module ROM
+  module SQL
+    module Migration
+      class Migrator
+        include Options
+
+        DEFAULT_PATH = 'db/migrate'.freeze
+        VERSION_FORMAT = '%Y%m%d%H%M%S'.freeze
+
+        option :path, reader: true, default: DEFAULT_PATH
+
+        attr_reader :connection
+
+        def initialize(connection, options = {})
+          super
+          @connection = connection
+        end
+
+        def run(options = {})
+          Sequel::Migrator.run(connection, path.to_s, options)
+        end
+
+        def migration(&block)
+          Sequel.migration(&block)
+        end
+
+        def create_file(name, version = generate_version)
+          filename = "#{version}_#{name}.rb"
+          dirname = Pathname(path)
+          fullpath = dirname.join(filename)
+
+          FileUtils.mkdir_p(dirname)
+          File.write(fullpath, migration_file_content)
+
+          fullpath
+        end
+
+        def generate_version
+          Time.now.utc.strftime(VERSION_FORMAT)
+        end
+
+        def migration_file_content
+          File.read(Pathname(__FILE__).dirname.join('template.rb').realpath)
+        end
+      end
+    end
+  end
+end

data/lib/rom/sql/migration/template.rb

@@ -0,0 +1,4 @@
+ROM::SQL.migration do
+  change do
+  end
+end

data/lib/rom/sql/relation.rb

@@ -80,7 +80,7 @@ module ROM
       # Get last tuple from the relation
       #
       # @example
-      #   users.first
+      #   users.last
       #
       # @return [Relation]
       #

data/lib/rom/sql/repository.rb

@@ -1,11 +1,15 @@
 require 'logger'
 
 require 'rom/repository'
+require 'rom/sql/migration'
 require 'rom/sql/commands'
 
 module ROM
   module SQL
     class Repository < ROM::Repository
+      include Options
+      include Migration
+
       # Return optionally configured logger
       #
       # @return [Object] logger
@@ -49,8 +53,13 @@ module ROM
       #
       # @api public
       def initialize(uri, options = {})
-        @connection = connect(uri, options)
+        repo_options = self.class.option_definitions.names
+        conn_options = options.reject { |k,_| repo_options.include?(k) }
+
+        @connection = connect(uri, conn_options)
         @schema = connection.tables
+
+        super(uri, options.reject { |k,_| conn_options.keys.include?(k) })
       end
 
       # Disconnect from database

data/lib/rom/sql/tasks/migration_tasks.rake

@@ -3,32 +3,38 @@ require "fileutils"
 
 namespace :db do
   desc "Perform migration reset (full erase and migration up)"
-  task reset: :load_setup do
-    ROM::SQL::Migration.run(target: 0)
-    ROM::SQL::Migration.run
+  task reset: :setup do
+    repository = ROM.env.repositories[:default]
+    repository.run_migrations(target: 0)
+    repository.run_migrations
     puts "<= db:reset executed"
   end
 
   desc "Migrate the database (options [version_number])]"
-  task :migrate, [:version] => :load_setup do |_, args|
+  task :migrate, [:version] => :setup do |_, args|
+    repository = ROM.env.repositories[:default]
     version = args[:version]
+
     if version.nil?
-      ROM::SQL::Migration.run
+      repository.run_migrations
       puts "<= db:migrate executed"
     else
-      ROM::SQL::Migration.run(target: version.to_i)
+      repository.run_migrations(target: version.to_i)
       puts "<= db:migrate version=[#{version}] executed"
     end
   end
 
   desc "Perform migration down (erase all data)"
-  task clean: :load_setup do
-    ROM::SQL::Migration.run(target: 0)
+  task clean: :setup do
+    repository = ROM.env.repositories[:default]
+
+    repository.run_migrations(target: 0)
     puts "<= db:clean executed"
   end
 
   desc "Create a migration (parameters: NAME, VERSION)"
-  task :create_migration, [:name, :version] => :load_setup do |_, args|
+  task :create_migration, [:name, :version] => :setup do |_, args|
+    repository = ROM.env.repositories[:default]
     name, version = args[:name], args[:version]
 
     if name.nil?
@@ -37,20 +43,8 @@ namespace :db do
       exit
     end
 
-    version ||= Time.now.utc.strftime("%Y%m%d%H%M%S")
-
-    filename = "#{version}_#{name}.rb"
-    dirname  = ROM::SQL::Migration.path
-    path     = File.join(dirname, filename)
-
-    FileUtils.mkdir_p(dirname)
-    File.write path, <<-MIGRATION
-ROM::SQL::Migration.create do
-  change do
-  end
-end
-    MIGRATION
+    path = repository.migrator.create_file(*[name, version].compact)
 
-    puts path
+    puts "<= migration file created #{path}"
   end
 end

data/lib/rom/sql/version.rb

@@ -1,5 +1,5 @@
 module ROM
   module SQL
-    VERSION = '0.4.0'.freeze
+    VERSION = '0.4.1'.freeze
   end
 end

data/spec/fixtures/migrations/20150403090603_create_carrots.rb

@@ -0,0 +1,8 @@
+ROM.env.repositories[:default].migration do
+  change do
+    create_table :carrots do
+      primary_key :id
+      String :name
+    end
+  end
+end

data/spec/integration/commands/create_spec.rb

@@ -106,4 +106,13 @@ describe 'Commands / Create' do
     expect(result.error).to be_instance_of(ROM::SQL::ConstraintError)
     expect(result.error.message).to match(/unique/)
   end
+
+  it 'handles database errors' do
+    Params.attribute :bogus_field
+
+    result = users.try { users.create.call(name: 'some name', bogus_field: 23) }
+
+    expect(result.error).to be_instance_of(ROM::SQL::DatabaseError)
+    expect(result.error.original_exception).to be_instance_of(Sequel::DatabaseError)
+  end
 end

data/spec/integration/commands/delete_spec.rb

@@ -52,4 +52,16 @@ describe 'Commands / Delete' do
 
     expect(result.value).to eql(id: 2, name: 'Jane')
   end
+
+  it 'handles database errors' do
+    command = users.delete.by_name('Jane')
+
+    expect(command.relation).to receive(:delete).and_raise(Sequel::DatabaseError)
+
+    result = users.try { command.call }
+
+    expect(result.value).to be(nil)
+    expect(result.error).to be_a(ROM::SQL::DatabaseError)
+    expect(result.error.original_exception).to be_a(Sequel::DatabaseError)
+  end
 end

data/spec/integration/commands/update_spec.rb

@@ -74,4 +74,14 @@ describe 'Commands / Update' do
 
     expect(result.value.to_a).to be_empty
   end
+
+  it 'handles database errors' do
+    result = users.try do
+      users.update.by_id(piotr[:id]).set(bogus_field: '#trollface')
+    end
+
+    expect(result.value).to be(nil)
+    expect(result.error).to be_a(ROM::SQL::DatabaseError)
+    expect(result.error.original_exception).to be_a(Sequel::DatabaseError)
+  end
 end

data/spec/integration/repository_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe ROM::SQL::Repository do
+  describe 'migration' do
+    let(:conn) { Sequel.connect(DB_URI) }
+
+    context 'creating migrations inline' do
+      subject(:repository) { ROM.env.repositories[:default] }
+
+      before do
+        ROM.setup(:sql, conn)
+        ROM.finalize
+      end
+
+      after do
+        [:rabbits, :carrots].each do |name|
+          repository.connection.drop_table?(name)
+        end
+      end
+
+      it 'allows creating and running migrations' do
+        migration = ROM::SQL.migration do
+          up do
+            create_table(:rabbits) do
+              primary_key :id
+              String :name
+            end
+          end
+
+          down do
+            drop_table(:rabbits)
+          end
+        end
+
+        migration.apply(repository.connection, :up)
+
+        expect(repository.connection[:rabbits]).to be_a(Sequel::Dataset)
+
+        migration.apply(repository.connection, :down)
+
+        expect(repository.connection.tables).to_not include(:rabbits)
+      end
+    end
+
+    context 'running migrations from a file system' do
+      let(:migration_dir) do
+        Pathname(__FILE__).dirname.join('../fixtures/migrations').realpath
+      end
+
+      let(:migrator) { ROM::SQL::Migration::Migrator.new(conn, path: migration_dir) }
+
+      before do
+        ROM.setup(:sql, [conn, migrator: migrator])
+        ROM.finalize
+      end
+
+      it 'runs migrations from a specified directory' do
+        ROM.env.repositories[:default].run_migrations
+      end
+    end
+  end
+end

data/spec/shared/database_setup.rb

@@ -1,12 +1,14 @@
 shared_context 'database setup' do
   subject(:rom) { setup.finalize }
 
-  let(:uri) { 'postgres://localhost/rom' }
+  let(:uri) { DB_URI }
   let(:conn) { Sequel.connect(uri) }
   let(:setup) { ROM.setup(:sql, conn) }
 
   def drop_tables
-    [:users, :tasks, :tags, :task_tags].each { |name| conn.drop_table?(name) }
+    [:users, :tasks, :tags, :task_tags, :rabbits, :carrots, :schema_migrations].each do |name|
+      conn.drop_table?(name)
+    end
   end
 
   before do

data/spec/spec_helper.rb

@@ -13,14 +13,26 @@ require 'rom/sql/rake_task'
 # FIXME: why do we need to require it manually??
 require 'sequel/adapters/postgres'
 require 'logger'
+begin
+  require 'byebug'
+rescue LoadError
+end
 
 LOGGER = Logger.new(File.open('./log/test.log', 'a'))
+DB_URI = 'postgres://localhost/rom'
 
 root = Pathname(__FILE__).dirname
+TMP_PATH = root.join('../tmp')
 
 Dir[root.join('shared/*.rb').to_s].each { |f| require f }
 
 RSpec.configure do |config|
+  config.before(:suite) do
+    tmp_test_dir = TMP_PATH.join('test')
+    FileUtils.rm_r(tmp_test_dir) if File.exist?(tmp_test_dir)
+    FileUtils.mkdir_p(tmp_test_dir)
+  end
+
   config.before do
     @constants = Object.constants
   end

data/spec/unit/migration_tasks_spec.rb

@@ -1,15 +1,23 @@
 require 'spec_helper'
 
 namespace :db do
-  task :load_setup  do
+  task :setup  do
+    # noop
   end
 end
 
 describe 'MigrationTasks' do
+  before do
+    ROM.setup(:sql, ['postgres://localhost/rom'])
+    ROM.finalize
+  end
+
+  let(:migrator) { ROM.env.repositories[:default].migrator }
+
   context 'db:reset' do
     it 'calls proper commands' do
-      expect(ROM::SQL::Migration).to receive(:run).with(target: 0)
-      expect(ROM::SQL::Migration).to receive(:run)
+      expect(migrator).to receive(:run).with(target: 0)
+      expect(migrator).to receive(:run)
 
       expect {
         Rake::Task["db:reset"].invoke
@@ -20,7 +28,7 @@ describe 'MigrationTasks' do
   context 'db:migrate' do
     context 'with VERSION' do
       it 'calls proper commands' do
-        expect(ROM::SQL::Migration).to receive(:run).with(target: 1)
+        expect(migrator).to receive(:run).with(target: 1)
 
         expect {
           Rake::Task["db:migrate"].invoke(1)
@@ -30,7 +38,7 @@ describe 'MigrationTasks' do
 
     context 'without VERSION' do
       it 'calls proper commands' do
-        expect(ROM::SQL::Migration).to receive(:run)
+        expect(migrator).to receive(:run)
 
         expect {
           Rake::Task["db:migrate"].execute
@@ -41,7 +49,7 @@ describe 'MigrationTasks' do
 
   context 'db:clean' do
     it 'calls proper commands' do
-      expect(ROM::SQL::Migration).to receive(:run).with(target: 0)
+      expect(migrator).to receive(:run).with(target: 0)
 
       expect {
         Rake::Task["db:clean"].invoke
@@ -63,36 +71,28 @@ describe 'MigrationTasks' do
     end
 
     context 'with NAME' do
-      let(:dirname) { 'db/migration' }
+      let(:dirname) { 'tmp/db/migrate' }
       let(:name) { 'foo_bar' }
       let(:version) { '001' }
       let(:filename) { "#{version}_#{name}.rb" }
       let(:path) { File.join(dirname, filename) }
 
-      before do
-        expect(ROM::SQL::Migration).to receive(:path).and_return(dirname)
-      end
-
       it 'calls proper commands with default VERSION' do
-        time = double(utc: double(strftime: '001'))
-        expect(Time).to receive(:now).and_return(time)
-        expect(FileUtils).to receive(:mkdir_p).with(dirname)
-        expect(File).to receive(:write).with(path, /ROM::SQL::Migration/)
+        expect(migrator).to receive(:create_file).with(name).and_return(path)
 
         expect {
           Rake::Task["db:create_migration"].execute(
             Rake::TaskArguments.new([:name], [name]))
-        }.to output(path+"\n").to_stdout
+        }.to output("<= migration file created #{path}\n").to_stdout
       end
 
       it 'calls proper commands with manualy set VERSION' do
-        expect(FileUtils).to receive(:mkdir_p).with(dirname)
-        expect(File).to receive(:write).with(path, /ROM::SQL::Migration/)
+        expect(migrator).to receive(:create_file).with(name, version).and_return(path)
 
         expect {
           Rake::Task["db:create_migration"].execute(
             Rake::TaskArguments.new([:name, :version], [name, version]))
-        }.to output(path+"\n").to_stdout
+        }.to output("<= migration file created #{path}\n").to_stdout
       end
     end
   end

data/spec/unit/migrator_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe ROM::SQL::Migration::Migrator do
+  subject(:migrator) { ROM::SQL::Migration::Migrator.new(conn, options) }
+
+  let(:conn) { Sequel.connect(DB_URI) }
+  let(:options) { { path: TMP_PATH.join('test/migrations') } }
+
+  describe '#create_file' do
+    it 'creates a migration file under configured path with specified version and name' do
+      file_path = migrator.create_file('create_users', 1)
+
+      expect(file_path).to eql(migrator.path.join('1_create_users.rb'))
+      expect(File.exist?(file_path)).to be(true)
+      expect(File.read(file_path)).to eql(migrator.migration_file_content)
+    end
+
+    it 'auto-generates version when it is not provided' do
+      file_path = migrator.create_file('create_users')
+
+      expect(file_path.to_s).to match(/.(\d+)_create_users\.rb/)
+      expect(File.exist?(file_path)).to be(true)
+      expect(File.read(file_path)).to eql(migrator.migration_file_content)
+    end
+  end
+end

data/spec/unit/repository_spec.rb

@@ -23,6 +23,20 @@ describe ROM::SQL::Repository do
     end
   end
 
+  describe 'using options' do
+    it 'allows custom sequel-specific options' do
+      migrator = double('migrator')
+
+      expect(Sequel).to receive(:connect)
+        .with(DB_URI, host: '127.0.0.1')
+        .and_return(conn)
+
+      repository = ROM::SQL::Repository.new(DB_URI, migrator: migrator, host: '127.0.0.1')
+
+      expect(repository.options).to eql(migrator: migrator)
+    end
+  end
+
   describe '#disconnect' do
     let(:repository) { ROM::SQL::Repository.new(uri) }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rom-sql
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-22 00:00:00.000000000 Z
+date: 2015-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sequel
@@ -109,11 +109,14 @@ files:
 - lib/rom/sql/commands.rb
 - lib/rom/sql/commands/create.rb
 - lib/rom/sql/commands/delete.rb
+- lib/rom/sql/commands/error_wrapper.rb
 - lib/rom/sql/commands/transaction.rb
 - lib/rom/sql/commands/update.rb
 - lib/rom/sql/commands_ext/postgres.rb
 - lib/rom/sql/header.rb
 - lib/rom/sql/migration.rb
+- lib/rom/sql/migration/migrator.rb
+- lib/rom/sql/migration/template.rb
 - lib/rom/sql/plugin/pagination.rb
 - lib/rom/sql/rake_task.rb
 - lib/rom/sql/relation.rb
@@ -128,10 +131,12 @@ files:
 - lib/rom/sql/version.rb
 - log/.gitkeep
 - rom-sql.gemspec
+- spec/fixtures/migrations/20150403090603_create_carrots.rb
 - spec/integration/commands/create_spec.rb
 - spec/integration/commands/delete_spec.rb
 - spec/integration/commands/update_spec.rb
 - spec/integration/read_spec.rb
+- spec/integration/repository_spec.rb
 - spec/shared/database_setup.rb
 - spec/shared/users_and_tasks.rb
 - spec/spec_helper.rb
@@ -141,8 +146,8 @@ files:
 - spec/unit/logger_spec.rb
 - spec/unit/many_to_many_spec.rb
 - spec/unit/many_to_one_spec.rb
-- spec/unit/migration_spec.rb
 - spec/unit/migration_tasks_spec.rb
+- spec/unit/migrator_spec.rb
 - spec/unit/one_to_many_spec.rb
 - spec/unit/plugin/pagination_spec.rb
 - spec/unit/relation_spec.rb
@@ -173,10 +178,12 @@ signing_key:
 specification_version: 4
 summary: SQL databases support for ROM
 test_files:
+- spec/fixtures/migrations/20150403090603_create_carrots.rb
 - spec/integration/commands/create_spec.rb
 - spec/integration/commands/delete_spec.rb
 - spec/integration/commands/update_spec.rb
 - spec/integration/read_spec.rb
+- spec/integration/repository_spec.rb
 - spec/shared/database_setup.rb
 - spec/shared/users_and_tasks.rb
 - spec/spec_helper.rb
@@ -186,10 +193,11 @@ test_files:
 - spec/unit/logger_spec.rb
 - spec/unit/many_to_many_spec.rb
 - spec/unit/many_to_one_spec.rb
-- spec/unit/migration_spec.rb
 - spec/unit/migration_tasks_spec.rb
+- spec/unit/migrator_spec.rb
 - spec/unit/one_to_many_spec.rb
 - spec/unit/plugin/pagination_spec.rb
 - spec/unit/relation_spec.rb
 - spec/unit/repository_spec.rb
 - spec/unit/schema_spec.rb
+has_rdoc: 

data/spec/unit/migration_spec.rb

@@ -1,34 +0,0 @@
-require 'spec_helper'
-
-describe ROM::SQL::Migration do
-  let(:migration) { ROM::SQL::Migration }
-
-  context '#run' do
-    it 'calls Sequel migration code' do
-      migration.path = 'foo/bar'
-      migration.connection = double
-      opts = { foo: 'bar' }
-
-      expect(Sequel::Migrator).to receive(:run)
-        .with(migration.connection, migration.path, opts)
-
-      migration.run(opts)
-    end
-  end
-
-  context '#path' do
-    it 'returns default path if non provided' do
-      migration.path = nil
-
-      expect(migration.path).to eq ROM::SQL::Migration::DEFAULT_PATH
-    end
-  end
-
-  context '.create' do
-    it 'calls Sequel migration block' do
-      expect(Sequel).to receive(:migration)
-
-      ROM::SQL::Migration.create {}
-    end
-  end
-end