rom-repository 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 14c56e0b7faccfcb4ed7d1b7b8506e3f5adc6384
-  data.tar.gz: 2c9e669ae2e2e863a033c9bc9169589d98200d87
+  metadata.gz: 1d1abbcf0ab779840aaf19b899c6e5b725c8621e
+  data.tar.gz: b4cfd46194e94c7509c920c21f54e4d317ace881
 SHA512:
-  metadata.gz: ac27d7fd92fe6385817f18063573da18f98f710d391d2dcf369cfc0fd07b4540582d6190aadd2d7cfd39b89a073541c7aa2defcb2d5c03e896238a405c6f8d27
-  data.tar.gz: 6e6af0a5a553888023c7d1164ab9e864572a9c3ac659f76b9220e484e8e9db06dae704c7fda3e244c8cef87fe050722891307fcc6379f26fecd0ac1936b2c105
+  metadata.gz: d96d070cf7eaf2729c8ebd1b78ed8cc9aebfc128d01c81211eca941fd53ad3f84d6be86ab2ba62e6ef9d1cbf97d4c1eaf299906bb7f0aac26842c070ac9f8c69
+  data.tar.gz: b82756a5892e7d62c5ce822372f51bd2b8af2e76d28b0e8dde4b01a9e798460bafac9b23ce511fbe761350c598b240024a0f6203e4946f784cb595d0df917c0d

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+# v1.2.0 2017-03-01
+
+### Fixed
+
+* Support for `#read` in rom-sql was restored via mapping to `ROM::OpenStruct` (solnic)
+* Using `#nodes` no longer executes redundant query with deeply nested aggregates (solnic)
+
+### Changed
+
+* Depends on rom >= 3.0.4 now as it provides `Relation::Graph#with_nodes` which is needed here (solnic)
+
+[Compare v1.1.0...v1.2.0](https://github.com/rom-rb/rom-repository/compare/v1.1.0...v1.2.0)
+
 # v1.1.0 2017-02-16
 
 ### Added

data/Gemfile

@@ -11,6 +11,7 @@ group :development do
 end
 
 group :test do
+  gem 'rom', git: 'https://github.com/rom-rb/rom.git', branch: 'master'
   gem 'rom-sql', git: 'https://github.com/rom-rb/rom-sql.git', branch: 'master'
   gem 'rspec'
   gem 'dry-struct'

data/lib/rom/open_struct.rb

@@ -0,0 +1,35 @@
+module ROM
+  # ROM's open structs are used for relations with empty schemas.
+  # Such relations may exist in cases like using raw SQL strings
+  # where schema was not explicitly defined using `view` DSL.
+  #
+  # @api public
+  class OpenStruct
+    IVAR = -> v { :"@#{v}" }
+
+    # @api private
+    def initialize(attributes)
+      attributes.each do |key, value|
+        instance_variable_set(IVAR[key], value)
+      end
+    end
+
+    # @api private
+    def respond_to_missing?(meth, include_private = false)
+      super || instance_variables.include?(IVAR[meth])
+    end
+
+    private
+
+    # @api private
+    def method_missing(meth, *args, &block)
+      ivar = IVAR[meth]
+
+      if instance_variables.include?(ivar)
+        instance_variable_get(ivar)
+      else
+        super
+      end
+    end
+  end
+end

data/lib/rom/repository/relation_proxy.rb

@@ -215,17 +215,6 @@ module ROM
           end
       end
 
-      # TODO: add a proper interface to `Relation::Graph` and `Relation::Curried` to rom core
-      #
-      # @api private
-      def with_nodes(nodes)
-        if relation.curried?
-          __new__(relation.send(:__new__, relation.relation.class.new(relation.root, nodes)))
-        else
-          __new__(relation.class.new(relation.root, nodes))
-        end
-      end
-
       # @api private
       def respond_to_missing?(meth, _include_private = false)
         relation.respond_to?(meth) || super

data/lib/rom/repository/struct_builder.rb

@@ -3,6 +3,7 @@ require 'dry/core/cache'
 require 'dry/core/class_builder'
 
 require 'rom/struct'
+require 'rom/open_struct'
 require 'rom/schema/attribute'
 
 module ROM
@@ -16,9 +17,13 @@ module ROM
           name, header = args
           attributes = visit(header).compact
 
-          build_class(name, ROM::Struct) do |klass|
-            attributes.each do |(name, type)|
-              klass.attribute(name, type)
+          if attributes.empty?
+            ROM::OpenStruct
+          else
+            build_class(name, ROM::Struct) do |klass|
+              attributes.each do |(name, type)|
+                klass.attribute(name, type)
+              end
             end
           end
         end

data/lib/rom/repository/version.rb

@@ -1,5 +1,5 @@
 module ROM
   class Repository
-    VERSION = '1.1.0'.freeze
+    VERSION = '1.2.0'.freeze
   end
 end

data/rom-repository.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = `git ls-files -- {spec}/*`.split("\n")
   gem.license       = 'MIT'
 
-  gem.add_runtime_dependency 'rom', '~> 3.0'
+  gem.add_runtime_dependency 'rom', '~> 3.1'
   gem.add_runtime_dependency 'rom-mapper', '~> 0.5'
   gem.add_runtime_dependency 'dry-core', '~> 0.2', '>= 0.2.1'
   gem.add_runtime_dependency 'dry-struct', '~> 0.1'

data/spec/integration/repository_spec.rb

@@ -336,4 +336,10 @@ RSpec.describe 'ROM repository' do
       expect(jane.post.body).to eql('Jane Post')
     end
   end
+
+  it 'loads structs using plain SQL' do
+    jane = repo.users.read("SELECT name FROM users WHERE name = 'Jane'").one
+
+    expect(jane.name).to eql('Jane')
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rom-repository
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-16 00:00:00.000000000 Z
+date: 2017-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rom
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rom-mapper
   requirement: !ruby/object:Gem::Requirement
@@ -117,6 +117,7 @@ files:
 - README.md
 - Rakefile
 - lib/rom-repository.rb
+- lib/rom/open_struct.rb
 - lib/rom/repository.rb
 - lib/rom/repository/changeset.rb
 - lib/rom/repository/changeset/associated.rb