rom-repository 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e6b048642fe2a94616f34fd16f97f14c66ef9d09
-  data.tar.gz: f5d68af52ed2f23e95f0b374c6dd8ec6c0fba51a
+  metadata.gz: 3d225169d8e6601c42a19f9e8504363fb766b49b
+  data.tar.gz: 2277ca38edb2706b648fabbd30da68cbbb9adb3c
 SHA512:
-  metadata.gz: 54fdd9a7b04880a7e3d3b9cdcaaf4794921bbfc9fe1fe95a6807b18e9c5d025cc295c86f8f4afb7f43a25939ef04bb665dfeeef84c768eb6b2d4037619b826d5
-  data.tar.gz: d4d7fe97225798174a5d7feee644f76188f321066501d2c8b4683dcc15d37b8fad1c1aa6fd0dd186962a3094a4ee9d486c29788d0047ffe830b8b7cc1e6dc2e1
+  metadata.gz: fb36f1ef4cd751ddb8de93a54018b6c057db268c00f66131a5911f7b3f632e1db159952fc6be2043a486ed6c31dedb6aced2933df57a3b9cb74768d2fa09f346
+  data.tar.gz: 73ce2e1fbcedc63495fd7b6bcd959a938427d9b16774396450dd04b26a64585a4f4f56033cf7763c29f9ca0e94cdb72517e01b2aa24920f0c7894bb60a1bfa4b

data/CHANGELOG.md

@@ -1,11 +1,19 @@
+# v1.0.2 2017-02-13
+
+### Fixed
+
+* Structs uses read types for attributes so that they don't perform an unexpected serialization (flash-gordon)
+
+[Compare v1.0.1...v1.0.2](https://github.com/rom-rb/rom-repository/compare/v1.0.1...v1.0.2)
+
 # v1.0.1 2017-01-31
 
 ### Fixed
 
 * `Changeset::Update` creates a command with restricted relation (solnic)
-* `Changeset#result` will always return `:many` for arrays and `:one` for other objects (even a custom object is used) (solnic)
+* `Changeset#result` will always return `:many` for arrays and `:one` for other objects (even when a custom object is used) (solnic)
 
-[Compare v1.0.1...v1.0.1](https://github.com/rom-rb/rom-repository/compare/v1.0.0...v1.0.1)
+[Compare v1.0.0...v1.0.1](https://github.com/rom-rb/rom-repository/compare/v1.0.0...v1.0.1)
 
 # v1.0.0 2017-01-30
 

data/Gemfile

@@ -4,13 +4,6 @@ gemspec
 
 gem 'inflecto'
 
-gem 'rom', git: 'https://github.com/rom-rb/rom.git', branch: 'master'
-gem 'rom-mapper', git: 'https://github.com/rom-rb/rom-mapper.git', branch: 'master'
-
-group :development, :test do
-  gem 'rom-sql', git: 'https://github.com/rom-rb/rom-sql.git', branch: 'master'
-end
-
 group :development do
   gem 'dry-equalizer', '~> 0.2'
   gem 'sqlite3', platforms: [:mri, :rbx]
@@ -18,6 +11,7 @@ group :development do
 end
 
 group :test do
+  gem 'rom-sql'
   gem 'rspec'
   gem 'dry-struct'
   gem 'byebug', platforms: :mri

data/Rakefile

@@ -1,3 +1,4 @@
+require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)

data/lib/rom/repository/struct_builder.rb

@@ -50,7 +50,7 @@ module ROM
       end
 
       def visit_attribute(attr)
-        [attr.aliased? && !attr.wrapped? ? attr.alias : attr.name, attr.type]
+        [attr.aliased? && !attr.wrapped? ? attr.alias : attr.name, attr.to_read_type]
       end
 
       def build_class(name, parent, &block)

data/lib/rom/repository/version.rb

@@ -1,5 +1,5 @@
 module ROM
   class Repository
-    VERSION = '1.0.1'.freeze
+    VERSION = '1.0.2'.freeze
   end
 end

data/spec/integration/typed_structs_spec.rb

@@ -1,31 +1,64 @@
 RSpec.describe 'ROM repository with typed structs' do
   subject(:repo) do
-    Class.new(ROM::Repository[:books]).new(rom)
+    Class.new(ROM::Repository[:books]) { commands :create }.new(rom)
   end
 
   include_context 'database'
   include_context 'seeds'
 
-  before do
-    configuration.relation(:books) do
-      schema(infer: true)
+  context 'typed projections' do
+    before do
+      configuration.relation(:books) do
+        schema(infer: true)
 
-      view(:index) do
-        schema { project(:id, :title, :created_at) }
-        relation { order(:title) }
+        view(:index) do
+          schema { project(:id, :title, :created_at) }
+          relation { order(:title) }
+        end
       end
+
+      rom.relations[:books].insert(title: 'Hello World', created_at: Time.now)
     end
 
-    rom.relations[:books].insert(title: 'Hello World', created_at: Time.now)
+    it 'loads typed structs' do
+      book = repo.books.index.first
+
+      expect(book).to be_kind_of(Dry::Struct)
+
+      expect(book.id).to be_kind_of(Integer)
+      expect(book.title).to eql('Hello World')
+      expect(book.created_at).to be_kind_of(Time)
+    end
   end
 
-  it 'loads typed structs' do
-    book = repo.books.index.first
+  context 'read-write type coercions' do
+    before do
+      configuration.relation(:books) do
+        schema(infer: true) do
+          attribute :title,
+                    ROM::Types::Coercible::String.meta(
+                      read: ROM::Types::Symbol.constructor(&:to_sym)
+                    )
+        end
+      end
+
+      configuration.commands(:books) do
+        define(:create) { result(:one) }
+      end
+    end
+
+    it 'loads typed structs' do
+      created_book = repo.create(title: :'Hello World', created_at: Time.now)
 
-    expect(book).to be_kind_of(Dry::Struct)
+      expect(created_book).to be_kind_of(Dry::Struct)
 
-    expect(book.id).to be_kind_of(Integer)
-    expect(book.title).to eql('Hello World')
-    expect(book.created_at).to be_kind_of(Time)
+      expect(created_book.id).to be_kind_of(Integer)
+      expect(created_book.title).to eql(:'Hello World')
+      expect(created_book.created_at).to be_kind_of(Time)
+
+      book = repo.books.to_a.first
+
+      expect(book).to eql(created_book)
+    end
   end
 end

data/spec/spec_helper.rb

@@ -53,4 +53,6 @@ RSpec.configure do |config|
   end
 
   config.include(MapperRegistry)
+
+  config.disable_monkey_patching!
 end

data/spec/unit/struct_builder_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe 'struct builder', '#call' do
       aliased?: false,
       wrapped?: false,
       foreign_key?: false,
-      type: ROM::Types.const_get(type),
+      to_read_type: ROM::Types.const_get(type),
       **opts
     )
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rom-repository
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-31 00:00:00.000000000 Z
+date: 2017-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rom
@@ -188,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Repository abstraction for rom-rb