rom-mapper 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 60d6552bfc31e32d4098f7919bdef5296b74fdac
-  data.tar.gz: 8eca5e969300fa63429c8332b4fa68e771f98f3c
+  metadata.gz: 888f5525802c8f106e5bd5432f4f03a6fa1a1e98
+  data.tar.gz: 61a9c8cd3fe194d14bc96723db96f758a825e23f
 SHA512:
-  metadata.gz: 01590a1d49c956c48e07611f29693185973a50bfba4ce5099ae4a8fbc88da251db70d132326f5ad4887f9e4d349d979ae26e111d9c999de3af4649457703f230
-  data.tar.gz: ad3179f84bd1df5314c736ba3fff9ba1aadd88241e64b285c75217242b7955de23abc26f40eac41b0a04d604b10311958d27a55103ae64afe34c2a15027da8a1
+  metadata.gz: 684566603982171e10278f29700ca6af5ac643356c6b0bf3953ade8603a4e4e40219e39d770441461f3efbd4f36e6001fd69ed23ec0a27c0138be767ad174133
+  data.tar.gz: 3cd50d174a5472f67f34216e128d480ba3ad754650425b83cdee62d1bcdfede53a169dd9b3aa1f59f84bef002f463b7b1443b5fe5440bade4264b03912da614b

data/.travis.yml

@@ -6,7 +6,7 @@ script: "bundle exec rake ci"
 rvm:
   - 2.0
   - 2.1
-  - 2.2
+  - 2.2.5
   - 2.3.0
   - rbx-2
   - jruby-9000

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+# v0.4.0 2016-07-27
+
+### Changed
+
+* Raise a meaningful exception if no coercer exists (astupka)
+* Don’t reject keys if copy_keys option is true (astupka)
+
+[Compare v0.3.0..v0.4.0](https://github.com/rom-rb/rom-mapper/compare/v0.3.0...v0.4.0)
+
 # v0.3.0 2016-01-06
 
 ### Added

data/Gemfile

@@ -2,6 +2,8 @@ source 'https://rubygems.org'
 
 gemspec
 
+gem 'rom-support', github: 'rom-rb/rom-support', branch: 'master'
+
 group :test do
   gem 'anima', '~> 0.2.0'
   gem 'virtus'

data/README.md

@@ -18,7 +18,7 @@ backends. It is the default mapper in ROM.
 
 Resources:
 
-- [Guides](http://rom-rb.org/guides/basics/mappers/)
+- [Guides](http://www.rubydoc.info/gems/rom-mapper/0.3.0/ROM/Mapper/AttributeDSL)
 - [Importing Data with ROM and Transproc](http://solnic.eu/2015/07/15/importing-data-with-rom-and-transproc.html)
 
 ## License

data/lib/rom/mapper/version.rb

@@ -1,5 +1,5 @@
 module ROM
   class Mapper
-    VERSION = '0.3.0'.freeze
+    VERSION = '0.4.0'.freeze
   end
 end

data/lib/rom/processor/transproc.rb

@@ -22,6 +22,7 @@ module ROM
         import ::Transproc::HashTransformations
         import ::Transproc::ClassTransformations
         import ::Transproc::ProcTransformations
+        INVALID_INJECT_UNION_VALUE = "%s attribute: block is required for :from with union value.".freeze
 
         def self.identity(tuple)
           tuple
@@ -32,6 +33,8 @@ module ROM
         end
 
         def self.inject_union_value(tuple, name, keys, coercer)
+          raise ROM::MapperMisconfiguredError, INVALID_INJECT_UNION_VALUE % [name] if !coercer
+
           values = tuple.values_at(*keys)
           result = coercer.call(*values)
 
@@ -128,7 +131,7 @@ module ROM
         if attribute.union?
           compose do |ops|
             ops << t(:inject_union_value, attribute.name, attribute.key, coercer)
-            ops << t(:reject_keys, attribute.key)
+            ops << t(:reject_keys, attribute.key) unless header.copy_keys
           end
         elsif coercer
           t(:map_value, attribute.name, t(:bind, mapper, coercer))

data/rom-mapper.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency 'dry-equalizer', '~> 0.2'
   gem.add_dependency 'transproc', '~> 0.4.0'
-  gem.add_dependency 'rom-support', '~> 1.0.0'
+  gem.add_dependency 'rom-support', '~> 2.0.0'
 
   gem.add_development_dependency 'rake', '~> 10.3'
   gem.add_development_dependency 'rspec', '~> 3.3'

data/spec/unit/rom/processor/transproc_spec.rb

@@ -86,7 +86,7 @@ describe ROM::Processor::Transproc do
     end
   end
 
-  describe 'key from exsisting keys' do
+  context 'key from existing keys' do
     let(:attributes) do
       coercer = ->(a, b) { b + a }
       [[:c, { from: [:a, :b], coercer: coercer }]]
@@ -104,9 +104,25 @@ describe ROM::Processor::Transproc do
       ]
     end
 
+    let(:copy_keys_expected_result) do
+      [
+        { a: 'works', b: 'this', c: 'thisworks'}
+      ]
+    end
+
     it 'returns tuples a new key added based on exsiting keys' do
       expect(transproc[relation]).to eql(expected_result)
     end
+
+    it 'raises a configuration exception if coercer block does not exist' do
+      attributes[0][1][:coercer] = nil
+      expect { transproc[relation] }.to raise_error(ROM::MapperMisconfiguredError)
+    end
+
+    it 'honors the copy_keys option' do
+      options.merge!({ copy_keys: true })
+      expect(transproc[relation]).to eql(copy_keys_expected_result)
+    end
   end
 
   describe 'rejecting keys' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rom-mapper
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-06 00:00:00.000000000 Z
+date: 2016-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-equalizer
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -139,9 +139,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: ROM mapper component
 test_files: []
-has_rdoc: