rom-http 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ceb0d5ad55a0025e591bbd6d1faa80c61daf1dcc
-  data.tar.gz: fa8e226b0edc81e712507776b0be4e6b5a107ea0
+  metadata.gz: 5fd07f83166373c0e0f2bfe8c83f8f68578818dc
+  data.tar.gz: e643299868045661adadfd6ea6881cf59feda4fe
 SHA512:
-  metadata.gz: 12cad00ba08382a6f334e872edc03be82ec1e337705324835227ea073d4970288ffb0478119c085eb5e011e82cf3dba859b707c20309eb75b2d7ea8792b6e022
-  data.tar.gz: 055fb8f3a1543398ba921a459066d852f3eca1df5912afb2dfd3337b18b70f49a57552e9b281c314fc568a7f2fe7d0a8a95c04c119510a4b4cc59a79eed50213
+  metadata.gz: 2a2de5a39a3cf600c2464250809a2e292c7abef3a8e1b2e79232ac035b14992a160a56035c5c7a65414ab60b643093ac375e234ffab952c6a262f3517cd146fd
+  data.tar.gz: 44315f4744aa86c60fb92c801bd1521e2834dbada29fd53a6cfc4a6f35f27fb09cb335719d9bb4b52be5f1bda9c549539f4e98c96fca2344640c2e7b0a096062

data/.travis.yml

@@ -5,17 +5,12 @@ cache: bundler
 bundler_args: --without sql benchmarks console tools
 script: "bundle exec rake ci"
 rvm:
-  - 2.2.6
-  - 2.3.3
-  - 2.4.0
-  - rbx-3
-  - jruby-9.1.6.0
+  - 2.3.4
+  - 2.4.1
+  - jruby-9.1.13.0
 env:
   global:
     - JRUBY_OPTS='--dev -J-Xmx1024M'
-matrix:
-  allow_failures:
-    - rvm: rbx-3
 notifications:
   webhooks:
     urls:

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+# v0.7.0 2018-01-11
+
+### Added
+  - Add Dataset#add_params(AMHOL)
+
+### Changed
+  - Updated error messages (AMHOL)
+  - updated to depend on ROM 4.0 (maximderbin)
+  - Removed ruby 2.1 support (maximderbin)
+  - Removed rbx-3 support (maximderbin)
+
+
+
+[Compare v0.5.0...v0.6.0](https://github.com/rom-rb/rom-http/compare/v0.6.0...v0.7.0)
+
 # v0.6.0 2017-02-06
 ### Changed
   - Make schemas mandatory and use schema API from ROM core (AMHOL)

data/Gemfile

@@ -2,10 +2,10 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'rom-repository', github: 'rom-rb/rom-repository', branch: 'master'
+gem 'rom-repository', '~> 2.0'
 
 group :test do
-  gem 'rom', github: 'rom-rb/rom', branch: 'master'
+  gem 'rom', '~> 4.0'
   gem 'faraday'
   gem 'inflecto'
 end

data/README.md

@@ -52,10 +52,7 @@ require 'net/http'
 
 class RequestHandler
   def call(dataset)
-    uri = URI(dataset.uri)
-    uri.path = dataset.absolute_path
-    uri.query = URI.encode_www_form(dataset.params)
-
+    uri = dataset.uri
     http = Net::HTTP.new(uri.host, uri.port)
     request_klass = Net::HTTP.const_get(Inflecto.classify(dataset.request_method))
 
@@ -119,27 +116,27 @@ require 'net/http'
 module ROM
   module MyAdapter
     class Dataset < ROM::HTTP::Dataset
-      default_request_handler ->(dataset) do
-        uri = URI(dataset.uri)
-        uri.path = dataset.absolute_path
-        uri.query = URI.encode_www_form(dataset.params)
+      configure do |config|
+        config.default_request_handler = ->(dataset) do
+          uri = dataset.uri
 
-        http = Net::HTTP.new(uri.host, uri.port)
-        request_klass = Net::HTTP.const_get(Inflecto.classify(dataset.request_method))
+          http = Net::HTTP.new(uri.host, uri.port)
+          request_klass = Net::HTTP.const_get(Inflecto.classify(dataset.request_method))
 
-        request = request_klass.new(uri.request_uri)
-        dataset.headers.each_with_object(request) do |(header, value), request|
-          request[header.to_s] = value
-        end
+          request = request_klass.new(uri.request_uri)
+          dataset.headers.each_with_object(request) do |(header, value), request|
+            request[header.to_s] = value
+          end
 
-        response = http.request(request)
-      end
+          response = http.request(request)
+        end
 
-      default_response_handler ->(response, dataset) do
-        if %i(post put patch).include?(dataset.request_method)
-          JSON.parse(response.body, symbolize_names: true)
-        else
-          Array([JSON.parse(response.body, symbolize_names: true)]).flatten
+        config.default_response_handler = ->(response, dataset) do
+          if %i(post put patch).include?(dataset.request_method)
+            JSON.parse(response.body, symbolize_names: true)
+          else
+            Array([JSON.parse(response.body, symbolize_names: true)]).flatten
+          end
         end
       end
     end

data/lib/rom/http/dataset.rb

@@ -1,4 +1,8 @@
+require 'uri'
+require 'dry-configurable'
+require 'dry/core/deprecations'
 require 'rom/initializer'
+require 'rom/http/dataset/class_interface'
 
 module ROM
   module HTTP
@@ -9,32 +13,25 @@ module ROM
     # @api public
     class Dataset
       PATH_SEPARATOR = '/'.freeze
-      STRIP_PATH = ->(path) { path.sub(%r{\A/}, '') }.freeze
 
-      include Enumerable
-      include Dry::Equalizer(:config, :options)
       extend ::ROM::Initializer
+      extend ::Dry::Configurable
+      extend ::ROM::HTTP::Dataset::ClassInterface
+      include ::Enumerable
+      include ::Dry::Equalizer(:config, :options)
+
+      setting :default_request_handler
+      setting :default_response_handler
+      setting :param_encoder, ->(params) { URI.encode_www_form(params) }
 
       param :config
 
       option :request_method, type: Types::Symbol, default: proc { :get }, reader: true
       option :base_path, type: Types::String, default: proc { name }
-      option :path, type: Types::String, default: proc { '' }
+      option :path, type: Types::String, default: proc { '' }, reader: false
       option :params, type: Types::Hash, default: proc { {} }, reader: true
       option :headers, type: Types::Hash, default: proc { {} }
 
-      class << self
-        def default_request_handler(handler = Undefined)
-          return @default_request_handler if Undefined === handler
-          @default_request_handler = handler
-        end
-
-        def default_response_handler(handler = Undefined)
-          return @default_response_handler if Undefined === handler
-          @default_response_handler = handler
-        end
-      end
-
       # Return the gateway's URI
       #
       # @return [String]
@@ -43,7 +40,13 @@ module ROM
       #
       # @api public
       def uri
-        config.fetch(:uri) { fail Error, ':uri configuration missing' }
+        uri = config.fetch(:uri) { fail Error, '+uri+ configuration missing' }
+        uri = URI(join_path(uri, path))
+        if request_method == :get && params.any?
+          uri.query = self.class.config.param_encoder.call(params)
+        end
+
+        uri
       end
 
       # Return request headers
@@ -83,7 +86,7 @@ module ROM
       #
       # @api public
       def base_path
-        STRIP_PATH.call(super)
+        strip_path(super)
       end
 
       # Return the dataset path
@@ -96,7 +99,7 @@ module ROM
       #
       # @api public
       def path
-        STRIP_PATH.call(join_path(base_path, super))
+        join_path(base_path, strip_path(options[:path].to_s))
       end
 
       # Return the dataset path
@@ -234,6 +237,25 @@ module ROM
         with_options(params: params)
       end
 
+      # Return a new dataset with merged request parameters
+      #
+      # @param [Hash] params the new request parameters to add
+      #
+      # @example
+      #   users = Dataset.new(config, params: { uid: 33 })
+      #   users.add_params(login: 'jdoe').params
+      #   # => { uid: 33, :login => 'jdoe' }
+      #
+      # @return [Dataset]
+      #
+      # @api public
+      def add_params(new_params)
+        # TODO: Should we merge arrays?
+        with_options(
+          params: ::ROM::HTTP::Transformer[:deep_merge][params, new_params]
+        )
+      end
+
       # Iterate over each response value
       #
       # @yield [Hash] a dataset tuple
@@ -299,14 +321,20 @@ module ROM
       private
 
       def response_handler
-        response_handler = config.fetch(:response_handler, self.class.default_response_handler)
-        fail Error, ':response_handler configuration missing' if response_handler.nil?
+        response_handler = config.fetch(
+          :response_handler,
+          self.class.config.default_response_handler
+        )
+        fail Error, '+default_response_handler+ configuration missing' if response_handler.nil?
         response_handler
       end
 
       def request_handler
-        request_handler = config.fetch(:request_handler, self.class.default_request_handler)
-        fail Error, ':response_handler configuration missing' if request_handler.nil?
+        request_handler = config.fetch(
+          :request_handler,
+          self.class.config.default_request_handler
+        )
+        fail Error, '+default_response_handler+ configuration missing' if request_handler.nil?
         request_handler
       end
 
@@ -317,6 +345,10 @@ module ROM
       def join_path(*paths)
         paths.reject(&:empty?).join(PATH_SEPARATOR)
       end
+
+      def strip_path(path)
+        path.sub(%r{\A/}, '')
+      end
     end
   end
 end

data/lib/rom/http/dataset/class_interface.rb

@@ -0,0 +1,33 @@
+module ROM
+  module HTTP
+    # HTTP Dataset
+    #
+    # Represents a specific HTTP collection resource
+    #
+    # @api public
+    class Dataset
+      # @api private
+      module ClassInterface
+        # TODO: Remove in favour of configuration
+        def default_request_handler(handler = Undefined)
+          ::Dry::Core::Deprecations.announce(
+            __method__,
+            'use configuration instead'
+          )
+          return config.default_request_handler if Undefined === handler
+          config.default_request_handler = handler
+        end
+
+        # TODO: Remove in favour of configuration
+        def default_response_handler(handler = Undefined)
+          ::Dry::Core::Deprecations.announce(
+            __method__,
+            'use configuration instead'
+          )
+          return config.default_response_handler if Undefined === handler
+          config.default_response_handler = handler
+        end
+      end
+    end
+  end
+end

data/lib/rom/http/error.rb

@@ -1,6 +1,5 @@
 module ROM
   module HTTP
     Error = Class.new(StandardError)
-    SchemaNotDefinedError = Class.new(Error)
   end
 end

data/lib/rom/http/gateway.rb

@@ -16,6 +16,8 @@ module ROM
     #
     # @api public
     class Gateway < ROM::Gateway
+      adapter :http
+
       attr_reader :datasets, :config
       private :datasets, :config
 

data/lib/rom/http/relation.rb

@@ -1,6 +1,5 @@
 require 'dry/core/cache'
 require 'rom/initializer'
-require 'rom/plugins/relation/key_inference'
 require 'rom/http/transformer'
 
 module ROM
@@ -14,22 +13,11 @@ module ROM
 
       adapter :http
 
-      use :key_inference
-
       option :transformer, reader: true, default: proc { ::ROM::HTTP::Transformer }
 
-      forward :with_request_method, :with_path, :append_path, :with_options,
-              :with_params, :clear_params
-
-
-      def initialize(*)
-        super
-
-        raise(
-          SchemaNotDefinedError,
-          "You must define a schema for #{self.class.register_as} relation"
-        ) unless schema?
-      end
+      forward :with_headers, :add_header, :with_options,
+              :with_base_path, :with_path, :append_path,
+              :with_request_method, :with_params, :add_params
 
       def primary_key
         attribute = schema.find(&:primary_key?)
@@ -83,8 +71,8 @@ module ROM
 
       private
 
-      def with_transformation(&block)
-        tuples = block.call
+      def with_transformation
+        tuples = yield
 
         transformed = with_schema_proc do |proc|
           transformer_proc[Array([tuples]).flatten(1).map(&proc.method(:call))]
@@ -93,12 +81,12 @@ module ROM
         tuples.kind_of?(Array) ? transformed : transformed.first
       end
 
-      def with_schema_proc(&block)
+      def with_schema_proc
         schema_proc = fetch_or_store(schema) do
           Types::Coercible::Hash.schema(schema.to_h)
         end
 
-        block.call(schema_proc)
+        yield(schema_proc)
       end
 
       def transformer_proc

data/lib/rom/http/transformer.rb

@@ -11,6 +11,7 @@ module ROM
       import :identity, from: ::Transproc::Coercions
       import :map_array, from: ::Transproc::ArrayTransformations
       import :rename_keys, from: ::Transproc::HashTransformations
+      import :deep_merge, from: ::Transproc::HashTransformations
     end
   end
 end

data/lib/rom/http/version.rb

@@ -1,5 +1,5 @@
 module ROM
   module HTTP
-    VERSION = '0.6.0'.freeze
+    VERSION = '0.7.0'.freeze
   end
 end

data/rom-http.gemspec

@@ -19,9 +19,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'concurrent-ruby'
-  spec.add_runtime_dependency 'rom', '~> 3.0.0'
+  spec.add_runtime_dependency 'addressable'
+  spec.add_runtime_dependency 'rom', '~> 4.0'
   spec.add_runtime_dependency 'dry-core', '~> 0.2', '>= 0.2.3'
   spec.add_runtime_dependency 'dry-equalizer', '~> 0.2'
+  spec.add_runtime_dependency 'dry-configurable', '~> 0.6'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rspec', '~> 3.1'

data/spec/integration/abstract/commands/create_spec.rb

@@ -47,7 +47,7 @@ RSpec.describe ROM::HTTP::Commands::Create do
       allow(response_handler).to receive(:call).and_return(tuple)
     end
 
-    subject! { container.command(:users).create.call(attributes) }
+    subject! { container.commands[:users].create.call(attributes) }
 
     it do
       expect(request_handler).to have_received(:call).with(dataset)
@@ -106,7 +106,7 @@ RSpec.describe ROM::HTTP::Commands::Create do
       allow(response_handler).to receive(:call).and_return(tuple_1, tuple_2)
     end
 
-    subject! { container.command(:users).create.call(attributes) }
+    subject! { container.commands[:users].create.call(attributes) }
 
     it do
       expect(request_handler).to have_received(:call).with(dataset_1)

data/spec/integration/abstract/commands/delete_spec.rb

@@ -42,7 +42,7 @@ RSpec.describe ROM::HTTP::Commands::Delete do
     allow(response_handler).to receive(:call).and_return(tuples)
   end
 
-  subject! { container.command(:users).delete.call }
+  subject! { container.commands[:users].delete.call }
 
   it do
     expect(request_handler).to have_received(:call).with(dataset)

data/spec/integration/abstract/commands/update_spec.rb

@@ -47,7 +47,7 @@ RSpec.describe ROM::HTTP::Commands::Update do
       allow(response_handler).to receive(:call).and_return(tuple)
     end
 
-    subject! { container.command(:users).update.call(attributes) }
+    subject! { container.commands[:users].update.call(attributes) }
 
     it do
       expect(request_handler).to have_received(:call).with(dataset)
@@ -106,7 +106,7 @@ RSpec.describe ROM::HTTP::Commands::Update do
       allow(response_handler).to receive(:call).and_return(tuple_1, tuple_2)
     end
 
-    subject! { container.command(:users).update.call(attributes) }
+    subject! { container.commands[:users].update.call(attributes) }
 
     it do
       expect(request_handler).to have_received(:call).with(dataset_1)

data/spec/integration/abstract/relation_spec.rb

@@ -2,7 +2,7 @@ require 'json'
 require 'rom-repository'
 
 RSpec.describe ROM::HTTP::Relation do
-  subject(:users) { container.relation(:users).by_id(id).filter(params) }
+  subject(:users) { container.relations[:users].by_id(id).filter(params) }
 
   include_context 'setup'
 
@@ -58,11 +58,15 @@ RSpec.describe ROM::HTTP::Relation do
 
   context 'using a repo' do
     let(:repo) do
-      Class.new(ROM::Repository) { relations :users }.new(container)
+      Class.new(ROM::Repository) do
+        def self.to_s
+          'UserRepo'
+        end
+      end.new(container)
     end
 
     it 'returns structs' do
-      user = repo.users.by_id(1337).filter(params).one
+      user = repo.users.by_id(1337).filter(params).first
 
       expect(user.id).to be(1337)
       expect(user.name).to eql('John')

data/spec/spec_helper.rb

@@ -5,6 +5,9 @@ Bundler.setup
 
 require 'rom-http'
 require 'rspec/its'
+require 'dry/configurable/test_interface'
+
+ROM::HTTP::Dataset.enable_test_interface
 
 begin
 require 'byebug'

data/spec/unit/rom/http/dataset_spec.rb

@@ -13,7 +13,22 @@ RSpec.describe ROM::HTTP::Dataset do
   let(:request_handler) { double(Proc) }
   let(:response_handler) { double(Proc) }
 
-  it { expect(dataset).to be_kind_of(Enumerable) }
+  it { expect(klass).to be_kind_of(::Dry::Configurable) }
+  it { expect(dataset).to be_kind_of(::Enumerable) }
+
+  describe 'settings' do
+    describe 'default_request_handler' do
+      it 'defaults to nil' do
+        expect(klass.config.default_request_handler).to be nil
+      end
+    end
+
+    describe 'default_response_handler' do
+      it 'defaults to nil' do
+        expect(klass.config.default_response_handler).to be nil
+      end
+    end
+  end
 
   describe 'defaults' do
     describe '#config' do
@@ -57,11 +72,21 @@ RSpec.describe ROM::HTTP::Dataset do
       module Test
         class Dataset < ROM::HTTP::Dataset; end
       end
+
+      allow(Dry::Core::Deprecations).to receive(:announce)
     end
 
+    after { Test::Dataset.reset_config }
+
     context 'when no default_request_handler set' do
+      subject! { Test::Dataset.default_request_handler }
+
       it 'returns nil' do
-        expect(klass.default_request_handler).to be nil
+        expect(Dry::Core::Deprecations).to have_received(:announce).with(
+          :default_request_handler,
+          'use configuration instead'
+        )
+        is_expected.to be nil
       end
     end
 
@@ -70,8 +95,14 @@ RSpec.describe ROM::HTTP::Dataset do
         Test::Dataset.default_request_handler(request_handler)
       end
 
+      subject! { Test::Dataset.default_request_handler }
+
       it 'returns the default request handler' do
-        expect(Test::Dataset.default_request_handler).to eq request_handler
+        expect(Dry::Core::Deprecations).to have_received(:announce).with(
+          :default_request_handler,
+          'use configuration instead'
+        ).twice
+        is_expected.to eq request_handler
       end
     end
   end
@@ -81,11 +112,21 @@ RSpec.describe ROM::HTTP::Dataset do
       module Test
         class Dataset < ROM::HTTP::Dataset; end
       end
+
+      allow(Dry::Core::Deprecations).to receive(:announce)
     end
 
+    after { Test::Dataset.reset_config }
+
     context 'when no default_response_handler set' do
+      subject! { Test::Dataset.default_response_handler }
+
       it 'returns nil' do
-        expect(klass.default_response_handler).to be nil
+        expect(Dry::Core::Deprecations).to have_received(:announce).with(
+          :default_response_handler,
+          'use configuration instead'
+        )
+        is_expected.to be nil
       end
     end
 
@@ -94,8 +135,14 @@ RSpec.describe ROM::HTTP::Dataset do
         Test::Dataset.default_response_handler(response_handler)
       end
 
+      subject! { Test::Dataset.default_response_handler }
+
       it 'returns the default response handler' do
-        expect(Test::Dataset.default_response_handler).to eq response_handler
+        expect(Dry::Core::Deprecations).to have_received(:announce).with(
+          :default_response_handler,
+          'use configuration instead'
+        ).twice
+        is_expected.to eq response_handler
       end
     end
   end
@@ -110,7 +157,107 @@ RSpec.describe ROM::HTTP::Dataset do
     end
 
     context 'when uri configured' do
-      it { expect(dataset.uri).to eq(uri) }
+      subject! { dataset.uri }
+
+      context 'when request method is GET' do
+        context 'with params' do
+          let(:options) do
+            {
+              params: {
+                username: 'John',
+                role: 'admin'
+              }
+            }
+          end
+          let(:expected_uri) { URI("#{uri}?username=John&role=admin") }
+
+          it { is_expected.to eq(expected_uri) }
+        end
+      end
+
+      context 'when request method is not GET' do
+        context 'with params' do
+          let(:options) do
+            {
+              request_method: :post,
+              params: {
+                username: 'John',
+                role: 'admin'
+              }
+            }
+          end
+          let(:expected_uri) { URI(uri) }
+
+          it { is_expected.to eq(expected_uri) }
+        end
+      end
+
+      context 'without dataset name' do
+        context 'with no path' do
+          let(:expected_uri) { URI(uri) }
+
+          it { is_expected.to eq(expected_uri) }
+        end
+
+        context 'with path' do
+          context 'without custom base_path' do
+            let(:options) { { path: '/users' } }
+            let(:expected_uri) { URI("#{uri}/users") }
+
+            it { is_expected.to eq(expected_uri) }
+          end
+
+          context 'with custom base_path' do
+            let(:options) { { base_path: '/blog', path: '/users' } }
+            let(:expected_uri) { URI("#{uri}/blog/users") }
+
+            it { is_expected.to eq(expected_uri) }
+          end
+        end
+      end
+
+      context 'with dataset name' do
+        let(:config) { super().merge(name: :blog) }
+
+        context 'with no path' do
+          let(:expected_uri) { URI("#{uri}/blog") }
+
+          it { is_expected.to eq(expected_uri) }
+        end
+
+        context 'with path' do
+          context 'without custom base_path' do
+            let(:options) { { path: '/users' } }
+            let(:expected_uri) { URI("#{uri}/blog/users") }
+
+            it { is_expected.to eq(expected_uri) }
+          end
+
+          context 'with custom base_path' do
+            let(:options) { { base_path: '/bloggers', path: '/users' } }
+            let(:expected_uri) { URI("#{uri}/bloggers/users") }
+
+            it { is_expected.to eq(expected_uri) }
+          end
+        end
+      end
+
+      context 'with custom base_path' do
+        let(:config) { super().merge(name: :blog) }
+
+        context 'with no path' do
+          let(:expected_uri) { URI("#{uri}/blog") }
+
+          it { is_expected.to eq(expected_uri) }
+        end
+
+        context 'with path' do
+          let(:options) { { path: '/users' } }
+          let(:expected_uri) { URI("#{uri}/blog/users") }
+
+          it { is_expected.to eq(expected_uri) }
+        end
+      end
     end
   end
 
@@ -224,24 +371,68 @@ RSpec.describe ROM::HTTP::Dataset do
     subject { dataset.path }
 
     context 'with no path option' do
-      it { is_expected.to eq('') }
+      context 'without dataset name' do
+        it { is_expected.to eq('') }
+      end
+
+      context 'with dataset name' do
+        let(:config) { super().merge(name: :users) }
+        it { is_expected.to eq('users') }
+      end
+
+      context 'with base path' do
+        let(:options) { { base_path: '/users' } }
+        it { is_expected.to eq('users') }
+      end
     end
 
     context 'with path option' do
       context 'when path is absolute' do
         let(:path) { '/users' }
-        let(:options) { { path: path } }
 
-        it 'removes the leading /' do
-          is_expected.to eq('users')
+        context 'without dataset name' do
+          let(:options) { { path: path } }
+
+          it 'removes the leading /' do
+            is_expected.to eq('users')
+          end
+        end
+
+        context 'with dataset name' do
+          let(:config) { super().merge(name: :blog) }
+          let(:options) { { path: path } }
+
+          it { is_expected.to eq('blog/users') }
+        end
+
+        context 'with base path' do
+          let(:options) { { base_path: '/blog', path: path } }
+
+          it { is_expected.to eq('blog/users') }
         end
       end
 
       context 'when path is not absolute' do
         let(:path) { 'users' }
-        let(:options) { { path: path } }
 
-        it { is_expected.to eq(path) }
+        context 'without dataset name' do
+          let(:options) { { path: path } }
+
+          it { is_expected.to eq(path) }
+        end
+
+        context 'with dataset name' do
+          let(:config) { super().merge(name: :blog) }
+          let(:options) { { path: path } }
+
+          it { is_expected.to eq('blog/users') }
+        end
+
+        context 'with base path' do
+          let(:options) { { base_path: '/blog', path: path } }
+
+          it { is_expected.to eq('blog/users') }
+        end
       end
     end
   end
@@ -449,6 +640,36 @@ RSpec.describe ROM::HTTP::Dataset do
     it { is_expected.to eq(new_dataset) }
   end
 
+  describe '#add_params' do
+    let(:options) do
+      {
+        params: {
+          user: {
+            uid: 3
+          }
+        }
+      }
+    end
+    let(:params) { { user: { name: 'Jack' } } }
+    let(:new_dataset) { double(ROM::HTTP::Dataset) }
+
+    before do
+      allow(dataset).to receive(:with_options).and_return(new_dataset)
+    end
+
+    subject! { dataset.add_params(params) }
+
+    it do
+      expect(dataset).to have_received(:with_options).with(params: {
+        user: {
+          uid: 3,
+          name: 'Jack'
+        }
+      })
+    end
+    it { is_expected.to eq(new_dataset) }
+  end
+
   describe '#each' do
     let(:response) { double(Array) }
     let(:block) { proc {} }
@@ -560,7 +781,7 @@ RSpec.describe ROM::HTTP::Dataset do
     end
 
     context 'when request_handler and response_handler configured' do
-      let(:klass) { Test::Dataset }
+      let(:dataset) { Test::Dataset.new(config, options) }
       let(:config) { {} }
 
       before do
@@ -575,6 +796,8 @@ RSpec.describe ROM::HTTP::Dataset do
         allow(response_handler).to receive(:call).and_return(result)
       end
 
+      after { Test::Dataset.reset_config }
+
       subject! { dataset.response }
 
       it { expect(request_handler).to have_received(:call).with(dataset) }

data/spec/unit/rom/http/relation_spec.rb

@@ -26,18 +26,6 @@ RSpec.describe ROM::HTTP::Relation do
     allow(dataset).to receive(:response).and_return(data)
   end
 
-  describe '#initialize' do
-    context 'when initialized without a schema defined' do
-      let(:relation_klass) do
-        Class.new(ROM::HTTP::Relation)
-      end
-
-      it do
-        expect { relation }.to raise_error(::ROM::HTTP::SchemaNotDefinedError)
-      end
-    end
-  end
-
   describe '#primary_key' do
     subject { relation.primary_key }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rom-http
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Piotr Solnica
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-07 00:00:00.000000000 Z
+date: 2018-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -26,20 +26,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rom
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: dry-core
   requirement: !ruby/object:Gem::Requirement
@@ -74,6 +88,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
+- !ruby/object:Gem::Dependency
+  name: dry-configurable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -157,6 +185,7 @@ files:
 - lib/rom/http/commands/delete.rb
 - lib/rom/http/commands/update.rb
 - lib/rom/http/dataset.rb
+- lib/rom/http/dataset/class_interface.rb
 - lib/rom/http/error.rb
 - lib/rom/http/gateway.rb
 - lib/rom/http/relation.rb
@@ -195,7 +224,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: HTTP support for ROM