rom-http 0.5.0 → 0.6.0.rc1

data/spec/unit/rom/http/relation_spec.rb

@@ -1,31 +1,279 @@
 RSpec.describe ROM::HTTP::Relation do
+  let(:relation_klass) do
+    Class.new(ROM::HTTP::Relation) do
+      schema do
+        attribute :id, ROM::Types::Strict::Int
+        attribute :name, ROM::Types::Strict::String
+      end
+    end
+  end
+  let(:relation) { relation_klass.new(dataset) }
+  let(:dataset) { ROM::HTTP::Dataset.new({ name: 'test' }, {}) }
+  let(:data) do
+    [
+      {
+        id: 1,
+        name: 'John'
+      },
+      {
+        id: 2,
+        name: 'Jill'
+      }
+    ]
+  end
+
+  before do
+    allow(dataset).to receive(:response).and_return(data)
+  end
+
   describe '#initialize' do
-    let(:relation) { relation_klass.new(dataset) }
-    let(:dataset) { ROM::HTTP::Dataset.new(nil, {}) }
+    context 'when initialized without a schema defined' do
+      let(:relation_klass) do
+        Class.new(ROM::HTTP::Relation)
+      end
+
+      it do
+        expect { relation }.to raise_error(::ROM::HTTP::SchemaNotDefinedError)
+      end
+    end
+  end
+
+  describe '#primary_key' do
+    subject { relation.primary_key }
+
+    context 'with no primary key defined in schema' do
+      it 'defaults to :id' do
+        is_expected.to eq(:id)
+      end
+    end
+
+    context 'with primary key defined in schema' do
+      context 'without alias' do
+        let(:relation_klass) do
+          Class.new(ROM::HTTP::Relation) do
+            schema do
+              attribute :id, ROM::Types::Strict::Int
+              attribute :name, ROM::Types::Strict::String.meta(primary_key: true)
+            end
+          end
+        end
+
+        it 'returns the attribute name of the primary key' do
+          is_expected.to eq(:name)
+        end
+      end
+
+      context 'with alias' do
+        let(:relation_klass) do
+          Class.new(ROM::HTTP::Relation) do
+            schema do
+              attribute :id, ROM::Types::Strict::Int.meta(primary_key: true, alias: :ident)
+              attribute :name, ROM::Types::Strict::String
+            end
+          end
+        end
+
+        it 'returns the attribute name of the primary key' do
+          is_expected.to eq(:ident)
+        end
+      end
+    end
+  end
+
+  describe '#project' do
+    subject { relation.project(:id).to_a }
+
+    it 'returns the projected data' do
+      is_expected.to match_array([
+        { id: 1 },
+        { id: 2 }
+      ])
+    end
+  end
+
+  describe '#exclude' do
+    subject { relation.exclude(:id).to_a }
+
+    it 'returns the data with specified keys excluded' do
+      is_expected.to match_array([
+        { name: 'John' },
+        { name: 'Jill' }
+      ])
+    end
+  end
+
+  describe '#rename' do
+    subject { relation.rename(id: :identity).to_a }
+
+    it 'returns the data with keys renamed according to mapping' do
+      is_expected.to match_array([
+        { name: 'John', identity: 1 },
+        { name: 'Jill', identity: 2 }
+      ])
+    end
+  end
+
+  describe '#prefix' do
+    subject { relation.prefix('user').to_a }
+
+    it 'returns the data with prefixed keys' do
+      is_expected.to match_array([
+        { user_id: 1, user_name: 'John' },
+        { user_id: 2, user_name: 'Jill' }
+      ])
+    end
+  end
+
+  describe '#wrap' do
+    context 'when called without a prefix' do
+      subject { relation.wrap.to_a }
+
+      it 'returns the data with keys prefixed by dataset name' do
+        is_expected.to match_array([
+          { test_id: 1, test_name: 'John' },
+          { test_id: 2, test_name: 'Jill' }
+        ])
+      end
+    end
+
+    context 'when called with a prefix' do
+      subject { relation.wrap('user').to_a }
 
-    context 'when relation has schema' do
+      it 'returns the data with keys prefixed by the given prefix' do
+        is_expected.to match_array([
+          { user_id: 1, user_name: 'John' },
+          { user_id: 2, user_name: 'Jill' }
+        ])
+      end
+    end
+  end
+
+  describe '#to_a' do
+    subject { relation.to_a }
+
+    context 'with standard schema' do
       let(:relation_klass) do
         Class.new(ROM::HTTP::Relation) do
           schema do
-            attribute 'id', ROM::Types::Strict::Int
+            attribute :id, ROM::Types::Strict::Int
           end
         end
       end
 
-      it 'sets the dataset response transformer' do
-        expect(relation.dataset.response_transformer)
-          .to be_a(ROM::HTTP::Dataset::ResponseTransformers::Schemad)
+      it 'applies the schema and returns the materialized results' do
+        is_expected.to match_array([
+          { id: 1 },
+          { id: 2 }
+        ])
       end
     end
 
-    context 'when relation does not have schema' do
+    context 'with aliased schema' do
       let(:relation_klass) do
-        Class.new(ROM::HTTP::Relation)
+        Class.new(ROM::HTTP::Relation) do
+          schema do
+            attribute :id, ROM::Types::Strict::Int
+            attribute :name, ROM::Types::Strict::String.meta(alias: :username)
+          end
+        end
+      end
+
+      it 'applies the schema and returns the materialized results' do
+        is_expected.to match_array([
+          { id: 1, username: 'John' },
+          { id: 2, username: 'Jill' }
+        ])
       end
+    end
+  end
+
+  %i[insert update].each do |method_name|
+    describe "##{method_name}" do
+      subject { relation.send(method_name, name: 'John') }
 
-      it 'keeps the default (schemaless) transformer' do
-        expect(relation.dataset.response_transformer)
-          .to be_a(ROM::HTTP::Dataset::ResponseTransformers::Schemaless)
+      before do
+        allow(dataset).to receive(method_name).and_return(data)
+      end
+
+      context 'with standard schema' do
+        let(:relation_klass) do
+          Class.new(ROM::HTTP::Relation) do
+            schema do
+              attribute :id, ROM::Types::Strict::Int
+            end
+          end
+        end
+
+        context 'when respond with single tuple' do
+          let(:data) { { id: 1, name: 'John' } }
+
+          it 'applies the schema and returns the materialized results' do
+            is_expected.to eq(id: 1)
+          end
+        end
+
+        context 'when respond with multiple tuples' do
+          let(:data) do
+            [
+              {
+                id: 1,
+                name: 'John'
+              },
+              {
+                id: 2,
+                name: 'Jill'
+              }
+            ]
+          end
+
+          it 'applies the schema and returns the materialized results' do
+            is_expected.to match_array([
+              { id: 1 },
+              { id: 2 }
+            ])
+          end
+        end
+      end
+
+      context 'with aliased schema' do
+        let(:relation_klass) do
+          Class.new(ROM::HTTP::Relation) do
+            schema do
+              attribute :id, ROM::Types::Strict::Int
+              attribute :name, ROM::Types::Strict::String.meta(alias: :username)
+            end
+          end
+        end
+
+        context 'when respond with single tuple' do
+          let(:data) { { id: 1, name: 'John' } }
+
+          it 'applies the schema and returns the materialized results' do
+            is_expected.to eq(id: 1, username: 'John')
+          end
+        end
+
+        context 'when respond with multiple tuples' do
+          let(:data) do
+            [
+              {
+                id: 1,
+                name: 'John'
+              },
+              {
+                id: 2,
+                name: 'Jill'
+              }
+            ]
+          end
+
+          it 'applies the schema and returns the materialized results' do
+            is_expected.to match_array([
+              { id: 1, username: 'John' },
+              { id: 2, username: 'Jill' }
+            ])
+          end
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rom-http
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0.rc1
 platform: ruby
 authors:
 - Piotr Solnica
@@ -10,10 +10,10 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-08 00:00:00.000000000 Z
+date: 2017-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: thread_safe
+  name: concurrent-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -27,47 +27,53 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: dry-types
+  name: rom
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0.rc
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0.rc
 - !ruby/object:Gem::Dependency
-  name: rom
+  name: dry-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.3
 - !ruby/object:Gem::Dependency
   name: dry-equalizer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -96,6 +102,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -129,6 +149,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- examples/repository_with_combine.rb
 - lib/rom-http.rb
 - lib/rom/http.rb
 - lib/rom/http/commands.rb
@@ -136,12 +157,10 @@ files:
 - lib/rom/http/commands/delete.rb
 - lib/rom/http/commands/update.rb
 - lib/rom/http/dataset.rb
-- lib/rom/http/dataset/response_transformers/schemad.rb
-- lib/rom/http/dataset/response_transformers/schemaless.rb
 - lib/rom/http/error.rb
 - lib/rom/http/gateway.rb
 - lib/rom/http/relation.rb
-- lib/rom/http/support/transformations.rb
+- lib/rom/http/transformer.rb
 - lib/rom/http/version.rb
 - rakelib/rubocop.rake
 - rom-http.gemspec
@@ -153,8 +172,6 @@ files:
 - spec/shared/users_and_tasks.rb
 - spec/spec_helper.rb
 - spec/support/mutant.rb
-- spec/unit/rom/http/dataset/response_transformers/schemad_spec.rb
-- spec/unit/rom/http/dataset/response_transformers/schemaless_spec.rb
 - spec/unit/rom/http/dataset_spec.rb
 - spec/unit/rom/http/gateway_spec.rb
 - spec/unit/rom/http/relation_spec.rb
@@ -173,12 +190,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.3
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: HTTP support for ROM
@@ -191,8 +208,6 @@ test_files:
 - spec/shared/users_and_tasks.rb
 - spec/spec_helper.rb
 - spec/support/mutant.rb
-- spec/unit/rom/http/dataset/response_transformers/schemad_spec.rb
-- spec/unit/rom/http/dataset/response_transformers/schemaless_spec.rb
 - spec/unit/rom/http/dataset_spec.rb
 - spec/unit/rom/http/gateway_spec.rb
 - spec/unit/rom/http/relation_spec.rb