rom-factory 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d518c3e2f7f686c9366ef1c54ba7a2c33d1858fd3507dde56b49a1f1e9c49efd
-  data.tar.gz: 7fdf505e789b85006f9dd639b1bc15b1ed76a2129144dd965494ab0853693ffa
+  metadata.gz: 405ffd84ef6d6c604dc925be2d885f9639986893281dea271ae65584505e40a3
+  data.tar.gz: 78e65374754604602d984aba6a0b7374041b5972fcd464187f6d0ec2a7a919a5
 SHA512:
-  metadata.gz: 90d96b038566692c001c2eabdee291276ec604910db01343b912d4c56690a6564278183f1315d87d6de42dc7716a4a3f26518dcff6f1ffcad1f3301f1553a737
-  data.tar.gz: 2ea5c2473d2a35b109978079f8ac71c3ea375b19643b787bc0c71b9549b03cfb3e09173fb33b30b1465ff85defabe588a075fc4e6857040d77fdc59fec9c04fe
+  metadata.gz: c787c81d9545fa094c84751dd81e0f2fcb4d66de479354f9fe44dd7b6df8442bdf4c913998cad3584ad3ff2e4741603edcfb1508e9eec3067c32686f1889ef81
+  data.tar.gz: 8128cb92776ecedc10e7da0d5e5213f4f4bb6b8663d3ace72a19cd2cf985cd78d85744119d3e61b7dfc4ac44478a912966fd9c14a59b48f463140d164a81827f

data/CHANGELOG.md

@@ -1,4 +1,12 @@
-## 0.8.0 to-be-released
+## 0.9.0 2019-08-12
+
+### Added
+
+* When attributes hash includes unknown attributes, a `ROM::Factory::UnknownAttributeError` will be raised (@rawburt)
+
+[Compare v0.8.0...v0.9.0](https://github.com/rom-rb/rom-factory/compare/v0.8.0...v0.9.0)
+
+## 0.8.0 2019-04-24
 
 ### Fixed
 

data/Gemfile

@@ -8,6 +8,7 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 gem 'rake', '~> 12.0'
 gem 'rspec', '~> 3.0'
+gem 'faker', '<= 1.9'
 
 group :test do
   gem 'rom-sql', '~> 3.0'

data/lib/rom/factory/builder.rb

@@ -33,6 +33,7 @@ module ROM::Factory
 
     # @api private
     def struct(*traits, **attrs)
+      validate_keys(traits, attrs)
       tuple_evaluator.struct(*traits, attrs)
     end
     alias_method :create, :struct
@@ -56,5 +57,14 @@ module ROM::Factory
     def relation
       tuple_evaluator.relation
     end
+
+    # @api private
+    def validate_keys(traits, tuple)
+      schema_keys = relation.schema.attributes.map(&:name)
+      assoc_keys = tuple_evaluator.assoc_names(traits)
+      unknown_keys = tuple.keys - schema_keys - assoc_keys
+
+      raise UnknownFactoryAttributes, unknown_keys unless unknown_keys.empty?
+    end
   end
 end

data/lib/rom/factory/builder/persistable.rb

@@ -23,6 +23,7 @@ module ROM
         # @api private
         def create(*traits, **attrs)
           tuple = tuple(*traits, attrs)
+          validate_keys(traits, attrs)
           persisted = persist(tuple)
 
           if tuple_evaluator.has_associations?(traits)

data/lib/rom/factory/constants.rb

@@ -7,5 +7,11 @@ module ROM
         super("Factory +#{name}+ not defined")
       end
     end
+
+    class UnknownFactoryAttributes < StandardError
+      def initialize(attrs)
+        super("Unknown attributes: #{attrs.join(', ')}")
+      end
+    end
   end
 end

data/lib/rom/factory/version.rb

@@ -2,6 +2,6 @@
 
 module ROM
   module Factory
-    VERSION = '0.8.0'
+    VERSION = '0.9.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rom-factory
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Janis Miezitis
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-24 00:00:00.000000000 Z
+date: 2019-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-configurable