rom-factory 0.10.1 → 0.11.0

data/.rubocop.yml

@@ -1,89 +1,247 @@
-# this file is managed by rom-rb/devtools project
-
+# This is a config synced from rom-rb/template-gem repo
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.7
+  NewCops: disable
+  SuggestExtensions: false
+  Exclude:
+    - spec/support/coverage.rb
+    - spec/support/warnings.rb
+    - spec/support/rspec_options.rb
+    - Gemfile.devtools
+    - "*.gemspec"
 
-Style/EachWithObject:
+Layout/ArgumentAlignment:
   Enabled: false
+  EnforcedStyle: with_fixed_indentation
 
-Style/StringLiterals:
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: false
+
+Layout/SpaceInLambdaLiteral:
+  Enabled: false
+
+Layout/MultilineMethodCallIndentation:
   Enabled: true
-  EnforcedStyle: single_quotes
+  EnforcedStyle: indented
 
-Style/Alias:
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+  EnforcedStyle: no_space
+  EnforcedStyleForEmptyBraces: no_space
+
+Layout/LineLength:
+  Max: 120
+  Exclude:
+    - "spec/**/*_spec.rb"
+
+Lint/AmbiguousBlockAssociation:
+  Enabled: true
+  # because 'expect { foo }.to change { bar }' is fine
+  Exclude:
+    - "spec/**/*.rb"
+
+Lint/BooleanSymbol:
   Enabled: false
 
-Style/LambdaCall:
+Lint/MissingSuper:
   Enabled: false
 
-Style/StabbyLambdaParentheses:
+Lint/ConstantDefinitionInBlock:
   Enabled: false
 
-Style/FormatString:
+Lint/EmptyBlock:
+  Exclude:
+  - "spec/**/*.rb"
+
+Lint/EmptyClass:
+  Exclude:
+  - "spec/**/*.rb"
+
+Lint/RaiseException:
   Enabled: false
 
-Style/Documentation:
+Lint/StructNewOverride:
   Enabled: false
 
-Layout/SpaceInLambdaLiteral:
+Lint/SuppressedException:
+  Exclude:
+    - "spec/**/*.rb"
+
+Lint/UselessMethodDefinition:
+  Exclude:
+    - "lib/rom/struct.rb"
+
+Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
-Layout/MultilineMethodCallIndentation:
-  Enabled: true
-  EnforcedStyle: indented
+Lint/ToEnumArguments:
+  Exclude:
+    - "lib/rom/command.rb"
+
+Naming/MethodParameterName:
+  Enabled: false
 
-Metrics/LineLength:
-  Max: 100
+Naming/AccessorMethodName:
+  Enabled: false
+
+Naming/VariableNumber:
+  Enabled: false
+
+Naming/PredicateName:
+  Enabled: false
+
+Naming/FileName:
+  Exclude:
+    - "lib/*-*.rb"
+
+Naming/MethodName:
+  Enabled: false
+
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
 
 Metrics/MethodLength:
-  Max: 22
+  Enabled: false
 
-Metrics/ClassLength:
-  Max: 150
+Metrics/ModuleLength:
+  Enabled: false
 
-Metrics/AbcSize:
-  Max: 20
+Metrics/ClassLength:
+  Enabled: false
 
 Metrics/BlockLength:
   Enabled: false
 
+Metrics/AbcSize:
+  Max: 36
+
 Metrics/CyclomaticComplexity:
   Enabled: true
-  Max: 10
+  Max: 12
 
-Lint/BooleanSymbol:
+Metrics/PerceivedComplexity:
+  Max: 14
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Style/AccessorGrouping:
+  Enabled: false
+
+Style/ExponentialNotation:
+  Enabled: false
+
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
   Enabled: false
 
 Style/AccessModifierDeclarations:
   Enabled: false
 
-Style/BlockDelimiters:
+Style/Alias:
+  Enabled: true
+  EnforcedStyle: prefer_alias_method
+
+Style/AsciiComments:
   Enabled: false
 
-Layout/IndentFirstArrayElement:
-  EnforcedStyle: consistent
+Style/BlockDelimiters:
+  Enabled: false
 
 Style/ClassAndModuleChildren:
-  Exclude:
-    - "spec/**/*_spec.rb"
+  Enabled: false
 
-Lint/HandleExceptions:
-  Exclude:
-    - "spec/spec_helper.rb"
+Style/ConditionalAssignment:
+  Enabled: false
 
-Naming/PredicateName:
+Style/DateTime:
   Enabled: false
 
-Naming/FileName:
-  Exclude:
-    - "lib/rom-*.rb"
+Style/Documentation:
+  Enabled: false
+
+Style/EachWithObject:
+  Enabled: false
+
+Style/FormatString:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/Lambda:
+  Enabled: false
+
+Style/LambdaCall:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/StabbyLambdaParentheses:
+  Enabled: false
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+  ConsistentQuotesInMultiline: false
+
+Style/StringLiteralsInInterpolation:
+  Enabled: true
+  EnforcedStyle: double_quotes
 
 Style/SymbolArray:
-  Exclude:
-    - "spec/**/*_spec.rb"
+  Enabled: false
 
-Style/ConditionalAssignment:
+Style/OptionalBooleanParameter:
   Enabled: false
 
-Naming/MethodName:
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
+
+Style/TrailingUnderscoreVariable:
+  Enabled: false
+
+Style/MultipleComparison:
+  Enabled: false
+
+Style/StringConcatenation:
+  Enabled: false
+
+Style/OpenStructUse:
+  Enabled: false
+
+Style/MapToHash:
+  Enabled: false
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/StructInheritance:
+  Enabled: false
+
+Style/PreferredHashMethods:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/MissingRespondToMissing:
+  Enabled: false
+
+Style/CombinableLoops:
   Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,50 @@
+<!--- DO NOT EDIT THIS FILE - IT'S AUTOMATICALLY GENERATED VIA DEVTOOLS --->
+
+## 0.11.0 2022-11-11
+
+### Fixed
+
+- Support for plural Faker generators (@wuarmin)
+
+### Added
+
+- Support for one-to-one associations (@ianks)
+- [internal] cache for Faker constants (@flash-gordon)
+
+### Changed
+
+- [BREAKING] attributes are always passed as keywords (@alassek)
+  This may affect your code in places where attributes are passed as hashes.
+  Places like
+
+  ```ruby
+  user_attributes = { name: 'Jane' }
+  Factory[:user, user_attributes]
+  ```
+  must be updated to
+  ```ruby
+  user_attributes = { name: 'Jane' }
+  Factory[:user, **user_attributes]
+  ```
+- Upgraded to the latest versions of dry-rb dependencies, compatible with rom 5.3 (@flash-gordon)
+- Support for Faker 1.x was dropped (@alassek)
+
+
+[Compare v0.10.2...v0.11.0](https://github.com/rom-rb/rom-factory/compare/v0.10.2...v0.11.0)
+
+## 0.10.2 2020-04-05
+
+
+### Fixed
+
+- Fix more keyword warnings (@flash-gordon)
+
+
+[Compare v0.10.1...v0.10.2](https://github.com/rom-rb/rom-factory/compare/v0.10.1...v0.10.2)
+
 ## 0.10.1 2019-12-28
 
+
 ### Added
 
 - Support for faker 2 (@ianks)
@@ -8,13 +53,15 @@
 
 - Keyword warnings reported by Ruby 2.7 (@flash-gordon)
 
+
 [Compare v0.10.0...v0.10.1](https://github.com/rom-rb/rom-factory/compare/v0.10.0...v0.10.1)
 
 ## 0.10.0 2019-12-11
 
+
 ### Added
 
-* `struct_namespace` option is supported by factory builders (@graceful-potato)
+- `struct_namespace` option is supported by factory builders (@graceful-potato)
 
   ``` ruby
   factories.define(:user, struct_namespace: MyApp::Entities) do |f|
@@ -24,98 +71,106 @@
 
 ### Fixed
 
-* Support building structs when child assoc does not define parent (@psparrow)
-* Fixed `TupleEvaluator#struct_attrs` for non-standard output schema (@AMHOL)
+- Support building structs when child assoc does not define parent (@psparrow)
+- Fixed `TupleEvaluator#struct_attrs` for non-standard output schema (@AMHOL)
+
 
 [Compare v0.9.1...v0.10.0](https://github.com/rom-rb/rom-factory/compare/v0.9.1...v0.10.0)
 
 ## 0.9.1 2019-10-23
 
+
 ### Fixed
 
-* Attributes of a struct are no longer accidentally passed to their associations (@psparrow)
+- Attributes of a struct are no longer accidentally passed to their associations (@psparrow)
+
 
 [Compare v0.9.0...v0.9.1](https://github.com/rom-rb/rom-factory/compare/v0.9.0...v0.9.1)
 
 ## 0.9.0 2019-08-12
 
+
 ### Added
 
-* When attributes hash includes unknown attributes, a `ROM::Factory::UnknownAttributeError` will be raised (@rawburt)
+- When attributes hash includes unknown attributes, a `ROM::Factory::UnknownAttributeError` will be raised (@rawburt)
+
 
 [Compare v0.8.0...v0.9.0](https://github.com/rom-rb/rom-factory/compare/v0.8.0...v0.9.0)
 
 ## 0.8.0 2019-04-24
 
+
 ### Fixed
 
-* Loaded association structs are no longer rejected by output schemas (issue #34) (flash-gordon + solnic)
+- Loaded association structs are no longer rejected by output schemas (issue #34) (flash-gordon + solnic)
+
 
 [Compare v0.7.0...v0.8.0](https://github.com/rom-rb/rom-factory/compare/v0.7.0...v0.8.0)
 
 ## 0.7.0 2018-11-17
 
+
 ### Added
 
-* Support for traits (v-kolesnikov)
-* Support building structs with associations (@ianks)
+- Support for traits (v-kolesnikov)
+- Support building structs with associations (@ianks)
 
 ### Fixed
 
-* Overwritten attributes with dependencies (JanaVPetrova)
+- Overwritten attributes with dependencies (JanaVPetrova)
+
 
 [Compare v0.6.0...v0.7.0](https://github.com/rom-rb/rom-factory/compare/v0.6.0...v0.7.0)
 
 ## 0.6.0 2018-01-31
 
+
 ### Added
 
-* Support for factories with custom struct namespaces (solnic)
+- Support for factories with custom struct namespaces (solnic)
 
-### Changed
+### Fixed
 
-* Accessing a factory which is not defined will result in `FactoryNotDefinedError` exception (GustavoCaso + solnic)
+- Using dependent attributes with sequences works correctly, ie `f.sequence(:login) { |i, name| "name-#{i}"}` (solnic)
 
-### Fixed
+### Changed
 
-* Using dependent attributes with sequences works correctly, ie `f.sequence(:login) { |i, name| "name-#{i}"}` (solnic)
+- Accessing a factory which is not defined will result in `FactoryNotDefinedError` exception (GustavoCaso + solnic)
 
 [Compare v0.5.0...v0.6.0](https://github.com/rom-rb/rom-factory/compare/v0.5.0...v0.6.0)
 
 ## 0.5.0 2017-10-24
 
+
 ### Added
 
-* Updated to rom 4.0 (solnic)
-* Support for `has_many` and `has_one` associations (solnic)
-* Support for attributes depending on values from other attributes (solnic)
-* Support for `rand` inside the generator block (flash-gordon)
+- Updated to rom 4.0 (solnic)
+- Support for `has_many` and `has_one` associations (solnic)
+- Support for attributes depending on values from other attributes (solnic)
+- Support for `rand` inside the generator block (flash-gordon)
 
 ### Changed
 
-* Depends on `rom-core` now (solnic)
+- Depends on `rom-core` now (solnic)
 
 [Compare v0.4.0...v0.5.0](https://github.com/rom-rb/rom-factory/compare/v0.4.0...v0.5.0)
 
-## v0.4.0 2017-03-03
+## 0.4.0 2017-03-03
 
-This is a revamp of the original `rom_factory` gem which adds new features and
 improves internals.
 
 ### Added
 
-* Support for defining multiple factories via `MyFactory = ROM::Factory.configure { |c| ... }` (solnic)
-* Support for builder inheritence via `define(admin: :user) { |f| ... }` (solnic)
-* Support for generating in-memory structs via `MyFactory.structs[:user]` that are not persisted (solnic)
-* Support for `belongs_to` associations via `f.association(:user)` (solnic)
-* New DSL for defining builders `MyFactory.define(:user) { |f| ... }` which infers default relation name (solnic)
-* New factory method `MyFactory#[]` ie `MyFactory[:user, name: "Jane"]` (solnic)
-* New `fake` helper which uses faker gem under the hood ie `f.email { fake(:internet, :email) }` (solnic)
+- Support for defining multiple factories via `MyFactory = ROM::Factory.configure { |c| ... }` (solnic)
+- Support for builder inheritence via `define(admin: :user) { |f| ... }` (solnic)
+- Support for generating in-memory structs via `MyFactory.structs[:user]` that are not persisted (solnic)
+- Support for `belongs_to` associations via `f.association(:user)` (solnic)
+- New DSL for defining builders `MyFactory.define(:user) { |f| ... }` which infers default relation name (solnic)
+- New factory method `MyFactory#[]` ie `MyFactory[:user, name: "Jane"]` (solnic)
+- New `fake` helper which uses faker gem under the hood ie `f.email { fake(:internet, :email) }` (solnic)
 
 ### Changed
 
-* `Rom::Factory::Config.configure` was replaced with `ROM::Factory.configure` (solnic)
-* Global factory config and builders are gone (solnic)
-* Structs are now based on dry-struct (solnic)
-
-[Compare v0.3.1...v0.4.0](https://github.com/rom-rb/rom-factory/compare/v0.3.1...v0.4.0)
+- `Rom::Factory::Config.configure` was replaced with `ROM::Factory.configure` (solnic)
+- Global factory config and builders are gone (solnic)
+- Structs are now based on dry-struct (solnic)

data/CODEOWNERS

@@ -0,0 +1 @@
+* @solnic

data/CODE_OF_CONDUCT.md

@@ -10,4 +10,4 @@ Project maintainers have the right and responsibility to remove, edit, or reject
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.
 
-This Code of Conduct is adapted from the [Contributor Covenant](http:contributor-covenant.org), version 1.0.0, available at [https://www.contributor-covenant.org/version/1/4/code-of-conduct](https://www.contributor-covenant.org/version/1/4/code-of-conduct)
+This Code of Conduct is adapted from the [Contributor Covenant](http:contributor-covenant.org), version 1.4.0, available at [https://www.contributor-covenant.org/version/1/4/code-of-conduct](https://www.contributor-covenant.org/version/1/4/code-of-conduct)

data/CONTRIBUTING.md

@@ -6,11 +6,11 @@ If you found a bug, report an issue and describe what's the expected behavior ve
 
 ## Reporting feature requests
 
-Report a feature request **only after discussing it first on [discourse.rom-rb.org](https://discourse.rom-rb.org)** where it was accepted. Please provide a concise description of the feature, don't link to a discussion thread, and instead summarize what was discussed.
+Report a feature request **only after discussing it first on [discourse.rom-rb.org](https://discourse.rom-rb.org)** where it was accepted. Please provide a concise description of the feature.
 
 ## Reporting questions, support requests, ideas, concerns etc.
 
-**PLEASE DON'T** - use [discourse.rom-rb.org](http://discourse.rom-rb.org) instead.
+**PLEASE DON'T** - use [discourse.rom-rb.org](https://discourse.rom-rb.org) instead.
 
 # Pull Request Guidelines
 
@@ -22,8 +22,8 @@ Other requirements:
 2) Follow the style conventions of the surrounding code. In most cases, this is standard ruby style.
 3) Add API documentation if it's a new feature
 4) Update API documentation if it changes an existing feature
-5) Bonus points for sending a PR to [github.com/rom-rb/rom-rb.org](github.com/rom-rb/rom-rb.org) which updates user documentation and guides
+5) Bonus points for sending a PR which updates user documentation in the `docsite` directory
 
 # Asking for help
 
-If these guidelines aren't helpful, and you're stuck, please post a message on [discourse.rom-rb.org](https://discourse.rom-rb.org) or join [our chat](https://rom-rb.zulipchat.com).
+If these guidelines aren't helpful, and you're stuck, please post a message on [discourse.rom-rb.org](https://discourse.rom-rb.org).

data/Gemfile

@@ -1,39 +1,39 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec
 
-git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
+eval_gemfile "Gemfile.devtools"
 
-gem 'rake', '~> 12.0'
-gem 'rspec', '~> 3.0'
+gem "faker", "~> 2.8"
 
-gem 'rom', github: 'rom-rb/rom', branch: 'master' do
-  gem 'rom-core'
+gem "rspec", "~> 3.0"
+
+git "https://github.com/rom-rb/rom.git", branch: "release-5.3" do
+  gem "rom-core"
+  gem "rom-changeset"
+  gem "rom-repository"
+  gem "rom"
 end
 
 group :test do
-  gem 'rom-sql', github: 'rom-rb/rom-sql', branch: 'master'
-  gem 'inflecto'
-  gem 'pry-byebug', platforms: :mri
-  gem 'pry', platforms: :jruby
-  gem 'codeclimate-test-reporter'
-  gem 'simplecov'
-
-  gem 'pg', '~> 0.21', platforms: [:mri, :truffleruby]
-  gem 'jdbc-postgres', platforms: :jruby
-  gem 'warning'
+  gem "pry", "~> 0.12.0", "<= 0.13"
+  gem "pry-byebug", "~> 3.8", platforms: :ruby
+  gem "rom-sql", github: "rom-rb/rom-sql", branch: "release-3.6"
+
+  gem "jdbc-postgres", platforms: :jruby
+  gem "pg", "~> 0.21", platforms: :ruby
 end
 
 group :tools do
-  gem 'byebug', platform: :mri
-  gem 'redcarpet' # for yard
+  gem "byebug", platform: :mri
+  gem "redcarpet" # for yard
 end
 
 group :benchmarks do
-  gem 'activerecord'
-  gem 'benchmark-ips'
-  gem 'factory_bot'
-  gem 'fabrication'
+  gem "activerecord"
+  gem "benchmark-ips"
+  gem "fabrication"
+  gem "factory_bot"
 end

data/Gemfile.devtools

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+# this file is managed by rom-rb/devtools project
+
+gem "rake", ">= 12.3.3"
+
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
+
+group :test do
+  gem "simplecov", require: false, platforms: :ruby
+  gem "simplecov-cobertura", require: false, platforms: :ruby
+  gem "rexml", require: false
+
+  gem "warning" if RUBY_VERSION >= "2.4.0"
+end
+
+group :tools do
+  # this is the same version that we use on codacy
+  gem "rubocop", "1.26.1"
+end

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2015-2019 rom-rb team
+Copyright (c) 2015-2021 rom-rb team
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in