rollout 2.4.2 → 2.5.0

data/spec/rollout_spec.rb

@@ -2,8 +2,7 @@ require "spec_helper"
 
 RSpec.describe "Rollout" do
   before do
-    @redis   = Redis.new
-    @rollout = Rollout.new(@redis)
+    @rollout = Rollout.new(Redis.current)
   end
 
   describe "when a group is activated" do
@@ -226,6 +225,16 @@ RSpec.describe "Rollout" do
     end
   end
 
+
+  describe 'set a group of users' do
+    it 'should replace the users with the given array' do
+      users = %w(1 2 3 4)
+      @rollout.activate_users(:chat, %w(10 20 30))
+      @rollout.set_users(:chat, users)
+      expect(@rollout.get(:chat).users).to eq(users)
+    end
+  end
+
   describe "activating a feature globally" do
     before do
       @rollout.activate(:chat)
@@ -420,7 +429,8 @@ RSpec.describe "Rollout" do
       expect(feature.to_hash).to eq(
         groups: [:caretakers, :greeters],
         percentage: 10,
-        users: %w(42)
+        users: %w(42),
+        data: {},
       )
 
       feature = @rollout.get(:signup)
@@ -440,7 +450,8 @@ RSpec.describe "Rollout" do
       expect(feature.to_hash).to eq(
         groups: [:caretakers, :greeters].to_set,
         percentage: 10,
-        users: %w(42).to_set
+        users: %w(42).to_set,
+        data: {},
       )
 
       feature = @rollout.get(:signup)
@@ -464,7 +475,8 @@ RSpec.describe "Rollout" do
         expect(@rollout.get(feature).to_hash).to eq(
           percentage: 0,
           users: [],
-          groups: []
+          groups: [],
+          data: {},
         )
       end
     end
@@ -476,7 +488,8 @@ RSpec.describe "Rollout" do
         expect(@rollout.get(feature).to_hash).to eq(
           percentage: 0,
           users: Set.new,
-          groups: Set.new
+          groups: Set.new,
+          data: {},
         )
       end
     end
@@ -595,6 +608,12 @@ RSpec.describe "Rollout" do
       expect(features[2].percentage).to eq 100
       expect(features.size).to eq 3
     end
+
+    describe 'when given feature keys is empty' do
+      it 'returns empty array' do
+        expect(@rollout.multi_get(*[])).to match_array([])
+      end
+    end
   end
 
   describe "#set_feature_data" do

data/spec/spec_helper.rb

@@ -1,18 +1,27 @@
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+# frozen_string_literal: true
 
-require "simplecov"
-require "rspec"
-require ENV["USE_REAL_REDIS"] == "true" ? "redis" : "fakeredis"
+require 'simplecov'
 
-SimpleCov.start do
-  formatter SimpleCov::Formatter::MultiFormatter.new([
-    SimpleCov::Formatter::HTMLFormatter,
-  ])
-end
+SimpleCov.start
+
+require 'bundler/setup'
+require 'redis'
+require 'rollout'
 
-require "rollout"
+Redis.current = Redis.new(
+  host: ENV.fetch('REDIS_HOST', '127.0.0.1'),
+  port: ENV.fetch('REDIS_PORT', '6379'),
+  db: ENV.fetch('REDIS_DB', '7'),
+)
 
 RSpec.configure do |config|
-  config.before { Redis.new.flushdb }
+  config.example_status_persistence_file_path = '.rspec_status'
+
+  # config.disable_monkey_patching!
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+
+  config.before { Redis.current.flushdb }
 end

metadata

@@ -1,113 +1,113 @@
 --- !ruby/object:Gem::Specification
 name: rollout
 version: !ruby/object:Gem::Version
-  version: 2.4.2
+  version: 2.5.0
 platform: ruby
 authors:
 - James Golick
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-30 00:00:00.000000000 Z
+date: 2020-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: '4.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.17'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: redis
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: fakeredis
+  name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.4'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.71'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.71'
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.17'
 description: Feature flippers with redis.
 email:
 - jamesgolick@gmail.com
@@ -115,21 +115,21 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".document"
+- ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
-- Appraisals
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
-- gemfiles/redis_3.gemfile
-- gemfiles/redis_4.gemfile
 - lib/rollout.rb
+- lib/rollout/feature.rb
+- lib/rollout/logging.rb
 - lib/rollout/version.rb
 - rollout.gemspec
+- spec/rollout/logging_spec.rb
 - spec/rollout_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/FetLife/rollout
@@ -144,18 +144,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Feature flippers with redis.
-test_files:
-- spec/rollout_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/.document

@@ -1,5 +0,0 @@
-README.rdoc
-lib/**/*.rb
-bin/*
-features/**/*.feature
-LICENSE

data/Appraisals

@@ -1,7 +0,0 @@
-appraise "redis-3" do
-  gem "redis", "~> 3.3.2"
-end
-
-appraise "redis-4" do
-  gem "redis", "4.0.0.rc1"
-end

data/Gemfile.lock

@@ -1,56 +0,0 @@
-PATH
-  remote: .
-  specs:
-    rollout (2.4.2)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    appraisal (2.2.0)
-      bundler
-      rake
-      thor (>= 0.14.0)
-    codeclimate-test-reporter (1.0.8)
-      simplecov (<= 0.13)
-    diff-lcs (1.3)
-    docile (1.1.5)
-    fakeredis (0.6.0)
-      redis (~> 3.2)
-    json (2.1.0)
-    rake (12.0.0)
-    redis (3.3.3)
-    rspec (3.6.0)
-      rspec-core (~> 3.6.0)
-      rspec-expectations (~> 3.6.0)
-      rspec-mocks (~> 3.6.0)
-    rspec-core (3.6.0)
-      rspec-support (~> 3.6.0)
-    rspec-expectations (3.6.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-mocks (3.6.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-support (3.6.0)
-    simplecov (0.13.0)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.1)
-    thor (0.19.4)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  appraisal
-  bundler (>= 1.0.0)
-  codeclimate-test-reporter
-  fakeredis
-  redis
-  rollout!
-  rspec
-  simplecov
-
-BUNDLED WITH
-   1.15.1

data/gemfiles/redis_3.gemfile

@@ -1,13 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-if RUBY_VERSION >= '2.0'
-  gem "json"
-else
-  gem "json", "~> 1.8.3"
-end
-
-gem "redis", "~> 3.3.2"
-
-gemspec :path => "../"

data/gemfiles/redis_4.gemfile

@@ -1,13 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-if RUBY_VERSION >= '2.0'
-  gem "json"
-else
-  gem "json", "~> 1.8.3"
-end
-
-gem "redis", "4.0.0.rc1"
-
-gemspec :path => "../"