rollout 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c64885c4cf5254332da642dc02ee9b21aeaa62c8
-  data.tar.gz: 7847a0a450a0641f71b1f47926ce867dc00e40af
+  metadata.gz: 4ba2a7c48e65a966b1b16abcb9efa4469eaadf61
+  data.tar.gz: ac9a3df6b56547de407611ee9f6faecf5b60acca
 SHA512:
-  metadata.gz: 8d673450a953468fbe6ebca47ee985af3499a37627dd1e086f5b018216d6bc2d3c12ffac1a33e2bbc369802d059faff2a69ef8f5899f7a7e10b6750a852ffad3
-  data.tar.gz: 594d9322387a7019ca0f0d34cf8d5c4133181ec960f7dd8749babc1353d978bd326505651f220dd3cf034b46113c7054a7c216f142605001cad43f0938860ffa
+  metadata.gz: 04d929b8f4cd7879140135c48f41a68080be70a6e17f6030657b68acae16f78459adf99a08772e491f64decbfbbcfe717699c2bf27c9cafc95be7acfad6d14d3
+  data.tar.gz: 39a9083e5295d7797a6c4aac21a1736c6df7a121c047f106b160de9400d2272bbf205529cf7f7a479aa922d418d14f0fe362bba896d099f3aa8ad67f1003d6bf

data/.travis.yml

@@ -1,12 +1,16 @@
 language: ruby
+cache: bundler
 sudo: false
 services:
   - redis-server
 rvm:
+  - 2.3.0
   - 2.2
   - 2.1
   - 2.0.0
   - 1.9.3
   - jruby-19mode
+env:
+  - USE_REAL_REDIS=true
 script:
   - bundle exec rspec

data/Gemfile.lock

@@ -1,23 +1,61 @@
 PATH
   remote: .
   specs:
-    rollout (2.2.1)
+    rollout (2.2.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    addressable (2.4.0)
+    builder (3.2.2)
     codeclimate-test-reporter (0.4.8)
       simplecov (>= 0.7.1, < 1.0.0)
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.2.5)
     docile (1.1.5)
+    fakeredis (0.5.0)
+      redis (~> 3.0)
+    faraday (0.9.2)
+      multipart-post (>= 1.2, < 3)
     git (1.2.9.1)
-    jeweler (1.6.4)
-      bundler (~> 1.0)
+    github_api (0.13.1)
+      addressable (~> 2.4.0)
+      descendants_tracker (~> 0.0.4)
+      faraday (~> 0.8, < 0.10)
+      hashie (>= 3.4)
+      multi_json (>= 1.7.5, < 2.0)
+      oauth2
+    hashie (3.4.3)
+    highline (1.7.8)
+    jeweler (2.0.1)
+      builder
+      bundler (>= 1.0)
       git (>= 1.2.5)
+      github_api
+      highline (>= 1.6.15)
+      nokogiri (>= 1.5.10)
       rake
+      rdoc
     json (1.8.3)
-    rake (10.4.2)
-    redis (3.2.1)
+    jwt (1.5.1)
+    mini_portile2 (2.0.0)
+    multi_json (1.11.2)
+    multi_xml (0.5.5)
+    multipart-post (2.0.0)
+    nokogiri (1.6.7.2)
+      mini_portile2 (~> 2.0.0.rc2)
+    oauth2 (1.1.0)
+      faraday (>= 0.8, < 0.10)
+      jwt (~> 1.0, < 1.5.2)
+      multi_json (~> 1.3)
+      multi_xml (~> 0.5)
+      rack (>= 1.2, < 3)
+    rack (1.6.4)
+    rake (10.5.0)
+    rdoc (4.2.2)
+      json (~> 1.4)
+    redis (3.2.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -36,6 +74,7 @@ GEM
       json (~> 1.8)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.0)
+    thread_safe (0.3.5)
 
 PLATFORMS
   ruby
@@ -43,7 +82,8 @@ PLATFORMS
 DEPENDENCIES
   bundler (>= 1.0.0)
   codeclimate-test-reporter
-  jeweler (~> 1.6.4)
+  fakeredis
+  jeweler
   redis
   rollout!
   rspec

data/README.md

@@ -4,6 +4,8 @@ Feature flippers.
 
 [![Build Status](https://travis-ci.org/FetLife/rollout.svg?branch=master)](https://travis-ci.org/FetLife/rollout)
 [![Code Climate](https://codeclimate.com/github/FetLife/rollout/badges/gpa.svg)](https://codeclimate.com/github/FetLife/rollout)
+[![Dependency
+Status](https://gemnasium.com/FetLife/rollout.svg)](https://gemnasium.com/FetLife/rollout)
 [//]: # ([![Test Coverage](https://codeclimate.com/github/FetLife/rollout/badges/coverage.svg)](https://codeclimate.com/github/FetLife/rollout/coverage))
 
 ## MAKE SURE TO READ THIS: 2.X Changes and Migration Path
@@ -17,17 +19,6 @@ This also has the effect of rollout no longer being dependent on redis. Just
 give it something that responds to `set(key,value)`, `get(key)` and
 `del(key)`.
 
-If you have been using the 1.x format, you can initialize Rollout with
-`migrate: true` and it'll do its best to automatically migrate your old
-features to the new format. There will be some performance impact, but it
-should be limited and short-lived since each feature only needs to get
-migrated once.
-
-## Rollout::Legacy
-
-If you'd prefer to continue to use the old layout in redis, `Rollout::Legacy`
-is a copy and paste of the old code :-).
-
 ## Install it
 
 ```bash
@@ -138,7 +129,21 @@ $rollout = Rollout.new($redis, randomize_percentage: true)
 When on `randomize_percentage` will make sure that 50% of users for feature A
 are selected independently from users for feature B.
 
-## Feature is broken
+## Global actions
+
+While groups can come in handy, the actual global setter for a feature does not require a group to be passed.
+
+```ruby
+$rollout.activate(:chat)
+```
+
+In that case you can check the global availability of a feature using the following
+
+```ruby
+$rollout.active?(:chat)
+```
+
+And if something is wrong you can set a feature off for everybody using
 
 Deactivate everybody at once:
 

data/lib/rollout.rb

@@ -1,5 +1,4 @@
 require "rollout/version"
-require "rollout/legacy"
 require "zlib"
 require "set"
 
@@ -50,13 +49,13 @@ class Rollout
     end
 
     def active?(rollout, user)
-      if user.nil?
-        @percentage == 100
-      else
+      if user
         id = user_id(user)
         user_in_percentage?(id) ||
           user_in_active_users?(id) ||
             user_in_active_group?(user, rollout)
+      else
+        @percentage == 100
       end
     end
 

data/lib/rollout/version.rb

@@ -1,3 +1,3 @@
 class Rollout
-  VERSION = "2.2.1"
+  VERSION = "2.2.2"
 end

data/rollout.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.email       = ["jamesgolick@gmail.com"]
   s.description = "Feature flippers with redis."
   s.summary = "Feature flippers with redis."
-  s.homepage = "https://github.com/jamesgolick/rollout"
+  s.homepage = "https://github.com/FetLife/rollout"
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
@@ -18,7 +18,8 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency "rspec"
   s.add_development_dependency "bundler", ">= 1.0.0"
-  s.add_development_dependency "jeweler", "~> 1.6.4"
+  s.add_development_dependency "jeweler"
   s.add_development_dependency "redis"
+  s.add_development_dependency "fakeredis"
   s.add_development_dependency "codeclimate-test-reporter"
 end

data/spec/rollout_spec.rb

@@ -417,37 +417,6 @@ RSpec.describe "Rollout" do
     end
   end
 
-  describe "migration mode" do
-    before do
-      @legacy = Rollout::Legacy.new(@redis)
-      @legacy.activate_percentage(:chat, 12)
-      @legacy.activate_user(:chat, double(id: 42))
-      @legacy.activate_user(:chat, double(id: 24))
-      @legacy.activate_group(:chat, :dope_people)
-      @rollout = Rollout.new(@redis, migrate: true)
-    end
-
-    it "imports the settings from the legacy rollout once" do
-      expect(@rollout.get(:chat).to_hash).to eq({
-        percentage: 12,
-        users: %w(24 42),
-        groups: [:dope_people]
-      })
-      @legacy.deactivate_all(:chat)
-      expect(@rollout.get(:chat).to_hash).to eq({
-        percentage: 12,
-        users: %w(24 42).to_set,
-        groups: [:dope_people].to_set
-      })
-      expect(@redis.get("feature:chat")).not_to be_nil
-    end
-
-    it "imports settings that were globally activated" do
-      @legacy.activate_globally(:video_chat)
-      expect(@rollout.get(:video_chat).to_hash[:percentage]).to eq(100)
-    end
-  end
-
   describe "#feature_states" do
     let(:user_double) { double(id: 7) }
 

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require "rollout"
 require "rspec"
-require "redis"
+require ENV["USE_REAL_REDIS"] == "true" ? "redis" : "fakeredis"
 require "codeclimate-test-reporter"
 
 SimpleCov.start do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollout
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - James Golick
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-21 00:00:00.000000000 Z
+date: 2016-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -42,16 +42,16 @@ dependencies:
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.4
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.4
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: fakeredis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -96,13 +110,11 @@ files:
 - LICENSE
 - README.md
 - lib/rollout.rb
-- lib/rollout/legacy.rb
 - lib/rollout/version.rb
 - rollout.gemspec
-- spec/legacy_spec.rb
 - spec/rollout_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/jamesgolick/rollout
+homepage: https://github.com/FetLife/rollout
 licenses: []
 metadata: {}
 post_install_message: 
@@ -126,6 +138,5 @@ signing_key:
 specification_version: 4
 summary: Feature flippers with redis.
 test_files:
-- spec/legacy_spec.rb
 - spec/rollout_spec.rb
 - spec/spec_helper.rb

data/lib/rollout/legacy.rb

@@ -1,134 +0,0 @@
-class Rollout
-  class Legacy
-    def initialize(redis)
-      @redis  = redis
-      @groups = {"all" => lambda { |user| true }}
-    end
-
-    def activate_globally(feature)
-      @redis.sadd(global_key, feature)
-    end
-
-    def deactivate_globally(feature)
-      @redis.srem(global_key, feature)
-    end
-
-    def activate_group(feature, group)
-      @redis.sadd(group_key(feature), group)
-    end
-
-    def deactivate_group(feature, group)
-      @redis.srem(group_key(feature), group)
-    end
-
-    def deactivate_all(feature)
-      @redis.del(group_key(feature))
-      @redis.del(user_key(feature))
-      @redis.del(percentage_key(feature))
-      deactivate_globally(feature)
-    end
-
-    def activate_user(feature, user)
-      @redis.sadd(user_key(feature), user.id)
-    end
-
-    def deactivate_user(feature, user)
-      @redis.srem(user_key(feature), user.id)
-    end
-
-    def define_group(group, &block)
-      @groups[group.to_s] = block
-    end
-
-    def active?(feature, user = nil)
-      if user
-        active_globally?(feature) ||
-          user_in_active_group?(feature, user) ||
-            user_active?(feature, user) ||
-              user_within_active_percentage?(feature, user)
-      else
-        active_globally?(feature)
-      end
-    end
-
-    def activate_percentage(feature, percentage)
-      @redis.set(percentage_key(feature), percentage)
-    end
-
-    def deactivate_percentage(feature)
-      @redis.del(percentage_key(feature))
-    end
-
-    def info(feature = nil)
-      if feature
-        {
-          :percentage => (active_percentage(feature) || 0).to_i,
-          :groups     => active_groups(feature).map { |g| g.to_sym },
-          :users      => active_user_ids(feature),
-          :global     => active_global_features
-        }
-      else
-        {
-          :global     => active_global_features
-        }
-      end
-    end
-
-    private
-      def key(name)
-        "feature:#{name}"
-      end
-
-      def group_key(name)
-        "#{key(name)}:groups"
-      end
-
-      def user_key(name)
-        "#{key(name)}:users"
-      end
-
-      def percentage_key(name)
-        "#{key(name)}:percentage"
-      end
-
-      def global_key
-        "feature:__global__"
-      end
-
-      def active_groups(feature)
-        @redis.smembers(group_key(feature)) || []
-      end
-
-      def active_user_ids(feature)
-        @redis.smembers(user_key(feature)).map { |id| id.to_i }
-      end
-
-      def active_global_features
-        (@redis.smembers(global_key) || []).map(&:to_sym)
-      end
-
-      def active_percentage(feature)
-        @redis.get(percentage_key(feature))
-      end
-
-      def active_globally?(feature)
-        @redis.sismember(global_key, feature)
-      end
-
-      def user_in_active_group?(feature, user)
-        active_groups(feature).any? do |group|
-          @groups.key?(group) && @groups[group].call(user)
-        end
-      end
-
-      def user_active?(feature, user)
-        @redis.sismember(user_key(feature), user.id)
-      end
-
-      def user_within_active_percentage?(feature, user)
-        percentage = active_percentage(feature)
-        return false if percentage.nil?
-        user.id % 100 < percentage.to_i
-      end
-  end
-end

data/spec/legacy_spec.rb

@@ -1,221 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "Rollout::Legacy" do
-  before do
-    @redis   = Redis.new
-    @rollout = Rollout::Legacy.new(@redis)
-  end
-
-  describe "when a group is activated" do
-    before do
-      @rollout.define_group(:fivesonly) { |user| user.id == 5 }
-      @rollout.activate_group(:chat, :fivesonly)
-    end
-
-    it "the feature is active for users for which the block evaluates to true" do
-      expect(@rollout).to be_active(:chat, double(id: 5))
-    end
-
-    it "is not active for users for which the block evaluates to false" do
-      expect(@rollout).not_to be_active(:chat, double(id: 1))
-    end
-
-    it "is not active if a group is found in Redis but not defined in Rollout" do
-      @rollout.activate_group(:chat, :fake)
-      expect(@rollout).not_to be_active(:chat, double(id: 1))
-    end
-  end
-
-  describe "the default all group" do
-    before do
-      @rollout.activate_group(:chat, :all)
-    end
-
-    it "evaluates to true no matter what" do
-      expect(@rollout).to be_active(:chat, double(id: 0))
-    end
-  end
-
-  describe "deactivating a group" do
-    before do
-      @rollout.define_group(:fivesonly) { |user| user.id == 5 }
-      @rollout.activate_group(:chat, :all)
-      @rollout.activate_group(:chat, :fivesonly)
-      @rollout.deactivate_group(:chat, :all)
-    end
-
-    it "deactivates the rules for that group" do
-      expect(@rollout).not_to be_active(:chat, double(id: 10))
-    end
-
-    it "leaves the other groups active" do
-      expect(@rollout).to be_active(:chat, double(id: 5))
-    end
-  end
-
-  describe "deactivating a feature completely" do
-    before do
-      @rollout.define_group(:fivesonly) { |user| user.id == 5 }
-      @rollout.activate_group(:chat, :all)
-      @rollout.activate_group(:chat, :fivesonly)
-      @rollout.activate_user(:chat, double(id: 51))
-      @rollout.activate_percentage(:chat, 100)
-      @rollout.activate_globally(:chat)
-      @rollout.deactivate_all(:chat)
-    end
-
-    it "removes all of the groups" do
-      expect(@rollout).not_to be_active(:chat, double(id: 0))
-    end
-
-    it "removes all of the users" do
-      expect(@rollout).not_to be_active(:chat, double(id: 51))
-    end
-
-    it "removes the percentage" do
-      expect(@rollout).not_to be_active(:chat, double(id: 24))
-    end
-
-    it "removes globally" do
-      expect(@rollout).not_to be_active(:chat)
-    end
-  end
-
-  describe "activating a specific user" do
-    before do
-      @rollout.activate_user(:chat, double(id: 42))
-    end
-
-    it "is active for that user" do
-      expect(@rollout).to be_active(:chat, double(id: 42))
-    end
-
-    it "remains inactive for other users" do
-      expect(@rollout).not_to be_active(:chat, double(id: 24))
-    end
-  end
-
-  describe "deactivating a specific user" do
-    before do
-      @rollout.activate_user(:chat, double(id: 42))
-      @rollout.activate_user(:chat, double(id: 24))
-      @rollout.deactivate_user(:chat, double(id: 42))
-    end
-
-    it "that user should no longer be active" do
-      expect(@rollout).not_to be_active(:chat, double(id: 42))
-    end
-
-    it "remains active for other active users" do
-      expect(@rollout).to be_active(:chat, double(id: 24))
-    end
-  end
-
-  describe "activating a feature globally" do
-    before do
-      @rollout.activate_globally(:chat)
-    end
-
-    it "activates the feature" do
-      expect(@rollout).to be_active(:chat)
-    end
-  end
-
-  describe "activating a feature for a percentage of users" do
-    before do
-      @rollout.activate_percentage(:chat, 20)
-    end
-
-    it "activates the feature for that percentage of the users" do
-      expect((1..120).select { |id| @rollout.active?(:chat, double(id: id)) }.length).to eq(39)
-    end
-  end
-
-  describe "activating a feature for a percentage of users" do
-    before do
-      @rollout.activate_percentage(:chat, 20)
-    end
-
-    it "activates the feature for that percentage of the users" do
-      expect((1..200).select { |id| @rollout.active?(:chat, double(id: id)) }.length).to eq(40)
-    end
-  end
-
-  describe "activating a feature for a percentage of users" do
-    before do
-      @rollout.activate_percentage(:chat, 5)
-    end
-
-    it "activates the feature for that percentage of the users" do
-      expect((1..100).select { |id| @rollout.active?(:chat, double(id: id)) }.length).to eq(5)
-    end
-  end
-
-
-  describe "deactivating the percentage of users" do
-    before do
-      @rollout.activate_percentage(:chat, 100)
-      @rollout.deactivate_percentage(:chat)
-    end
-
-    it "becomes inactivate for all users" do
-      expect(@rollout).not_to be_active(:chat, double(id: 24))
-    end
-  end
-
-  describe "deactivating the feature globally" do
-    before do
-      @rollout.activate_globally(:chat)
-      @rollout.deactivate_globally(:chat)
-    end
-
-    it "becomes inactivate" do
-      expect(@rollout).not_to be_active(:chat)
-    end
-  end
-
-  describe "#info" do
-    context "global features" do
-      let(:features) { [:signup, :chat, :table] }
-
-      before do
-        features.each do |f|
-          @rollout.activate_globally(f)
-        end
-      end
-
-      it "returns all global features" do
-        expect(@rollout.info[:global]).to include(*features)
-      end
-    end
-
-    describe "with a percentage set" do
-      before do
-        @rollout.activate_percentage(:chat, 10)
-        @rollout.activate_group(:chat, :caretakers)
-        @rollout.activate_group(:chat, :greeters)
-        @rollout.activate_globally(:signup)
-        @rollout.activate_user(:chat, double(id: 42))
-      end
-
-      it "returns info about all the activations" do
-        info = @rollout.info(:chat)
-        expect(info[:percentage]).to eq(10)
-        expect(info[:groups]).to include(:caretakers, :greeters)
-        expect(info[:users]).to include(42)
-        expect(info[:global]).to include(:signup)
-      end
-    end
-
-    describe "without a percentage set" do
-      it "defaults to 0" do
-        expect(@rollout.info(:chat)).to eq(
-          percentage: 0,
-          groups: [],
-          users: [],
-          global: [],
-        )
-      end
-    end
-  end
-end