rollout 2.0.0a → 2.0.0b

data/.gitignore

@@ -17,5 +17,6 @@ tmtags
 coverage
 rdoc
 pkg
+*.gem
 
 ## PROJECT::SPECIFIC

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rollout (1.2.0)
+    rollout (2.0.0a)
       redis
 
 GEM
@@ -18,7 +18,7 @@ GEM
     mocha (0.9.8)
       rake
     rake (0.9.2.2)
-    redis (2.2.2)
+    redis (3.0.2)
     rspec (2.10.0)
       rspec-core (~> 2.10.0)
       rspec-expectations (~> 2.10.0)

data/README.rdoc

@@ -4,15 +4,15 @@ Feature flippers.
 
 == MAKE SURE TO READ THIS: 2.0 Changes and Migration Path
 
-  As of rollout-2.x, only one key is used per feature for performance reasons. The data format is `percentage|user_id,user_id,...|group,_group...`. This has the effect of making concurrent feature modifications unsafe, but in practice, I doubt this will actually be a problem.
+As of rollout-2.x, only one key is used per feature for performance reasons. The data format is <tt>percentage|user_id,user_id,...|group,_group...</tt>. This has the effect of making concurrent feature modifications unsafe, but in practice, I doubt this will actually be a problem.
 
-  This also has the effect of rollout no longer being dependent on redis. Just give it something that responds to `set(key,value)` and `get(key)`
+This also has the effect of rollout no longer being dependent on redis. Just give it something that responds to <tt>set(key,value)</tt> and <tt>get(key)</tt>.
 
-  If you have been using the 1.x format, you can initialize Rollout with `:migrate => true` and it'll do its best to automatically migrate your old features to the new format. There will be some performance impact, but it should be limited and short-lived since each feature only needs to get migrated once.
+If you have been using the 1.x format, you can initialize Rollout with <tt>:migrate => true</tt> and it'll do its best to automatically migrate your old features to the new format. There will be some performance impact, but it should be limited and short-lived since each feature only needs to get migrated once.
 
 == Rollout::Legacy
 
-  If you'd prefer to continue to use the old layout in redis, `Rollout::Legacy` is a copy and paste of the old code :-).
+If you'd prefer to continue to use the old layout in redis, <tt>Rollout::Legacy</tt> is a copy and paste of the old code :-).
 
 == Install it
 

data/lib/rollout.rb

@@ -26,7 +26,7 @@ class Rollout
     end
 
     def remove_user(user)
-      @users.delete(user.id)
+      @users.delete(user.id.to_i)
     end
 
     def add_group(group)
@@ -34,7 +34,7 @@ class Rollout
     end
 
     def remove_group(group)
-      @groups.delete(group)
+      @groups.delete(group.to_sym)
     end
 
     def clear

data/lib/rollout/version.rb

@@ -1,3 +1,3 @@
 class Rollout
-  VERSION = "2.0.0a"
+  VERSION = "2.0.0b"
 end

data/spec/rollout_spec.rb

@@ -40,8 +40,10 @@ describe "Rollout" do
     before do
       @rollout.define_group(:fivesonly) { |user| user.id == 5 }
       @rollout.activate_group(:chat, :all)
+      @rollout.activate_group(:chat, :some)
       @rollout.activate_group(:chat, :fivesonly)
       @rollout.deactivate_group(:chat, :all)
+      @rollout.deactivate_group(:chat, "some")
     end
 
     it "deactivates the rules for that group" do
@@ -49,7 +51,7 @@ describe "Rollout" do
     end
 
     it "leaves the other groups active" do
-      @rollout.should be_active(:chat, stub(:id => 5))
+      @rollout.get(:chat).groups.should == [:fivesonly]
     end
   end
 
@@ -98,8 +100,10 @@ describe "Rollout" do
   describe "deactivating a specific user" do
     before do
       @rollout.activate_user(:chat, stub(:id => 42))
+      @rollout.activate_user(:chat, stub(:id => 4242))
       @rollout.activate_user(:chat, stub(:id => 24))
       @rollout.deactivate_user(:chat, stub(:id => 42))
+      @rollout.deactivate_user(:chat, stub(:id => "4242"))
     end
 
     it "that user should no longer be active" do
@@ -107,7 +111,7 @@ describe "Rollout" do
     end
 
     it "remains active for other active users" do
-      @rollout.should be_active(:chat, stub(:id => 24))
+      @rollout.get(:chat).users.should == [24]
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rollout
 version: !ruby/object:Gem::Version
-  version: 2.0.0a
+  version: 2.0.0b
   prerelease: 5
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70240073640980 !ruby/object:Gem::Requirement
+  requirement: &70157179413940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 2.10.0
   type: :development
   prerelease: false
-  version_requirements: *70240073640980
+  version_requirements: *70157179413940
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70240073640480 !ruby/object:Gem::Requirement
+  requirement: &70157179413360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70240073640480
+  version_requirements: *70157179413360
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70240073640020 !ruby/object:Gem::Requirement
+  requirement: &70157179412840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.6.4
   type: :development
   prerelease: false
-  version_requirements: *70240073640020
+  version_requirements: *70157179412840
 - !ruby/object:Gem::Dependency
   name: bourne
-  requirement: &70240073639560 !ruby/object:Gem::Requirement
+  requirement: &70157179412320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -54,10 +54,10 @@ dependencies:
         version: '1.0'
   type: :development
   prerelease: false
-  version_requirements: *70240073639560
+  version_requirements: *70157179412320
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70240073639100 !ruby/object:Gem::Requirement
+  requirement: &70157179411820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -65,10 +65,10 @@ dependencies:
         version: 0.9.8
   type: :development
   prerelease: false
-  version_requirements: *70240073639100
+  version_requirements: *70157179411820
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &70240073638720 !ruby/object:Gem::Requirement
+  requirement: &70157179411400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70240073638720
+  version_requirements: *70157179411400
 description: Feature flippers with redis.
 email:
 - jamesgolick@gmail.com