rollout 0.2.0 → 0.2.1

data/README.rdoc

@@ -73,6 +73,22 @@ Deactivate everybody at once:
 
 For some of our less stable features, we are actually measuring the error rate using redis, and deactivating them automatically when it raises above a certain threshold. It's pretty cool. See http://github.com/jamesgolick/degrade for the failure detection code.
 
+== Namespacing
+
+Rollout separates its keys from other keys on the Redis server using the "feature" keyspace.
+
+You can namespace keys further to support multiple environments by using the http://github.com/defunkt/redis-namespace gem.
+
+  $ns = Redis::Namespace.new(Rails.env, :redis => $redis)
+  $rollout = Rollout.new($ns)
+  $rollout.activate_group(:chat, :all)
+  
+This example would use the "development:feature:chat:groups" key.
+
+== Implementations in other languages
+
+* Python: http://github.com/asenchi/proclaim
+
 == Note on Patches/Pull Requests
  
 * Fork the project.

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.2.1

data/lib/rollout.rb

@@ -62,7 +62,7 @@ class Rollout
     end
 
     def user_in_active_group?(feature, user)
-      @redis.smembers(group_key(feature)).any? { |group| @groups[group].call(user) }
+      @redis.smembers(group_key(feature)).any? { |group| @groups.key?(group) && @groups[group].call(user) }
     end
 
     def user_active?(feature, user)
@@ -72,7 +72,6 @@ class Rollout
     def user_within_active_percentage?(feature, user)
       percentage = @redis.get(percentage_key(feature))
       return false if percentage.nil?
-
-      user.id % 10 < percentage.to_i / 10
+      user.id % 100 < percentage.to_i
     end
 end

data/rollout.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rollout}
-  s.version = "0.2.0"
+  s.version = "0.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Golick"]
-  s.date = %q{2010-07-18}
+  s.date = %q{2010-10-15}
   s.description = %q{Conditionally roll out features with redis.}
   s.email = %q{jamesgoick@gmail.com}
   s.extra_rdoc_files = [

data/spec/rollout_spec.rb

@@ -19,6 +19,11 @@ describe "Rollout" do
     it "is not active for users for which the block evaluates to false" do
       @rollout.should_not be_active(:chat, stub(:id => 1))
     end
+
+    it "is not active if a group is found in Redis but not defined in Rollout" do
+      @rollout.activate_group(:chat, :fake)
+      @rollout.should_not be_active(:chat, stub(:id => 1))
+    end
   end
 
   describe "the default all group" do
@@ -107,10 +112,31 @@ describe "Rollout" do
     end
 
     it "activates the feature for that percentage of the users" do
-      (1..120).select { |id| @rollout.active?(:chat, stub(:id => id)) }.length.should == 24
+      (1..120).select { |id| @rollout.active?(:chat, stub(:id => id)) }.length.should == 39
     end
   end
 
+  describe "activating a feature for a percentage of users" do
+    before do
+      @rollout.activate_percentage(:chat, 20)
+    end
+
+    it "activates the feature for that percentage of the users" do
+      (1..200).select { |id| @rollout.active?(:chat, stub(:id => id)) }.length.should == 40
+    end
+  end
+
+  describe "activating a feature for a percentage of users" do
+    before do
+      @rollout.activate_percentage(:chat, 5)
+    end
+
+    it "activates the feature for that percentage of the users" do
+      (1..100).select { |id| @rollout.active?(:chat, stub(:id => id)) }.length.should == 5
+    end
+  end
+
+
   describe "deactivating the percentage of users" do
     before do
       @rollout.activate_percentage(:chat, 100)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rollout
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 2
-  - 0
-  version: 0.2.0
+  - 1
+  version: 0.2.1
 platform: ruby
 authors: 
 - James Golick
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-07-18 00:00:00 -07:00
+date: 2010-10-15 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency