rollbar 2.18.2 → 2.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc9f32ab8c6d24f72b8c9da57f175524f7942f39
-  data.tar.gz: f46f2f866b7a0049ce8a0e2d2e5af6763bed93dc
+  metadata.gz: cbabec796ebc75cdf994e05081fe2f29f2613fc3
+  data.tar.gz: 8f6e293f90b0d3840f8168a1b181fde56fcf8bd8
 SHA512:
-  metadata.gz: 6f7c1ac02748f5b3c669fe694ecb9989c6cc941ab6321cc4a3faa4f6ad9f28ebe9efedf1add9b1fad7ba328561921a0d456c8ed2bdfb3feb2e773baebbece73d
-  data.tar.gz: 111635866796fc71e1cb6e261661d6c7094a19afabbb591aec0690bf9927bd00cedca2470fdd8544fd62d9d3a1f35f23a63c6ef904e1a31f089d0f2d5a8fced6
+  metadata.gz: cdab38d35f1e2461172cc10883e821d59879a0eb8cef1be4d26c318341dce9ece1e15d9d3f8e1d44c8ab72a82958be6629713622c45fe5934cbefa5e02a7bdfe
+  data.tar.gz: 3d0050f93cd0e855031aa00115f3cf6050be92cb65b64c30978be49e19cd6b07c5dd871c56fff66e881f62b596f7aa29c1ea4f217e266d3a94194ff2980d683e

data/.rubocop.yml

@@ -8,9 +8,15 @@ Style/HashSyntax:
   SupportedStyles:
     - hash_rockets
 
+Style/SymbolArray:
+  Enabled: false # %i[] syntax isn't 1.9.x compatible
+
 Metrics/LineLength:
   Max: 1000
 
+Metrics/MethodLength:
+  Max: 15 # Relax slightly from the default of 10
+
 Style/DoubleNegation:
   Enabled: false
 
@@ -19,3 +25,12 @@ Style/Lambda:
 
 Style/EachWithObject:
   Enabled: false
+
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context'] # RSpec DSL is expected to have long blocks.
+
+Style/ExpandPathArguments:
+  Enabled: false # syntax requires Ruby >= 2.0
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false # rubocop compares to gemspec, yet won't allow 1.9 as minimum version

data/.travis.yml

@@ -4,23 +4,55 @@ services:
 language: ruby
 # Broken bundler on travis CI - https://github.com/bundler/bundler/issues/2784
 before_install:
-  - gem update --system 2.1.11
+  - gem update --system 2.7.7
   - gem --version
-  - gem install bundler
+  - gem install bundler -v 1.6.1
   - bundle --version
+
 rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
   - 2.2.2
-  - jruby-18mode
-  - jruby-19mode
+  - 2.3.0
+  - 2.3.8
+  - 2.4.5
+  - 2.5.3
+  - 2.6.0
   - rbx
+  - jruby-9.1.9.0
+  #
+  # # About legacy JRuby
+  #
+  # Legacy JRubies (jruby-18mode, jruby-19mode) have been disabled for some time by
+  # listing all possible targets in either the exclude or allow_failures sections.
+  # I have taken a look at getting them running, and have found that no valid
+  # combination of dependencies is possible for Rails 3.0 and higher. It appears
+  # Rails 2.2 is meant to work, though I haven't tried it.
+  #
+  # For Rails 3.0, it is possible to get a working bundle with all gem dependencies,
+  # but the JDBC adapter gem needs an earlier version of ActiveSupport, and it will
+  # fail at runtime.
+  #
+  # For Rails 3.1 and 3.2, Rack 1.3.x and higher require Ruby 2.x, while Rails 3.x will
+  # not accept any 1.2.x version of Rack. Even if this could be resolved, one would
+  # hit the above runtime issue amyway.
+  #
+  # # About current JRuby
+  #
+  # While current JRuby builds aim to be Ruby 2.5.x compatible, the JDBC adapter
+  # gem is constrained to only Rails 5.0, 5.1 and 5.2 at this time. (Old versions
+  # of the gem allow >= Rails 2.2, but in practice it will not work with Rails 3.0
+  # and higher because of the ActiveSupport issue described above.) For as long as
+  # the test suite relies on Rails and SqlLite, it is not possible to include
+  # earlier Rails for JRuby.
+
 jdk:
-  - openjdk6
+  # These are the JDKs currently supported on Travis (Trusty - Ubuntu 14.04)
   - openjdk7
-  - oraclejdk7
+  - openjdk8
   - oraclejdk8
+  - oraclejdk9
 env:
   - ROLLBAR_SSL_CERT_FILE=/home/travis/build/rollbar/rollbar-gem/spec/cacert.pem
 gemfile:
@@ -32,149 +64,177 @@ gemfile:
   - gemfiles/rails42.gemfile
   - gemfiles/rails50.gemfile
   - gemfiles/rails51.gemfile
+  - gemfiles/rails52.gemfile
 matrix:
-  include:
-    - rvm: 1.8.7
-      gemfile: gemfiles/ruby_1_8_and_1_9_2.gemfile
-      jdk: openjdk6
-    - rvm: 1.9.2
-      gemfile: gemfiles/ruby_1_8_and_1_9_2.gemfile
-      jdk: openjdk6
+  include: []
+
   allow_failures:
     - rvm: ruby-head
-    - rvm: jruby-18mode
     - rvm: jruby-head
+    # Ruby 2.6.x is still being eveluated and may have test failures
+    - rvm: 2.6.0
+    # oraclejdk9 has a dependency issue that needs to be investigated
+    - jdk: oraclejdk9
 
-    # NOTE: Allowing this to fail because of some strange error in rspec-core `undefined method `example_group_finished'`.
-    # Seems to work with oraclejdk7.
-    - rvm: jruby-19mode
-      jdk: openjdk7
   exclude:
     # Don't run tests for non-jruby environments with the JDK.
     # NOTE: openjdk7 is missing from these exclusions so that Travis will run at least 1 build for the given rvm.
-    - rvm: 1.8.7
-      jdk: openjdk6
-    - rvm: 1.8.7
-      jdk: oraclejdk7
-    - rvm: 1.8.7
-      jdk: oraclejdk8
-    - rvm: 1.9.2
-      jdk: openjdk6
-    - rvm: 1.9.2
-      jdk: oraclejdk7
-    - rvm: 1.9.2
-      jdk: oraclejdk8
-    - rvm: 1.9.3
-      jdk: openjdk6
     - rvm: 1.9.3
-      jdk: oraclejdk7
+      jdk: openjdk8
     - rvm: 1.9.3
       jdk: oraclejdk8
+    - rvm: 1.9.3
+      jdk: oraclejdk9
     - rvm: 2.0.0
-      jdk: openjdk6
-    - rvm: 2.0.0
-      jdk: oraclejdk7
+      jdk: openjdk8
     - rvm: 2.0.0
       jdk: oraclejdk8
+    - rvm: 2.0.0
+      jdk: oraclejdk9
     - rvm: 2.1.0
-      jdk: openjdk6
-    - rvm: 2.1.0
-      jdk: oraclejdk7
+      jdk: openjdk8
     - rvm: 2.1.0
       jdk: oraclejdk8
+    - rvm: 2.1.0
+      jdk: oraclejdk9
     - rvm: 2.2.2
-      jdk: openjdk6
+      jdk: openjdk8
     - rvm: 2.2.2
-      jdk: oraclejdk7
+      jdk: oraclejdk8
     - rvm: 2.2.2
+      jdk: oraclejdk9
+    - rvm: 2.3.0
+      jdk: openjdk8
+    - rvm: 2.3.0
+      jdk: oraclejdk8
+    - rvm: 2.3.0
+      jdk: oraclejdk9
+    - rvm: 2.3.8
+      jdk: openjdk8
+    - rvm: 2.3.8
+      jdk: oraclejdk8
+    - rvm: 2.3.8
+      jdk: oraclejdk9
+    - rvm: 2.4.5
+      jdk: openjdk8
+    - rvm: 2.4.5
+      jdk: oraclejdk8
+    - rvm: 2.4.5
+      jdk: oraclejdk9
+    - rvm: 2.5.3
+      jdk: openjdk8
+    - rvm: 2.5.3
       jdk: oraclejdk8
+    - rvm: 2.5.3
+      jdk: oraclejdk9
+    - rvm: 2.6.0
+      jdk: openjdk8
+    - rvm: 2.6.0
+      jdk: oraclejdk8
+    - rvm: 2.6.0
+      jdk: oraclejdk9
 
     - rvm: ruby-head
-      jdk: openjdk6
-    - rvm: ruby-head
-      jdk: oraclejdk7
+      jdk: openjdk8
     - rvm: ruby-head
       jdk: oraclejdk8
+    - rvm: ruby-head
+      jdk: oraclejdk9
     - rvm: rbx
-      jdk: openjdk6
-    - rvm: rbx
-      jdk: oraclejdk7
+      jdk: openjdk8
     - rvm: rbx
       jdk: oraclejdk8
+    - rvm: rbx
+      jdk: oraclejdk9
 
-    # TODO: comment as to why these are excluded
-    - rvm: 1.8.7
-      gemfile: gemfiles/rails31.gemfile
-    - rvm: 1.8.7
-      gemfile: gemfiles/rails32.gemfile
-    - rvm: 1.8.7
-      gemfile: gemfiles/rails40.gemfile
-    - rvm: 1.8.7
-      gemfile: gemfiles/rails41.gemfile
-    - rvm: 1.8.7
-      gemfile: gemfiles/rails42.gemfile
-    - rvm: 1.8.7
-      gemfile: gemfiles/rails50.gemfile
-    - rvm: 1.8.7
-      gemfile: gemfiles/rails51.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/rails31.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/rails32.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/rails40.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/rails41.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/rails42.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/rails50.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/rails51.gemfile
+    # Rails 5.x requires Ruby 2.2.2 or higher
     - rvm: 1.9.3
       gemfile: gemfiles/rails50.gemfile
     - rvm: 1.9.3
       gemfile: gemfiles/rails51.gemfile
+    - rvm: 1.9.3
+      gemfile: gemfiles/rails52.gemfile
+    # Rails 5.x requires Ruby 2.2.2 or higher
     - rvm: 2.0.0
       gemfile: gemfiles/rails50.gemfile
     - rvm: 2.0.0
       gemfile: gemfiles/rails51.gemfile
+    - rvm: 2.0.0
+      gemfile: gemfiles/rails52.gemfile
+    # Rails 5.x requires Ruby 2.2.2 or higher
     - rvm: 2.1.0
       gemfile: gemfiles/rails50.gemfile
     - rvm: 2.1.0
       gemfile: gemfiles/rails51.gemfile
+    - rvm: 2.1.0
+      gemfile: gemfiles/rails52.gemfile
+    # MRI 2.2.2 supports Rails 3.2.x and higher
     - rvm: 2.2.2
       gemfile: gemfiles/rails30.gemfile
     - rvm: 2.2.2
       gemfile: gemfiles/rails31.gemfile
-    - rvm: jruby-18mode
+    # MRI 2.3.x supports Rails 4.0.x and higher
+    - rvm: 2.3.0
       gemfile: gemfiles/rails30.gemfile
-    - rvm: jruby-18mode
+    - rvm: 2.3.0
       gemfile: gemfiles/rails31.gemfile
-    - rvm: jruby-18mode
+    - rvm: 2.3.0
       gemfile: gemfiles/rails32.gemfile
-    - rvm: jruby-18mode
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails30.gemfile
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails31.gemfile
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails32.gemfile
+    - rvm: 2.3.8
       gemfile: gemfiles/rails40.gemfile
-    - rvm: jruby-18mode
+    - rvm: 2.3.8
       gemfile: gemfiles/rails41.gemfile
-    - rvm: jruby-18mode
-      gemfile: gemfiles/rails42.gemfile
-    - rvm: jruby-19mode
+    # MRI 2.4.x and higher (e.g. 2.5.x, 2.6.x, etc) supports Rails 4.2.8 and higher
+    # Rails lower than 4.2.8 is incompatible with Ruby 2.4 Integer class
+    - rvm: 2.4.5
       gemfile: gemfiles/rails30.gemfile
-    - rvm: jruby-19mode
+    - rvm: 2.4.5
       gemfile: gemfiles/rails31.gemfile
-    - rvm: jruby-19mode
+    - rvm: 2.4.5
       gemfile: gemfiles/rails32.gemfile
-    - rvm: jruby-19mode
+    - rvm: 2.4.5
       gemfile: gemfiles/rails40.gemfile
-    - rvm: jruby-19mode
+    - rvm: 2.4.5
       gemfile: gemfiles/rails41.gemfile
-    - rvm: jruby-19mode
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails30.gemfile
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails31.gemfile
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails32.gemfile
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails40.gemfile
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails41.gemfile
+    - rvm: 2.6.0
+      gemfile: gemfiles/rails30.gemfile
+    - rvm: 2.6.0
+      gemfile: gemfiles/rails31.gemfile
+    - rvm: 2.6.0
+      gemfile: gemfiles/rails32.gemfile
+    - rvm: 2.6.0
+      gemfile: gemfiles/rails40.gemfile
+    - rvm: 2.6.0
+      gemfile: gemfiles/rails41.gemfile
+    # JRuby JDBC Adapter is only compatible with Rails >= 5.x
+    - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/rails30.gemfile
+    - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/rails31.gemfile
+    - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/rails32.gemfile
+    - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/rails40.gemfile
+    - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/rails41.gemfile
+    - rvm: jruby-9.1.9.0
       gemfile: gemfiles/rails42.gemfile
-    - rvm: jruby-19mode
-      gemfile: gemfiles/rails50.gemfile
-    - rvm: jruby-19mode
-      gemfile: gemfiles/rails51.gemfile
     - rvm: rbx
       gemfile: gemfiles/rails30.gemfile
     - rvm: rbx
@@ -191,3 +251,5 @@ matrix:
       gemfile: gemfiles/rails50.gemfile
     - rvm: rbx
       gemfile: gemfiles/rails51.gemfile
+    - rvm: rbx
+      gemfile: gemfiles/rails52.gemfile

data/Gemfile

@@ -7,23 +7,25 @@ is_jruby = defined?(JRUBY_VERSION) || (defined?(RUBY_ENGINE) && RUBY_ENGINE == '
 gem 'activerecord-jdbcsqlite3-adapter', :platform => :jruby
 gem 'appraisal'
 gem 'jruby-openssl', :platform => :jruby
-gem 'rails', '4.2.7.1'
+gem 'rails', '4.2.8'
 gem 'rake'
 gem 'rspec-rails', '~> 3.4'
-gem 'sqlite3', :platform => [:ruby, :mswin, :mingw]
+gem 'sqlite3', '< 1.4.0', :platform => [:ruby, :mswin, :mingw]
 
 unless is_jruby
-  if RUBY_VERSION >= '2.4.0'
-    gem 'oj', '~> 2.16.1'
+  if RUBY_VERSION >= '2.5'
+    gem 'oj'
+  elsif RUBY_VERSION >= '2.4.0'
+    gem 'oj', '~> 2.16.1' # rubocop:disable Bundler/DuplicatedGem
   else
-    gem 'oj', '~> 2.12.14'
+    gem 'oj', '~> 2.12.14' # rubocop:disable Bundler/DuplicatedGem
   end
 end
 
 if RUBY_VERSION > '1.8.7' && RUBY_VERSION < '2.2.2'
-  gem 'sidekiq', '>= 2.13.0', '< 5.0'
+  gem 'sidekiq', '~> 2.13.0'
 else
-  gem 'sidekiq', '>= 2.13.0'
+  gem 'sidekiq', '>= 2.13.0' # rubocop:disable Bundler/DuplicatedGem
 end
 
 platforms :rbx do
@@ -34,20 +36,24 @@ platforms :rbx do
 end
 
 if RUBY_VERSION.start_with?('1.9')
+  gem 'shoryuken', '>= 4.0.0', '<= 4.0.2'
   gem 'sucker_punch', '~> 1.0'
 elsif RUBY_VERSION.start_with?('2')
-  gem 'sucker_punch', '~> 2.0'
+  gem 'codacy-coverage'
+  gem 'shoryuken' # rubocop:disable Bundler/DuplicatedGem
+  gem 'simplecov'
+  gem 'sucker_punch', '~> 2.0' # rubocop:disable Bundler/DuplicatedGem
 end
 
 gem 'aws-sdk-sqs'
-gem 'database_cleaner', '~> 1.0.0'
+gem 'database_cleaner'
 gem 'delayed_job', :require => false
 gem 'generator_spec'
 gem 'girl_friday', '>= 0.11.1'
 gem 'redis'
-gem 'resque'
-gem 'shoryuken'
+gem 'resque', '< 2.0.0'
+gem 'rspec-command'
+gem 'rubocop', :require => false
 gem 'sinatra'
-gem 'webmock'
-
+gem 'webmock', :require => false
 gemspec

data/README.md

@@ -3,6 +3,12 @@
 [![Gem Version](https://badge.fury.io/rb/rollbar.svg)](http://badge.fury.io/rb/rollbar)
 [![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=rollbar&package-manager=bundler&version-scheme=semver&target-version=latest)](https://dependabot.com/compatibility-score.html?dependency-name=rollbar&package-manager=bundler&version-scheme=semver&new-version=latest)
 
+> WARNING: Ruby 2.6.0 introduced a new bug bug ([#15472 -
+Invalid JSON data being sent from Net::HTTP in some cases with Ruby 2.6.0](https://bugs.ruby-lang.org/issues/15472)) that may result in the Rollbar API returning an error when an exception is reported.  (See [rollbar-gem issue #797](https://github.com/rollbar/rollbar-gem/issues/797)).
+> Until the Ruby maintainers have released the fix for this bug, we advise Rollbar users to not upgrade their applications to Ruby 2.6.0.
+
+
+
 [Rollbar](https://rollbar.com) is a real-time exception reporting service for Ruby and other languages. The Rollbar service will alert you of problems with your code and help you understand them in a ways never possible before. We love it and we hope you will too.
 
 Rollbar-gem is the SDK for Ruby apps and includes support for apps using Rails, Sinatra, Rack, plain Ruby, and other frameworks.
@@ -16,6 +22,12 @@ Rollbar-gem is the SDK for Ruby apps and includes support for apps using Rails,
 
 For complete usage instructions and configuration reference, see our [Ruby SDK docs](https://docs.rollbar.com/docs/ruby).
 
+## Compatibility
+
+Version >= 2.19.0 is compatible with Ruby >= 1.9.3.
+
+Version < 2.19.0 is compatible with Ruby >= 1.8.7.
+
 ## Release History & Changelog
 
 See our [Releases](https://github.com/rollbar/rollbar-gem/releases) page for a list of all releases, including changes.