rollbar 2.18.2 → 2.19.0

data/spec/rollbar/middleware/sinatra_spec.rb

@@ -1,197 +0,0 @@
-require 'spec_helper'
-require 'rollbar/middleware/sinatra'
-require 'sinatra/base'
-require 'rack/test'
-
-class SinatraDummy < Sinatra::Base
-  class DummyError < StandardError; end
-
-  use Rollbar::Middleware::Sinatra
-
-  get '/foo' do
-    raise DummyError.new
-  end
-
-  get '/bar' do
-    'this will not crash'
-  end
-
-  post '/crash_post' do
-    raise DummyError.new
-  end
-end
-
-describe Rollbar::Middleware::Sinatra, :reconfigure_notifier => true do
-  include Rack::Test::Methods
-
-  def app
-    SinatraDummy
-  end
-
-  let(:logger_mock) { double('logger').as_null_object }
-
-  before do
-    Rollbar.configure do |config|
-      config.logger = logger_mock
-      config.framework = 'Sinatra'
-    end
-  end
-
-  let(:uncaught_level) do
-    Rollbar.configuration.uncaught_exception_level
-  end
-
-  let(:expected_report_args) do
-    [uncaught_level, exception, { :use_exception_level_filters => true }]
-  end
-
-  describe '#call' do
-    context 'for a crashing endpoint' do
-      # this is the default for test mode in Sinatra
-      context 'with raise_errors? == true' do
-        let(:exception) { kind_of(SinatraDummy::DummyError) }
-
-        before do
-          allow(app.settings).to receive(:raise_errors?).and_return(true)
-        end
-
-        it 'reports the error to Rollbar API and raises error' do
-          expect(Rollbar).to receive(:log).with(*expected_report_args)
-
-          expect do
-            get '/foo'
-          end.to raise_error(SinatraDummy::DummyError)
-        end
-      end
-
-      context 'with raise_errors? == false' do
-        let(:exception) { kind_of(SinatraDummy::DummyError) }
-
-        before do
-          allow(app.settings).to receive(:raise_errors?).and_return(false)
-        end
-
-        it 'reports the error to Rollbar, but nothing is raised' do
-          expect(Rollbar).to receive(:log).with(*expected_report_args)
-          get '/foo'
-        end
-      end
-    end
-
-    context 'for a NOT crashing endpoint' do
-      it 'doesnt report any error to Rollbar API' do
-        expect(Rollbar).not_to receive(:log)
-        get '/bar'
-      end
-    end
-
-    context 'if the middleware itself fails' do
-      let(:exception) { Exception.new }
-
-      before do
-        allow_any_instance_of(described_class).to receive(:framework_error).and_raise(exception)
-        allow(app.settings).to receive(:raise_errors?).and_return(false)
-      end
-
-      it 'reports the report error' do
-        expect(Rollbar).to receive(:log).with(*expected_report_args)
-
-        expect do
-          get '/foo'
-        end.to raise_error(exception)
-      end
-    end
-
-    context 'with GET parameters' do
-      let(:exception) { kind_of(SinatraDummy::DummyError) }
-      let(:params) do
-        {
-          'key' => 'value'
-        }
-      end
-
-      it 'appear in the sent payload' do
-        expect do
-          get '/foo', params
-        end.to raise_error(exception)
-
-        expect(Rollbar.last_report[:request][:GET]).to be_eql(params)
-      end
-    end
-
-    context 'with POST parameters' do
-      let(:exception) { kind_of(SinatraDummy::DummyError) }
-      let(:params) do
-        {
-          'key' => 'value'
-        }
-      end
-
-      it 'appear in the sent payload' do
-        expect do
-          post '/crash_post', params
-        end.to raise_error(exception)
-
-        expect(Rollbar.last_report[:request][:POST]).to be_eql(params)
-      end
-    end
-
-    context 'with JSON POST parameters' do
-      let(:exception) { kind_of(SinatraDummy::DummyError) }
-      let(:params) do
-        {
-          'key' => 'value'
-        }
-      end
-
-      it 'appears in the sent payload when application/json is the content type' do
-        expect do
-          post '/crash_post', params.to_json, { 'CONTENT_TYPE' => 'application/json' }
-        end.to raise_error(exception)
-
-        expect(Rollbar.last_report[:request][:body]).to be_eql(params.to_json)
-      end
-
-      it 'appears in the sent payload when the accepts header contains json' do
-        expect do
-          post '/crash_post', params, { 'ACCEPT' => 'application/vnd.github.v3+json' }
-        end.to raise_error(exception)
-
-        expect(Rollbar.last_report[:request][:POST]).to be_eql(params)
-      end
-    end
-
-    it 'resets the notifier scope in every request' do
-      get '/bar'
-      id1 = Rollbar.scope_object.object_id
-
-      get '/bar'
-      id2 = Rollbar.scope_object.object_id
-
-      expect(id1).not_to be_eql(id2)
-    end
-
-    context 'with person data' do
-      let(:exception) { kind_of(SinatraDummy::DummyError) }
-      let(:person_data) do
-        { 'email' => 'person@example.com' }
-      end
-
-      it 'includes person data from env' do
-        expect do
-          get '/foo', {}, 'rollbar.person_data' => person_data
-        end.to raise_error(exception)
-
-        expect(Rollbar.last_report[:person]).to be_eql(person_data)
-      end
-
-      it 'includes empty person data when not in env' do
-        expect do
-          get '/foo'
-        end.to raise_error(exception)
-
-        expect(Rollbar.last_report[:person]).to be_eql({})
-      end
-    end
-  end
-end

data/spec/rollbar/notifier_spec.rb

@@ -1,67 +0,0 @@
-require 'rollbar'
-require 'rollbar/notifier'
-
-describe Rollbar::Notifier do
-  describe '#scope' do
-    let(:new_scope) do
-      { 'foo' => 'bar' }
-    end
-    let(:new_config) do
-      { 'environment' => 'foo' }
-    end
-
-    it 'creates a new notifier with merged scope and configuration' do
-      new_notifier = subject.scope(new_scope, new_config)
-
-      expect(new_notifier).not_to be(subject)
-      expect(subject.configuration.environment).to be_eql(nil)
-      expect(new_notifier.configuration.environment).to be_eql('foo')
-      expect(new_notifier.scope_object['foo']).to be_eql('bar')
-      expect(new_notifier.configuration).not_to be(subject.configuration)
-      expect(new_notifier.scope_object).not_to be(subject.scope_object)
-    end
-  end
-
-  describe '#scope!' do
-    let(:new_scope) do
-      { 'foo' => 'bar' }
-    end
-    let(:new_config) do
-      { 'environment' => 'foo' }
-    end
-
-    it 'mutates the notifier with a merged scope and configuration' do
-      result = subject.scope!(new_scope, new_config)
-
-      expect(result).to be(subject)
-      expect(subject.configuration.environment).to be_eql('foo')
-      expect(subject.scope_object['foo']).to be_eql('bar')
-      expect(subject.configuration).to be(subject.configuration)
-      expect(subject.scope_object).to be(subject.scope_object)
-    end
-  end
-  
-  if RUBY_PLATFORM == 'java'
-    describe '#extract_arguments' do
-      # See https://docs.oracle.com/javase/8/docs/api/java/lang/Throwable.html
-      # for more background
-      it 'extracts java.lang.Exception' do
-        begin
-          raise java.lang.Exception.new('Hello')
-        rescue => e
-          message, exception, extra = Rollbar::Notifier.new.send(:extract_arguments, [e])
-          expect(exception).to eq(e)
-        end
-      end
-      
-      it 'extracts java.lang.Error' do
-        begin
-          raise java.lang.AssertionError.new('Hello')
-        rescue java.lang.Error => e
-          message, exception, extra = Rollbar::Notifier.new.send(:extract_arguments, [e])
-          expect(exception).to eq(e)
-        end
-      end
-    end
-  end
-end

data/spec/rollbar/plugin_spec.rb

@@ -1,209 +0,0 @@
-require 'spec_helper'
-require 'rollbar/plugin'
-
-describe Rollbar::Plugin do
-  describe '#load!' do
-    subject { described_class.new(:plugin) }
-
-    before { subject.instance_eval(&plugin_proc) }
-
-    context 'with requires not passing' do
-      let(:dummy_object) { '' }
-      let(:plugin_proc) do
-        dummy = dummy_object
-
-        proc do
-          require_dependency('rollbar')
-          dependency do
-            true
-          end
-
-          execute do
-            dummy.upcase
-          end
-
-          execute do
-            dummy.downcase
-          end
-        end
-      end
-
-      it 'doesnt finish loading the plugin' do
-        expect(dummy_object).to receive(:upcase)
-        expect(dummy_object).to receive(:downcase)
-
-        subject.load!
-
-        expect(subject.loaded).to be_eql(true)
-      end
-    end
-
-    context 'with requires not passing' do
-      let(:dummy_object) { '' }
-      let(:plugin_proc) do
-        dummy = dummy_object
-
-        proc do
-          require_dependency('sure-this-doesnt-exists')
-          dependency do
-            true
-          end
-
-          execute do
-            dummy.upcase
-          end
-
-          execute do
-            dummy.downcase
-          end
-        end
-      end
-
-      it 'doesnt finish loading the plugin' do
-        expect(dummy_object).not_to receive(:upcase)
-        expect(dummy_object).not_to receive(:downcase)
-
-        subject.load!
-
-        expect(subject.loaded).to be_eql(false)
-      end
-    end
-
-    context 'with true dependencies' do
-      let(:dummy_object) { '' }
-      let(:plugin_proc) do
-        dummy = dummy_object
-
-        proc do
-          dependency do
-            true
-          end
-
-          dependency do
-            1 == 1.0
-          end
-
-          execute do
-            dummy.upcase
-          end
-
-          execute do
-            dummy.downcase
-          end
-        end
-      end
-
-      it 'calls the callables' do
-        expect(dummy_object).to receive(:upcase).once
-        expect(dummy_object).to receive(:downcase).once
-
-        subject.load!
-
-        expect(subject.loaded).to be_eql(true)
-      end
-    end
-
-    context 'with dependencies failing' do
-      let(:dummy_object) { '' }
-      let(:plugin_proc) do
-        dummy = dummy_object
-
-        proc do
-          dependency do
-            true
-          end
-
-          dependency do
-            raise StandardError.new('the-error')
-          end
-
-          execute do
-            dummy.upcase
-          end
-
-          execute do
-            dummy.downcase
-          end
-        end
-      end
-
-      it 'doesnt finish loading the plugin' do
-        expect(dummy_object).not_to receive(:upcase)
-        expect(dummy_object).not_to receive(:downcase)
-        expect(Rollbar).to receive(:log_error).with("Error trying to load plugin 'plugin': StandardError, the-error")
-
-        subject.load!
-
-        expect(subject.loaded).to be_eql(false)
-      end
-    end
-
-    context 'with callables failing' do
-      let(:dummy_object) { '' }
-      let(:plugin_proc) do
-        dummy = dummy_object
-
-        proc do
-          dependency do
-            true
-          end
-
-          dependency do
-            1 == 1.0
-          end
-
-          execute do
-            raise StandardError.new('the-error')
-          end
-
-          execute do
-            dummy.downcase
-          end
-        end
-      end
-
-      it 'doesnt finish loading the plugin' do
-        expect(dummy_object).not_to receive(:downcase)
-        expect(Rollbar).to receive(:log_error).with("Error trying to load plugin 'plugin': StandardError, the-error")
-
-        subject.load!
-
-        expect(subject.loaded).to be_eql(true)
-      end
-    end
-
-    context 'with false dependencies' do
-      let(:dummy_object) { '' }
-      let(:plugin_proc) do
-        dummy = dummy_object
-
-        proc do
-          dependency do
-            true
-          end
-
-          dependency do
-            1 == 2.0
-          end
-
-          execute do
-            dummy.upcase
-          end
-
-          execute do
-            dummy.downcase
-          end
-        end
-      end
-
-      it 'calls the callables' do
-        expect(dummy_object).not_to receive(:upcase)
-        expect(dummy_object).not_to receive(:downcase)
-
-        subject.load!
-
-        expect(subject.loaded).to be_eql(false)
-      end
-    end
-  end
-end