rollbar 2.9.1 → 2.10.0

data/spec/rollbar/scrubbers_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+require 'rollbar/scrubbers'
+
+describe Rollbar::Scrubbers do
+  describe '.scrub_value' do
+    context 'with random scrub length' do
+      before do
+        allow(Rollbar.configuration).to receive(:randomize_scrub_length).and_return(true)
+      end
+
+      let(:value) { 'herecomesaverylongvalue' }
+
+      it 'randomizes the scrubbed string' do
+        expect(described_class.scrub_value(value)).to match(/\*{3,8}/)
+      end
+    end
+
+    context 'with no-random scrub length' do
+      before do
+        allow(Rollbar.configuration).to receive(:randomize_scrub_length).and_return(false)
+      end
+
+      let(:value) { 'herecomesaverylongvalue' }
+
+      it 'randomizes the scrubbed string' do
+        expect(described_class.scrub_value(value)).to match(/\*{#{value.length}}/)
+      end
+    end
+  end
+end

data/spec/rollbar/sidekiq_spec.rb

@@ -10,13 +10,18 @@ describe Rollbar::Sidekiq, :reconfigure_notifier => false do
     let(:msg_or_context) { ['hello', 'error_backtrace', 'backtrace', 'goodbye'] }
     let(:exception) { StandardError.new('oh noes') }
     let(:rollbar) { double }
-    let(:expected_args) { { :request => { :params => ['hello', 'goodbye'] } } }
+    let(:expected_args) do
+      {
+        :request => { :params => ['hello', 'goodbye'] },
+        :framework => "Sidekiq: #{Sidekiq::VERSION}"
+      }
+    end
 
     subject { described_class }
 
     it 'constructs scope from filtered params' do
       allow(rollbar).to receive(:error)
-      expect(Rollbar).to receive(:scope).with(expected_args) {rollbar}
+      expect(Rollbar).to receive(:scope).with(expected_args) { rollbar }
 
       described_class.handle_exception(msg_or_context, exception)
     end
@@ -28,6 +33,22 @@ describe Rollbar::Sidekiq, :reconfigure_notifier => false do
       described_class.handle_exception(msg_or_context, exception)
     end
 
+    context 'when a sidekiq worker class is set' do
+      it 'adds the sidekiq#queue-name to the error report context' do
+        msg_or_context = {"retry" => true, "retry_count" => 1, 'queue' => 'default', 'class' => 'MyWorkerClass'}
+        expected_args = {
+          :request => { :params => msg_or_context },
+          :framework => "Sidekiq: #{Sidekiq::VERSION}",
+          :context => 'MyWorkerClass',
+          :queue => 'default'
+        }
+
+        allow(rollbar).to receive(:error)
+        allow(Rollbar).to receive(:scope).with(expected_args).and_return(rollbar)
+        described_class.handle_exception(msg_or_context, exception)
+      end
+    end
+
     context 'when set a sidekiq_threshold' do
       before do
         Rollbar.configuration.sidekiq_threshold = 2

data/spec/rollbar_spec.rb

@@ -234,6 +234,7 @@ describe Rollbar do
       let(:configuration) do
         config = Rollbar::Configuration.new
         config.enabled = true
+        config.access_token = test_access_token
         config
       end
       let(:message) { 'message' }
@@ -1756,9 +1757,10 @@ describe Rollbar do
         config.project_gems = gems
       end
 
-      gems.each {|gem|
-        gem_paths.push(Gem::Specification.find_by_name(gem).gem_dir)
-      }
+      gem_paths = gems.map do |gem|
+        gem_spec = Gem::Specification.find_all_by_name(gem)[0]
+        gem_spec.gem_dir if gem_spec
+      end.compact
 
       data = notifier.send(:build_payload, 'info', 'test', nil, {})['data']
       data[:project_package_paths].kind_of?(Array).should == true

data/spec/spec_helper.rb

@@ -44,6 +44,13 @@ RSpec.configure do |config|
 
   config.use_transactional_fixtures = true
   config.order = 'random'
+  config.expect_with(:rspec) do |c|
+    c.syntax = [:should, :expect]
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.syntax = [:should, :expect]
+  end
 
   config.before(:suite) do
     DatabaseCleaner.strategy = :truncation

data/spec/support/matchers.rb

@@ -0,0 +1,23 @@
+RSpec::Matchers.define :be_eql_hash_with_regexes do |expected|
+  def check_value(actual_value, expected_value)
+    if expected_value.is_a?(Hash)
+      expected_value.all? { |k, _| check_value(actual_value[k], expected_value[k]) }
+    elsif expected_value.is_a?(Array)
+      expected_value.each_with_index.map do |v, i|
+        check_value(actual_value[i], v)
+      end.all?
+    elsif expected_value.is_a?(Regexp)
+      actual_value.match(expected_value)
+    else
+      actual_value == expected_value
+    end
+  end
+
+  match do |actual|
+    expected.all? do |key, expected_value|
+      actual_value = actual[key]
+
+      check_value(actual_value, expected_value)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.9.1
+  version: 2.10.0
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-09 00:00:00.000000000 Z
+date: 2016-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -55,6 +55,7 @@ files:
 - gemfiles/rails40.gemfile
 - gemfiles/rails41.gemfile
 - gemfiles/rails42.gemfile
+- gemfiles/rails50.gemfile
 - lib/generators/rollbar/rollbar_generator.rb
 - lib/generators/rollbar/templates/initializer.rb
 - lib/rails/rollbar_runner.rb
@@ -66,6 +67,7 @@ files:
 - lib/rollbar/configuration.rb
 - lib/rollbar/core_ext/basic_socket.rb
 - lib/rollbar/core_ext/thread.rb
+- lib/rollbar/delay/delayed_job.rb
 - lib/rollbar/delay/girl_friday.rb
 - lib/rollbar/delay/resque.rb
 - lib/rollbar/delay/sidekiq.rb
@@ -103,6 +105,7 @@ files:
 - lib/rollbar/rake_tasks.rb
 - lib/rollbar/request_data_extractor.rb
 - lib/rollbar/scrubbers.rb
+- lib/rollbar/scrubbers/params.rb
 - lib/rollbar/scrubbers/url.rb
 - lib/rollbar/sidekiq.rb
 - lib/rollbar/tasks/rollbar.cap
@@ -166,6 +169,7 @@ files:
 - spec/dummyapp/config/locales/devise.en.yml
 - spec/dummyapp/config/locales/en.yml
 - spec/dummyapp/config/routes.rb
+- spec/dummyapp/config/secrets.yml
 - spec/dummyapp/db/migrate/20121121184652_devise_create_users.rb
 - spec/dummyapp/db/migrate/20121121184654_add_name_to_users.rb
 - spec/dummyapp/db/schema.rb
@@ -186,6 +190,7 @@ files:
 - spec/requests/home_spec.rb
 - spec/rollbar/active_job_spec.rb
 - spec/rollbar/configuration_spec.rb
+- spec/rollbar/delay/delayed_job_spec.rb
 - spec/rollbar/delay/girl_friday_spec.rb
 - spec/rollbar/delay/resque_spec.rb
 - spec/rollbar/delay/thread_spec.rb
@@ -203,7 +208,9 @@ files:
 - spec/rollbar/middleware/sinatra_spec.rb
 - spec/rollbar/rake_spec.rb
 - spec/rollbar/request_data_extractor_spec.rb
+- spec/rollbar/scrubbers/params_spec.rb
 - spec/rollbar/scrubbers/url_spec.rb
+- spec/rollbar/scrubbers_spec.rb
 - spec/rollbar/sidekig/clear_scope_spec.rb
 - spec/rollbar/sidekiq_spec.rb
 - spec/rollbar/truncation/frames_strategy_spec.rb
@@ -221,6 +228,7 @@ files:
 - spec/support/fixture_helpers.rb
 - spec/support/get_ip_raising.rb
 - spec/support/helpers.rb
+- spec/support/matchers.rb
 - spec/support/notifier_helpers.rb
 - spec/support/shared_contexts.rb
 homepage: https://rollbar.com
@@ -296,6 +304,7 @@ test_files:
 - spec/dummyapp/config/locales/devise.en.yml
 - spec/dummyapp/config/locales/en.yml
 - spec/dummyapp/config/routes.rb
+- spec/dummyapp/config/secrets.yml
 - spec/dummyapp/db/migrate/20121121184652_devise_create_users.rb
 - spec/dummyapp/db/migrate/20121121184654_add_name_to_users.rb
 - spec/dummyapp/db/schema.rb
@@ -316,6 +325,7 @@ test_files:
 - spec/requests/home_spec.rb
 - spec/rollbar/active_job_spec.rb
 - spec/rollbar/configuration_spec.rb
+- spec/rollbar/delay/delayed_job_spec.rb
 - spec/rollbar/delay/girl_friday_spec.rb
 - spec/rollbar/delay/resque_spec.rb
 - spec/rollbar/delay/thread_spec.rb
@@ -333,7 +343,9 @@ test_files:
 - spec/rollbar/middleware/sinatra_spec.rb
 - spec/rollbar/rake_spec.rb
 - spec/rollbar/request_data_extractor_spec.rb
+- spec/rollbar/scrubbers/params_spec.rb
 - spec/rollbar/scrubbers/url_spec.rb
+- spec/rollbar/scrubbers_spec.rb
 - spec/rollbar/sidekig/clear_scope_spec.rb
 - spec/rollbar/sidekiq_spec.rb
 - spec/rollbar/truncation/frames_strategy_spec.rb
@@ -351,5 +363,6 @@ test_files:
 - spec/support/fixture_helpers.rb
 - spec/support/get_ip_raising.rb
 - spec/support/helpers.rb
+- spec/support/matchers.rb
 - spec/support/notifier_helpers.rb
 - spec/support/shared_contexts.rb