rollbar 2.6.3 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 719fb1702368226fe659a956193cb0476c6b96ae
-  data.tar.gz: c144264db862735c7821968b10964923b804d577
+  metadata.gz: dd9b6e18ebb383811eeb94a71ebb3c257c6f8eb3
+  data.tar.gz: 53fff3d9e6c7e382ddad631f09fbbfb790761875
 SHA512:
-  metadata.gz: 3a9d33625014e9e3736dabc1a18f23b0b6604603eb1716f39bef8f27be5d88836983f1dece46fda0106062bbd7c8b7c99b2e224b3c685ec66b9981644bc4f550
-  data.tar.gz: 7eb6361019cad3de5a3184fcc9db7d3ed5fa43459b6748eeb1570fe3d5a058f857d507dae735295aba892c1df8a540c713cbc078c0a6235094baf29b4aec5519
+  metadata.gz: 6a71c85969223088bba62f91c54e68fc05bf803f7e7de5fdba8df2912ccb20d14b8eccb896ba6d5e1710f3b0695bcd0faca91a655e2edc93f229a287ebb79a52
+  data.tar.gz: 41ae2da0a51043db97987f019ef0628ae9b52f9385ae6772df2691c1b95171543d3883d6e2fad6e0c467f1545e48e3360bae41fde06d8f0296b9f0d848bede45

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Change Log
 
+## 2.7.0
+
+- Delayed job integration fix. See [#355](https://github.com/rollbar/rollbar-gem/pull/355).
+ - Delayed job support limited to versions >= 3.0
+- Better diagnostic when failsafe is on. See [#354](https://github.com/rollbar/rollbar-gem/pull/354).
+- Document Language/Framework Support. See [#352](https://github.com/rollbar/rollbar-gem/pull/352).
+
 ## 2.6.3
 
 Change:

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.6.3)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.7.0)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 [Rollbar](https://rollbar.com) is an error tracking service for Ruby and other languages. The Rollbar service will alert you of problems with your code and help you understand them in a ways never possible before. We love it and we hope you will too.
@@ -12,7 +12,7 @@ This is the Ruby library for Rollbar. It will instrument many kinds of Ruby appl
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rollbar', '~> 2.6.3'
+gem 'rollbar', '~> 2.7.0'
 ```
 
 If you are not using JRuby we suggest using [Oj](https://github.com/ohler55/oj) for JSON serialization. In order to install Oj you can add this line to your Gemfile:
@@ -446,6 +446,8 @@ If you use [custom jobs](https://github.com/collectiveidea/delayed_job#custom-jo
 config.delayed_job_enabled = false
 ```
 
+Only versions >= 3.0 of delayed_job are supported.
+
 
 ## Asynchronous reporting
 
@@ -703,6 +705,11 @@ Rollbar.configure do|config|
 end
 ```
 
+## Supported Language/Framework Versions
+
+We support Ruby >= 1.8.7.
+
+We support Rails >= 3.0.
 
 ## Help / Support
 

data/lib/rollbar.rb

@@ -628,6 +628,8 @@ module Rollbar
           nearest_frame = backtrace[0]
 
           exception_info = exception.class.name
+          # #to_s and #message defaults to class.to_s. Add message only if add valuable info.
+          exception_info += %Q{: "#{exception.message}"} if exception.message != exception.class.to_s
           exception_info += " in #{nearest_frame}" if nearest_frame
 
           body += "#{exception_info}: #{message}"

data/lib/rollbar/delayed_job.rb

@@ -23,12 +23,18 @@ module Rollbar
       end
     end
 
+    class RollbarPlugin < ::Delayed::Plugin
+      callbacks do |lifecycle|
+        lifecycle.around(:invoke_job, &Delayed::invoke_job_callback)
+      end
+    end
+
     self.wrapped = false
 
     def self.wrap_worker
       return if wrapped
 
-      around_invoke_job(&invoke_job_callback)
+      ::Delayed::Worker.plugins << RollbarPlugin
 
       self.wrapped = true
     end
@@ -39,10 +45,6 @@ module Rollbar
       wrap_worker
     end
 
-    def self.around_invoke_job(&block)
-      ::Delayed::Worker.lifecycle.around(:invoke_job, &block)
-    end
-
     def self.invoke_job_callback
       proc do |job, *args, &block|
         begin

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "2.6.3"
+  VERSION = "2.7.0"
 end

data/spec/rollbar/delayed_job_spec.rb

@@ -12,9 +12,13 @@ describe Rollbar::Delayed, :reconfigure_notifier => true do
     end
   end
 
+  before(:all) do
+    # technically, this is called once when rollbar hooks are required
+    Rollbar::Delayed.wrap_worker!
+  end
+
   before do
     Delayed::Backend::Test.prepare_worker
-    Rollbar::Delayed.wrap_worker!
 
     Delayed::Worker.backend = :test
     Delayed::Backend::Test::Job.delete_all

data/spec/rollbar_spec.rb

@@ -1575,6 +1575,17 @@ describe Rollbar do
       notifier.send(:send_failsafe, nil, nil)
     end
 
+    context 'with a non default exception message' do
+      let(:exception) { StandardError.new 'Something is wrong' }
+
+      it 'adds it to exception info' do
+        sent_payload = notifier.send(:send_failsafe, "test failsafe", exception)
+
+        expected_message = 'Failsafe from rollbar-gem. StandardError: "Something is wrong": test failsafe'
+        expect(sent_payload['data'][:body][:message][:body]).to be_eql(expected_message)
+      end
+    end
+
     context 'without exception object' do
       it 'just sends the given message' do
         sent_payload = notifier.send(:send_failsafe, "test failsafe", nil)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.6.3
+  version: 2.7.0
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-26 00:00:00.000000000 Z
+date: 2015-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails