rollbar 2.6.0 → 2.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 94bfaab6020d2299a4f491bcaf08c1fb1e7ffaa7
-  data.tar.gz: 37873db26e50016607aa5b03a7298da79fe112a4
+  metadata.gz: 9fcf3784b3933d22fda12776862079a51dc40d51
+  data.tar.gz: 63ad42beb99619d2543b386074d7f8e9b61486b1
 SHA512:
-  metadata.gz: 6389ed78df71156fb8f44c22a9d2550d99e367988fede657a3ec58b83bd09781403e8f1d2571f657a7ec535bf1b2c1a12447fb9aace2f678c332d0e1d2fddeae
-  data.tar.gz: 601cdc2a21f5a2e4ba23a157ed378058e3440cf4e72fea2d1d1b85631cbfa9d67ae0ece44157a732256eee9846ccc7c22cf692bb79fa9e5abadf9b5f36c77a55
+  metadata.gz: 9dd2b1859ad864c4c76af2fff36ed43671e4811e7c91bd6a7f251f86e207904d5d02f51efe222956ff9784523531b3cb40b8a35785b9af1395c97ea19aa3c638
+  data.tar.gz: 155d347bb7540525e3c17bcb773af226f60cae09806aa3aa2223c19493a049f09a7df091f05b28358cf38653e16d4fafb53f8816cdcf5ae1ab1ec2c2b0bf8b40

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## 2.6.1
+
+Bug fix:
+
+- Don't skip delayed_job reports if attempts > dj_threshold. See [#340](https://github.com/rollbar/rollbar-gem/pull/340).
+
 ## 2.6.0
 
 Features

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.6.0)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.6.1)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 [Rollbar](https://rollbar.com) is an error tracking service for Ruby and other languages. The Rollbar service will alert you of problems with your code and help you understand them in a ways never possible before. We love it and we hope you will too.
@@ -12,7 +12,7 @@ This is the Ruby library for Rollbar. It will instrument many kinds of Ruby appl
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rollbar', '~> 2.6.0'
+gem 'rollbar', '~> 2.6.1'
 ```
 
 If you are not using JRuby we suggest using [Oj](https://github.com/ohler55/oj) for JSON serialization. In order to install Oj you can add this line to your Gemfile:

data/lib/rollbar/delayed_job.rb

@@ -56,13 +56,17 @@ module Rollbar
     end
 
     def self.report(e, job)
-      return unless job.attempts <= ::Rollbar.configuration.dj_threshold
+      return if skip_report?(job)
 
       data = build_job_data(job)
 
       ::Rollbar.scope(:request => data).error(e, :use_exception_level_filters => true)
     end
 
+    def self.skip_report?(job)
+      job.attempts < ::Rollbar.configuration.dj_threshold
+    end
+
     def self.build_job_data(job)
       return nil unless ::Rollbar.configuration.report_dj_data
 

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "2.6.0"
+  VERSION = "2.6.1"
 end

data/spec/rollbar/delayed_job_spec.rb

@@ -58,4 +58,29 @@ describe Rollbar::Delayed, :reconfigure_notifier => true do
       end
     end
   end
+
+  describe '.skip_report' do
+    let(:configuration) { Rollbar.configuration }
+    let(:threshold) { 5 }
+
+    before do
+      allow(configuration).to receive(:dj_threshold).and_return(threshold)
+    end
+
+    context 'with attempts > configuration.dj_threshold' do
+      let(:job) { double(:attempts => 6) }
+
+      it 'returns true' do
+        expect(described_class.skip_report?(job)).to be(false)
+      end
+    end
+
+    context 'with attempts < configuration.dj_threshold' do
+      let(:job) { double(:attempts => 3) }
+
+      it 'returns false' do
+        expect(described_class.skip_report?(job)).to be(true)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.6.0
+  version: 2.6.1
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-11 00:00:00.000000000 Z
+date: 2015-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails