rollbar 2.23.2 → 2.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9073beef837ad644c6679c6f95599b7eb6e387d089c9f8d88448cbf39960ea22
-  data.tar.gz: 148751730bba10444641bd319314b7af7ee69a51e2c15cc686a909f797eec379
+  metadata.gz: c1848033c2fc853846ba902fbe4dc6095ad17a6e27595a3937484a6036154b76
+  data.tar.gz: a42d4a1274624ea5991b66b0df1ce7031d699390c5dcf574b98d8fe03ea5519d
 SHA512:
-  metadata.gz: c8b0529b951944385beba61f53f43c3ea4270fe38c94fb85639a55a833d2e67c92ae61e88325ba3e3c4a0b64492aab3c95bc6faa6f458df1e9ad792c1e38e77d
-  data.tar.gz: 6d12a2415ac6ba94b7e5b00b944a4de7afe5a4fa6e43c9d86618c944d0968e0aeb8d601a34363fd97b89bc4ff5316b7dfa2cff6a54aee1a7f198b5690391da23
+  metadata.gz: 5d71b0e452e917b566e48a292368a242404c2d26e91c011f641f1fb7bde2b05ee8bd88a9af6d595bf6581cea17d5d4a996af63104c4ea55a19de564760b4f7f3
+  data.tar.gz: b7ec97dfa2625823709eba27b5252706fce661877b9e4338595228c901e5766ab9752a5103a87f929d7af8ae9c687a978f7630d93d0aee5611ab58e5771ccd2c

data/.rubocop.yml

@@ -69,6 +69,10 @@ Style/FrozenStringLiteralComment:
   # throughout the project, in order to prepare for a future Ruby 3.x.
   Enabled: false
 
+Style/SafeNavigation:
+  # Not available in Ruby < 2.3.
+  Enabled: false
+
 #
 # Performance cops are opt in, and `Enabled: true` is always required.
 # Full list is here: https://github.com/rubocop-hq/rubocop-performance/tree/master/lib/rubocop/cop/performance

data/docs/configuration.md

@@ -129,6 +129,7 @@ An array of backup handlers if the async handlers fails. Each should respond to
 
 For use with `write_to_file`. Indicates location of the rollbar log file being
 tracked by [rollbar-agent](https://github.com/rollbar/rollbar-agent).
+Enable `files_with_pid_name_enabled` if you want to have different files for each process(only works if extension `rollbar`)
 
 ### framework
 

data/lib/rails/rollbar_runner.rb

@@ -39,7 +39,7 @@ module Rails
     end
 
     def eval_runner
-      if Rails.version >= '5.1.0'
+      if Gem::Version.new(Rails.version) >= Gem::Version.new('5.1.0')
         rails5_runner
       else
         legacy_runner
@@ -55,6 +55,8 @@ module Rails
     end
 
     def rails5_runner
+      require 'rails/command'
+
       Rails::Command.invoke 'runner', ARGV
     end
 

data/lib/rollbar/configuration.rb

@@ -24,7 +24,6 @@ module Rollbar
     attr_accessor :environment
     attr_accessor :exception_level_filters
     attr_accessor :failover_handlers
-    attr_accessor :filepath
     attr_accessor :framework
     attr_accessor :ignored_person_ids
     attr_accessor :host
@@ -61,7 +60,6 @@ module Rollbar
     attr_accessor :async_json_payload
     attr_reader :use_eventmachine
     attr_accessor :web_base
-    attr_accessor :write_to_file
     attr_reader :send_extra_frame_data
     attr_accessor :use_exception_level_filters_default
     attr_accessor :proxy
@@ -70,6 +68,13 @@ module Rollbar
     attr_accessor :log_payload
     attr_accessor :backtrace_cleaner
 
+    attr_accessor :write_to_file
+    attr_accessor :filepath
+    attr_accessor :files_with_pid_name_enabled
+    attr_accessor :files_processed_enabled
+    attr_accessor :files_processed_duration # seconds
+    attr_accessor :files_processed_size # bytes
+
     attr_reader :project_gem_paths
     attr_accessor :configured_options
 
@@ -134,7 +139,6 @@ module Rollbar
       @use_eventmachine = false
       @verify_ssl_peer = true
       @web_base = DEFAULT_WEB_BASE
-      @write_to_file = false
       @send_extra_frame_data = :none
       @project_gem_paths = []
       @use_exception_level_filters_default = false
@@ -150,6 +154,12 @@ module Rollbar
         :on_report_internal_error => nil # params: exception
       }
 
+      @write_to_file = false
+      @files_with_pid_name_enabled = false
+      @files_processed_enabled = false
+      @files_processed_duration = 60
+      @files_processed_size = 5 * 1000 * 1000
+
       @configured_options = ConfiguredOptions.new(self)
     end
 

data/lib/rollbar/notifier.rb

@@ -19,7 +19,8 @@ module Rollbar
     attr_accessor :last_report
     attr_accessor :scope_object
 
-    @file_semaphore = Mutex.new
+    MUTEX = Mutex.new
+    EXTENSION_REGEXP = /.rollbar\z/.freeze
 
     def initialize(parent_notifier = nil, payload_options = nil, scope = nil)
       if parent_notifier
@@ -200,11 +201,11 @@ module Rollbar
     def process_item(item)
       if configuration.write_to_file
         if configuration.use_async
-          @file_semaphore.synchronize do
-            write_item(item)
+          MUTEX.synchronize do
+            do_write_item(item)
           end
         else
-          write_item(item)
+          do_write_item(item)
         end
       else
         send_item(item)
@@ -675,27 +676,24 @@ module Rollbar
       end
     end
 
-    def write_item(item)
-      if configuration.use_async
-        @file_semaphore.synchronize do
-          do_write_item(item)
-        end
-      else
-        do_write_item(item)
-      end
-    end
-
     def do_write_item(item)
       log_info '[Rollbar] Writing item to file'
 
       body = item.dump
       return unless body
 
+      file_name = if configuration.files_with_pid_name_enabled
+                    configuration.filepath.gsub(EXTENSION_REGEXP, "_#{Process.pid}\\0")
+                  else
+                    configuration.filepath
+                  end
+
       begin
-        @file ||= File.open(configuration.filepath, 'a')
+        @file ||= File.open(file_name, 'a')
 
         @file.puts(body)
         @file.flush
+        update_file(@file, file_name)
 
         log_info '[Rollbar] Success'
       rescue IOError => e
@@ -703,6 +701,18 @@ module Rollbar
       end
     end
 
+    def update_file(file, file_name)
+      return unless configuration.files_processed_enabled
+
+      time_now = Time.now
+      return if configuration.files_processed_duration > time_now - file.birthtime && file.size < configuration.files_processed_size
+
+      new_file_name = file_name.gsub(EXTENSION_REGEXP, "_processed_#{time_now.to_i}\\0")
+      File.rename(file, new_file_name)
+      file.close
+      @file = File.open(file_name, 'a')
+    end
+
     def failsafe_reason(message, exception)
       body = ''
 

data/lib/rollbar/plugins/delayed_job/plugin.rb

@@ -12,7 +12,13 @@ module Rollbar
         lifecycle.around(:invoke_job, &Delayed.invoke_job_callback)
         lifecycle.after(:failure) do |_, job, _, _|
           data = Rollbar::Delayed.build_job_data(job)
-          ::Rollbar.scope(:request => data).error("Job has failed and won't be retried anymore: " + job.last_error, :use_exception_level_filters => true) if job.last_error
+
+          # DelayedJob < 4.1 doesn't provide job#error
+          if job.class.method_defined? :error
+            ::Rollbar.scope(:request => data).error(job.error, :use_exception_level_filters => true) if job.error
+          elsif job.last_error
+            ::Rollbar.scope(:request => data).error("Job has failed and won't be retried anymore: " + job.last_error, :use_exception_level_filters => true)
+          end
         end
       end
     end

data/lib/rollbar/request_data_extractor.rb

@@ -247,7 +247,12 @@ module Rollbar
     end
 
     def sensitive_headers_list
-      Rollbar.configuration.scrub_headers || []
+      return [] unless Rollbar.configuration.scrub_headers && Rollbar.configuration.scrub_headers.is_a?(Array)
+
+      # Normalize into the expected matching format
+      Rollbar.configuration.scrub_headers.map do |header|
+        header.split(/[-_]/).map(&:capitalize).join('-').gsub(/^Http-/, '')
+      end
     end
   end
 end

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = '2.23.2'.freeze
+  VERSION = '2.24.0'.freeze
 end

data/rollbar.gemspec

@@ -13,6 +13,7 @@ Gem::Specification.new do |gem|
   gem.homepage      = 'https://rollbar.com'
   gem.license       = 'MIT'
   gem.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  gem.files        += ['spec/support/rollbar_api.rb'] # useful helper for app spec/tests.
   gem.name          = 'rollbar'
   gem.require_paths = ['lib']
   gem.required_ruby_version = '>= 1.9.3'

data/spec/support/rollbar_api.rb

@@ -0,0 +1,67 @@
+require 'rack/request'
+
+class RollbarAPI
+  UNAUTHORIZED_ACCESS_TOKEN = 'unauthorized'.freeze
+
+  def call(env)
+    request = Rack::Request.new(env)
+    json = JSON.parse(request.body.read)
+
+    return unauthorized unless authorized?(json, request)
+
+    return bad_request(json) unless valid_data?(json, request)
+
+    success(json, request)
+  end
+
+  protected
+
+  def authorized?(json, _request)
+    json['access_token'] != UNAUTHORIZED_ACCESS_TOKEN
+  end
+
+  def response_headers
+    {
+      'Content-Type' => 'application/json'
+    }
+  end
+
+  def valid_data?(json, _request)
+    !!json['access_token']
+  end
+
+  def unauthorized
+    [401, response_headers, [unauthorized_body]]
+  end
+
+  def bad_request(_json)
+    [400, response_headers, [bad_request_body]]
+  end
+
+  def success(json, request)
+    [200, response_headers, [success_body(json, request)]]
+  end
+
+  def unauthorized_body
+    result(1, nil, 'invalid access token')
+  end
+
+  def bad_request_body
+    result(1, nil, 'bad request')
+  end
+
+  def success_body(json, _request)
+    result(0, {
+             :id => rand(1_000_000),
+             :uuid => json['data']['uuid']
+           }, nil)
+  end
+
+  def result(err, body, message)
+    {
+      :err => err,
+      :result => body,
+      :message => message
+    }.to_json
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.23.2
+  version: 2.24.0
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-13 00:00:00.000000000 Z
+date: 2020-02-14 00:00:00.000000000 Z
 dependencies: []
 description: Easy and powerful exception tracking for Ruby
 email:
@@ -134,6 +134,7 @@ files:
 - lib/tasks/benchmark.rake
 - lib/tasks/tasks.rake
 - rollbar.gemspec
+- spec/support/rollbar_api.rb
 homepage: https://rollbar.com
 licenses:
 - MIT
@@ -158,7 +159,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubyforge_project: 
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Reports exceptions to Rollbar