rollbar 2.10.0 → 2.11.0

data/spec/spec_helper.rb

@@ -20,6 +20,12 @@ require File.expand_path('../dummyapp/config/environment', __FILE__)
 require 'rspec/rails'
 require 'database_cleaner'
 
+begin
+  require 'webmock/rspec'
+  WebMock.disable_net_connect!(:allow => 'codeclimate.com')
+rescue LoadError
+end
+
 namespace :dummy do
   load 'spec/dummyapp/Rakefile'
 end
@@ -60,6 +66,8 @@ RSpec.configure do |config|
     DatabaseCleaner.start
     DatabaseCleaner.clean
     Rollbar.reset_notifier!
+
+    stub_request(:any, /api.rollbar.com/).to_rack(RollbarAPI.new) if defined?(WebMock)
   end
 
   config.after(:each) do

data/spec/support/notifier_helpers.rb

@@ -6,6 +6,7 @@ module NotifierHelpers
       config.logger = ::Rails.logger
       config.root = ::Rails.root
       config.framework = "Rails: #{::Rails::VERSION::STRING}"
+      config.open_timeout = 60
       config.request_timeout = 60
     end
   end

data/spec/support/rollbar_api.rb

@@ -0,0 +1,57 @@
+require 'rack/request'
+
+class RollbarAPI
+  def call(env)
+    request = Rack::Request.new(env)
+    json = JSON.parse(request.body.read)
+
+    return bad_request(json) unless access_token?(json)
+
+    success(json)
+  end
+
+  private
+
+  def response_headers
+    {
+      'Content-Type' => 'application/json'
+    }
+  end
+
+  def access_token?(json)
+
+    !!json['access_token']
+  end
+
+  def bad_request(json)
+    # We don't have for now any test doing bad requests
+    # so raise here in order to detect that scenario
+    raise
+
+
+    [400, response_headers, [bad_request_body]]
+  end
+
+  def success(json)
+    [200, response_headers, [success_body(json)]]
+  end
+
+  def bad_request_body
+    result(1, nil, 'bad request')
+  end
+
+  def success_body(json)
+    result(0, {
+      :id => rand(1_000_000),
+      :uuid => json['data']['uuid']
+    }, nil)
+  end
+
+  def result(err, body, message)
+    {
+      :err => err,
+      :result => body,
+      :message => message
+    }.to_json
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.10.0
+  version: 2.11.0
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-21 00:00:00.000000000 Z
+date: 2016-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -56,35 +56,28 @@ files:
 - gemfiles/rails41.gemfile
 - gemfiles/rails42.gemfile
 - gemfiles/rails50.gemfile
+- gemfiles/ruby_1_8_and_1_9_2.gemfile
 - lib/generators/rollbar/rollbar_generator.rb
 - lib/generators/rollbar/templates/initializer.rb
 - lib/rails/rollbar_runner.rb
 - lib/rollbar.rb
-- lib/rollbar/active_job.rb
-- lib/rollbar/active_record_extension.rb
 - lib/rollbar/capistrano.rb
 - lib/rollbar/capistrano3.rb
 - lib/rollbar/configuration.rb
-- lib/rollbar/core_ext/basic_socket.rb
-- lib/rollbar/core_ext/thread.rb
 - lib/rollbar/delay/delayed_job.rb
 - lib/rollbar/delay/girl_friday.rb
 - lib/rollbar/delay/resque.rb
 - lib/rollbar/delay/sidekiq.rb
 - lib/rollbar/delay/sucker_punch.rb
 - lib/rollbar/delay/thread.rb
-- lib/rollbar/delayed_job.rb
 - lib/rollbar/encoding.rb
 - lib/rollbar/encoding/encoder.rb
 - lib/rollbar/encoding/legacy_encoder.rb
 - lib/rollbar/exception_reporter.rb
 - lib/rollbar/exceptions.rb
-- lib/rollbar/goalie.rb
+- lib/rollbar/item.rb
+- lib/rollbar/item/backtrace.rb
 - lib/rollbar/js.rb
-- lib/rollbar/js/frameworks.rb
-- lib/rollbar/js/frameworks/rails.rb
-- lib/rollbar/js/middleware.rb
-- lib/rollbar/js/version.rb
 - lib/rollbar/json.rb
 - lib/rollbar/json/default.rb
 - lib/rollbar/json/oj.rb
@@ -92,22 +85,37 @@ files:
 - lib/rollbar/lazy_store.rb
 - lib/rollbar/logger.rb
 - lib/rollbar/logger_proxy.rb
+- lib/rollbar/middleware/js.rb
 - lib/rollbar/middleware/rack/builder.rb
 - lib/rollbar/middleware/rack/test_session.rb
 - lib/rollbar/middleware/rails/rollbar.rb
 - lib/rollbar/middleware/rails/show_exceptions.rb
 - lib/rollbar/middleware/sinatra.rb
-- lib/rollbar/rack.rb
+- lib/rollbar/plugin.rb
+- lib/rollbar/plugins.rb
+- lib/rollbar/plugins/active_job.rb
+- lib/rollbar/plugins/basic_socket.rb
+- lib/rollbar/plugins/delayed_job.rb
+- lib/rollbar/plugins/delayed_job/job_data.rb
+- lib/rollbar/plugins/delayed_job/plugin.rb
+- lib/rollbar/plugins/goalie.rb
+- lib/rollbar/plugins/rack.rb
+- lib/rollbar/plugins/rails.rb
+- lib/rollbar/plugins/rails/controller_methods.rb
+- lib/rollbar/plugins/rails/railtie30.rb
+- lib/rollbar/plugins/rails/railtie32.rb
+- lib/rollbar/plugins/rails/railtie_mixin.rb
+- lib/rollbar/plugins/rake.rb
+- lib/rollbar/plugins/sidekiq.rb
+- lib/rollbar/plugins/sidekiq/plugin.rb
+- lib/rollbar/plugins/thread.rb
+- lib/rollbar/plugins/validations.rb
 - lib/rollbar/rails.rb
-- lib/rollbar/rails/controller_methods.rb
-- lib/rollbar/railtie.rb
-- lib/rollbar/rake.rb
 - lib/rollbar/rake_tasks.rb
 - lib/rollbar/request_data_extractor.rb
 - lib/rollbar/scrubbers.rb
 - lib/rollbar/scrubbers/params.rb
 - lib/rollbar/scrubbers/url.rb
-- lib/rollbar/sidekiq.rb
 - lib/rollbar/tasks/rollbar.cap
 - lib/rollbar/truncation.rb
 - lib/rollbar/truncation/frames_strategy.rb
@@ -137,6 +145,7 @@ files:
 - spec/dummyapp/app/helpers/.gitkeep
 - spec/dummyapp/app/mailers/.gitkeep
 - spec/dummyapp/app/models/.gitkeep
+- spec/dummyapp/app/models/post.rb
 - spec/dummyapp/app/models/user.rb
 - spec/dummyapp/app/views/devise/registrations/edit.html.erb
 - spec/dummyapp/app/views/devise/registrations/new.html.erb
@@ -185,34 +194,40 @@ files:
 - spec/fixtures/payloads/message.json
 - spec/fixtures/payloads/sample.trace.json
 - spec/fixtures/payloads/sample.trace_chain.json
+- spec/fixtures/plugins/dummy1.rb
+- spec/fixtures/plugins/dummy2.rb
 - spec/generators/rollbar/rollbar_generator_rails30_spec.rb
 - spec/generators/rollbar/rollbar_generator_spec.rb
 - spec/requests/home_spec.rb
-- spec/rollbar/active_job_spec.rb
 - spec/rollbar/configuration_spec.rb
 - spec/rollbar/delay/delayed_job_spec.rb
 - spec/rollbar/delay/girl_friday_spec.rb
 - spec/rollbar/delay/resque_spec.rb
 - spec/rollbar/delay/thread_spec.rb
-- spec/rollbar/delayed_job/job_data.rb
-- spec/rollbar/delayed_job_spec.rb
 - spec/rollbar/encoding/encoder_spec.rb
-- spec/rollbar/js/frameworks/rails_spec.rb
-- spec/rollbar/js/middleware_spec.rb
+- spec/rollbar/item_spec.rb
 - spec/rollbar/json/oj_spec.rb
 - spec/rollbar/json_spec.rb
 - spec/rollbar/lazy_store_spec.rb
 - spec/rollbar/logger_proxy_spec.rb
 - spec/rollbar/logger_spec.rb
-- spec/rollbar/middleware/rack/builder_spec.rb
+- spec/rollbar/middleware/js_spec.rb
 - spec/rollbar/middleware/sinatra_spec.rb
-- spec/rollbar/rake_spec.rb
+- spec/rollbar/plugin_spec.rb
+- spec/rollbar/plugins/active_job_spec.rb
+- spec/rollbar/plugins/delayed_job/job_data.rb
+- spec/rollbar/plugins/delayed_job_spec.rb
+- spec/rollbar/plugins/rack_spec.rb
+- spec/rollbar/plugins/rails_js_spec.rb
+- spec/rollbar/plugins/rake_spec.rb
+- spec/rollbar/plugins/sidekiq_spec.rb
+- spec/rollbar/plugins/validations_spec.rb
+- spec/rollbar/plugins_spec.rb
 - spec/rollbar/request_data_extractor_spec.rb
 - spec/rollbar/scrubbers/params_spec.rb
 - spec/rollbar/scrubbers/url_spec.rb
 - spec/rollbar/scrubbers_spec.rb
 - spec/rollbar/sidekig/clear_scope_spec.rb
-- spec/rollbar/sidekiq_spec.rb
 - spec/rollbar/truncation/frames_strategy_spec.rb
 - spec/rollbar/truncation/min_body_strategy_spec.rb
 - spec/rollbar/truncation/strings_strategy_spec.rb
@@ -230,6 +245,7 @@ files:
 - spec/support/helpers.rb
 - spec/support/matchers.rb
 - spec/support/notifier_helpers.rb
+- spec/support/rollbar_api.rb
 - spec/support/shared_contexts.rb
 homepage: https://rollbar.com
 licenses:
@@ -272,6 +288,7 @@ test_files:
 - spec/dummyapp/app/helpers/.gitkeep
 - spec/dummyapp/app/mailers/.gitkeep
 - spec/dummyapp/app/models/.gitkeep
+- spec/dummyapp/app/models/post.rb
 - spec/dummyapp/app/models/user.rb
 - spec/dummyapp/app/views/devise/registrations/edit.html.erb
 - spec/dummyapp/app/views/devise/registrations/new.html.erb
@@ -320,34 +337,40 @@ test_files:
 - spec/fixtures/payloads/message.json
 - spec/fixtures/payloads/sample.trace.json
 - spec/fixtures/payloads/sample.trace_chain.json
+- spec/fixtures/plugins/dummy1.rb
+- spec/fixtures/plugins/dummy2.rb
 - spec/generators/rollbar/rollbar_generator_rails30_spec.rb
 - spec/generators/rollbar/rollbar_generator_spec.rb
 - spec/requests/home_spec.rb
-- spec/rollbar/active_job_spec.rb
 - spec/rollbar/configuration_spec.rb
 - spec/rollbar/delay/delayed_job_spec.rb
 - spec/rollbar/delay/girl_friday_spec.rb
 - spec/rollbar/delay/resque_spec.rb
 - spec/rollbar/delay/thread_spec.rb
-- spec/rollbar/delayed_job/job_data.rb
-- spec/rollbar/delayed_job_spec.rb
 - spec/rollbar/encoding/encoder_spec.rb
-- spec/rollbar/js/frameworks/rails_spec.rb
-- spec/rollbar/js/middleware_spec.rb
+- spec/rollbar/item_spec.rb
 - spec/rollbar/json/oj_spec.rb
 - spec/rollbar/json_spec.rb
 - spec/rollbar/lazy_store_spec.rb
 - spec/rollbar/logger_proxy_spec.rb
 - spec/rollbar/logger_spec.rb
-- spec/rollbar/middleware/rack/builder_spec.rb
+- spec/rollbar/middleware/js_spec.rb
 - spec/rollbar/middleware/sinatra_spec.rb
-- spec/rollbar/rake_spec.rb
+- spec/rollbar/plugin_spec.rb
+- spec/rollbar/plugins/active_job_spec.rb
+- spec/rollbar/plugins/delayed_job/job_data.rb
+- spec/rollbar/plugins/delayed_job_spec.rb
+- spec/rollbar/plugins/rack_spec.rb
+- spec/rollbar/plugins/rails_js_spec.rb
+- spec/rollbar/plugins/rake_spec.rb
+- spec/rollbar/plugins/sidekiq_spec.rb
+- spec/rollbar/plugins/validations_spec.rb
+- spec/rollbar/plugins_spec.rb
 - spec/rollbar/request_data_extractor_spec.rb
 - spec/rollbar/scrubbers/params_spec.rb
 - spec/rollbar/scrubbers/url_spec.rb
 - spec/rollbar/scrubbers_spec.rb
 - spec/rollbar/sidekig/clear_scope_spec.rb
-- spec/rollbar/sidekiq_spec.rb
 - spec/rollbar/truncation/frames_strategy_spec.rb
 - spec/rollbar/truncation/min_body_strategy_spec.rb
 - spec/rollbar/truncation/strings_strategy_spec.rb
@@ -365,4 +388,5 @@ test_files:
 - spec/support/helpers.rb
 - spec/support/matchers.rb
 - spec/support/notifier_helpers.rb
+- spec/support/rollbar_api.rb
 - spec/support/shared_contexts.rb

data/lib/rollbar/active_record_extension.rb

@@ -1,14 +0,0 @@
-module Rollbar
-  module ActiveRecordExtension
-    extend ActiveSupport::Concern
-
-    def report_validation_errors_to_rollbar
-      self.errors.full_messages.each do |error|
-        Rollbar.log_info "[Rollbar] Reporting form validation error: #{error} for #{self.to_s}"
-        Rollbar.warning("Form Validation Error: #{error} for #{self.to_s}")
-      end
-    end
-  end
-end
-
-ActiveRecord::Base.send(:include, Rollbar::ActiveRecordExtension)

data/lib/rollbar/core_ext/basic_socket.rb

@@ -1,7 +0,0 @@
-require 'socket'
-
-class BasicSocket
-  def as_json
-    to_s
-  end
-end

data/lib/rollbar/core_ext/thread.rb

@@ -1,9 +0,0 @@
-class Thread
-  def initialize_with_rollbar(*args, &block)
-    self[:_rollbar_notifier] ||= Rollbar.notifier.scope
-    initialize_without_rollbar(*args, &block)
-  end
-
-  alias_method :initialize_without_rollbar, :initialize
-  alias_method :initialize, :initialize_with_rollbar
-end

data/lib/rollbar/goalie.rb

@@ -1,33 +0,0 @@
-module Goalie
-  class CustomErrorPages
-    alias_method :orig_render_exception, :render_exception
-
-    private
-
-    def render_exception(env, exception)
-      exception_data = nil
-      begin
-        controller = env['action_controller.instance']
-        request_data = controller.rollbar_request_data rescue nil
-        person_data = controller.rollbar_person_data rescue nil
-        exception_data = Rollbar.scope(:request => request_data, :person => person_data).error(exception, :use_exception_level_filters => true)
-      rescue => e
-        Rollbar.log_warning "[Rollbar] Exception while reporting exception to Rollbar: #{e}"
-      end
-
-      # if an exception was reported, save uuid in the env
-      # so it can be displayed to the user on the error page
-      if exception_data.is_a?(Hash)
-        env['rollbar.exception_uuid'] = exception_data[:uuid]
-        Rollbar.log_info "[Rollbar] Exception uuid saved in env: #{exception_data[:uuid]}"
-      elsif exception_data == 'disabled'
-        Rollbar.log_info "[Rollbar] Exception not reported because Rollbar is disabled"
-      elsif exception_data == 'ignored'
-        Rollbar.log_info "[Rollbar] Exception not reported because it was ignored"
-      end
-
-      # now continue as normal
-      orig_render_exception(env, exception)
-    end
-  end
-end

data/lib/rollbar/js/frameworks.rb

@@ -1,6 +0,0 @@
-module Rollbar
-  module Js
-    module Frameworks
-    end
-  end
-end

data/lib/rollbar/js/frameworks/rails.rb

@@ -1,49 +0,0 @@
-module Rollbar
-  module Js
-    module Frameworks
-      class Rails
-        attr_accessor :prepared
-
-        alias prepared? prepared
-
-        def prepare
-          return if prepared?
-
-          if secure_headers?
-            insert_middleware_after_secure_headers
-          else
-            insert_middleware
-          end
-
-          self.prepared = true
-        end
-
-        def insert_middleware_after_secure_headers
-          instance = self
-
-          Rollbar::Railtie.initializer 'rollbar.js.frameworks.rails', :after => 'secure_headers.middleware' do |_app|
-            instance.insert_middleware
-          end
-        end
-
-        def insert_middleware
-          require 'rollbar/js/middleware'
-
-          config = {
-            :options => Rollbar.configuration.js_options,
-            :enabled => Rollbar.configuration.js_enabled
-          }
-          rails_config.middleware.use(::Rollbar::Js::Middleware, config)
-        end
-
-        def secure_headers?
-          defined?(::SecureHeaders)
-        end
-
-        def rails_config
-          ::Rails.configuration
-        end
-      end
-    end
-  end
-end

data/lib/rollbar/js/version.rb

@@ -1,5 +0,0 @@
-module Rollbar
-  module Js
-    VERSION = "0.1.0"
-  end
-end