rollbar 2.0.2 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3192b99dde07b8f93d737831572a14e9c4a70fc8
-  data.tar.gz: 54e036304757db8f713901432e1674e4a4d15d26
+  metadata.gz: 141bbcb7b184a6e0a7330e36a03410eb8f7c27bb
+  data.tar.gz: bd98279d9c4ce8374777422c9f039f2d12679dea
 SHA512:
-  metadata.gz: eb3a1102861bad460201b1630e8f5f695f1d35f1597619031de0af24f74f88eb9d3416f93030f50ae2c42a9eb3261facd166af26bea23c7ff8d2be634d1c7815
-  data.tar.gz: 9224fceb5d30020abc43f760011cc6de687d177569ceba92d500991a9cfc64e88e6834aa700a2c21838e4141995481b15af26d4be6df2464e7d1e34b4d7e2c20
+  metadata.gz: 293b307609d27587058a3d08092de6354080e00b583bedce97efe65536d6350d98337fa39ad894fdd70059ea59022182bc50b534e59e82c6976447e7c564f441
+  data.tar.gz: d02ab75d127bee8545fc54060ed93bb5bad3a259d8ee05afa6a85c313cd3f736c0c950008f30cccd9c8ef67d226edaf898d39a4db44dc79675640c7843f561f0

data/.travis.yml

@@ -12,10 +12,9 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
-  - ruby-head
+  - 2.2.2
   - jruby-18mode
   - jruby-19mode
-  - jruby-head
   - rbx
 jdk:
   - openjdk6
@@ -90,61 +89,70 @@ matrix:
       jdk: oraclejdk8
 
     # TODO: comment as to why these are excluded
+    - rvm: 1.8.7
+      gemfile: gemfiles/rails31.gemfile
+    - rvm: 1.8.7
+      gemfile: gemfiles/rails32.gemfile
     - rvm: 1.8.7
       gemfile: gemfiles/rails40.gemfile
     - rvm: 1.8.7
       gemfile: gemfiles/rails41.gemfile
     - rvm: 1.8.7
-      gemfile: gemfiles/rails32.gemfile
-    - rvm: 1.8.7
+      gemfile: gemfiles/rails42.gemfile
+    - rvm: 1.9.2
       gemfile: gemfiles/rails31.gemfile
+    - rvm: 1.9.2
+      gemfile: gemfiles/rails32.gemfile
     - rvm: 1.9.2
       gemfile: gemfiles/rails40.gemfile
     - rvm: 1.9.2
       gemfile: gemfiles/rails41.gemfile
     - rvm: 1.9.2
-      gemfile: gemfiles/rails32.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/rails31.gemfile
-    - rvm: 1.9.3
-      gemfile: gemfiles/rails41.gemfile
-    - rvm: ruby-head
+      gemfile: gemfiles/rails42.gemfile
+    - rvm: 2.2.2
       gemfile: gemfiles/rails30.gemfile
-    - rvm: ruby-head
+    - rvm: 2.2.2
       gemfile: gemfiles/rails31.gemfile
-    - rvm: ruby-head
-      gemfile: gemfiles/rails40.gemfile
-    - rvm: ruby-head
-      gemfile: gemfiles/rails41.gemfile
     - rvm: jruby-18mode
       gemfile: gemfiles/rails30.gemfile
     - rvm: jruby-18mode
       gemfile: gemfiles/rails31.gemfile
+    - rvm: jruby-18mode
+      gemfile: gemfiles/rails32.gemfile
     - rvm: jruby-18mode
       gemfile: gemfiles/rails40.gemfile
     - rvm: jruby-18mode
       gemfile: gemfiles/rails41.gemfile
+    - rvm: jruby-18mode
+      gemfile: gemfiles/rails42.gemfile
     - rvm: jruby-19mode
       gemfile: gemfiles/rails30.gemfile
     - rvm: jruby-19mode
       gemfile: gemfiles/rails31.gemfile
     - rvm: jruby-19mode
-      gemfile: gemfiles/rails40.gemfile
+      gemfile: gemfiles/rails32.gemfile
     - rvm: jruby-19mode
-      gemfile: gemfiles/rails41.gemfile
-    - rvm: jruby-head
-      gemfile: gemfiles/rails30.gemfile
-    - rvm: jruby-head
-      gemfile: gemfiles/rails31.gemfile
-    - rvm: jruby-head
       gemfile: gemfiles/rails40.gemfile
-    - rvm: jruby-head
+    - rvm: jruby-19mode
       gemfile: gemfiles/rails41.gemfile
+    - rvm: jruby-19mode
+      gemfile: gemfiles/rails42.gemfile
     - rvm: rbx
       gemfile: gemfiles/rails30.gemfile
     - rvm: rbx
       gemfile: gemfiles/rails31.gemfile
+    - rvm: rbx
+      gemfile: gemfiles/rails32.gemfile
     - rvm: rbx
       gemfile: gemfiles/rails40.gemfile
     - rvm: rbx
       gemfile: gemfiles/rails41.gemfile
+    - rvm: rbx
+      gemfile: gemfiles/rails42.gemfile
+gemfile:
+  - gemfiles/rails30.gemfile
+  - gemfiles/rails31.gemfile
+  - gemfiles/rails32.gemfile
+  - gemfiles/rails40.gemfile
+  - gemfiles/rails41.gemfile
+  - gemfiles/rails42.gemfile

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## 2.1.0
+
+New feature:
+
+- If you use `ActiveJob`, you can now include the `Rollbar::ActiveJob` module into your ActiveJob classes. Then, errors happening in your jobs will be automatically reported to Rollbar.
+
 ## 2.0.2
 
 Bug fixes:

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.0.2)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v2.1.0)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 [Rollbar](https://rollbar.com) is an error tracking service for Ruby and other languages. The Rollbar service will alert you of problems with your code and help you understand them in a ways never possible before. We love it and we hope you will too.
@@ -12,7 +12,7 @@ This is the Ruby library for Rollbar. It will instrument many kinds of Ruby appl
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rollbar', '~> 2.0.2
+gem 'rollbar', '~> 2.1.0
 ```
 
 And then execute:
@@ -400,6 +400,18 @@ Rollbar.configure do |config|
 end
 ```
 
+## ActiveJob integration
+
+Include the module `Rollbar::ActiveJob` in you jobs to report any uncaught errors in a job to Rollbar.
+
+```ruby
+class YourAwesomeJob < ActiveJob::Base
+  include Rollbar::ActiveJob
+end
+```
+
+If you need to customize the reporting write your own `rescue_from` handler instead of using the `Rollbar::ActiveJob` module.
+
 ## Delayed::Job integration
 
 If `delayed_job` is defined, Rollbar will automatically install a plugin that reports any uncaught exceptions that occur in jobs.

data/gemfiles/rails32.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "test-unit"   # Please see https://github.com/rspec/rspec-rails/issues/1273
 gem "sqlite3", :platform => [:ruby, :mswin, :mingw]
 gem "jruby-openssl", :platform => :jruby
 gem "activerecord-jdbcsqlite3-adapter", :platform => :jruby
@@ -11,6 +12,6 @@ gem "racc", :platform => :rbx
 gem "minitest", :platform => :rbx
 gem "rubysl-test-unit", :platform => :rbx
 gem "rubinius-developer_tools", :platform => :rbx
-gem "rails", "3.2.21"
+gem "rails", "3.2.22"
 
 gemspec :path => "../"

data/gemfiles/rails40.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "test-unit"   # Please see https://github.com/rspec/rspec-rails/issues/1273
 gem "sqlite3", :platform => [:ruby, :mswin, :mingw]
 gem "jruby-openssl", :platform => :jruby
 gem "activerecord-jdbcsqlite3-adapter", :platform => :jruby

data/gemfiles/rails41.gemfile

@@ -10,6 +10,6 @@ gem "rubysl", "~> 2.0", :platform => :rbx
 gem "racc", :platform => :rbx
 gem "minitest", :platform => :rbx
 gem "rubinius-developer_tools", :platform => :rbx
-gem "rails", "4.1.9"
+gem "rails", "4.1.12"
 
 gemspec :path => "../"

data/gemfiles/rails42.gemfile

@@ -0,0 +1,15 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "sqlite3", :platform => [:ruby, :mswin, :mingw]
+gem "jruby-openssl", :platform => :jruby
+gem "activerecord-jdbcsqlite3-adapter", :platform => :jruby
+gem "appraisal"
+gem "rubysl", "~> 2.0", :platform => :rbx
+gem "racc", :platform => :rbx
+gem "minitest", :platform => :rbx
+gem "rubinius-developer_tools", :platform => :rbx
+gem "rails", "4.2.3"
+
+gemspec :path => "../"

data/lib/rollbar.rb

@@ -723,6 +723,7 @@ module Rollbar
 
       require 'rollbar/active_record_extension' if defined?(ActiveRecord)
       require 'rollbar/sidekiq' if defined?(Sidekiq)
+      require 'rollbar/active_job' if defined?(ActiveJob)
       require 'rollbar/goalie' if defined?(Goalie)
       require 'rollbar/rack' if defined?(Rack)
       require 'rollbar/rake' if defined?(Rake)

data/lib/rollbar/active_job.rb

@@ -0,0 +1,10 @@
+module Rollbar
+  # Report any uncaught errors in a job to Rollbar
+  module ActiveJob
+    def self.included(base)
+      base.send :rescue_from, Exception do |exception|
+        Rollbar.error(exception, :job => self.class.name, :job_id => job_id)
+      end
+    end
+  end
+end

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "2.0.2"
+  VERSION = "2.1.0"
 end

data/rollbar.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |gem|
   gem.description   = %q{Rails plugin to catch and send exceptions to Rollbar}
   gem.executables   = ['rollbar-rails-runner']
   gem.summary       = %q{Reports exceptions to Rollbar}
-  gem.homepage      = "https://github.com/rollbar/rollbar-gem"
+  gem.homepage      = "https://rollbar.com"
   gem.license       = 'MIT'
 
   gem.files         = `git ls-files`.split($\)

data/spec/controllers/home_controller_spec.rb

@@ -160,7 +160,7 @@ describe HomeController do
       end
 
       it "should save controller and action in the payload body" do
-        post 'report_exception'
+        post '/report_exception'
 
         route = controller.send(:rollbar_request_data)[:route]
 
@@ -183,7 +183,7 @@ describe HomeController do
         :secret_token => "f6805fea1cae0fb79c5e63bbdcd12bc6",
       }
 
-      post 'report_exception', params
+      post '/report_exception', params
 
       filtered = Rollbar.last_report[:request][:params]
 
@@ -206,7 +206,7 @@ describe HomeController do
         :notpass => "hidden"
       }
 
-      post 'report_exception', params
+      post '/report_exception', params
 
       filtered = Rollbar.last_report[:request][:params]
 
@@ -231,14 +231,14 @@ describe HomeController do
     it "should raise a NameError and report an exception after a GET" do
       logger_mock.should_receive(:info).with('[Rollbar] Success').once
 
-      get 'report_exception'
+      get '/report_exception'
       response.should be_success
     end
 
     it "should raise a NameError and have PUT params in the reported exception" do
       logger_mock.should_receive(:info).with('[Rollbar] Success')
 
-      put 'report_exception', :putparam => "putval"
+      put '/report_exception', :putparam => "putval"
 
       Rollbar.last_report.should_not be_nil
       Rollbar.last_report[:request][:params]["putparam"].should == "putval"
@@ -260,7 +260,7 @@ describe HomeController do
       @request.env["HTTP_ACCEPT"] = "application/json"
 
       params = { :jsonparam => 'jsonval' }.to_json
-      post 'report_exception', params, { 'CONTENT_TYPE' => 'application/json' }
+      post '/report_exception', params, { 'CONTENT_TYPE' => 'application/json' }
 
       Rollbar.last_report.should_not be_nil
       Rollbar.last_report[:request][:params]['jsonparam'].should == 'jsonval'
@@ -271,7 +271,7 @@ describe HomeController do
     it "should raise an uncaught exception and report a message" do
       logger_mock.should_receive(:info).with('[Rollbar] Success').once
 
-      expect { get 'cause_exception' }.to raise_exception
+      expect { get '/cause_exception' }.to raise_exception
     end
 
     context 'show_exceptions' do
@@ -298,7 +298,7 @@ describe HomeController do
       it "middleware should catch the exception and only report to rollbar once" do
         logger_mock.should_receive(:info).with('[Rollbar] Success').once
 
-        get 'cause_exception'
+        get '/cause_exception'
       end
 
       it 'should not fail if the controller doesnt contain the person method' do
@@ -306,7 +306,7 @@ describe HomeController do
           config.person_method = 'invalid_method'
         end
 
-        get 'cause_exception'
+        get '/cause_exception'
       end
 
       context 'with logged user' do
@@ -318,7 +318,7 @@ describe HomeController do
         before { cookies[:session_id] = user.id }
 
         it 'sends the current user data' do
-          put 'report_exception', 'foo' => 'bar'
+          put '/report_exception', 'foo' => 'bar'
 
           person_data = Rollbar.last_report[:person]
 

data/spec/requests/home_spec.rb

@@ -12,7 +12,7 @@ describe HomeController do
     it "should report uncaught exceptions" do
       # only seems to be relevant in 3.1 and 3.2
       if ::Rails::VERSION::STRING.starts_with? "3.1" or ::Rails::VERSION::STRING.starts_with? "3.2"
-        expect{ get 'current_user', nil, :cookie => '8%B' }.to raise_exception
+        expect { get '/current_user', nil, :cookie => '8%B' }.to raise_exception
 
         Rollbar.last_report.should_not be_nil
 
@@ -37,7 +37,7 @@ describe HomeController do
     end
 
     it "should report uncaught exceptions" do
-      expect { get 'current_user' }.to raise_exception
+      expect { get '/current_user' }.to raise_exception
 
       body = Rollbar.last_report[:body]
       trace = body[:trace] && body[:trace] || body[:trace_chain][0]

data/spec/rollbar/active_job_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+require 'active_support/rescuable'
+require 'rollbar/active_job'
+
+describe Rollbar::ActiveJob do
+  class TestJob
+    # To mix in rescue_from
+    include ActiveSupport::Rescuable
+    include Rollbar::ActiveJob
+
+    attr_reader :job_id
+
+    def perform(exception, job_id)
+      @job_id = job_id
+      # ActiveJob calls rescue_with_handler when a job raises an exception
+      rescue_with_handler(exception) || raise(exception)
+    end
+  end
+
+  let(:exception) { StandardError.new('oh no') }
+  let(:job_id) { "123" }
+
+  it "reports the error to Rollbar" do
+    expected_params = { :job => "TestJob", :job_id => job_id }
+    expect(Rollbar).to receive(:error).with(exception, expected_params)
+    expect { TestJob.new.perform(exception, job_id) }.not_to raise_error
+  end
+end

data/spec/rollbar/logger_proxy_spec.rb

@@ -24,11 +24,10 @@ describe Rollbar::LoggerProxy do
 
   describe '#call' do
     context 'if the logger fails' do
-      let(:exception) { StandardError.new }
       it 'doesnt raise' do
-        allow(logger).to receive(:info).and_raise(exception)
+        allow(logger).to receive(:info).and_raise(StandardError.new)
 
-        expect { subject.log('info', message) }.not_to raise_error(exception)
+        expect { subject.log('info', message) }.not_to raise_error
       end
     end
   end

data/spec/rollbar/truncation/min_body_strategy_spec.rb

@@ -17,7 +17,7 @@ describe Rollbar::Truncation::MinBodyStrategy do
         result = Rollbar::JSON.load(described_class.call(payload))
 
         trace = result['data']['body']['trace']
-        expect(trace['frames']).to have(2).items
+        expect(trace['frames'].count).to eq 2
         expect(trace['exception']['message']).to be_eql('a' * 255)
       end
     end
@@ -36,10 +36,10 @@ describe Rollbar::Truncation::MinBodyStrategy do
         result = Rollbar::JSON.load(described_class.call(payload))
 
         traces = result['data']['body']['trace_chain']
-        expect(traces[0]['frames']).to have(2).items
+        expect(traces[0]['frames'].count).to eq 2
         expect(traces[0]['exception']['message']).to be_eql('a' * 255)
 
-        expect(traces[1]['frames']).to have(2).items
+        expect(traces[1]['frames'].count).to eq 2
         expect(traces[1]['exception']['message']).to be_eql('a' * 255)
       end
     end

data/spec/rollbar_spec.rb

@@ -444,7 +444,7 @@ describe Rollbar do
 
         payload = notifier.send(:build_payload, 'info', 'message', nil, nil)
 
-        payload['data'][:project_package_paths].should have(2).items
+        expect(payload['data'][:project_package_paths].count).to eq 2
       end
 
       it 'should include a code_version' do
@@ -943,7 +943,7 @@ describe Rollbar do
       filepaths = last_report[:body][:trace][:frames].map {|frame| frame[:filename] }.reverse
 
       expect(filepaths[0]).not_to include(gem_lib_dir)
-      expect(filepaths.any? {|filepath| filepath.include?(gem_dir) }).to be_true
+      expect(filepaths.any? {|filepath| filepath.include?(gem_dir) }).to eq true
     end
 
     it 'should return the exception data with a uuid, on platforms with SecureRandom' do
@@ -1361,7 +1361,7 @@ describe Rollbar do
     it 'should have use the Rails logger when configured to do so' do
       configure
       expect(Rollbar.send(:logger)).to be_kind_of(Rollbar::LoggerProxy)
-      expect(Rollbar.send(:logger).object).should == ::Rails.logger
+      expect(Rollbar.send(:logger).object).to eq ::Rails.logger
     end
 
     it 'should use the default_logger when no logger is set' do
@@ -1720,7 +1720,7 @@ describe Rollbar do
   describe '#custom_data' do
     before do
       Rollbar.configure do |config|
-        config.custom_data_method = proc { raise 'this-will-raise' } 
+        config.custom_data_method = proc { raise 'this-will-raise' }
       end
 
       expect_any_instance_of(Rollbar::Notifier).to receive(:error).and_return(report_data)

data/spec/spec_helper.rb

@@ -24,7 +24,7 @@ RSpec.configure do |config|
   config.include(FixtureHelpers)
   config.include(EncodingHelpers)
 
-  config.color_enabled = true
+  config.color = true
   config.formatter = 'documentation'
 
   config.use_transactional_fixtures = true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-07-22 00:00:00.000000000 Z
+date: 2015-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -203,10 +203,12 @@ files:
 - gemfiles/rails32.gemfile
 - gemfiles/rails40.gemfile
 - gemfiles/rails41.gemfile
+- gemfiles/rails42.gemfile
 - lib/generators/rollbar/rollbar_generator.rb
 - lib/generators/rollbar/templates/initializer.rb
 - lib/rails/rollbar_runner.rb
 - lib/rollbar.rb
+- lib/rollbar/active_job.rb
 - lib/rollbar/active_record_extension.rb
 - lib/rollbar/better_errors.rb
 - lib/rollbar/capistrano.rb
@@ -309,6 +311,7 @@ files:
 - spec/fixtures/payloads/sample.trace_chain.json
 - spec/generators/rollbar/rollbar_generator_spec.rb
 - spec/requests/home_spec.rb
+- spec/rollbar/active_job_spec.rb
 - spec/rollbar/configuration_spec.rb
 - spec/rollbar/delay/girl_friday_spec.rb
 - spec/rollbar/delay/resque_spec.rb
@@ -335,7 +338,7 @@ files:
 - spec/support/get_ip_raising.rb
 - spec/support/notifier_helpers.rb
 - spec/support/shared_contexts.rb
-homepage: https://github.com/rollbar/rollbar-gem
+homepage: https://rollbar.com
 licenses:
 - MIT
 metadata: {}
@@ -418,6 +421,7 @@ test_files:
 - spec/fixtures/payloads/sample.trace_chain.json
 - spec/generators/rollbar/rollbar_generator_spec.rb
 - spec/requests/home_spec.rb
+- spec/rollbar/active_job_spec.rb
 - spec/rollbar/configuration_spec.rb
 - spec/rollbar/delay/girl_friday_spec.rb
 - spec/rollbar/delay/resque_spec.rb