rollbar 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f74dc5fc9ff24bdca6794e33d2b5b97b7d431c32
-  data.tar.gz: 40d644a903089a249e2f745cd419c563d666886e
+  metadata.gz: c71304582c4e3e90c305212907f516cce923104a
+  data.tar.gz: 233e2f5605cefcdce34ae82021d176c349c5fbb0
 SHA512:
-  metadata.gz: c8cf1b1c07b04b0a14487d38209206cea6c360a4c901c776061cfbf67808443fce33fa4726f2dbac0d29ac52b180e07fbc8b564c5f9a852a6062e5b31e6ae811
-  data.tar.gz: 49f9c3af52d8933fd5241bd6a344d85ecc52716243d485f2558bcdf89dda9506e3dc5b51b789b87a7d9776ee12ee0c4c3a2761dd3e59054f646285f133884875
+  metadata.gz: ea71e508f060e52cc6e80320035fd9f97ad269ba3a7635b1dce6554910ed18f3be0cab12ecb373f2d1f6b9213d28b87d7f85bd470926e26b3b44328adb246d3d
+  data.tar.gz: d7399f7773162732ddba0f66f5080818005308d03ab8e4d3e110b966b54d595439f2ccaa5cc16a85b997cd22939d9ec1de2777862e4d9dc675a4004b26d285f4

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## 1.4.2
+
+Bug fixes:
+
+- Fix null 'context' in internal error reports. See [#208](https://github.com/rollbar/rollbar-gem/pull/208)
+
 ## 1.4.1
 
 Bug fixes:

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.4.1)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.4.2)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https://rollbar.com).
@@ -9,7 +9,7 @@ Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https:/
 
 Add this line to your application's Gemfile:
 
-    gem 'rollbar', '~> 1.4.1'
+    gem 'rollbar', '~> 1.4.2'
 
 And then execute:
 

data/lib/rollbar.rb

@@ -228,15 +228,8 @@ module Rollbar
       if data[:person]
         person_id = data[:person][configuration.person_id_method.to_sym]
         return 'ignored' if configuration.ignored_person_ids.include?(person_id)
-
-        is_proc = data[:person].respond_to?(:call)
-        data[:person] = data[:person].call if is_proc
       end
 
-      data[:request] = data[:request].call if data[:request].respond_to?(:call)
-      data[:context] = data[:context].call if data[:context].respond_to?(:call)
-      data.delete(:context) unless data[:context]
-
       schedule_payload(payload)
 
       log_instance_link(data)
@@ -300,6 +293,14 @@ module Rollbar
 
       Rollbar::Util.deep_merge(data, configuration.payload_options)
 
+      data[:person] = data[:person].call if data[:person].respond_to?(:call)
+      data[:request] = data[:request].call if data[:request].respond_to?(:call)
+      data[:context] = data[:context].call if data[:context].respond_to?(:call)
+
+      # Our API doesn't allow null context values, so just delete
+      # the key if value is nil.
+      data.delete(:context) unless data[:context]
+
       payload = {
         'access_token' => configuration.access_token,
         'data' => data

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "1.4.1"
+  VERSION = "1.4.2"
 end

data/spec/rollbar_spec.rb

@@ -1,4 +1,4 @@
-# encoding: UTF-8
+# encoding: utf-8
 
 require 'logger'
 require 'socket'
@@ -1490,6 +1490,25 @@ describe Rollbar do
     end
   end
 
+  context 'when reporting internal error with nil context' do
+    let(:context_proc) { proc {} }
+    let(:scoped_notifier) { notifier.scope(:context => context_proc) }
+    let(:exception) { Exception.new }
+    let(:logger_mock) { double("Rails.logger").as_null_object }
+
+    it 'reports successfully' do
+      configure
+
+      Rollbar.configure do |config|
+        config.logger = logger_mock
+      end
+
+      logger_mock.should_receive(:info).with('[Rollbar] Sending payload').once
+      logger_mock.should_receive(:info).with('[Rollbar] Success').once
+      scoped_notifier.send(:report_internal_error, exception)
+    end
+  end
+
   context "request_data_extractor" do
     before(:each) do
       class DummyClass

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-20 00:00:00.000000000 Z
+date: 2015-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json