rollbar 1.2.8 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7601f7e94acde264cb7c32f5ab7360a8f1b60316
-  data.tar.gz: 54c7075daf5c090a9cf143f7795931f4744a5e2c
+  metadata.gz: e9493d3e9cc3010a83a29d4f9557427033205990
+  data.tar.gz: 4428dd3601a7caa1e03d1ef9c69b06b024646642
 SHA512:
-  metadata.gz: c9b0da8ae42a915de193b95d63f9e3e60325af0aa799c060dc0453258e602ee3b1330552a68429237bee75c5c6bf18b442623bb53a6efd74a394675d8c7cf7d2
-  data.tar.gz: 2d360c8176626f5a7fb15cfbf8d6ec48801b68970c4304afc898f6ea8fec785d128e347be2988814c481c4c57f65dc8b6f337322533ccd10b98a9afc87128a6a
+  metadata.gz: fc0e09305ff42a01f654ddb8b89762a5d0466adf0a34d2a179ec0332ccf28ab8dda8deae16d3932fdb075714f4ce469aa8a53d9af78d08284335e259fd9314ec
+  data.tar.gz: 703b39ce8494345fbfd88c2268a4042dd24df9364b0f920289e1314f2cc192098d5ad36b067b967e42b4a0529eebd80254792c5535a46a7150be0174a7f4d226

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Change Log
 
+## 1.2.9
+
+Bug fixes:
+
+- Fix issue causing request and person data to not be collected for RoutingErrors. See [#178](https://github.com/rollbar/rollbar-gem/pull/178)
+
+
 ## 1.2.8
 
 New features:

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.2.8)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.2.9)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https://rollbar.com).
@@ -9,7 +9,7 @@ Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https:/
 
 Add this line to your application's Gemfile:
 
-    gem 'rollbar', '~> 1.2.8'
+    gem 'rollbar', '~> 1.2.9'
 
 And then execute:
 

data/lib/rollbar/exception_reporter.rb

@@ -1,7 +1,8 @@
 module Rollbar
   module ExceptionReporter
     def report_exception_to_rollbar(env, exception)
-      Rollbar.log_debug "[Rollbar] Reporting exception: #{exception.try(:message)}"
+      exception_message = exception.respond_to?(:message) ? exception.message : 'No Exception Message'
+      Rollbar.log_debug "[Rollbar] Reporting exception: #{exception_message}"
 
       exception_data = Rollbar.log(Rollbar.configuration.uncaught_exception_level, exception)
 

data/lib/rollbar/middleware/rails/rollbar.rb

@@ -15,7 +15,9 @@ module Rollbar
         def call(env)
           Rollbar.reset_notifier!
 
-          Rollbar.scoped(fetch_scope(env)) do
+          env['rollbar.scope'] = scope = fetch_scope(env)
+
+          Rollbar.scoped(scope) do
             begin
               response = @app.call(env)
 

data/lib/rollbar/middleware/rails/show_exceptions.rb

@@ -6,10 +6,15 @@ module Rollbar
 
         def render_exception_with_rollbar(env, exception)
           key = 'action_dispatch.show_detailed_exceptions'
-          if exception.is_a? ActionController::RoutingError and env[key]
-            report_exception_to_rollbar(env, exception)
+
+          if exception.is_a?(ActionController::RoutingError) && env[key]
+            scope = extract_scope_from(env)
+
+            Rollbar.scoped(scope) do
+              report_exception_to_rollbar(env, exception)
+            end
           end
-          
+
           render_exception_without_rollbar(env, exception)
         end
 
@@ -17,10 +22,22 @@ module Rollbar
           call_without_rollbar(env)
         rescue ActionController::RoutingError => exception
           # won't reach here if show_detailed_exceptions is true
-          report_exception_to_rollbar(env, exception)
+          scope = extract_scope_from(env)
+
+          Rollbar.scoped(scope) do
+            report_exception_to_rollbar(env, exception)
+          end
+
           raise exception
         end
 
+        def extract_scope_from(env)
+          scope = env['rollbar.scope']
+          Rollbar.log_warn('[Rollbar] rollbar.scope key has being removed from Rack env.') unless scope
+
+          scope || {}
+        end
+
         def self.included(base)
           base.send(:alias_method_chain, :call, :rollbar)
           base.send(:alias_method_chain, :render_exception, :rollbar)

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "1.2.8"
+  VERSION = "1.2.9"
 end

data/spec/controllers/home_controller_spec.rb

@@ -330,6 +330,15 @@ describe HomeController do
     end
   end
 
+  context 'with routing errors', :type => :request do
+    it 'raises a RoutingError exception' do
+      expect { get '/foo/bar', :foo => :bar }.to raise_exception
+
+      report = Rollbar.last_report
+      expect(report[:request][:params]['foo']).to be_eql('bar')
+    end
+  end
+
   after(:each) do
     Rollbar.configure do |config|
       config.logger = ::Rails.logger

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.9
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-13 00:00:00.000000000 Z
+date: 2014-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json