rollbar 1.2.6 → 1.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 351948d24ee5ac0337e6634714c7ea4d7e249ba8
-  data.tar.gz: 955b414770c864582161de98a11b1058f6e64e60
+  metadata.gz: 07ce16a5ab6884c863b075b5577833c618d95331
+  data.tar.gz: 4179b7db73210d42a749530727e16a99851bc932
 SHA512:
-  metadata.gz: 2363a7f139ec3b1dec85d257991b2bbc3723a7e57b4685aa348e6f374ce0611741cdb84caab134dbb46a65980d50d3a9fd9b8714a2e073780d12e3ce9ae6bc6c
-  data.tar.gz: 4f239f26138c594cb162d5b185f3210dcaf07ee0fa6a3f1159bf1bd46290a6fef9e049df144a7c70ceac1e4e39e107a497330c613072998fb7848fd92e9bef43
+  metadata.gz: 5c660d4e522c250e09638d12a67c25e13e44bfa8bb3ca6175333ae0be0429432bf8bc3f7a4f5e3a0f502f5be44fde5ff7fe14c1b259bd09ea7b9ca11646f9c3b
+  data.tar.gz: 5709042d36222c875d3de163d53f073f1367db082c931829f75115624dfa5d4aa77b6a5ba7120277afa416494048be2bd568a70527fdc4b86430287249a936e7

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+**1.2.7**
+- Restore `exception_level_filters` feature, which was inadvertently removed in 1.2.0. See [#160](https://github.com/rollbar/rollbar-gem/pull/160) 
+- Fix bug where rollbar_url incorrectly handled comma-separated X-Forwarded-Proto header values. See [#112](https://github.com/rollbar/rollbar-gem/issues/112)
+
 **1.2.6**
 - Fix bug in non-Rails environments. See [#155](https://github.com/rollbar/rollbar-gem/pull/155)
 - Fix intermittent test failures

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.2.6)](https://travis-ci.org/rollbar/rollbar-gem/branches)
+# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.2.7)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https://rollbar.com).
@@ -9,7 +9,7 @@ Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https:/
 
 Add this line to your application's Gemfile:
 
-    gem 'rollbar', '~> 1.2.6'
+    gem 'rollbar', '~> 1.2.7'
 
 And then execute:
 
@@ -57,7 +57,7 @@ Be sure to initialize Rollbar with your access token somewhere during startup:
 
 ```ruby
 Rollbar.configure do |config|
-  config.access_token = POST_SERVER_ITEM_ACCESS_TOKEN
+  config.access_token = 'POST_SERVER_ITEM_ACCESS_TOKEN'
   # other configuration settings
   # ...
 end

data/THANKS.md

@@ -4,6 +4,7 @@ Huge thanks to the following contributors (by github username). For the most up-
 
 - [alexdunae](https://github.com/alexdunae)
 - [allspiritseve](https://github.com/allspiritseve)
+- [antico5](https://github.com/antico5)
 - [arr-ee](https://github.com/arr-ee)
 - [awmichel](https://github.com/awmichel)
 - [bradx3](https://github.com/bradx3)

data/lib/rollbar.rb

@@ -128,6 +128,9 @@ module Rollbar
 
       return 'ignored' if ignored?(exception)
 
+      exception_level = filtered_level(exception)
+      level = exception_level if exception_level
+
       begin
         report(level, message, exception, extra)
       rescue Exception => e
@@ -191,6 +194,8 @@ module Rollbar
     end
 
     def filtered_level(exception)
+      return unless exception
+
       filter = configuration.exception_level_filters[exception.class.name]
       if filter.respond_to?(:call)
         filter.call(exception)

data/lib/rollbar/request_data_extractor.rb

@@ -78,7 +78,8 @@ module Rollbar
     end
 
     def rollbar_url(env)
-      scheme = env['HTTP_X_FORWARDED_PROTO'] || env['rack.url_scheme']
+      forwarded_proto = env['HTTP_X_FORWARDED_PROTO'] || env['rack.url_scheme'] || ''
+      scheme = forwarded_proto.split(',').first
 
       host = env['HTTP_X_FORWARDED_HOST'] || env['HTTP_HOST'] || env['SERVER_NAME']
       path = env['ORIGINAL_FULLPATH'] || env['REQUEST_URI']

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "1.2.6"
+  VERSION = "1.2.7"
 end

data/spec/rollbar/middleware/rack/builder_spec.rb

@@ -85,4 +85,45 @@ describe Rollbar::Middleware::Rack::Builder, :reconfigure_notifier => true do
       expect(reported_params['body.value']).to be_eql(1000)
     end
   end
+
+  context 'with multiple HTTP_X_FORWARDED_PROTO values' do
+    let(:headers) do
+      { 'HTTP_X_FORWARDED_PROTO' => 'https,http' }
+    end
+
+    it 'uses the first scheme to generate the url' do
+      expect do
+        request.post('/will_crash', headers)
+      end.to raise_error(exception)
+
+      last_report = Rollbar.last_report
+      expect(last_report[:request][:url]).to match(/https:/)
+    end
+  end
+
+  context 'without HTTP_X_FORWARDED_PROTO' do
+    it 'uses the the url_scheme set by Rack' do
+      expect do
+        request.post('/will_crash')
+      end.to raise_error(exception)
+
+      last_report = Rollbar.last_report
+      expect(last_report[:request][:url]).to match(/http:/)
+    end
+  end
+
+  context 'with single HTTP_X_FORWARDED_PROTO value' do
+    let(:headers) do
+      { 'HTTP_X_FORWARDED_PROTO' => 'https' }
+    end
+
+    it 'uses the scheme received in X-Forwarded-Proto header' do
+      expect do
+        request.post('/will_crash', headers)
+      end.to raise_error(exception)
+
+      last_report = Rollbar.last_report
+      expect(last_report[:request][:url]).to match(/https:/)
+    end
+  end
 end

data/spec/rollbar_spec.rb

@@ -725,6 +725,15 @@ describe Rollbar do
       Rollbar.error(exception)
     end
 
+    it 'sends the correct filtered level' do
+      Rollbar.configure do |config|
+        config.exception_level_filters = { 'NameError' => 'warning' }
+      end
+
+      Rollbar.error(exception)
+      expect(Rollbar.last_report[:level]).to be_eql('warning')
+    end
+
     it "should work with an IO object as rack.errors" do
       logger_mock.should_receive(:info).with('[Rollbar] Success')
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 1.2.6
+  version: 1.2.7
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-28 00:00:00.000000000 Z
+date: 2014-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json