rollbar 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 974df157ef4f414f7ced05c23d2d0be0f4d49a9f
-  data.tar.gz: 479ae3bd11bb3de2de5642f3b276f58a40640924
+  metadata.gz: 848cb96180e379178a47ca132eb966b8564907f6
+  data.tar.gz: 59a914a93b7358d55000ab5ed4c56ec66bff6661
 SHA512:
-  metadata.gz: f6cc68a7e71d5d3aa58665ad4413a2bf865346d4b187147206c1075d5dc06832bdd0a1d43231f275fd97b265dc813dcf3376932f1111fdbf235d9cc498887d24
-  data.tar.gz: 65e503c7599b35d659f2a2f45687a3e089ce034913279bd3ac1919ebc29c6dd31966f5dd881e17b01c137c943240319cd6592e507a5e968c7b1c468bd0d1fd0a
+  metadata.gz: 6548900e375f976d9a07bd1a9c3c466315ce71eebd076c67f008926fc697a3dbdceacca958ff3cae0dd7d6c435af43fd3be89bf29ac53ef139d134458488a2ff
+  data.tar.gz: f4cae49db511b1ee6ec231eabde6090e5a37344b4f25d23bc5adee7815d3bb8db77fcd2db3d810ecc521f36ed89bd94b5b20e2402127029327784c1a0031b39b

data/CHANGELOG.md

@@ -1,7 +1,9 @@
 # Change Log
 
-**1.2.3**
+**1.2.4**
 - Fix issue where requiring 'rack' unnecessarily broke things in non-rack apps. See [#150](https://github.com/rollbar/rollbar-gem/pull/150)
+
+**1.2.3**
 - Bring back `enforce_valid_utf8`, which got lost in the 1.2.0 upgrade. See [#148](https://github.com/rollbar/rollbar-gem/pull/148)
 - Fix bug with raw post extraction for application/json requests. See [#147](https://github.com/rollbar/rollbar-gem/pull/147)
 

data/lib/rollbar.rb

@@ -12,7 +12,6 @@ end
 require 'rollbar/version'
 require 'rollbar/configuration'
 require 'rollbar/logger_proxy'
-require 'rollbar/request_data_extractor'
 require 'rollbar/exception_reporter'
 require 'rollbar/active_record_extension' if defined?(ActiveRecord)
 require 'rollbar/util'

data/lib/rollbar/exception_reporter.rb

@@ -1,12 +1,10 @@
 module Rollbar
   module ExceptionReporter
-    include RequestDataExtractor
-
     def report_exception_to_rollbar(env, exception)
       Rollbar.log_debug "[Rollbar] Reporting exception: #{exception.try(:message)}"
-      
+
       exception_data = Rollbar.log(Rollbar.configuration.uncaught_exception_level, exception)
-      
+
       if exception_data.is_a?(Hash)
         env['rollbar.exception_uuid'] = exception_data[:uuid]
         Rollbar.log_debug "[Rollbar] Exception uuid saved in env: #{exception_data[:uuid]}"

data/lib/rollbar/middleware/rails/rollbar.rb

@@ -1,3 +1,6 @@
+require 'rollbar/request_data_extractor'
+require 'rollbar/exception_reporter'
+
 module Rollbar
   module Middleware
     module Rails

data/lib/rollbar/rails/controller_methods.rb

@@ -1,3 +1,5 @@
+require 'rollbar/request_data_extractor'
+
 module Rollbar
   module Rails
     module ControllerMethods

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "1.2.3"
+  VERSION = "1.2.4"
 end

data/spec/rollbar_spec.rb

@@ -606,44 +606,6 @@ describe Rollbar do
       end
     end
 
-    context 'enforce_valid_utf8' do
-      it 'should replace invalid utf8 values' do
-        payload = {
-          :bad_value => "bad value 1\255",
-          :bad_value_2 => "bad\255 value 2",
-          "bad\255 key" => "good value",
-          :hash => {
-            :inner_bad_value => "\255\255bad value 3",
-            "inner \255bad key" => 'inner good value',
-            "bad array key\255" => [
-              'good array value 1',
-              "bad\255 array value 1\255",
-              {
-                :inner_inner_bad => "bad inner \255inner value"
-              }
-            ]
-          }
-        }
-
-        payload_copy = payload.clone
-        notifier.send(:enforce_valid_utf8, payload_copy)
-
-        payload_copy[:bad_value].should == "bad value 1"
-        payload_copy[:bad_value_2].should == "bad value 2"
-        payload_copy["bad key"].should == "good value"
-        payload_copy.keys.should_not include("bad\456 key")
-        payload_copy[:hash][:inner_bad_value].should == "bad value 3"
-        payload_copy[:hash]["inner bad key"].should == 'inner good value'
-        payload_copy[:hash]["bad array key"].should == [
-          'good array value 1',
-          'bad array value 1',
-          {
-            :inner_inner_bad => 'bad inner inner value'
-          }
-        ]
-      end
-    end
-
     context 'truncate_payload' do
       it 'should truncate all nested strings in the payload' do
         payload = {
@@ -908,6 +870,19 @@ describe Rollbar do
 
       payload['data'][:level].should == 'debug'
     end
+
+    context 'with invalid utf8 encoding' do
+      let(:extra) do
+        { :extra => "bad value 1\255" }
+      end
+
+      it 'removes te invalid characteres' do
+        Rollbar.info('removing invalid chars', extra)
+
+        extra_value = Rollbar.last_report[:body][:message][:extra][:extra]
+        expect(extra_value).to be_eql('bad value 1')
+      end
+    end
   end
 
   # Backwards

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-22 00:00:00.000000000 Z
+date: 2014-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json