rollbar 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a432f94f474059f9731e64f22f23963c4b3926e
-  data.tar.gz: 0ccbc7ed06b952be8139592dcc7e40ca8ff396be
+  metadata.gz: 974df157ef4f414f7ced05c23d2d0be0f4d49a9f
+  data.tar.gz: 479ae3bd11bb3de2de5642f3b276f58a40640924
 SHA512:
-  metadata.gz: 098d37ecd9ba8c011bc73fb23da48d90d19c70d123a455412ede696de8b22c369a76b3a80fb9d8874afc6c7ab3c2dadda2a205ad1b7e8430f3e68339d68b837d
-  data.tar.gz: ba67c227bd1f08f21943cfcfa58a043c0be64845d5e98b227456fac58caecb2713110322c1c10482d14ef2e490a12fcfaf7c2eb5b80c37a198211fd7e3460c72
+  metadata.gz: f6cc68a7e71d5d3aa58665ad4413a2bf865346d4b187147206c1075d5dc06832bdd0a1d43231f275fd97b265dc813dcf3376932f1111fdbf235d9cc498887d24
+  data.tar.gz: 65e503c7599b35d659f2a2f45687a3e089ce034913279bd3ac1919ebc29c6dd31966f5dd881e17b01c137c943240319cd6592e507a5e968c7b1c468bd0d1fd0a

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change Log
 
+**1.2.3**
+- Fix issue where requiring 'rack' unnecessarily broke things in non-rack apps. See [#150](https://github.com/rollbar/rollbar-gem/pull/150)
+- Bring back `enforce_valid_utf8`, which got lost in the 1.2.0 upgrade. See [#148](https://github.com/rollbar/rollbar-gem/pull/148)
+- Fix bug with raw post extraction for application/json requests. See [#147](https://github.com/rollbar/rollbar-gem/pull/147)
+
 **1.2.2**
 - Fix issue with delayed_job and Rollbar.report_exception (bug introduced in 1.2.0). See [#145](https://github.com/rollbar/rollbar-gem/issues/145)
 - Explicitly require 'rack' in request_data_extractor. See [#144](https://github.com/rollbar/rollbar-gem/pull/144)

data/README.md

@@ -1,4 +1,4 @@
-# Rollbar notifier for Ruby [![Build Status](https://secure.travis-ci.org/rollbar/rollbar-gem.png?branch=master)](https://travis-ci.org/rollbar/rollbar-gem)
+# Rollbar notifier for Ruby [![Build Status](https://api.travis-ci.org/rollbar/rollbar-gem.svg?branch=v1.1.0)](https://travis-ci.org/rollbar/rollbar-gem/branches)
 
 <!-- RemoveNext -->
 Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https://rollbar.com).
@@ -9,7 +9,7 @@ Ruby gem for reporting exceptions, errors, and log messages to [Rollbar](https:/
 
 Add this line to your application's Gemfile:
 
-    gem 'rollbar', '~> 1.2.1'
+    gem 'rollbar', '~> 1.1.0'
 
 And then execute:
 

data/lib/rollbar.rb

@@ -279,10 +279,14 @@ module Rollbar
 
       Rollbar::Util.deep_merge(data, configuration.payload_options)
 
-      {
+      payload = {
         'access_token' => configuration.access_token,
         'data' => data
       }
+
+      enforce_valid_utf8(payload)
+
+      payload
     end
 
     def build_payload_body(message, exception, extra)

data/lib/rollbar/request_data_extractor.rb

@@ -103,10 +103,11 @@ module Rollbar
     def rollbar_raw_post_params(rack_req)
       return {} unless rack_req.env['CONTENT_TYPE'] =~ %r{application/json}i
 
-      params = MultiJson.decode(rack_req.body.read)
+      MultiJson.decode(rack_req.body.read)
+    rescue
+      {}
+    ensure
       rack_req.body.rewind
-
-      params
     end
 
     def rollbar_request_params(env)

data/lib/rollbar/version.rb

@@ -1,3 +1,3 @@
 module Rollbar
-  VERSION = "1.2.2"
+  VERSION = "1.2.3"
 end

data/spec/rollbar/middleware/rack/builder_spec.rb

@@ -40,7 +40,6 @@ describe Rollbar::Middleware::Rack::Builder do
         request.get('/will_crash', :params => params)
       end.to raise_error(exception)
 
-
       expect(Rollbar.last_report[:request][:params]).to be_eql(params)
     end
   end
@@ -52,10 +51,22 @@ describe Rollbar::Middleware::Rack::Builder do
 
     it 'sends them to Rollbar' do
       expect do
-        request.post('/will_crash', :params => params, 'CONTENT_TYPE' => 'application/json')
+        request.post('/will_crash', :input => params.to_json, 'CONTENT_TYPE' => 'application/json')
       end.to raise_error(exception)
 
       expect(Rollbar.last_report[:request][:params]).to be_eql(params)
     end
+
+    context 'with crashing payload' do
+      let(:body) { 'this is not a valid json' }
+
+      it 'returns {} and doesnt raise' do
+        expect do
+          request.post('/dont_crash', :input => body, 'CONTENT_TYPE' => 'application/json')
+        end.to raise_error(exception)
+
+        expect(Rollbar.last_report[:request][:params]).to be_eql({})
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -34,6 +34,7 @@ RSpec.configure do |config|
   config.after(:each) do
     DatabaseCleaner.clean
   end
+  config.backtrace_exclusion_patterns = [/gems\/rspec-.*/]
 end
 
 def reset_configuration

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rollbar
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Rollbar, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-20 00:00:00.000000000 Z
+date: 2014-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json